Bug ID 5122
Summary Review Request: omxplayer - Raspberry Pi command line OMX player
Product Package Reviews
Version Current
Hardware arm
OS GNU/Linux
Status NEW
Severity enhancement
Priority P1
Component Review Request
Assignee rpmfusion-package-review@rpmfusion.org
Reporter zonexpertconsulting@outlook.com
CC rpmfusion-package-review@rpmfusion.org
namespace rpi

FAS account: kni

WHY NOT FEDORA?
---------------
This package needs ffmpeg, in addition to raspberrypi-vc.

SPEC URL:
https://raw.githubusercontent.com/knight-of-ni/specfiles/master/omxplayer.spec

SRPM URL:
http://koji.rpmfusion.org/kojifiles/work/tasks/3453/283453/omxplayer-20181014-3.7f3faf6.fc30rpi.src.rpm

DESCRIPTION
-----------
OMXPlayer is a video player specifically made for the Raspberry Pi's GPU.
It relies on the OpenMAX hardware acceleration API, which is the Broadcom's
VideoCore officially supported API for GPU video/audio processing.

NOTES
-----

- I have removed the bundled ffmpeg requirement. The package builds against the
ffmpeg package in the rpi namespace.

- This package has no cmake or autotools. Just a Makefile. The Makefile must be
altered for compatibility. My preference was to use sed to accomplish this,
rather than patch files. I found it easier to manipulate the compiler flags
this way as I was testing.

- This is still a work in progress. I have not yet run the player, but I do
want to start the peer review process to verify my work.

PROVIDES
---------
$ rpm -q --provides omxplayer-20181014-3.7f3faf6.fc29.armv7hl.rpm
omxplayer = 20181014-3.7f3faf6.fc29
omxplayer(armv7hl-32) = 20181014-3.7f3faf6.fc29

REQUIRES
--------
$ rpm -q --requires omxplayer-20181014-3.7f3faf6.fc29.armv7hl.rpm
/usr/bin/bash
fbset
gnu-free-sans-fonts
ld-linux-armhf.so.3
ld-linux-armhf.so.3(GLIBC_2.4)
libasound.so.2
libasound.so.2(ALSA_0.9)
libasound.so.2(ALSA_0.9.0rc4)
libavcodec.so.58
libavcodec.so.58(LIBAVCODEC_58)
libavformat.so.58
libavformat.so.58(LIBAVFORMAT_58)
libavutil.so.56
libavutil.so.56(LIBAVUTIL_56)
libbcm_host.so
libbrcmEGL.so
libbrcmGLESv2.so
libc.so.6
libc.so.6(GLIBC_2.28)
libc.so.6(GLIBC_2.4)
libc.so.6(GLIBC_2.8)
libdbus-1.so.3
libdbus-1.so.3(LIBDBUS_1_3)
libfreetype.so.6
libgcc_s.so.1
libgcc_s.so.1(GCC_3.5)
libm.so.6
libm.so.6(GLIBC_2.27)
libm.so.6(GLIBC_2.4)
libopenmaxil.so
libpcre.so.1
libpthread.so.0
libpthread.so.0(GLIBC_2.4)
librt.so.1
librt.so.1(GLIBC_2.4)
libstdc++.so.6
libstdc++.so.6(CXXABI_1.3)
libstdc++.so.6(CXXABI_1.3.8)
libstdc++.so.6(CXXABI_ARM_1.3.3)
libstdc++.so.6(GLIBCXX_3.4)
libstdc++.so.6(GLIBCXX_3.4.11)
libstdc++.so.6(GLIBCXX_3.4.15)
libstdc++.so.6(GLIBCXX_3.4.18)
libstdc++.so.6(GLIBCXX_3.4.19)
libstdc++.so.6(GLIBCXX_3.4.20)
libstdc++.so.6(GLIBCXX_3.4.21)
libswresample.so.3
libswresample.so.3(LIBSWRESAMPLE_3)
libswscale.so.5
libvchiq_arm.so
libvcos.so
libz.so.1
omxplayer-libs(armv7hl-32) = 20181014-3.7f3faf6.fc29
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1
rtld(GNU_HASH)

RPMLINT
--------
>omxplayer.src:80: W: macro-in-comment %{commit_date}
>omxplayer.src:81: W: macro-in-comment %{commit_short}
>omxplayer.src:83: W: macro-in-comment %{url}
This is a false positive caused by the way the specfile generates version.h

>omxplayer.armv7hl: E: incorrect-fsf-address /usr/share/licenses/omxplayer/COPYING
PR sent upstream:
https://github.com/popcornmix/omxplayer/pull/670

>omxplayer.armv7hl: W: spurious-executable-perm /usr/share/man/man1/omxplayer.1.gz

I'm not how this mangpage ended up with execute bit set. Can look into this if
asked to.

>omxplayer.armv7hl: W: no-manual-page-for-binary omxplayer.bin
False positve. omxplayer is a wrapper for omxplayer.bin. Thus, omxplayer.1 is
the man page for this binary.

>omxplayer-desktop.armv7hl: E: explicit-lib-dependency libnotify
The desktop subpackage has libnotify as an installation requirement. I left it
in due to historical reasons. I am not sure why it is there, but I can look
into it if asked.

>omxplayer-desktop.armv7hl: W: no-documentation
This subpackage is nothing but a .desktop file. It doesn't need documentation.

>omxplayer-desktop.armv7hl: W: desktopfile-without-binary /usr/share/applications/omxplayer.desktop lxterminal

The binary is in the base package. 

>3 packages and 0 specfiles checked; 2 errors, 7 warnings.


You are receiving this mail because: