[Bug 680] Review Request: alsa-plugins-freeworld - This package includes freeworld plugins for ALSA
http://bugzilla.rpmfusion.org/show_bug.cgi?id=680
Eric Moret <eric.moret(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |eric.moret(a)gmail.com
--- Comment #2 from Eric Moret <eric.moret(a)gmail.com> 2009-06-23 22:23:50 ---
Hello Nic,
Feel free to have a look at the package review for the initial alsa-plugins
https://bugzilla.redhat.com/show_bug.cgi?id=222248, it says something about the
maemo package. No legal reasons, but lack of any other relevant package for the
N800 platform. If that has changed then I could revisit the inclusion of the
maemo package in fedora. Regarding the speex plugin, it depends on ffmpeg
which is part of rpmfusion so yes, speex would be a good candidate for
inclusion in rpmfusion.
This is not a formal review:
* Looking at your package, it would be best to split this into separate
sub-packages so people do not end up with everything and the kichen sink when
they only want the a52 plugin for example.
* For consistency, you should include a sample configuration file for the
plugins.
* You should also include the matching doc for each of you sub-package taken
out of the doc/ dir
* missing %post and %postun
* Are you sure that --with-speex=lib compiles on x86_64 ?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.