[Bug 436] Review request: moonlight - Moonlight is an open source implementation of Microsoft Silverlight for Unix systems

http://bugzilla.rpmfusion.org/show_bug.cgi?id=436 --- Comment #29 from NicolasChauvet <kwizart(a)gmail.com&gt; 2009-04-11 10:55:50 --- I still don't like the way the spec sort it's different part. Specially having %file section before the %install ones Why are theses options not using the usual %configure macro ? %{?env_options} %{?configure_options} Why aren't you using a dist tag. Please use one. it definitely make sense to have a dist tag for binary package. (even for a noarch packages that was built using a special version of rpm) About this: * Why this symlink is deleted ? * You should probably use that to remove .la in subdirectory (if any). find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';' * Why are you removing pkgconfig ? -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.