[Bug 310] scid - A chess database application
http://bugzilla.rpmfusion.org/show_bug.cgi?id=310
--- Comment #18 from Mikhail Kalenkov <Mikhail.Kalenkov(a)gmail.com> 2009-06-17
09:08:07 ---
(In reply to comment #17)
SPEC - http://katrine.lpi.ru/kalenkov/fusion/scid.spec
SRPM - http://katrine.lpi.ru/kalenkov/fusion/scid-3.7.3-4.fc11.src.rpm
Thanks for the update. Here is the rest of the package review:
? What is this line for:
iconv -f cp1251 -t utf8 tcl/lang/russian.tcl -o tcl/lang/russian.tcl.utf8 &&
mv -f tcl/lang/russian.tcl.utf8 tcl/lang/russian.tcl
You didn't package this. Something missing?
tcl/lang/*.tcl files are building
blocks of the /usr/bin/scid tcl script. I
convert russian.tcl into utf8 encoding, because otherwise scid doesn't show
Cyrillic letters in menu items.
* Fedora specific optflags are not used for all compilations. From
the
build.log:
g++ -pipe -Wall -fno-exceptions -fno-rtti -O3 -fstrict-aliasing
-fomit-frame-pointer -c -o eval.o eval.cpp
gcc -O3 -Wall -fomit-frame-pointer --std=gnu89 -D_GNU_SOURCE -DGNUFUN -c
killers.c -o .o/killers.o
This needs attention. Do a
rpm -E %{optflags}
to see what flags need to be passed. Remember that these flags should not be
overriden.
fixed. I wrote two patches scid-makefile-togaII.patch and
scid-makefile-phalanx.patch. Actually I don't like the way I fix optflags
issues. Could you recommend a better way?
* There are a few compilation warnings of type
src/egtb/tbindex.cpp:1204: warning: format '%d' expects type 'int',
but
argument 2 has type 'size_t'
Please fix them as they might cause problems in 64bit systems. (Replacing %d by
%zd should solve it) Don't forget to send the patch upstream and provide a link
from their tracker.
There is no such warnings during compilation on my i386 box.
http://katrine.lpi.ru/kalenkov/fusion/build-scid.log
* Please explain in the SPEC file where
Source2: %{name}.png
Deleted
Source3: %{name}.svg
I created scid.svg myself.
Actually I will drop it with next scid release
because current scid cvs tree contains better svg icon.
Also you could try to upstream them along with
Source1: %{name}.desktop
Ok, I'll try.
* It appears to me that the help/ directory is worth putting in %doc
I guess it is not necessary because help/*.html files are building blocks of
the /usr/bin/scid tcl script and can be accessed from the scid application
(help menu item).
* Also please include the doc files in src/egtb/ in %doc
Is it
really necessary? These files are useful only for developers.
? What is all that stuff it the pocket/ directory? Don't we want
them?
pocket/ directory contains scid source code adopted for Pocket PC.
* The final license tag will then be something like
License: GPLv2+ and freely redistributable and distributable only in Scid
Also please explain briefly with comments next to the license tag what files
belong to each group.
Is it necessary to specify license tag for subpackages?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.