[Bug 740] Review request: meka - Multi machine emulator for MS-DOS, MS-Windows and GNU/Linux

http://bugzilla.rpmfusion.org/show_bug.cgi?id=740 solarflow99(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|2 |3 Status|NEW |ASSIGNED --- Comment #10 from solarflow99(a)gmail.com 2010-11-25 09:10:42 --- ok, I don't see a special group for reviewers, so i'll assume I can do it. Taking this package for review. rpmlint output is OK, I just see this one warning (W): meka.src: W: invalid-license Distributable The value of the License tag was not recognized. I assume this license is OK right? Just a few minor ideas to consider for the spec file, perhaps the blank line between Summary and Group can be moved and put after URL instead, double spaces between macros such as %description, %build, etc. tabs can align the values instead of a space to look something like this: Source2: %{name}.desktop Source3: freedos-source.tar.gz Group: Applications/Emulators Buildroot: %{_tmppath}/%{name}-%{version}-%{release}-root BuildRequires: bison BuildRequires: desktop-file-utils BuildRequires: xorg-x11-font-utils Requires: hicolor-icon-theme All this looks good after this, I can set block to: approved, and this package will be available. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.