Comment # 13
on bug 3805
from Antonio Trande
- Include "BSD and Boost" licenses.
- '-I/usr/include/boost_1_54_0' flag is a nonsense;
please, remove it or change the path.
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (unspecified)", "*No copyright* BSL (v1.0)", "Unknown or
generated". 126 files have unknown license. Detailed output of
licensecheck in /home/sagitter/cannonball/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Macros in Summary, %description expandable at SRPM build time.
Note: Macros in: cannonball (description)
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in cannonball
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
cannonball-debuginfo
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on debuginfo package(s).
Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
Rpmlint
-------
Checking: cannonball-0.3-2.fc27.x86_64.rpm
cannonball-debuginfo-0.3-2.fc27.x86_64.rpm
cannonball-0.3-2.fc27.src.rpm
cannonball.x86_64: W: spelling-error %description -l en_US gameplay -> game
play, game-play, nameplate
cannonball.x86_64: W: invalid-license MAME
cannonball.x86_64: W: only-non-binary-in-usr-lib
cannonball.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
cannonball.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
cannonball.x86_64: W: no-manual-page-for-binary cannonball
cannonball-debuginfo.x86_64: W: invalid-license MAME
cannonball-debuginfo.x86_64: E: debuginfo-without-sources
cannonball.src: W: spelling-error %description -l en_US gameplay -> game play,
game-play, nameplate
cannonball.src: W: invalid-license MAME
3 packages and 0 specfiles checked; 1 errors, 9 warnings.
Rpmlint (debuginfo)
-------------------
Checking: cannonball-debuginfo-0.3-2.fc27.x86_64.rpm
cannonball-debuginfo.x86_64: W: invalid-license MAME
cannonball-debuginfo.x86_64: E: debuginfo-without-sources
1 packages and 0 specfiles checked; 1 errors, 1 warnings.
Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
cannonball-debuginfo.x86_64: W: invalid-license MAME
cannonball-debuginfo.x86_64: E: debuginfo-without-sources
cannonball.x86_64: W: spelling-error %description -l en_US gameplay -> game
play, game-play, nameplate
cannonball.x86_64: W: invalid-license MAME
cannonball.x86_64: W: only-non-binary-in-usr-lib
cannonball.x86_64: W: no-manual-page-for-binary cannonball
2 packages and 0 specfiles checked; 1 errors, 5 warnings.
Requires
--------
cannonball-debuginfo (rpmlib, GLIBC filtered):
cannonball (rpmlib, GLIBC filtered):
/bin/sh
hicolor-icon-theme
libSDL-1.2.so.0()(64bit)
libc.so.6()(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
libm.so.6()(64bit)
libstdc++.so.6()(64bit)
libstdc++.so.6(CXXABI_1.3)(64bit)
libstdc++.so.6(CXXABI_1.3.8)(64bit)
libstdc++.so.6(CXXABI_1.3.9)(64bit)
rtld(GNU_HASH)
Provides
--------
cannonball-debuginfo:
cannonball-debuginfo
cannonball-debuginfo(x86-64)
debuginfo(build-id)
cannonball:
application()
application(cannonball.desktop)
cannonball
cannonball(x86-64)
Source checksums
----------------
https://github.com/djyt/cannonball/archive/v0.3/cannonball-0.3.tar.gz :
CHECKSUM(SHA256) this package :
572b983b5490f1131d502e573d59e87ff841d5baa608b40482c198686818a476
CHECKSUM(SHA256) upstream package :
572b983b5490f1131d502e573d59e87ff841d5baa608b40482c198686818a476
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -rn
cannonball-0.3-2.fc25.src.rpm
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6