Comment # 5
on bug 3999
from Vasiliy Glazov
APPROVED
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 6 files have unknown license. Detailed
output of licensecheck in /home/vascom/review-xt7-player-
mpv/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: update-desktop-database is invoked in %post and %postun if package
contains desktop file(s) with a MimeType: entry.
Note: desktop file(s) with MimeType entry in xt7-player-mpv
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in xt7-player-mpv
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 51200 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: xt7-player-mpv-0.21.384-1.fc26.noarch.rpm
xt7-player-mpv-0.21.384-1.fc22.src.rpm
xt7-player-mpv.noarch: W: spelling-error Summary(en_US) gui -> GUI, goo, gun
xt7-player-mpv.noarch: W: spelling-error %description -l en_US youtube -> you
tube, you-tube, YouTube
xt7-player-mpv.noarch: W: spelling-error %description -l en_US shoutcast -> sh
outcast, sh-outcast, shout cast
xt7-player-mpv.noarch: W: spelling-error %description -l en_US dvbt -> debt
xt7-player-mpv.noarch: W: spelling-error %description -l en_US playlist -> play
list, play-list, pluralist
xt7-player-mpv.noarch: W: spelling-error %description -l en_US managment ->
management, engagement, Mantegna
xt7-player-mpv.noarch: W: no-manual-page-for-binary xt7-player-mpv.gambas
xt7-player-mpv.src: W: spelling-error Summary(en_US) gui -> GUI, goo, gun
xt7-player-mpv.src: W: spelling-error %description -l en_US youtube -> you
tube, you-tube, YouTube
xt7-player-mpv.src: W: spelling-error %description -l en_US shoutcast -> sh
outcast, sh-outcast, shout cast
xt7-player-mpv.src: W: spelling-error %description -l en_US dvbt -> debt
xt7-player-mpv.src: W: spelling-error %description -l en_US playlist -> play
list, play-list, pluralist
xt7-player-mpv.src: W: spelling-error %description -l en_US managment ->
management, engagement, Mantegna
2 packages and 0 specfiles checked; 0 errors, 13 warnings.
Rpmlint (installed packages)
----------------------------
xt7-player-mpv.noarch: W: spelling-error Summary(en_US) gui -> GUI, goo, gun
xt7-player-mpv.noarch: W: spelling-error %description -l en_US youtube -> you
tube, you-tube, YouTube
xt7-player-mpv.noarch: W: spelling-error %description -l en_US shoutcast -> sh
outcast, sh-outcast, shout cast
xt7-player-mpv.noarch: W: spelling-error %description -l en_US dvbt -> debt
xt7-player-mpv.noarch: W: spelling-error %description -l en_US playlist -> play
list, play-list, pluralist
xt7-player-mpv.noarch: W: spelling-error %description -l en_US managment ->
management, engagement, Mantegna
xt7-player-mpv.noarch: W: no-manual-page-for-binary xt7-player-mpv.gambas
1 packages and 0 specfiles checked; 0 errors, 7 warnings.
Requires
--------
xt7-player-mpv (rpmlib, GLIBC filtered):
/bin/sh
/usr/bin/env
ffmpeg
gambas3-gb-args
gambas3-gb-compress
gambas3-gb-dbus
gambas3-gb-desktop
gambas3-gb-form
gambas3-gb-form-dialog
gambas3-gb-form-mdi
gambas3-gb-form-stock
gambas3-gb-gui
gambas3-gb-image
gambas3-gb-libxml
gambas3-gb-net
gambas3-gb-net-curl
gambas3-gb-qt5-ext
gambas3-gb-settings
gambas3-gb-signal
gambas3-gb-util-web
gambas3-gb-web
gambas3-runtime
hicolor-icon-theme
mpv
wget
youtube-dl
Provides
--------
xt7-player-mpv:
appdata()
appdata(xt7-player-mpv.appdata.xml)
application()
application(xt7-player-mpv.desktop)
mimehandler(application/asx)
mimehandler(application/ogg)
mimehandler(application/sdp)
mimehandler(application/smil)
mimehandler(application/streamingmedia)
mimehandler(application/vnd.ms-asf)
mimehandler(application/vnd.rn-realmedia)
mimehandler(application/vnd.rn-realmedia-vbr)
mimehandler(application/vnd.rn-realplayer)
mimehandler(application/x-cda)
mimehandler(application/x-mplayer2)
mimehandler(application/x-ms-asf)
mimehandler(application/x-ms-wmd)
mimehandler(application/x-ms-wmz)
mimehandler(application/x-ogg)
mimehandler(application/x-pn-realaudio)
mimehandler(application/x-smil)
mimehandler(application/x-streamingmedia)
mimehandler(audio/aac)
mimehandler(audio/ac3)
mimehandler(audio/basic)
mimehandler(audio/m3u)
mimehandler(audio/m4a)
mimehandler(audio/mp1)
mimehandler(audio/mp2)
mimehandler(audio/mp3)
mimehandler(audio/mp4)
mimehandler(audio/mpeg)
mimehandler(audio/mpeg3)
mimehandler(audio/mpeg4)
mimehandler(audio/mpegurl)
mimehandler(audio/mpg)
mimehandler(audio/scpls)
mimehandler(audio/vnd.mpegurl)
mimehandler(audio/vnd.rn-realaudio)
mimehandler(audio/vorbis)
mimehandler(audio/wav)
mimehandler(audio/x-aac)
mimehandler(audio/x-adpcm)
mimehandler(audio/x-flac)
mimehandler(audio/x-m3u)
mimehandler(audio/x-m4a)
mimehandler(audio/x-matroska)
mimehandler(audio/x-mp1)
mimehandler(audio/x-mp2)
mimehandler(audio/x-mp3)
mimehandler(audio/x-mpeg)
mimehandler(audio/x-mpeg3)
mimehandler(audio/x-mpegurl)
mimehandler(audio/x-mpg)
mimehandler(audio/x-ms-asf)
mimehandler(audio/x-ms-asx)
mimehandler(audio/x-ms-wax)
mimehandler(audio/x-ms-wma)
mimehandler(audio/x-ms-wmp)
mimehandler(audio/x-ms-wmv)
mimehandler(audio/x-musepack)
mimehandler(audio/x-oggflac)
mimehandler(audio/x-pls)
mimehandler(audio/x-pn-realaudio)
mimehandler(audio/x-pn-realaudio-plugin)
mimehandler(audio/x-pn-windows-pcm)
mimehandler(audio/x-realaudio)
mimehandler(audio/x-scpls)
mimehandler(audio/x-vorbis)
mimehandler(audio/x-wav)
mimehandler(video/avi)
mimehandler(video/mediaplayer)
mimehandler(video/mp4)
mimehandler(video/mpeg)
mimehandler(video/mpeg4)
mimehandler(video/msvideo)
mimehandler(video/nsv)
mimehandler(video/quicktime)
mimehandler(video/vnd.mpegurl)
mimehandler(video/vnd.rn-realvideo)
mimehandler(video/x-3gpp)
mimehandler(video/x-3gpp2)
mimehandler(video/x-avi)
mimehandler(video/x-divx)
mimehandler(video/x-fli)
mimehandler(video/x-m4v)
mimehandler(video/x-matroska)
mimehandler(video/x-mpeg)
mimehandler(video/x-mpeg2)
mimehandler(video/x-mpegurl)
mimehandler(video/x-ms-asf)
mimehandler(video/x-ms-asf-plugin)
mimehandler(video/x-ms-asx)
mimehandler(video/x-ms-wax)
mimehandler(video/x-ms-wm)
mimehandler(video/x-ms-wma)
mimehandler(video/x-ms-wmp)
mimehandler(video/x-ms-wmv)
mimehandler(video/x-ms-wmx)
mimehandler(video/x-ms-wvx)
mimehandler(video/x-msmpeg)
mimehandler(video/x-msvideo)
mimehandler(video/x-ogm)
mimehandler(video/x-pn-realvideo)
mimehandler(video/x-pn-realvideo-plugin)
mimehandler(video/x-qtc)
mimehandler(video/x-realvideo)
mimehandler(video/x-theora)
xt7-player-mpv
Source checksums
----------------
https://github.com/kokoko3k/xt7-player-mpv/archive/0.21.384.tar.gz#/xt7-player-mpv-0.21.384.tar.gz
:
CHECKSUM(SHA256) this package :
d12f70e623078c26cc63a53acddcf1a853f2e207ebc70a66bdabac4e50683ded
CHECKSUM(SHA256) upstream package :
d12f70e623078c26cc63a53acddcf1a853f2e207ebc70a66bdabac4e50683ded
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64-rpmfusion_free -u
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3999
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl,
Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6