[Bug 3657] Review request: rpmfusion-free-appstream-data - Appstream metadata for the RPMFusion free repository

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3657 Hans de Goede <j.w.r.degoede(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.w.r.degoede(a)gmail.com Blocks|2 |4 --- Comment #3 from Hans de Goede <j.w.r.degoede(a)gmail.com&gt; 2015-06-01 12:33:47 CEST --- Hi, Full review done: Good: - rpmlint checks return: rpmfusion-free-appstream-data.src:28: W: macro-in-comment %{reponame} rpmfusion-free-appstream-data.src:28: W: macro-in-comment %{repoversion} rpmfusion-free-appstream-data.src:28: W: macro-in-comment %{version} rpmfusion-free-appstream-data.src: W: invalid-url Source1: rpmfusion-free-22-icons.tar.gz rpmfusion-free-appstream-data.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 5 warnings. These can all be ignored. - package meets naming guidelines - package meets packaging guidelines - license (CC0) OK - spec file legible, in am. english - source matches upstream -> NA - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - content only, content which enriches existing foss apps, so ok - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Everything looks good: Reviewed. Regards, Hans -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.