[Bug 2101] Review request: vbam - Gameboy Advance Emulator combining features of all VBA forks

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2101 --- Comment #4 from Andrea Musuruane <musuruan(a)gmail.com&gt; 2012-01-07 16:21:33 CET --- I'm a Fedora and RPM Fusion packager but I'm not a sponsor. I can give you a hand though. * The start page to read and learn about Fedora Packaging Guidelines is the following one: https://fedoraproject.org/wiki/Packaging/Guidelines * Improve the Summary and Description: https://fedoraproject.org/wiki/Packaging/Guidelines#Summary_and_description Notice that most user won't know what "VBA forks" are. * Group tag is no longer needed. * For packages hosted on sourceforge, use this format for Source0: https://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net Notice that %{name} and %{version} macro are used so you can avoid to update them at each release. * There is no need to include some packages or their dependencies as BuildRequires because they would occur too often. These packages are considered the minimum build environment. A list is provided here: https://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 * Please use the %cmake macro instead of plain cmake, following this guideline: https://fedoraproject.org/wiki/Packaging:Cmake * In this way you'll also see the compiler output and you'll also see if it's using Fedora optflags - and you will notice they aren't used: https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags * Look also at how the %install section is depicted in %cmake page: %install rm -rf $RPM_BUILD_ROOT make install DESTDIR=$RPM_BUILD_ROOT The "rm -rf $RPM_BUILD_ROOT" is no longer required in the %install section so please avoid this line. Most important, there is no need to specify the CFLAGS at install time. * For packages that include translation, follow this guideline: https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files Notice that you must BR gettext. * Also make use of the %{name} and other macros: https://fedoraproject.org/wiki/Packaging/Guidelines#Macros * It is not simply enough to just include the .desktop file in the package, one MUST run desktop-file-install (in %install) OR desktop-file-validate (in %check or %install) and have BuildRequires: desktop-file-utils, to help ensure .desktop file safety and spec-compliance: https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files In this way you will notice other problems inside the desktop file. * If an application installs icons into one of the subdirectories in %{_datadir}/icons/ (such as hicolor in the following examples), icon caches must be updated so that the installed icons show up in menus right after package installation: https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache * There's already a man page in the debian subdirectory. You can use this one. * The source package contains bundled libraries (fex subdir): https://fedoraproject.org/wiki/Packaging/Guidelines#Duplication_of_system... This must be avoided: https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries * There is no need to update the desktop database because the desktop file doesn't have an entry 'MimeType': https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.