[Bug 2133] Review Request: libspotify - Official Spotify API

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2133 Jeremy Newton <alexjnewt(a)hotmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexjnewt(a)hotmail.com --- Comment #4 from Jeremy Newton <alexjnewt(a)hotmail.com&gt; 2012-01-23 16:37:00 CET --- Few quick things I noticed while skimming through your SPEC: *It seems a little redundant to do prep on both sources, if only one is required, it seems unnecessary. I'm not sure how one should handle this but it did strike me as odd when I saw it. *You have not included documentation in your package. At a quick glance of the source, I have noticed there is license files and a readme in the tar's. All of these are documentation and should be included, no? *You haven't given any reason for ignoring the warnings you did. It makes it a little difficult to review a package with warnings that has no explanation of such warnings being ignored. Only the warning of lack of documentation is what I would think needs explaining, but definitely something to note next time to avoid things from being unclear to the reviewers. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.