5:19 p.m.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2429
Michael Cronenworth <mike(a)cchtml.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |mike(a)cchtml.com
Blocks|2 |3
AssignedTo|rpmfusion-package-review@rp |mike(a)cchtml.com
|mfusion.org |
--- Comment #7 from Michael Cronenworth <mike(a)cchtml.com> 2014-10-05 19:19:56 CEST
---
I'll review this.
I see the Conflicts is still in place. Do you plan on retiring the "gens"
package?
Do you have a Fedora FAS or RPMFusion FAS account? What is your user name?
Preliminary review:
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- Package does not contain any libtool archives (.la)
Note: gens-gs : /usr/lib/mdp/mdp_misc_game_genie.la gens-gs :
/usr/lib/mdp/mdp_misc_ips_patcher.la gens-gs :
/usr/lib/mdp/mdp_misc_sgens.la gens-gs :
/usr/lib/mdp/mdp_misc_vdp_layer_options.la gens-gs :
/usr/lib/mdp/mdp_render_2xsai.la gens-gs :
/usr/lib/mdp/mdp_render_blargg_ntsc.la gens-gs :
/usr/lib/mdp/mdp_render_epx.la gens-gs : /usr/lib/mdp/mdp_render_epx_plus.la
gens-gs : /usr/lib/mdp/mdp_render_hq2x.la gens-gs :
/usr/lib/mdp/mdp_render_hq3x.la gens-gs : /usr/lib/mdp/mdp_render_hq4x.la
gens-gs : /usr/lib/mdp/mdp_render_interpolated.la gens-gs :
/usr/lib/mdp/mdp_render_interpolated_scanline.la gens-gs :
/usr/lib/mdp/mdp_render_interpolated_scanline_25.la gens-gs :
/usr/lib/mdp/mdp_render_interpolated_scanline_50.la gens-gs :
/usr/lib/mdp/mdp_render_scale2x.la gens-gs :
/usr/lib/mdp/mdp_render_scale3x.la gens-gs :
/usr/lib/mdp/mdp_render_scale4x.la gens-gs :
/usr/lib/mdp/mdp_render_scanline.la gens-gs :
/usr/lib/mdp/mdp_render_scanline_25.la gens-gs :
/usr/lib/mdp/mdp_render_scanline_50.la gens-gs :
/usr/lib/mdp/mdp_render_super_2xsai.la gens-gs :
/usr/lib/mdp/mdp_render_super_eagle.la
See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries
(Please delete all libtool files)
- Large documentation must go in a -doc subpackage. Large could be size (~1MB)
or number of files.
Note: Documentation size is 1884160 bytes in 99 files.
See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation
(Could you use %doc for README and license files?)
- License field needs to reflect free and non-free licensed pieces
(MIT, BSD, and a non-free license were found)
- Conflicts with "gens" - will you retire "gens" or patch this package
to not
conflict with it?
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"LGPL (v2 or later)", "GPL (v2 or later)", "Unknown or
generated",
"MIT/X11 (BSD like)", "BSD (3 clause)", "GPL (v2 or later)
(with
incorrect FSF address)", "ISC", "LGPL (v2.1 or later)". 64
files have
unknown license. Detailed output of licensecheck in
/home/michael/Downloads/gens-gs/licensecheck.txt
[!]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/share/gens(gens)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[!]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[!]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in gens-gs
[x]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[!]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[!]: Package should not use obsolete m4 macros
Note: Some obsoleted macros found, see the attachment.
See: https://fedorahosted.org/FedoraReview/wiki/AutoTools
[!]: Large data in /usr/share should live in a noarch subpackage if package is
arched.
Note: Arch-ed rpms have a total of 1996800 bytes in /usr/share
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
Rpmlint
-------
Checking: gens-gs-2.16.7-3.fc20.i686.rpm
gens-gs-2.16.7-3.fc20.src.rpm
gens-gs.i686: E: incorrect-fsf-address
/usr/share/doc/gens-gs-2.16.7/COPYING.txt
gens-gs.i686: W: no-manual-page-for-binary mdp_test
gens-gs.i686: W: no-manual-page-for-binary gens
gens-gs.src:46: W: configure-without-libdir-spec
2 packages and 0 specfiles checked; 1 errors, 3 warnings.
Rpmlint (installed packages)
----------------------------
# rpmlint gens-gs
gens-gs.i686: E: incorrect-fsf-address
/usr/share/doc/gens-gs-2.16.7/COPYING.txt
gens-gs.i686: W: no-manual-page-for-binary mdp_test
gens-gs.i686: W: no-manual-page-for-binary gens
1 packages and 0 specfiles checked; 1 errors, 2 warnings.
# echo 'rpmlint-done:'
Requires
--------
gens-gs (rpmlib, GLIBC filtered):
/bin/sh
hicolor-icon-theme
libGL.so.1
libSDL-1.2.so.0
libX11.so.6
libatk-1.0.so.0
libc.so.6
libcairo.so.2
libdl.so.2
libfontconfig.so.1
libfreetype.so.6
libgcc_s.so.1
libgcc_s.so.1(GCC_3.0)
libgdk-x11-2.0.so.0
libgdk_pixbuf-2.0.so.0
libgio-2.0.so.0
libglib-2.0.so.0
libgobject-2.0.so.0
libgtk-x11-2.0.so.0
libm.so.6
libminizip.so.1
libpango-1.0.so.0
libpangocairo-1.0.so.0
libpangoft2-1.0.so.0
libpng16.so.16
libpng16.so.16(PNG16_0)
libpthread.so.0
librt.so.1
libstdc++.so.6
libstdc++.so.6(CXXABI_1.3)
libz.so.1
Provides
--------
gens-gs:
application()
application(gens.desktop)
gens-gs
gens-gs(x86-32)
libtool(/usr/lib/mdp/mdp_misc_game_genie.la)
libtool(/usr/lib/mdp/mdp_misc_ips_patcher.la)
libtool(/usr/lib/mdp/mdp_misc_sgens.la)
libtool(/usr/lib/mdp/mdp_misc_vdp_layer_options.la)
libtool(/usr/lib/mdp/mdp_render_2xsai.la)
libtool(/usr/lib/mdp/mdp_render_blargg_ntsc.la)
libtool(/usr/lib/mdp/mdp_render_epx.la)
libtool(/usr/lib/mdp/mdp_render_epx_plus.la)
libtool(/usr/lib/mdp/mdp_render_hq2x.la)
libtool(/usr/lib/mdp/mdp_render_hq3x.la)
libtool(/usr/lib/mdp/mdp_render_hq4x.la)
libtool(/usr/lib/mdp/mdp_render_interpolated.la)
libtool(/usr/lib/mdp/mdp_render_interpolated_scanline.la)
libtool(/usr/lib/mdp/mdp_render_interpolated_scanline_25.la)
libtool(/usr/lib/mdp/mdp_render_interpolated_scanline_50.la)
libtool(/usr/lib/mdp/mdp_render_scale2x.la)
libtool(/usr/lib/mdp/mdp_render_scale3x.la)
libtool(/usr/lib/mdp/mdp_render_scale4x.la)
libtool(/usr/lib/mdp/mdp_render_scanline.la)
libtool(/usr/lib/mdp/mdp_render_scanline_25.la)
libtool(/usr/lib/mdp/mdp_render_scanline_50.la)
libtool(/usr/lib/mdp/mdp_render_super_2xsai.la)
libtool(/usr/lib/mdp/mdp_render_super_eagle.la)
Unversioned so-files
--------------------
gens-gs: /usr/lib/mdp/mdp_misc_game_genie.so
gens-gs: /usr/lib/mdp/mdp_misc_ips_patcher.so
gens-gs: /usr/lib/mdp/mdp_misc_sgens.so
gens-gs: /usr/lib/mdp/mdp_misc_vdp_layer_options.so
gens-gs: /usr/lib/mdp/mdp_render_2xsai.so
gens-gs: /usr/lib/mdp/mdp_render_blargg_ntsc.so
gens-gs: /usr/lib/mdp/mdp_render_epx.so
gens-gs: /usr/lib/mdp/mdp_render_epx_plus.so
gens-gs: /usr/lib/mdp/mdp_render_hq2x.so
gens-gs: /usr/lib/mdp/mdp_render_hq3x.so
gens-gs: /usr/lib/mdp/mdp_render_hq4x.so
gens-gs: /usr/lib/mdp/mdp_render_interpolated.so
gens-gs: /usr/lib/mdp/mdp_render_interpolated_scanline.so
gens-gs: /usr/lib/mdp/mdp_render_interpolated_scanline_25.so
gens-gs: /usr/lib/mdp/mdp_render_interpolated_scanline_50.so
gens-gs: /usr/lib/mdp/mdp_render_scale2x.so
gens-gs: /usr/lib/mdp/mdp_render_scale3x.so
gens-gs: /usr/lib/mdp/mdp_render_scale4x.so
gens-gs: /usr/lib/mdp/mdp_render_scanline.so
gens-gs: /usr/lib/mdp/mdp_render_scanline_25.so
gens-gs: /usr/lib/mdp/mdp_render_scanline_50.so
gens-gs: /usr/lib/mdp/mdp_render_super_2xsai.so
gens-gs: /usr/lib/mdp/mdp_render_super_eagle.so
Source checksums
----------------
http://segaretro.org/images/6/6d/Gens-gs-r7.tar.gz :
CHECKSUM(SHA256) this package :
6320cd7bee85472891e1e29b21731d2c8180d04db67ee21256491f3f9ad145c1
CHECKSUM(SHA256) upstream package :
6320cd7bee85472891e1e29b21731d2c8180d04db67ee21256491f3f9ad145c1
AutoTools: Obsoleted m4s found
------------------------------
AC_PROG_LIBTOOL found in: gens-gs-r7/configure.ac:45
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.