[Bug 2532] Review request: Gmediafinder - software to search stream an/or download files
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2532
--- Comment #16 from Michel Alexandre Salim <michel+rpmf(a)sylvestre.me> 2012-10-31
09:16:11 CET ---
Almost there:
- you still need to list:
%dir %{_datadir}/pyshared
separately, since nobody currently owns that directory. This is in addition
to listing %{_datadir}/pyshared/GmediaFinder, which you already did.
(I made a mistake in my initial review comment - you should claim only the
directory, which %dir does. In theory you can just list %{_datadir}/pyshared
and not %{_datadir}/pyshared/GmediaFinder, instead of both, but assuming that
pyshared is meant to be used by multiple projects, it's safer to not own any
other files in pyshared.)
- the changelog should also include the gitrev -- the %{version}-%{release}
should match that of the RPM itself. It's annoying because Emacs' rpm-mode does
not do this automatically when the release tag is not a simple number -- sorry
for that.
Change those and I think this is ready to go.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.