[Bug 20] Review request: blcr-kmod - kmod for Berkeley Lab Checkpoint/ Restart for Linux
http://bugzilla.rpmfusion.org/show_bug.cgi?id=20
Thorsten Leemhuis <fedora(a)leemhuis.info> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fedora(a)leemhuis.info
AssignedTo|rpmfusion-package- |fedora(a)leemhuis.info
|review(a)rpmfusion.org |
--- Comment #1 from Thorsten Leemhuis <fedora(a)leemhuis.info> 2008-02-03 17:08:54
---
https://nbecker.dyndns.org/RPM/blcr-kmod-0.6.4-2.fc8.src.rpm looks good in
general. Some minor issues:
* Please use a full URL to the Source0
* Would be nice to rename Source11 from madwifi-foo to blcr-foo; while at it:
does xen need to be excluded (which is what this file does)?
* This
#BuildRequires: sharutils
looks like a leftover from the madwifi spec file. There are other old commands
in the install section as well. Consider to remove them all.
* What's the story behind this:
# Disable RedHat's automatic build of a debuginfo subpackage:
%define debug_package %{nil}
If there is a reason for it (I can't see one) please add a comment
* This seems unneeded:
(cd blcr-%{version} ;
)
* This
URL: http://www.blcr.org/
can't be reached.
* some people might argue that
License: GPLv2+
is wrong because the kernel itself is GPLv2 (without +), thus the resulting
binary becomes GPLv2 when used with the kenrel. But the source is GPLv2+, thus
I'd say this is fine.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.