Bug ID 4750
Summary Review request: deepin-music - Deepin Music Player
Product Package Reviews
Version Current
Hardware x86_64
OS GNU/Linux
Status NEW
Severity enhancement
Priority P1
Component Review Request
Assignee rpmfusion-package-review@rpmfusion.org
Reporter sztsian@gmail.com
CC rpmfusion-package-review@rpmfusion.org, sensor.wen@gmail.com
Blocks 2
namespace free

Spec URL: https://zsun.fedorapeople.org/pub/pkgs/rpmfusion/deepin-music.spec
SRPM URL:
https://zsun.fedorapeople.org/pub/pkgs/rpmfusion/deepin-music-3.1.7.2-2.fc27.src.rpm
Description: Deepin Music Player
Fedora Account System Username: zsun
RPMFusion FAS Username: zsun

* Why this package is not eligible to be included in Fedora:
This depends on some codec that are not accepted in Fedora.

* This is my second RPM Fusion package. (The other is bug 4749 which is also
just filed)
* I am a current Fedora Packager

* RPMlint:
$ rpmlint *.rpm
deepin-music.src: I: enchant-dictionary-not-found zh_CN
deepin-music.src: W: spelling-error %description -l en_US tweakful -> tweak
deepin-music.src: W: spelling-error %description -l en_US gstreamer ->
streamer, g streamer, steamer
deepin-music.src: W: spelling-error %description -l en_US quanpin -> piquant
deepin-music.x86_64: W: spelling-error %description -l en_US tweakful -> tweak
deepin-music.x86_64: W: spelling-error %description -l en_US gstreamer ->
streamer, g streamer, steamer
deepin-music.x86_64: W: spelling-error %description -l en_US quanpin -> piquant

For these above, they are from upstream and I believe they are expected.

deepin-music.x86_64: E: zero-length
/usr/share/dbus-1/services/com.deepin.dde.music.service

Upstream provided an empty file.
https://github.com/linuxdeepin/deepin-music/blob/master/music-player/data/com.deepin.dde.music.service

deepin-music.x86_64: W: no-manual-page-for-binary deepin-music
deepin-music.x86_64: E: invalid-desktopfile
/usr/share/applications/deepin-music.desktop file contains group "Next Shortcut
Group", but groups extending the format should start with "X-"
deepin-music.x86_64: E: invalid-desktopfile
/usr/share/applications/deepin-music.desktop file contains group "PlayPause
Shortcut Group", but groups extending the format should start with "X-"
deepin-music.x86_64: E: invalid-desktopfile
/usr/share/applications/deepin-music.desktop file contains group "Previous
Shortcut Group", but groups extending the format should start with "X-"

For desktop file related. This music player is originally part of Deepin
Desktop Environment(Short as DDE), and above are written under DDE's way. So I
believe I shouldn't modify them.

deepin-music-debuginfo.x86_64: E: useless-provides debuginfo(build-id)

For debuginfo(build-id), all packages built in rawhide contains this, so I
assume this won't hurt.

deepin-music-debugsource.x86_64: W: no-documentation
deepin-music-devel.x86_64: W: only-non-binary-in-usr-lib
deepin-music-devel.x86_64: W: no-documentation
5 packages and 0 specfiles checked; 5 errors, 10 warnings.


Referenced Bugs:


You are receiving this mail because: