[Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
Orcan Ogetbil <orcanbahri(a)yahoo.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |orcanbahri(a)yahoo.com
Status|NEW |ASSIGNED
--- Comment #7 from Orcan Ogetbil <orcanbahri(a)yahoo.com> 2008-11-25 05:45:13 ---
I reviewed this package. There are a couple minor issues, and I also have a few
questions:
* Each package must consistently use macros, as described in the macros section
of Packaging Guidelines. There are usages of both %{buildroot} and
$RPM_BUILD_ROOT; also %{optflags} and $RPM_OPT_FLAGS. Please stick to one
notation.
* Please preserve the timestamps of the doc files by using "touch -r file1
file2" when you are fixing the encoding
* For the .desktop file:
** Use Name: Gambatte Qt instead of QT
** Please add a Generic Name
* About %description. There are a few files compiled in the SDL-package that
are in C.
? Any possible (license) issues with the 2 source images you added?
? What are the 4 exports in the %build section for? Aren't they too many?
? What is the hwtests directory for? Worth to package?
! You may want to consider adding mime-types for gameboy rom images in the qt
package (you can use the same icons). Mime-types provide convenience.
? Can't you just use "%post qt" instead of "%post -n gambatte-qt"
?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.