Comment # 19 on bug 4361 from Xavier Bachelot

(In reply to Dominik 'Rathann' Mierzejewski from comment #17)
> (In reply to Xavier Bachelot from comment #16)
> > Created attachment 1750 [details]
> > Version bump, Recommends tweak, debuginfo fix
> > 
> > The interesting part of this patch is the -debuginfo fix, the remaining is
> > trivial.
> 
> That was brilliant! I blame the HB's custom configure script written in
> python.
> 
It took my quite some time and several attempts to figure it out. I was really
puzzled at this issue and the solution came from the specfile included in
HandBrake.

> We can also drop the clip_id patch after libbluray is updated to 1.0.0.
> 
I think it will need to be conditionally applied to %fedora >= 26, as I'll keep
libbluray 0.9.3 for %fedora <= 25 and %rhel.

> Regarding BuildRequires: gcc make, I don't think I should drop them. The
> fedora-review recommendation is out of date. See
> https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires_2 .
> 
Yes, agreed. It doesn't hurt anyway and seems more future proof.

> The link to https://fedorahosted.org/FedoraReview/wiki/AutoTools doesn't
> exist anymore, so I'm not sure what the recommendation is.
> 
Probably the best to do is just file a bug upstream.

> Anyway, here's an updated RPM with your patch applied.
> 
> Spec URL: https://www.greysector.net/~rathann/review/HandBrake/HandBrake.spec
> SRPM URL:
> https://www.greysector.net/~rathann/review/HandBrake/HandBrake-1.0.3-1.fc27.
> src.rpm

Thanks, I will take another look this evening but consider the package
APPROVED.
Sorry it took me so long to do the review.

And also, hopefully 1.0.3 helps with Simone's subtitle issue, but this is
upstream's job to fix it, and it should not hold us from importing the package
(but given the writing on downstream distribution of HandBrake on their
website, I don't expect much from them... What a pity...).