Bug ID | 4363 |
---|---|
Summary | Review request: chromium-libs-media-freeworld - Chromium media libraries built with all possible codecs |
Product | Package Reviews |
Version | Current |
Hardware | x86_64 |
OS | GNU/Linux |
Status | NEW |
Severity | enhancement |
Priority | P1 |
Component | Review Request |
Assignee | rpmfusion-package-review@rpmfusion.org |
Reporter | alexjnewt@gmail.com |
CC | rpmfusion-package-review@rpmfusion.org |
SPEC URL: https://dl.dropboxusercontent.com/u/42480493/chromium-libs-media-freeworld.spec SRPM URL: https://dl.dropboxusercontent.com/u/42480493/chromium-libs-media-freeworld-54.0.2840.90-1.fc25.src.rpm Description: Chromium media libraries built with all possible codecs. Chromium is an open-source web browser, powered by WebKit (Blink). This package replaces the default chromium-libs-media package, which is limited in what it can include. RPMlint output: chromium-libs-media-freeworld.src: W: spelling-error Summary(en_US) codecs -> codes, coders, code's chromium-libs-media-freeworld.src: W: spelling-error %description -l en_US codecs -> codes, coders, code's chromium-libs-media-freeworld.src:227: E: hardcoded-library-path in /usr/lib/libc.so chromium-libs-media-freeworld.src:879: W: macro-in-comment %{target} chromium-libs-media-freeworld.src:90: W: mixed-use-of-spaces-and-tabs (spaces: line 90, tab: line 60) chromium-libs-media-freeworld.src: W: invalid-url Source2: depot_tools.git-master.tar.gz 1 packages and 0 specfiles checked; 1 errors, 5 warnings. None of this really matters too much. As for the hardcoded-library-path error, please read the note in the spec for more details. The mixed-use-of-spaces-and-tabs is trivial and will be fixed in the next revision. This package is mostly based off of the chromium package but has been trimmed down to only really include the two codec libraries that Fedora will not provide for legal reasons. I'm sure I'm probably building too much and things can be trimmed down. Note that this package takes forever to compile, but as I said, the spec likely needs to be cleaned up, but feedback is welcome for sure. This will likely go into rpmfusion free, but I'll be honest, I need to look into the source a bit more as there maybe some nonfree bits. I'll continue to work on it, I just wanted to upload something that built, so I can get feedback. One issue that should be addressed though; chromium depends on chromium-libs-media, which this package provides as an alternative to the trimmed down fedora version. I would think if chromium updates without this packaging being updated, this package would be removed by the updater, while if this package updates before chromium, it would cause broken dependencies. EItherway, having rpmfusion's packages out of sync with Fedora's would no so nice. Perhaps a "chromium-freeworld" package would be better? The maintainer for chromium has made it painfully easy to package a freeworld version, so this wouldn't be too bad. I'll run a build of a chromium-freeworld package overnight for testing, as I'm sort of leaning towards this being a better option.