[Bug 171] Review Request: rpmfusion-config-display - tool to manage proprietary graphic drivers

http://bugzilla.rpmfusion.org/show_bug.cgi?id=171 Orcan Ogetbil <oget.fedora(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|2 |3 Status|NEW |ASSIGNED --- Comment #30 from Orcan Ogetbil <oget.fedora(a)gmail.com&gt; 2009-01-23 07:09:02 --- Good work. I did most of the package review. Yet there's a little bit more work to do. Note that this is not a software review or critique. * Please make the description span the 80 columns. It'll look nicer. * We don't need to package the INSTALL file. * Please put the full text of GPLv2 into the COPYING file. The COPYING file, as is, looks scary. * Each package must consistently use macros. In most places %{name} is used. At two places, you use "rpmfusion-config-display". ? Can we make a pixmap (icon) for this? * Requires: pygtk2-libglade will pull python-2.5+ and pygtk2. So no need to add Requires: pygtk2 and python >= 2.4 * Requires: pyxf86config >= 0.3.1 Do we need the version requirement for this? Even Fedora-7 comes with 0.3.33 * BuildRequires: automake, autoconf, python-devel >= 2.4 seem not necessary. Instead, you just need BR: python What is left to review? I still have to check the scriptlets and stuff that goes to /etc , initscript etc. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.