[Bug 195] Review request: perl-Crypt-IDEA - Perl interface to IDEA block cipher
http://bugzilla.rpmfusion.org/show_bug.cgi?id=195
Orcan Ogetbil <oget.fedora(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |oget.fedora(a)gmail.com
Blocks|2 |3
AssignedTo|rpmfusion-package- |oget.fedora(a)gmail.com
|review(a)rpmfusion.org |
--- Comment #1 from Orcan Ogetbil <oget.fedora(a)gmail.com> 2009-01-16 22:23:00 ---
The package seems in shape. There are a suggestion (!), a few issues that need
to be corrected (*) and a question (?)
! If you use a delimiter other than / on sed, it will make things easier to
read.
* Please explain all non-trivial things you do in a SPEC file (especially the
sed and rm commands) as comments
* Please preserve the timestamps of non-compiled files.
* The file "changes" should go to %doc
? Packages must not own files or directories already owned by other packages.
%{perl_vendorarch}/Crypt/ and %{perl_vendorarch}/auto/Crypt/ are owned by
crypto-utils. But there is an exception rule for perl packages and I believe
this package falls into that category. Am I right?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.