[Bug 43] Review Request: mixxx - Mixxx is an open source software for DJ'ing

http://bugzilla.rpmfusion.org/show_bug.cgi?id=43 --- Comment #4 from Orcan Ogetbil <orcanbahri(a)yahoo.com&gt; 2008-10-01 04:29:26 --- ### means comments and questions *** means issues, they need to be corrected FEDORA GUIDELINES: source files match upstream: 1dc04e9d628c96c75a219384252d990659e9dd0a1f23aa72b8f0774395771df1 mixxx-1.6.1-src.tar.gz package meets naming and versioning guidelines. ***specfile is properly named, is cleanly written and but uses macros ***inconsistently. ***Two portions from the spec file: ***... ***chmod +x $RPM_BUILD_ROOT%{_datadir}/mixxx/midi/convert ***... ***%{_datadir}/%{name}/ *** Please use the macros consistently (e.g. %{name}) in this example. dist tag is present. build root is correct. %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) license field matches the actual license. license is open source-compatible. License text included in package. latest version is being packaged. ###BuildRequires are proper ###One of the plugins require libdjconsole-devel which is not available. But this plugin is not enabled by default, so I think it's fine. compiler flags are appropriate. %clean is present. package installs properly package uninstalls properly debuginfo package looks complete. ###is rpmlint silent? ###No but the the warning is from the debug-info package: mixxx-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/mixxx-1.6.1/src/.obj ###which can be ignored final provides and requires are sane. owns the directories it creates. doesn't own any directories it shouldn't. no duplicates in %files. file permissions are appropriate. no scriptlets present. code, not content. documentation is small, so no -docs subpackage is necessary. %docs are not necessary for the proper functioning of the package. no headers. no libtool .la droppings. ###GUI app: desktop file placed in proper place. no mime-types installed. ###desktop-file-install called properly. I just have one question here: What ###is this for? : --remove-category Application RPMFUSION The package can be published in rpmfusion because it requires(build-requires) libmad(libmad-devel), which is not available through Fedora but through rpmfusion. ---- The package can be approved when the above issue is fixed. (It can even be approved now if we are not as strict as Fedora in terms of packaging guidelines.) But since I'm not sponsored yet, I can't do this. I hope this guide helps the actual reviewer. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.