[Bug 309] Review request: openttd - An open source reimplementation of the game "Transport Tycoon Deluxe"

http://bugzilla.rpmfusion.org/show_bug.cgi?id=309 --- Comment #4 from Andrea Musuruane <musuruan(a)gmail.com&gt; 2009-01-09 12:31:56 --- I don't see anything wrong in submitting this now to RPM Fusion and moving it later to Fedora (with a quick review since the package should not have any problems if we review it here now). Looking at the spec file I see: * macro usage should be improved in source URL: Source0: http://dl.sourceforge.net/openttd/%{name}-%{version}-source.tar.bz2 also use %{name} instead of openttd. * desktop-file-install --vendor="fedora" \ --dir=${RPM_BUILD_ROOT}%{_datadir}/applications %{SOURCE1} You must not use a vendor. Please read: https://fedoraproject.org/wiki/TomCallaway/DesktopFileVendor * Moreover, why didn't you use the upstream desktop file? Cannot it be adjusted with desktop-file-install or patched to be compliant? * You have at least an unowned directory. %{_datadir}/pixmaps is not provided by any of the packages you require. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.