[Bug 2151] New: Review request: perle-serial-kmod - Perle Serial PCI card kernel module(s)
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2151
Bug #: 2151
Summary: Review request: perle-serial-kmod - Perle Serial PCI
card kernel module(s)
Classification: Unclassified
Product: Package Reviews
Version: Current
Platform: All
OS/Version: GNU/Linux
Status: NEW
Severity: normal
Priority: P5
Component: Review Request
AssignedTo: rpmfusion-package-review(a)rpmfusion.org
ReportedBy: philipp(a)redfish-solutions.com
CC: rpmfusion-package-review(a)rpmfusion.org
Perle Systems makes several PCI and PCIe serial cards, but there support for
linux 2.6 and 3.x is lacking.
This package patches their driver tarball and builds it as per rpmfusion as
kmod.
ftp://ftp.redfish-solutions.com/pub/perle-serial-kmod.spec
ftp://ftp.redfish-solutions.com/pub/perle-serial-kmod-3.8.0-6.1.fc16.1.sr...
== description ==
This package provides a driver for the family of Perle serial cards.
The cards supported are:
Perle UltraPort1, 2, 4, 8, 8i, and 16 cards
Perle UltraPort1, 2, 4, 8, 8i, and 16 SI cards
Perle UltraPort1, 2, 4, 8, and 8i Express cards
Perle PCI-RAS V.92 (4 and 8 port) cards
Perle Speed1, 2, 4, and 8 LE cards
Read /usr/share/doc/perle-serial/README for more info.
====
This is a kmod package, and as such can't be included in Fedora.
====
$ rpmlint perle-serial-kmod.spec
perle-serial-kmod.spec:44: W: mixed-use-of-spaces-and-tabs (spaces: line 44,
tab: line 6)
0 packages and 1 specfiles checked; 0 errors, 1 warnings.
$
The spaces come as a result of cut&paste of taking the description directly
from upstream files.
$ rpmlint ../RPMS/x86_64/*perle-serial*
kmod-perle-serial-3.1.9-1.fc16.x86_64.x86_64: W: summary-not-capitalized C
perle-serial kernel module(s) for 3.1.9-1.fc16.x86_64
kmod-perle-serial-3.1.9-1.fc16.x86_64.x86_64: W: unstripped-binary-or-object
/lib/modules/3.1.9-1.fc16.x86_64/extra/perle-serial/perle-serial.ko
kmod-perle-serial-3.1.9-1.fc16.x86_64.x86_64: W: no-documentation
kmod-perle-serial.x86_64: W: spelling-error Summary(en_US) Metapackage -> Meta
package, Meta-package, Prepackage
kmod-perle-serial.x86_64: W: no-documentation
perle-serial-kmod-common.x86_64: W: spelling-error Summary(en_US) userland ->
user land, user-land, slanderous
perle-serial-kmod-common.x86_64: W: spelling-error %description -l en_US
Userland -> User land, User-land, Slanderous
perle-serial-kmod-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/perle-serial-kmod-3.8.0/_kmod_build_3.1.9-1.fc16.x86_64/perle-serial.c
4 packages and 0 specfiles checked; 1 errors, 7 warnings.
$
"Userland" and "Metapackage" are legitimate words in this lexicon.
The wrong FSF address in perle-serial.c is directly from the upstream sources.
Kernel modules are unstripped (or they wouldn't load otherwise).
The not capitalized warning applies to a string that's generated from a macro.
The documentation is in the -common package.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.