[Bug 985] Review request: ProjectX-0.90.4.00-2

http://bugzilla.rpmfusion.org/show_bug.cgi?id=985 --- Comment #16 from Göran Uddeborg <goeran(a)uddeborg.se&gt; 2010-08-02 18:18:52 --- A script is included as you suggested that does the download and tar packaging. (And excludes empty directories, I was fooled by my .cvsrc there.) This script makes the date part of the name. The start script in /usr/bin is a separate source file. That change also made the separate %attr() no longer needed. The tag name is adjusted to exactly match the wiki page. I'm not quite sure what other gcj bits you find missing. There are some additional comments on the wiki page on how to do with packages that have subpackages, but that doesn't apply to this package. Or do you mean you want an explicit %attr() although there is a %defattr()? I'm also no expert on Java, and try to follow the instructions. But I'm not sure what you see that I miss. I'm really confused why your build fails. It builds fine for me. Also with mock, which should rule out environment influences like .cvsrc above. Furthermore, your error message says it saves the rejects to MANIFEST.MF.rej, but ProjectX.sysjava.patch only patches build.sh. Is the ProjectX.sysjava.patch in your build environment not the one from the latest SRPM? Updated version available at: ftp://ftp.uddeborg.se/pub/ProjectX/ProjectX.spec ftp://ftp.uddeborg.se/pub/ProjectX/ProjectX-0.90.4.00-5.20100801cvs.fc14.src.rpm -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.