[Bug 3102] Review Request: vdr-softhddevice - A software and GPU emulated HD output device plugin for VDR
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3102
--- Comment #10 from Alec Leamas <leamas.alec(a)gmail.com> 2014-01-10 08:49:17 CET
---
No blocker, but please remove also gittag, using %short_commit in release
instead. After all, 5.%{short_commit}%{?disttag} is a perfectly sane
revision; %gittag just adds noise.
The fedora config file is fine just the user finds it. But generally
speaking, she will not do this since she will look in the docs for it.
Hence a specific README.fedora is probably needed which just says that
the configuration file is added. No blocker.
Is the %description outdated? The website lists (many) more capabilitites.
Or is it just that not everything is enabled in the Fedora build?
If the list becomes too long I'd suggest removing the planned features -
they are probably less interesting as package info.
Please try to reorganize %prep so all charset conversions are lumped
together and done in a (more) uniform way. As of now, you keep the date
on one file - the other is plain wrong (see the rpmlint warning). I
suggest for f in ChangeLog README.txt; do (...)
The sed patching of Makefile in %prep seems to be a no-op. Can you just
remove it?
The configuration seems somewhat messy. The Makefile looks for a pkgconfig
file, but vdr-devel does not provide this. OTOH vdr-devel does provide
a vdr-config binary, but this is not used in the Makefile. Probably worth
reporting upstream. If you maintain vdr-devel (?), you could just add a
pkgconfig .pc file to it so things are more consistent. Or patch Makefile to
use vdr-config. No blocker, it sort of "works" as-is.
You need to add %{optflags} to the build (CFLAGS=%{optflags} should
work, but must be checked.)
Rpmlint:
vdr-softhddevice.i686: W: file-not-utf8
/usr/share/doc/vdr-softhddevice-0.6.0/README.txt
vdr-softhddevice.i686: W: incoherent-version-in-changelog
0.6.0-5.git978fc59.fc20 ['0.6.0-5.git978fc59.fc19', '0.6.0-5.git978fc59']
Fix these (omit the disttag in the changelog revision, otherwise it fails
depending on buildhost).
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.