https://bugzilla.rpmfusion.org/show_bug.cgi?id=3493 tuxor1337(a)web.de changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2 -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3493 --- Comment #1 from tuxor1337(a)web.de 2015-02-16 11:54:02 CET --- New revised version of spec file: mp3splt-gtk - a GTK3 GUI that uses libmp3splt http://tovotu.de/data/rpmfusion/mp3splt-gtk-0.9.2-2.fc21.src.rpm http://tovotu.de/data/rpmfusion/mp3splt-gtk.spec mp3splt is not eligible to be included in Fedora because it depends on libmad at build time which uses patented technology (mp3 codec). rpmlint output: 1 packages and 0 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3493 MartinKG <mgansser(a)alice.de&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |3 AssignedTo|rpmfusion-package-review@rp |mgansser(a)alice.de |mfusion.org | -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3493 --- Comment #3 from MartinKG <mgansser(a)alice.de&gt; 2015-07-07 18:46:53 CEST --- can not do a fedora-review because some packages are not yet in the repo DEBUG util.py:378: Error: No Package found for libaudclient-devel >= 3.0 DEBUG util.py:378: Error: No Package found for libmp3splt-devel >= 0.9.2 -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3493 --- Comment #4 from MartinKG <mgansser(a)alice.de&gt; 2016-07-22 13:02:51 CEST --- 1. Is the description up to date ? The homepage on http://mp3splt.sourceforge.net/mp3splt_page/home.php tells me the following: "Mp3Splt-project is a utility to split mp3, ogg vorbis and native FLAC files selecting a begin and an end time position ...." 2. please remove comment or change it to # %%{_docdir}/mp3splt-gtk/doxygen 3. - update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in mp3splt-gtk See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop- database 4. Uses parallel make %{?_smp_mflags} macro. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3493 MartinKG <mgansser(a)alice.de&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|3 |4 --- Comment #6 from MartinKG <mgansser(a)alice.de&gt; 2016-07-23 14:53:11 CEST --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "GPL (v2 or later)", "Unknown or generated". 28 files have unknown license. Detailed output of licensecheck in /home/martin/rpmbuild/SPECS/mp3splt- gtk/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gnome/help [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in mp3splt-gtk [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 81920 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mp3splt- gtk-debuginfo [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros Rpmlint ------- Checking: mp3splt-gtk-0.9.2-1.fc25.x86_64.rpm mp3splt-gtk-debuginfo-0.9.2-1.fc25.x86_64.rpm mp3splt-gtk-0.9.2-1.fc25.src.rpm mp3splt-gtk.x86_64: W: spelling-error Summary(en_US) frontend -> fronted, front end, front-end mp3splt-gtk.x86_64: W: spelling-error %description -l en_US ogg -> egg, org, Gog mp3splt-gtk.x86_64: W: spelling-error %description -l en_US vorbis -> Orbison mp3splt-gtk.x86_64: W: spelling-error %description -l en_US filenames -> file names, file-names, filaments mp3splt-gtk.x86_64: W: spelling-error %description -l en_US cddb -> Cd mp3splt-gtk.x86_64: W: spelling-error %description -l en_US splitpoints -> split points, split-points, shinsplints mp3splt-gtk.src: W: spelling-error Summary(en_US) frontend -> fronted, front end, front-end mp3splt-gtk.src: W: spelling-error %description -l en_US ogg -> egg, org, Gog mp3splt-gtk.src: W: spelling-error %description -l en_US vorbis -> Orbison mp3splt-gtk.src: W: spelling-error %description -l en_US filenames -> file names, file-names, filaments mp3splt-gtk.src: W: spelling-error %description -l en_US cddb -> Cd mp3splt-gtk.src: W: spelling-error %description -l en_US splitpoints -> split points, split-points, shinsplints 3 packages and 0 specfiles checked; 0 errors, 12 warnings. Rpmlint (debuginfo) ------------------- Checking: mp3splt-gtk-debuginfo-0.9.2-1.fc25.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- mp3splt-gtk.x86_64: W: spelling-error Summary(en_US) frontend -> fronted, front end, front-end mp3splt-gtk.x86_64: W: spelling-error %description -l en_US ogg -> egg, org, Gog mp3splt-gtk.x86_64: W: spelling-error %description -l en_US vorbis -> Orbison mp3splt-gtk.x86_64: W: spelling-error %description -l en_US filenames -> file names, file-names, filaments mp3splt-gtk.x86_64: W: spelling-error %description -l en_US cddb -> Cd mp3splt-gtk.x86_64: W: spelling-error %description -l en_US splitpoints -> split points, split-points, shinsplints 2 packages and 0 specfiles checked; 0 errors, 6 warnings. Requires -------- mp3splt-gtk-debuginfo (rpmlib, GLIBC filtered): mp3splt-gtk (rpmlib, GLIBC filtered): /bin/sh desktop-file-utils libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo-gobject.so.2()(64bit) libcairo.so.2()(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgstreamer-1.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libm.so.6()(64bit) libmp3splt.so.0()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) rtld(GNU_HASH) Provides -------- mp3splt-gtk-debuginfo: mp3splt-gtk-debuginfo mp3splt-gtk-debuginfo(x86-64) mp3splt-gtk: application() application(mp3splt-gtk.desktop) mimehandler(application/ogg) mimehandler(application/x-cddb) mimehandler(application/x-cue) mimehandler(audio/mpeg) mimehandler(audio/ogg) mimehandler(audio/x-mp3) mimehandler(audio/x-vorbis+ogg) mp3splt-gtk mp3splt-gtk(x86-64) Source checksums ---------------- http://downloads.sourceforge.net/mp3splt/mp3splt-gtk-0.9.2.tar.gz : CHECKSUM(SHA256) this package : 2084cc942b5d1aa6ff74848a41d05cb37876cbc74dfdc341ceb424c763887650 CHECKSUM(SHA256) upstream package : 2084cc942b5d1aa6ff74848a41d05cb37876cbc74dfdc341ceb424c763887650 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64-rpmfusion_free -rn ../SRPMS/mp3splt-gtk-0.9.2-1.fc24.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 **************************************************** No issues. Package is APPROVED . -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3493 Nicolas Chauvet <kwizart(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33 | -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.