http://bugzilla.rpmfusion.org/show_bug.cgi?id=479 Zarko Pintar <zarko.pintar(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zarko.pintar(a)gmail.com --- Comment #2 from Zarko Pintar <zarko.pintar(a)gmail.com&gt; 2009-04-09 08:53:28 --- (In reply to comment #0) Hmm, correct paths to spec and rpm must be this: SPEC: http://6mata.com/review/xmms-mplayer.spec SRPM: http://6mata.com/review/xmms-mplayer-0.5-1.fc10.src.rpm I can not open files via :8014!! Zarko -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=479 --- Comment #4 from Jussi Lehtola <jussi.lehtola(a)iki.fi&gt; 2009-05-21 11:14:08 --- rpmlint output is clean. MUST: The spec file for the package is legible and macros are used consistently. OK MUST: The package must be named according to the Package Naming Guidelines. - The name of the package should perhaps be xmmsmplayer as it is the name of the tarball and of the upstream project. However, upstream refers to this as xmms-mplayer which is more logical, so this is OK. MUST: The spec file name must match the base package %{name}. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. NEEDSWORK - I can't find a single mention of a license in the tarball, webpage states its contents is licensed under GPL. Please contact author to get license headers in source code. MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. OK MUST: The package MUST successfully compile and build into binary rpms. OK MUST: The spec file MUST handle locales properly. N/A MUST: Optflags are used and time stamps preserved. OK - Time stamps are not preserved in make install, but the only things installed are compiled files. However it would be nice to preserve time stamps for those, too. MUST: Packages containing shared library files must call ldconfig. N/A MUST: A package must own all directories that it creates or require the package that owns the directory. NEEDSWORK - Add explicit Requires: xmms-libs for dir ownership. (Although this is pulled in by xmms's requirement on libxmms.so.1) MUST: Files only listed once in %files listings. OK MUST: Debuginfo package is complete. OK MUST: Permissions on files must be set properly. OK MUST: Clean section exists. OK MUST: Large documentation files must go in a -doc subpackage. OK MUST: All relevant items are included in %doc. Items in %doc do not affect runtime of application. OK - You might want to add a [ -s NEWS ] && exit 1 to the setup phase so that if NEWS becomes a non-empty file the build fails. MUST: Header files must be in a -devel package. N/A MUST: Static libraries must be in a -static package. N/A MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A MUST: If a package contains library files with a suffix then library files ending in .so must go in a -devel package. N/A MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency. N/A MUST: Packages does not contain any .la libtool archives. OK MUST: Desktop files are installed properly. N/A MUST: No file conflicts with other packages and no general names. OK MUST: Buildroot cleaned before install. OK SHOULD: %{?dist} tag is used in release. OK SHOULD: If the package does not include license text(s) as separate files from upstream, the packager should query upstream to include it. OK SHOULD: The package builds in mock. OK -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=479 Jussi Lehtola <jussi.lehtola(a)iki.fi&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|3 |4 --- Comment #6 from Jussi Lehtola <jussi.lehtola(a)iki.fi&gt; 2009-05-21 19:37:42 --- (In reply to comment #5) Right, hadn't noticed that. Well, according to https://fedoraproject.org/wiki/Licensing/FAQ#How_do_I_figure_out_what_ver... the COPYING file included is the last resort; if it's a GPL copying then license tag should be set to GPL+, so that's OK. Well, I'm not quite sure how to read the guidelines on this one. The end result is that the package requires the libs package due to the .so dependency, and since the xmms is very old this is probably OK. The package has been APPROVED -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=479 Thorsten Leemhuis <fedora(a)leemhuis.info&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33 | --- Comment #8 from Thorsten Leemhuis <fedora(a)leemhuis.info&gt; 2009-05-21 19:56:28 --- (In reply to comment #7) done -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.