[Bug 750] New: Review request: opencore-amr - OpenCORE Adaptive Multi Rate Narrowband and Wideband speech lib
8:48 a.m.
http://bugzilla.rpmfusion.org/show_bug.cgi?id=750
Summary: Review request: opencore-amr - OpenCORE Adaptive Multi
Rate Narrowband and Wideband speech lib
Product: Package Reviews
Version: Current
Platform: All
OS/Version: GNU/Linux
Status: NEW
Severity: normal
Priority: P5
Component: Review Request
AssignedTo: rpmfusion-package-review(a)rpmfusion.org
ReportedBy: j.w.r.degoede(a)hhs.nl
CC: rpmfusion-package-review(a)rpmfusion.org
Estimated Hours: 0.0
SPEC: http://people.atrpms.net/~hdegoede/opencore-amr.spec
SRPM: http://people.atrpms.net/~hdegoede/opencore-amr-0.1.1-1.fc11.src.rpm
Library of OpenCORE Framework implementation of Adaptive Multi Rate Narrowband
and Wideband speech codec.
rpmlint says:
opencore-amr-devel.x86_64: W: no-documentation
Which can be ignored.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:48 a.m.
New subject: [Bug 750] Review request: opencore-amr - OpenCORE Adaptive Multi Rate Narrowband and Wideband speech lib
http://bugzilla.rpmfusion.org/show_bug.cgi?id=750
Hans de Goede <j.w.r.degoede(a)hhs.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |2
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:02 a.m.
New subject: [Bug 750] Review request: opencore-amr - OpenCORE Adaptive Multi Rate Narrowband and Wideband speech lib
http://bugzilla.rpmfusion.org/show_bug.cgi?id=750
--- Comment #1 from Hans de Goede <j.w.r.degoede(a)hhs.nl> 2009-08-06 11:02:44 ---
p.s.
Why not Fedora?
Because the amr codecs are patented
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:15 a.m.
New subject: [Bug 750] Review request: opencore-amr - OpenCORE Adaptive Multi Rate Narrowband and Wideband speech lib
http://bugzilla.rpmfusion.org/show_bug.cgi?id=750
Till Maas <opensource(a)till.name> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |opensource(a)till.name
--- Comment #2 from Till Maas <opensource(a)till.name> 2009-08-06 11:15:39 ---
Source0 does not work and there are no files released at SF.net:
https://sourceforge.net/projects/opencore-amr/files/
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:25 a.m.
New subject: [Bug 750] Review request: opencore-amr - OpenCORE Adaptive Multi Rate Narrowband and Wideband speech lib
http://bugzilla.rpmfusion.org/show_bug.cgi?id=750
--- Comment #3 from Hans de Goede <j.w.r.degoede(a)hhs.nl> 2009-08-06 11:25:16 ---
(In reply to comment #2)
Source0 does not work and there are no files released at SF.net:
https://sourceforge.net/projects/opencore-amr/files/
Weird,
I downloaded the tar.gz file in the src.rpm using spectool, so the URL
definitely
was correct a couple of days ago.
Also if you look here:
http://sourceforge.net/projects/opencore-amr/
And then scroll down in the newsfeed you will see an item about the release
of the opencore-amr-0.1.1.tar.gz file, and a link to it (which no longer
works).
This could be some temporary sourceforge glitch I guess ??
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9 a.m.
New subject: [Bug 750] Review request: opencore-amr - OpenCORE Adaptive Multi Rate Narrowband and Wideband speech lib
http://bugzilla.rpmfusion.org/show_bug.cgi?id=750
Andrea Musuruane <musuruan(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |musuruan(a)gmail.com
Blocks|2 |3
AssignedTo|rpmfusion-package- |musuruan(a)gmail.com
|review(a)rpmfusion.org |
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9 a.m.
New subject: [Bug 750] Review request: opencore-amr - OpenCORE Adaptive Multi Rate Narrowband and Wideband speech lib
http://bugzilla.rpmfusion.org/show_bug.cgi?id=750
Andrea Musuruane <musuruan(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
9:41 a.m.
New subject: [Bug 750] Review request: opencore-amr - OpenCORE Adaptive Multi Rate Narrowband and Wideband speech lib
http://bugzilla.rpmfusion.org/show_bug.cgi?id=750
Andrea Musuruane <musuruan(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|3 |4
--- Comment #4 from Andrea Musuruane <musuruan(a)gmail.com> 2009-08-07 11:41:24 ---
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (ASL 2.0)
OK - License field in spec matches
see below - License file included in package
OK - Spec in American English
OK - Spec is legible.
see below - Sources match upstream md5sum:
NA - Package needs ExcludeArch
OK - BuildRequires correct
NA - Spec handles locales/find_lang
NA - Package is relocatable and has a reason to be.
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
OK, RPM Fusion - Package is code or permissible content.
NA - Doc subpackage needed/used.
OK - Packages %doc files don't affect runtime.
OK - Headers/static libs in -devel subpackage.
OK - Spec has needed ldconfig in post and postun
NA - .pc files in -devel subpackage/requires pkgconfig
OK - .so files in -devel subpackage.
OK - -devel package Requires: %{name} = %{version}-%{release}
OK - .la files are removed.
NA - Package is a GUI app and has a .desktop file
OK - Package compiles and builds on at least one arch. (F11/x84_64)
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
opencore-amr-devel.x86_64: W: no-documentation
OK - final provides and requires are sane:
opencore-amr-0.1.1-1.fc10.src.rpm
=
rpmlib(CompressedFileNames) <= 3.0.4-1
opencore-amr-0.1.1-1.fc10.x86_64.rpm
libopencore-amrnb.so.0()(64bit)
libopencore-amrwb.so.0()(64bit)
opencore-amr = 0.1.1-1.fc10
opencore-amr(x86-64) = 0.1.1-1.fc10
=
/sbin/ldconfig
/sbin/ldconfig
libc.so.6()(64bit)
libc.so.6(GLIBC_2.2.5)(64bit)
libc.so.6(GLIBC_2.3.4)(64bit)
libopencore-amrnb.so.0()(64bit)
libopencore-amrwb.so.0()(64bit)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rtld(GNU_HASH)
opencore-amr-debuginfo-0.1.1-1.fc10.x86_64.rpm
opencore-amr-debuginfo = 0.1.1-1.fc10
opencore-amr-debuginfo(x86-64) = 0.1.1-1.fc10
=
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
opencore-amr-devel-0.1.1-1.fc10.x86_64.rpm
opencore-amr-devel = 0.1.1-1.fc10
opencore-amr-devel(x86-64) = 0.1.1-1.fc10
=
libopencore-amrnb.so.0()(64bit)
libopencore-amrwb.so.0()(64bit)
opencore-amr = 0.1.1-1.fc10
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
SHOULD Items:
OK - Should build in mock. (fedora-11-x86_64)
see below - Should function as described.
OK - Should have sane scriptlets.
OK - Should have subpackages require base package with fully versioned depend.
OK - Should have dist tag
see below - Should package latest version
Issues:
1. The source package does not include the text of the license, you should
contact upstream and encourage them to correct this mistake.
2. I couldn't check if sources matches upstream because they are no longer
available. I couldn't even tell if you packaged the latest version. I have to
trust you.
3. How can I test this library? Is there any program that can already use it?
These issues are not mandatory.
APPROVED!
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
3:12 p.m.
New subject: [Bug 750] Review request: opencore-amr - OpenCORE Adaptive Multi Rate Narrowband and Wideband speech lib
http://bugzilla.rpmfusion.org/show_bug.cgi?id=750
--- Comment #5 from Hans de Goede <j.w.r.degoede(a)hhs.nl> 2009-08-07 17:12:39 ---
(In reply to comment #4)
1. The source package does not include the text of the license, you
should
contact upstream and encourage them to correct this mistake.
It does, see:
opencore-amr/opencore/NOITCE
2. I couldn't check if sources matches upstream because they are
no longer
available. I couldn't even tell if you packaged the latest version. I have to
trust you.
I know, this sucks, it was still there a week ago I'll send upstream a mail
about this, its weird.
3. How can I test this library? Is there any program that can already
use it?
Once this is build I'll do a new gstreamer-ugly release which uses this to
generate amr decoding plugins. Then you should be able to play .3gp movies
with sound in gstreamer apps (such as totem).
APPROVED!
Thanks for the trust!
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
3:14 p.m.
New subject: [Bug 750] Review request: opencore-amr - OpenCORE Adaptive Multi Rate Narrowband and Wideband speech lib
http://bugzilla.rpmfusion.org/show_bug.cgi?id=750
Hans de Goede <j.w.r.degoede(a)hhs.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |33
--- Comment #6 from Hans de Goede <j.w.r.degoede(a)hhs.nl> 2009-08-07 17:14:46 ---
Package CVS request
======================
Package Name: opencore-amr
Short Description: OpenCORE Adaptive Multi Rate Narrowband and Wideband speech
lib
Owners: jwrdegoede
Branches: F-10 F-11
InitialCC:
----------------------
License tag: free
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
4:18 p.m.
New subject: [Bug 750] Review request: opencore-amr - OpenCORE Adaptive Multi Rate Narrowband and Wideband speech lib
http://bugzilla.rpmfusion.org/show_bug.cgi?id=750
--- Comment #7 from Andrea Musuruane <musuruan(a)gmail.com> 2009-08-07 18:18:21 ---
(In reply to comment #5)
(In reply to comment #4)
> 1. The source package does not include the text of the license, you should
> contact upstream and encourage them to correct this mistake.
>
It does, see:
opencore-amr/opencore/NOITCE
No, it does not. NOTICE only includes this text:
/* ------------------------------------------------------------------
* Copyright (C) 2009 PacketVideo
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied.
* See the License for the specific language governing permissions
* and limitations under the License.
* -------------------------------------------------------------------
*/
With a pointer to the license.
Fedora guidelines state: "If the source package does not include the text of
the license(s), the packager should contact upstream and encourage them to
correct this mistake."
(http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text)
Therefore you should ask upstrem to include the full text of the license:
http://www.apache.org/licenses/LICENSE-2.0.txt
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
5:10 p.m.
New subject: [Bug 750] Review request: opencore-amr - OpenCORE Adaptive Multi Rate Narrowband and Wideband speech lib
http://bugzilla.rpmfusion.org/show_bug.cgi?id=750
Thorsten Leemhuis <fedora(a)leemhuis.info> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|33 |
--- Comment #8 from Thorsten Leemhuis <fedora(a)leemhuis.info> 2009-08-08 19:10:29
---
(In reply to comment #6)
Package CVS request
done
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
7:10 p.m.
New subject: [Bug 750] Review request: opencore-amr - OpenCORE Adaptive Multi Rate Narrowband and Wideband speech lib
http://bugzilla.rpmfusion.org/show_bug.cgi?id=750
--- Comment #9 from Hans de Goede <j.w.r.degoede(a)hhs.nl> 2009-08-11 21:10:34 ---
(In reply to comment #7)
> It does, see:
> opencore-amr/opencore/NOITCE
No, it does not. NOTICE only includes this text:
<snip>
With a pointer to the license.
Fedora guidelines state: "If the source package does not include the text of
the license(s), the packager should contact upstream and encourage them to
correct this mistake."
(http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text)
Therefore you should ask upstrem to include the full text of the license:
http://www.apache.org/licenses/LICENSE-2.0.txt
Ah, ofcourse you are right, sorry. I've mailed upstream about this.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
8:03 p.m.
New subject: [Bug 750] Review request: opencore-amr - OpenCORE Adaptive Multi Rate Narrowband and Wideband speech lib
http://bugzilla.rpmfusion.org/show_bug.cgi?id=750
Hans de Goede <j.w.r.degoede(a)hhs.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #10 from Hans de Goede <j.w.r.degoede(a)hhs.nl> 2009-08-11 22:03:10 ---
Thanks for the CVS module creation, imported and build for F-11 and devel,
closing.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
5371
days inactive
5376
days old
rpmfusion-developers@lists.rpmfusion.org
13 comments
1 participants
participants (1)
-
RPM Fusion Bugzilla