https://bugzilla.rpmfusion.org/show_bug.cgi?id=2429 Andrea Musuruane <musuruan(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |musuruan(a)gmail.com --- Comment #1 from Andrea Musuruane <musuruan(a)gmail.com&gt; 2012-07-31 12:19:45 CEST --- Hi Jeremy! I had a glance yesterday at your package and I found some issues. But I noticed that the version you are packaging is almost 3 years old. Considering the current upstream GIT version uses another build-system and another toolkit, I wonder if it is not the case to package a preview of the next release, thus you can work with upstream to solve some issues. What do you think? BTW, the License: field refers to the licenses of the contents of the binary rpm. It is not a list of licences used in the source files. Therefore the license of gens-gs should be GPLv2+ (that is what you get combining LGPLv2+ and GPLv2+ sources). https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License:_field Both v2.16.7 and the current GIT version are bundling a lot of external libraries. This is not permitted and the package should be patched to use the system libraries. https://fedoraproject.org/wiki/Packaging:Guidelines#Duplication_of_system... Conflicts should also be avoided. You can work with upstream to resolve the conflict with gens. I don't know how stable is the current GIT version, so there can be a time where a user wants to have both gens and gens-gs installed. https://fedoraproject.org/wiki/Packaging:Guidelines#Conflicts -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2429 --- Comment #3 from Andrea Musuruane <musuruan(a)gmail.com&gt; 2012-08-02 10:33:32 CEST --- (In reply to comment #2) You are welcome! Try talking with upstream about his plans. I think it may be good for him to know there is interest in his project. There is another problem I'd like to point out. There reason why gens-gs must currently go to nonfree is because of the starscream license is incompatible with GPLv2+: http://developer.berlios.de/docman/display_doc.php?docid=1708&group_i... More info here: http://www.lutris.net/blog/2010/04/25/day-15-sonic-2-on-sega-genesis-1992/ What about talking with upstream about not using starscream? After all, the internet is full of CPU emulators (and GPL licensed ones). An emulator written in C would also be great for portability. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2429 --- Comment #5 from Jeremy Newton <alexjnewt(a)gmail.com&gt; 2014-01-02 02:30:58 CET --- Note that all RPMLint errors are the same save for a new one: configure-without-libdir-spec. I'm a little confused about this error as setting the libdir doesn't seem to silence this for me. I'm assuming it's a false positive. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2429 Michael Cronenworth <mike(a)cchtml.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mike(a)cchtml.com Blocks|2 |3 AssignedTo|rpmfusion-package-review@rp |mike(a)cchtml.com |mfusion.org | --- Comment #7 from Michael Cronenworth <mike(a)cchtml.com&gt; 2014-10-05 19:19:56 CEST --- I'll review this. I see the Conflicts is still in place. Do you plan on retiring the "gens" package? Do you have a Fedora FAS or RPMFusion FAS account? What is your user name? Preliminary review: Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not contain any libtool archives (.la) Note: gens-gs : /usr/lib/mdp/mdp_misc_game_genie.la gens-gs : /usr/lib/mdp/mdp_misc_ips_patcher.la gens-gs : /usr/lib/mdp/mdp_misc_sgens.la gens-gs : /usr/lib/mdp/mdp_misc_vdp_layer_options.la gens-gs : /usr/lib/mdp/mdp_render_2xsai.la gens-gs : /usr/lib/mdp/mdp_render_blargg_ntsc.la gens-gs : /usr/lib/mdp/mdp_render_epx.la gens-gs : /usr/lib/mdp/mdp_render_epx_plus.la gens-gs : /usr/lib/mdp/mdp_render_hq2x.la gens-gs : /usr/lib/mdp/mdp_render_hq3x.la gens-gs : /usr/lib/mdp/mdp_render_hq4x.la gens-gs : /usr/lib/mdp/mdp_render_interpolated.la gens-gs : /usr/lib/mdp/mdp_render_interpolated_scanline.la gens-gs : /usr/lib/mdp/mdp_render_interpolated_scanline_25.la gens-gs : /usr/lib/mdp/mdp_render_interpolated_scanline_50.la gens-gs : /usr/lib/mdp/mdp_render_scale2x.la gens-gs : /usr/lib/mdp/mdp_render_scale3x.la gens-gs : /usr/lib/mdp/mdp_render_scale4x.la gens-gs : /usr/lib/mdp/mdp_render_scanline.la gens-gs : /usr/lib/mdp/mdp_render_scanline_25.la gens-gs : /usr/lib/mdp/mdp_render_scanline_50.la gens-gs : /usr/lib/mdp/mdp_render_super_2xsai.la gens-gs : /usr/lib/mdp/mdp_render_super_eagle.la See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries (Please delete all libtool files) - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1884160 bytes in 99 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation (Could you use %doc for README and license files?) - License field needs to reflect free and non-free licensed pieces (MIT, BSD, and a non-free license were found) - Conflicts with "gens" - will you retire "gens" or patch this package to not conflict with it? ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2 or later)", "GPL (v2 or later)", "Unknown or generated", "MIT/X11 (BSD like)", "BSD (3 clause)", "GPL (v2 or later) (with incorrect FSF address)", "ISC", "LGPL (v2.1 or later)". 64 files have unknown license. Detailed output of licensecheck in /home/michael/Downloads/gens-gs/licensecheck.txt [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/gens(gens) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [!]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [!]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in gens-gs [x]: Useful -debuginfo package or justification otherwise. [-]: Package is not known to require an ExcludeArch tag. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1996800 bytes in /usr/share [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: gens-gs-2.16.7-3.fc20.i686.rpm gens-gs-2.16.7-3.fc20.src.rpm gens-gs.i686: E: incorrect-fsf-address /usr/share/doc/gens-gs-2.16.7/COPYING.txt gens-gs.i686: W: no-manual-page-for-binary mdp_test gens-gs.i686: W: no-manual-page-for-binary gens gens-gs.src:46: W: configure-without-libdir-spec 2 packages and 0 specfiles checked; 1 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint gens-gs gens-gs.i686: E: incorrect-fsf-address /usr/share/doc/gens-gs-2.16.7/COPYING.txt gens-gs.i686: W: no-manual-page-for-binary mdp_test gens-gs.i686: W: no-manual-page-for-binary gens 1 packages and 0 specfiles checked; 1 errors, 2 warnings. # echo 'rpmlint-done:' Requires -------- gens-gs (rpmlib, GLIBC filtered): /bin/sh hicolor-icon-theme libGL.so.1 libSDL-1.2.so.0 libX11.so.6 libatk-1.0.so.0 libc.so.6 libcairo.so.2 libdl.so.2 libfontconfig.so.1 libfreetype.so.6 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgdk-x11-2.0.so.0 libgdk_pixbuf-2.0.so.0 libgio-2.0.so.0 libglib-2.0.so.0 libgobject-2.0.so.0 libgtk-x11-2.0.so.0 libm.so.6 libminizip.so.1 libpango-1.0.so.0 libpangocairo-1.0.so.0 libpangoft2-1.0.so.0 libpng16.so.16 libpng16.so.16(PNG16_0) libpthread.so.0 librt.so.1 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libz.so.1 Provides -------- gens-gs: application() application(gens.desktop) gens-gs gens-gs(x86-32) libtool(/usr/lib/mdp/mdp_misc_game_genie.la) libtool(/usr/lib/mdp/mdp_misc_ips_patcher.la) libtool(/usr/lib/mdp/mdp_misc_sgens.la) libtool(/usr/lib/mdp/mdp_misc_vdp_layer_options.la) libtool(/usr/lib/mdp/mdp_render_2xsai.la) libtool(/usr/lib/mdp/mdp_render_blargg_ntsc.la) libtool(/usr/lib/mdp/mdp_render_epx.la) libtool(/usr/lib/mdp/mdp_render_epx_plus.la) libtool(/usr/lib/mdp/mdp_render_hq2x.la) libtool(/usr/lib/mdp/mdp_render_hq3x.la) libtool(/usr/lib/mdp/mdp_render_hq4x.la) libtool(/usr/lib/mdp/mdp_render_interpolated.la) libtool(/usr/lib/mdp/mdp_render_interpolated_scanline.la) libtool(/usr/lib/mdp/mdp_render_interpolated_scanline_25.la) libtool(/usr/lib/mdp/mdp_render_interpolated_scanline_50.la) libtool(/usr/lib/mdp/mdp_render_scale2x.la) libtool(/usr/lib/mdp/mdp_render_scale3x.la) libtool(/usr/lib/mdp/mdp_render_scale4x.la) libtool(/usr/lib/mdp/mdp_render_scanline.la) libtool(/usr/lib/mdp/mdp_render_scanline_25.la) libtool(/usr/lib/mdp/mdp_render_scanline_50.la) libtool(/usr/lib/mdp/mdp_render_super_2xsai.la) libtool(/usr/lib/mdp/mdp_render_super_eagle.la) Unversioned so-files -------------------- gens-gs: /usr/lib/mdp/mdp_misc_game_genie.so gens-gs: /usr/lib/mdp/mdp_misc_ips_patcher.so gens-gs: /usr/lib/mdp/mdp_misc_sgens.so gens-gs: /usr/lib/mdp/mdp_misc_vdp_layer_options.so gens-gs: /usr/lib/mdp/mdp_render_2xsai.so gens-gs: /usr/lib/mdp/mdp_render_blargg_ntsc.so gens-gs: /usr/lib/mdp/mdp_render_epx.so gens-gs: /usr/lib/mdp/mdp_render_epx_plus.so gens-gs: /usr/lib/mdp/mdp_render_hq2x.so gens-gs: /usr/lib/mdp/mdp_render_hq3x.so gens-gs: /usr/lib/mdp/mdp_render_hq4x.so gens-gs: /usr/lib/mdp/mdp_render_interpolated.so gens-gs: /usr/lib/mdp/mdp_render_interpolated_scanline.so gens-gs: /usr/lib/mdp/mdp_render_interpolated_scanline_25.so gens-gs: /usr/lib/mdp/mdp_render_interpolated_scanline_50.so gens-gs: /usr/lib/mdp/mdp_render_scale2x.so gens-gs: /usr/lib/mdp/mdp_render_scale3x.so gens-gs: /usr/lib/mdp/mdp_render_scale4x.so gens-gs: /usr/lib/mdp/mdp_render_scanline.so gens-gs: /usr/lib/mdp/mdp_render_scanline_25.so gens-gs: /usr/lib/mdp/mdp_render_scanline_50.so gens-gs: /usr/lib/mdp/mdp_render_super_2xsai.so gens-gs: /usr/lib/mdp/mdp_render_super_eagle.so Source checksums ---------------- http://segaretro.org/images/6/6d/Gens-gs-r7.tar.gz : CHECKSUM(SHA256) this package : 6320cd7bee85472891e1e29b21731d2c8180d04db67ee21256491f3f9ad145c1 CHECKSUM(SHA256) upstream package : 6320cd7bee85472891e1e29b21731d2c8180d04db67ee21256491f3f9ad145c1 AutoTools: Obsoleted m4s found ------------------------------ AC_PROG_LIBTOOL found in: gens-gs-r7/configure.ac:45 -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2429 --- Comment #9 from Michael Cronenworth <mike(a)cchtml.com&gt; 2014-10-05 21:35:49 CEST --- (In reply to comment #8) Hm.. it doesn't make sense to have two packages that do the same thing that come from the same source, but please patch around the conflict. You can ignore this. Yes, but please keep README, COPYING, etc. in %doc in your mail %files list. It's a false positive. It sees you modified configure.ac. Upon further looking at the %configure line, you should not need to pass prefix or build options. No. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2429 --- Comment #11 from Andrea Musuruane <musuruan(a)gmail.com&gt; 2014-10-05 22:37:03 CEST --- (In reply to comment #10) I'm gens maintainer. I really don't like when people puts words in my mouth. This is what I said at the time: https://bugzilla.rpmfusion.org/show_bug.cgi?id=2392#c1 -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2429 --- Comment #13 from Jeremy Newton <alexjnewt(a)gmail.com&gt; 2014-10-27 23:45:50 CET --- Sorry for the delay again, looks like my autoconf skills are a little rusty. SPEC URL: http://dl.dropbox.com/u/42480493/gens-gs.spec SOURCE RPM URL: http://dl.dropbox.com/u/42480493/gens-gs-2.16.7-5.fc20.src.rpm Everything should be fixed and gens-gs no longer conflicts with gens. Let me know if I missed something. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2429 Jeremy Newton <alexjnewt(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33 --- Comment #15 from Jeremy Newton <alexjnewt(a)gmail.com&gt; 2014-10-28 00:57:41 CET --- Thanks! I'll remove the --prefix=/usr before I upload it. Package CVS request ====================== Package Name: gens-gs Short Description: Sega Genesis, Sega CD, and Sega 32X emulator Owners: jem256 Branches: F-19 F-20 devel InitialCC: ---------------------- License tag: nonfree -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2429 Jeremy Newton <alexjnewt(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #16 from Jeremy Newton <alexjnewt(a)gmail.com&gt; 2014-11-25 01:24:00 CET --- Good to go; built and should be in testing within a few days -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.