[Bug 1992] New: Review Request: winetricks - Package manager for Win32 DLLs and applications on POSIX
11:55 a.m.
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1992
Summary: Review Request: winetricks - Package manager for Win32
DLLs and applications on POSIX
Product: Package Reviews
Version: Current
Platform: All
OS/Version: GNU/Linux
Status: NEW
Severity: normal
Priority: P5
Component: Review Request
AssignedTo: rpmfusion-package-review(a)rpmfusion.org
ReportedBy: tc(a)tchol.org
CC: rpmfusion-package-review(a)rpmfusion.org
Estimated Hours: 0.0
Spec: http://tchol.org/rpmfusion/winetricks.spec
SRPM: http://tchol.org/rpmfusion/winetricks-20110629-1.fc16.src.rpm
Description:
Winetricks is an easy way to work around problems in Wine.
It has a menu of supported games/apps for which it install all workarounds
automatically. It also lets you install missing DLLs or tweak various Wine
settings individually.
It can be used via a GUI or the command line, whichever you prefer. The command
line mode is particularly useful as a building block in fancier Wine front-ends
and in automated regression testing.
$ rpmlint SPECS/winetricks.spec
SPECS/winetricks.spec: W: no-%build-section
0 packages and 1 specfiles checked; 0 errors, 1 warnings.
$ rpmlint RPMS/noarch/winetricks-20110629-1.fc16.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
This package is not eligible for Fedora because, while it is free itself, it is
used to install numerous non-free software packages. Typically it downloads an
installer from an official source and simply runs its via Wine, so users have
the opportunity to review the EULA of individual packages to see if the terms
are legal and/or acceptable to them before installing non-free software on
their systems.
I'm not a current RPMFusion or Fedora packager.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
11:57 a.m.
New subject: [Bug 1992] Review Request: winetricks - Package manager for Win32 DLLs and applications on POSIX
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1992
T.C. Hollingsworth <tc(a)tchol.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |2, 30
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:45 p.m.
New subject: [Bug 1992] Review Request: winetricks - Package manager for Win32 DLLs and applications on POSIX
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1992
Xavier Bachelot <xavier(a)bachelot.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |xavier(a)bachelot.org
--- Comment #1 from Xavier Bachelot <xavier(a)bachelot.org> 2011-10-19 16:45:06 ---
I'm not a sponsor so this is an informal review. Here are a couple comments :
- Source files are not valid, you should create an svn snapshot from upstream
source code and work from there. See
https://fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control
- You don't need the BuildRoot tag, the "rm -rf %{buildroot}" at the
beginning
of the %prep section and the whole %clean section unless you want to build for
EL5.
See https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
- The %defattr line in the %files section is not needed unless you want to
build for EL5.
See https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions
- The install of the winetricks file could be made simpler :
install -Dp -m0755 %SOURCE0 %{buildroot}%{_bindir}/winetricks
- Same for the manpage. Also no need to gzip it, rpmbuild will take care of
that.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:21 p.m.
New subject: [Bug 1992] Review Request: winetricks - Package manager for Win32 DLLs and applications on POSIX
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1992
--- Comment #2 from T.C. Hollingsworth <tc(a)tchol.org> 2011-10-19 17:21:09 ---
Thanks! I've fixed it up according to your suggestions.
Spec: http://tchol.org/rpmfusion/winetricks.spec
SRPM: http://tchol.org/rpmfusion/winetricks-20110629-2.fc16.src.rpm
$ rpmlint SPECS/winetricks.spec
SPECS/winetricks.spec: W: no-%build-section
SPECS/winetricks.spec: W: invalid-url Source0: winetricks-20110629.tar.xz
0 packages and 1 specfiles checked; 0 errors, 2 warnings.
$ rpmlint RPMS/noarch/winetricks-20110629-2.fc16.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:25 a.m.
New subject: [Bug 1992] Review Request: winetricks - Package manager for Win32 DLLs and applications on POSIX
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1992
--- Comment #3 from Xavier Bachelot <xavier(a)bachelot.org> 2011-10-20 12:25:07 ---
The release tag is not correct. It should be 2.20110629svn666. See
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages
You'd rather use svn export to generate the tarball. Also, you could add
something like "%global svn_changeset 666" and use it in the spec file, rather
than hardcoding the changeset.
The %attr for the man page is not needed in the %file section.
Also, replace the .gz by .*, in case the compression method for manpages
changes someday.
As winetricks provides a GUI, you must install a desktop file. See
https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files
Can you explain the need for the manual Requires: ? Especially coreutils,
xdg-utils and perl.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
11:46 a.m.
New subject: [Bug 1992] Review Request: winetricks - Package manager for Win32 DLLs and applications on POSIX
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1992
--- Comment #4 from Xavier Bachelot <xavier(a)bachelot.org> 2011-10-20 13:46:28 ---
rpmlint on the srpm is not clean :
winetricks.src: W: strange-permission winetricks.spec 0600L
winetricks.src: W: no-%build-section
winetricks.src: W: invalid-url Source0: winetricks-20110629.tar.xz
Please change specfile perms to 644.
Please add a %build section either empty or better with a comment saying
there's nothing to build.
The invalid url for source0 can be ignored.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
12:21 p.m.
New subject: [Bug 1992] Review Request: winetricks - Package manager for Win32 DLLs and applications on POSIX
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1992
--- Comment #5 from T.C. Hollingsworth <tc(a)tchol.org> 2011-10-20 14:21:30 ---
(In reply to comment #3)
The release tag is not correct. It should be 2.20110629svn666. See
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages
It's my understanding that listing the snapshot in the release is only required
for pre- and post-release snapshots. This is an official stable release; we're
just using SVN since upstream doesn't provide proper tarballs.
You'd rather use svn export to generate the tarball. Also, you
could add
something like "%global svn_changeset 666" and use it in the spec file, rather
than hardcoding the changeset.
Fixed.
The %attr for the man page is not needed in the %file section.
Strangely, yesterday rpmlint gave a "spurious-executable-perm" error on the
manpage, but it isn't today. (F16 bug perhaps?) Fixed.
Also, replace the .gz by .*, in case the compression method for
manpages
changes someday.
As winetricks provides a GUI, you must install a desktop file. See
https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files
Fixed these two also.
Can you explain the need for the manual Requires: ? Especially
coreutils,
xdg-utils and perl.
RPM's automatic dependency generator picks up nothing but /bin/sh so it seems I
have to specify everything:
$ rpm -qpR winetricks-20110629-2.noexplicitrequires.fc16.noarch.rpm
/bin/sh
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1
Regarding the specific packages you mentioned: coreutils is needed for
sha1sum, xdg-utils is needed because it uses "xdg-open", and Perl is used by
one of the "tricks" to edit config files.
(In reply to comment #4)
rpmlint on the srpm is not clean :
Also fixed.
--
Spec: http://tchol.org/rpmfusion/winetricks.spec
SRPM: http://tchol.org/rpmfusion/winetricks-20110629-3.fc16.src.rpm
$ rpmlint winetricks.spec
winetricks.spec: W: invalid-url Source0: winetricks-20110629.tar.xz
0 packages and 1 specfiles checked; 0 errors, 1 warnings.
$ rpmlint winetricks-20110629-3.fc16.src.rpm
winetricks.src: W: invalid-url Source0: winetricks-20110629.tar.xz
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
$ rpmlint winetricks-20110629-3.fc16.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
12:50 p.m.
New subject: [Bug 1992] Review Request: winetricks - Package manager for Win32 DLLs and applications on POSIX
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1992
--- Comment #6 from Xavier Bachelot <xavier(a)bachelot.org> 2011-10-20 14:50:19 ---
(In reply to comment #5)
(In reply to comment #3)
> The release tag is not correct. It should be 2.20110629svn666. See
> https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages
It's my understanding that listing the snapshot in the release is only required
for pre- and post-release snapshots. This is an official stable release; we're
just using SVN since upstream doesn't provide proper tarballs.
Ok, sorry I thought r666 was the latest trunk revision.
As you need to create a tarball anyway, is there a reason not to go with trunk
head ?
I'm fine with all the other fixes, thanks for the quick answer.
I will not go further into the review, as I think the package is pretty clean
now. Let's wait for a sponsor to continue the review.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:14 p.m.
New subject: [Bug 1992] Review Request: winetricks - Package manager for Win32 DLLs and applications on POSIX
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1992
Sérgio Basto <sergio(a)serjux.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |sergio(a)serjux.com
--- Comment #7 from Sérgio Basto <sergio(a)serjux.com> 2011-10-21 22:14:53 ---
I also am interested , I will test it on F15 .
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:18 p.m.
New subject: [Bug 1992] Review Request: winetricks - Package manager for Win32 DLLs and applications on POSIX
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1992
Nicolas Chauvet <kwizart(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |UPSTREAM
--- Comment #46 from Nicolas Chauvet <kwizart(a)gmail.com> ---
imported in fedora
--
You are receiving this mail because:
You are on the CC list for the bug.
2780
days inactive
4566
days old
rpmfusion-developers@lists.rpmfusion.org
9 comments
1 participants
participants (1)
-
RPM Fusion Bugzilla