10:29 a.m.
On 30.07.2008 18:09, Sergio Pascual wrote:
Author: sergiopr
Update of /cvs/free/rpms/lastfm/F-9
In directory se02.es.rpmfusion.net:/tmp/cvs-serv19968
Modified Files:
lastfm.spec
Log Message:
* Wed Jul 23 2008 Sergio Pascual <sergio.pasra at gmail.com> 1.4.0.56102-3
[...]
- Vendor changed to rpmfusion
[...]
Index: lastfm.spec
===================================================================
RCS file: /cvs/free/rpms/lastfm/F-9/lastfm.spec,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- lastfm.spec 23 Jul 2008 06:22:11 -0000 1.1
+++ lastfm.spec 30 Jul 2008 16:09:37 -0000 1.2
@@ -2,7 +2,7 @@
Name: lastfm
Version: 1.4.0.56102
-Release: 2%{?dist}
+Release: 3%{?dist}
Summary: Last.fm music client
[...]
-desktop-file-install --vendor="livna" \
+desktop-file-install --vendor="rpmfusion" \
Do we want to do that (here and everywhere)? Quoting from
http://fedoraproject.org/wiki/Packaging/Guidelines
* If upstream uses <vendor_id>, leave it intact, otherwise
use fedora as <vendor_id>.
* It is important that vendor_id stay constant for the life of a package.
This is mostly for the sake of menu-editing (which bases off of .desktop file/path
names).
Opinions?
CU
knurd
10:35 a.m.
New subject: rpms/lastfm/F-9 lastfm.spec,1.1,1.2
2008/8/5 Thorsten Leemhuis <fedora(a)leemhuis.info>:
> -desktop-file-install --vendor="livna" \
> +desktop-file-install --vendor="rpmfusion" \
Do we want to do that (here and everywhere)? Quoting from
http://fedoraproject.org/wiki/Packaging/Guidelines
> * If upstream uses <vendor_id>, leave it intact, otherwise use fedora
> as <vendor_id>.
> * It is important that vendor_id stay constant for the life of a
> package.
> This is mostly for the sake of menu-editing (which bases off of .desktop
> file/path names).
Opinions?
I agree <vendor_id> should be constant therefore we should not change
it from "dribble" or "livna" to "rpmfusion".
These are not new packages. We should preserve the original
<vendor_id> since we are committed to have a clean upgrade path from
Dribble, Livna and Freshrpms.
Bye,
Andrea.
11:17 a.m.
New subject: rpms/lastfm/F-9 lastfm.spec,1.1,1.2
On Tue August 5 2008, Thorsten Leemhuis wrote:
On 30.07.2008 18:09, Sergio Pascual wrote:
> -desktop-file-install --vendor="livna" \
> +desktop-file-install --vendor="rpmfusion" \
Do we want to do that (here and everywhere)? Quoting from
http://fedoraproject.org/wiki/Packaging/Guidelines
> * If upstream uses <vendor_id>, leave it intact, otherwise use fedora
> as <vendor_id>. * It is important that vendor_id stay constant for the
> life of a package.
>
> This is mostly for the sake of menu-editing (which bases off of .desktop
> file/path names).
Opinions?
Iirc it was proposed to drop the vendor_id or not to use it as a file prefix
in Fedora in the future. Therefore I would keep the vendor_id constant until
it is clear, whether it can be dropped.
Regards,
Till
12:43 p.m.
New subject: rpms/lastfm/F-9 lastfm.spec,1.1,1.2
Thorsten Leemhuis wrote:
On 30.07.2008 18:09, Sergio Pascual wrote:
> Author: sergiopr
>
> Update of /cvs/free/rpms/lastfm/F-9
> In directory se02.es.rpmfusion.net:/tmp/cvs-serv19968
>
> Modified Files:
> lastfm.spec Log Message:
> * Wed Jul 23 2008 Sergio Pascual <sergio.pasra at gmail.com>
> 1.4.0.56102-3
> [...]
> - Vendor changed to rpmfusion
> [...]
>
> Index: lastfm.spec
> ===================================================================
> RCS file: /cvs/free/rpms/lastfm/F-9/lastfm.spec,v
> retrieving revision 1.1
> retrieving revision 1.2
> diff -u -r1.1 -r1.2
> --- lastfm.spec 23 Jul 2008 06:22:11 -0000 1.1
> +++ lastfm.spec 30 Jul 2008 16:09:37 -0000 1.2
> @@ -2,7 +2,7 @@
>
> Name: lastfm
> Version: 1.4.0.56102
> -Release: 2%{?dist}
> +Release: 3%{?dist}
> Summary: Last.fm music client
> [...]
> -desktop-file-install --vendor="livna" \
> +desktop-file-install --vendor="rpmfusion" \
Do we want to do that (here and everywhere)? Quoting from
http://fedoraproject.org/wiki/Packaging/Guidelines
> * If upstream uses <vendor_id>, leave it intact, otherwise use
> fedora as <vendor_id>.
> * It is important that vendor_id stay constant for the life of a
> package.
> This is mostly for the sake of menu-editing (which bases off of
> .desktop file/path names).
This is one danger of introducing artificial vendors. I'm working with
Matthias Classen (fedora desktop, gtk fame) to draft new guidelines to
discourage this practice.
In the meantime, for any particular Fedora release, it's still a good
idea to make a best effort to keep the vendor constant. You can
consider changing it for F-10+ if you like...
-- Rex
1:47 p.m.
New subject: rpms/lastfm/F-9 lastfm.spec,1.1,1.2
On Tue, 05 Aug 2008 07:43:31 -0500, Rex Dieter wrote:
In the meantime, for any particular Fedora release, it's still a
good
idea to make a best effort to keep the vendor constant. You can
consider changing it for F-10+ if you like...
Changing it breaks panel icons, for example, and creates orphans in
the GConf settings.
2:16 p.m.
New subject: rpms/lastfm/F-9 lastfm.spec,1.1,1.2
Michael Schwendt wrote:
On Tue, 05 Aug 2008 07:43:31 -0500, Rex Dieter wrote:
> In the meantime, for any particular Fedora release, it's still a good
> idea to make a best effort to keep the vendor constant. You can
> consider changing it for F-10+ if you like...
Changing it breaks panel icons, for example, and creates orphans in
the GConf settings.
Gconf stores the name of the .desktop file(s)?
-- Rex
4:53 p.m.
New subject: rpms/lastfm/F-9 lastfm.spec,1.1,1.2
On Tue, 05 Aug 2008 09:16:01 -0500, Rex Dieter wrote:
Michael Schwendt wrote:
> On Tue, 05 Aug 2008 07:43:31 -0500, Rex Dieter wrote:
>
>> In the meantime, for any particular Fedora release, it's still a good
>> idea to make a best effort to keep the vendor constant. You can
>> consider changing it for F-10+ if you like...
>
> Changing it breaks panel icons, for example, and creates orphans in
> the GConf settings.
Gconf stores the name of the .desktop file(s)?
Yes, for launchers on the panel the full path to the desktop file
is stored. Example of breakage for Emacs:
$ gconftool-2 -R /apps/panel/objects|grep loca|grep emacs
launcher_location = /usr/share/applications/gnu-emacs.desktop
launcher_location = /usr/share/applications/emacs.desktop
The first is the old .desktop file name. The upgrade renamed it, broke the
launcher. The old launcher object is still in the db, but invisible in the
panel. I guess it would return if I created a gnu-emacs.desktop file in
the same path.
$ gconftool-2 -R /apps/panel/objects/object_1
toplevel_id = top_panel
bonobo_iid =
attached_toplevel_id =
use_custom_icon = false
action_type = lock
tooltip =
custom_icon =
launcher_location = /usr/share/applications/gnu-emacs.desktop
use_menu_path = false
panel_right_stick = false
object_type = launcher-object
position = 247
locked = false
menu_path = applications:/
5952
days inactive
5952
days old
rpmfusion-developers@lists.rpmfusion.org
6 comments
5 participants
participants (5)
-
Andrea Musuruane -
Michael Schwendt -
Rex Dieter -
Thorsten Leemhuis -
Till Maas