[Bug 1702] New: Review Request: imagination - A lightweight and simple GTK based DVD slide show creator
6:48 p.m.
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1702
Summary: Review Request: imagination - A lightweight and simple
GTK based DVD slide show creator
Product: Package Reviews
Version: Current
Platform: All
URL: http://imagination.sourceforge.net/
OS/Version: GNU/Linux
Status: NEW
Severity: normal
Priority: P5
Component: Review Request
AssignedTo: rpmfusion-package-review(a)rpmfusion.org
ReportedBy: hobbes1069(a)gmail.com
CC: rpmfusion-package-review(a)rpmfusion.org
Blocks: 2
Estimated Hours: 0.0
SOURCE:
https://docs.google.com/leaf?id=0B4A6of0Rl4nUY2U3MGU2OTUtMzc1Yy00M2Y0LTg0...
SPEC:
https://docs.google.com/leaf?id=0B4A6of0Rl4nUMDM3MDBkNDEtMThkMC00MGZkLWEw...
Description:
Imagination is a lightweight and simple DVD slide show maker
written in C language and built with the GTK+2 toolkit.
This package can not be included in Fedora due to requiring ffmpeg.
$ rpmlint imagination-3.0-1.fc14.src.rpm imagination-3.0-1.fc14.x86_64.rpm
imagination.x86_64: W: no-manual-page-for-binary imagination
2 packages and 0 specfiles checked; 0 errors, 1 warnings.
This is a GUI only program and does include multilingual html documentation.
The SourceForge page lists the license as GPL but I contacted the author and he
responded that it is GPLv2 and he will include a LICENSE file in the next
release.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:16 p.m.
Hello,
There was already a review request for imagination :
https://bugzilla.rpmfusion.org/show_bug.cgi?id=1617
But there wasn't any reviewer ...
Regards,
Cédric OLIVIER
Le 15/04/2011 20:48, RPM Fusion Bugzilla a écrit :
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1702
Summary: Review Request: imagination - A lightweight and simple
GTK based DVD slide show creator
Product: Package Reviews
Version: Current
Platform: All
URL: http://imagination.sourceforge.net/
OS/Version: GNU/Linux
Status: NEW
Severity: normal
Priority: P5
Component: Review Request
AssignedTo: rpmfusion-package-review(a)rpmfusion.org
ReportedBy: hobbes1069(a)gmail.com
CC: rpmfusion-package-review(a)rpmfusion.org
Blocks: 2
Estimated Hours: 0.0
SOURCE:
https://docs.google.com/leaf?id=0B4A6of0Rl4nUY2U3MGU2OTUtMzc1Yy00M2Y0LTg0...
SPEC:
https://docs.google.com/leaf?id=0B4A6of0Rl4nUMDM3MDBkNDEtMThkMC00MGZkLWEw...
Description:
Imagination is a lightweight and simple DVD slide show maker
written in C language and built with the GTK+2 toolkit.
This package can not be included in Fedora due to requiring ffmpeg.
$ rpmlint imagination-3.0-1.fc14.src.rpm imagination-3.0-1.fc14.x86_64.rpm
imagination.x86_64: W: no-manual-page-for-binary imagination
2 packages and 0 specfiles checked; 0 errors, 1 warnings.
This is a GUI only program and does include multilingual html documentation.
The SourceForge page lists the license as GPL but I contacted the author and he
responded that it is GPLv2 and he will include a LICENSE file in the next
release.
9:26 p.m.
On Fri, Apr 15, 2011 at 4:16 PM, Olivier Cédric <cedric.olivier(a)free.fr> wrote:
Hello,
There was already a review request for imagination :
https://bugzilla.rpmfusion.org/show_bug.cgi?id=1617
But there wasn't any reviewer ...
Woops, thought I checked on that but I'm working on about 3 different
packages and must have forgotten this one.
Since mine is for version 3.0 should we close 1617?
Thanks,
Richard
12:13 a.m.
On 04/16/2011 12:26 AM, Richard Shaw wrote:
On Fri, Apr 15, 2011 at 4:16 PM, Olivier
Cédric<cedric.olivier(a)free.fr> wrote:
> Hello,
>
> There was already a review request for imagination :
> https://bugzilla.rpmfusion.org/show_bug.cgi?id=1617
>
> But there wasn't any reviewer ...
Woops, thought I checked on that but I'm working on about 3 different
packages and must have forgotten this one.
Since mine is for version 3.0 should we close 1617?
Thanks,
Richard
Actually the polite and more useful way would be talk with the
original submitter and work together on an updated package. One of you
can review the other and maybe you could both co-maintain the result.
7:53 a.m.
Le 16/04/2011 02:13, manuel "lonely wolf" wolfshant a écrit :
On 04/16/2011 12:26 AM, Richard Shaw wrote:
> On Fri, Apr 15, 2011 at 4:16 PM, Olivier
> Cédric<cedric.olivier(a)free.fr> wrote:
>> Hello,
>>
>> There was already a review request for imagination :
>> https://bugzilla.rpmfusion.org/show_bug.cgi?id=1617
>>
>> But there wasn't any reviewer ...
> Woops, thought I checked on that but I'm working on about 3 different
> packages and must have forgotten this one.
>
> Since mine is for version 3.0 should we close 1617?
>
> Thanks,
> Richard
Actually the polite and more useful way would be talk with the
original submitter and work together on an updated package. One of you
can review the other and maybe you could both co-maintain the result.
I am the original submitter and I am ok to close 1617 and review your
new review request. I will do review next week.
For co maintain, it's as you want.
Cédric OLIVIER
2:43 p.m.
On Sat, Apr 16, 2011 at 2:53 AM, Olivier Cédric <cedric.olivier(a)free.fr> wrote:
I am the original submitter and I am ok to close 1617 and review your
new
review request. I will do review next week.
For co maintain, it's as you want.
I'll leave it up to you if you want to be a co-maintainer.
The only problem I have with the package right now is getting the
documentation in the right place. I only recently figured out that
%doc will only automatically put files from the buildroot into
/usr/share/doc/%{name}-%{version}.
The installed files from the package put the html documentation in
/usr/share/doc/%{name}. I've tried:
%install
rm -rf $RPM_BUILD_ROOT
make install DESTDIR=$RPM_BUILD_ROOT
# Move documentation so it will go in the right directory
mkdir -p %{buildroot}%{_docdir}/%{name}-%{version}
mv %{buildroot}%{_docdir}/%{name}/html \
%{buildroot}%{_docdir}/%{name}-%{version}/html
... but it didn't work.
And now I know why. When %doc is called it cleans the doc directory
prior to moving the files into it...
What's the right way to handle this? It just seems redundant to have a
/usr/share/doc/imagination and /usr/share/doc/imagination-3.0
Thanks,
Richard
3:02 p.m.
Le 16/04/2011 16:43, Richard Shaw a écrit :
On Sat, Apr 16, 2011 at 2:53 AM, Olivier
Cédric<cedric.olivier(a)free.fr> wrote:
> I am the original submitter and I am ok to close 1617 and review your new
> review request. I will do review next week.
> For co maintain, it's as you want.
I'll leave it up to you if you want to be a co-maintainer.
The only problem I have with the package right now is getting the
documentation in the right place. I only recently figured out that
%doc will only automatically put files from the buildroot into
/usr/share/doc/%{name}-%{version}.
The installed files from the package put the html documentation in
/usr/share/doc/%{name}. I've tried:
%install
rm -rf $RPM_BUILD_ROOT
make install DESTDIR=$RPM_BUILD_ROOT
# Move documentation so it will go in the right directory
mkdir -p %{buildroot}%{_docdir}/%{name}-%{version}
mv %{buildroot}%{_docdir}/%{name}/html \
%{buildroot}%{_docdir}/%{name}-%{version}/html
... but it didn't work.
And now I know why. When %doc is called it cleans the doc directory
prior to moving the files into it...
What's the right way to handle this? It just seems redundant to have a
/usr/share/doc/imagination and /usr/share/doc/imagination-3.0
Thanks,
Richard
I Think I was solvded this problem in my imagination-2.1.1 spec file with
:
%doc AUTHORS COPYING INSTALL README TODO
%doc %{_datadir}/doc/%{name}
Regards,
Cédric
3:08 p.m.
On 17/04/11 00:43, Richard Shaw wrote:
mv %{buildroot}%{_docdir}/%{name}/html \
%{buildroot}%{_docdir}/%{name}-%{version}/html
Are the html files standalone documentation, or are they used directly
by the application eg to show help ?
If it's the second, then I think we wouldn't mark them as %doc, since
%doc items must not affect the application running.
3:14 p.m.
On Sun, 17 Apr 2011 01:08:32 +1000, DT wrote:
On 17/04/11 00:43, Richard Shaw wrote:
> mv %{buildroot}%{_docdir}/%{name}/html \
> %{buildroot}%{_docdir}/%{name}-%{version}/html
Are the html files standalone documentation, or are they used directly
by the application eg to show help ?
If it's the second, then I think we wouldn't mark them as %doc, since
%doc items must not affect the application running.
More precisely, you refer to --excludedocs installs of packages.
The excluded doc files MUST NOT crash the application. If the app can
cope with missing doc files and e.g. displays an error dialog, that
would be acceptable.
3:12 p.m.
On Sat, 16 Apr 2011 09:43:32 -0500, RS wrote:
The only problem I have with the package right now is getting the
documentation in the right place. I only recently figured out that
%doc will only automatically put files from the buildroot into
/usr/share/doc/%{name}-%{version}.
The installed files from the package put the html documentation in
/usr/share/doc/%{name}. I've tried:
%install
rm -rf $RPM_BUILD_ROOT
make install DESTDIR=$RPM_BUILD_ROOT
# Move documentation so it will go in the right directory
mkdir -p %{buildroot}%{_docdir}/%{name}-%{version}
mv %{buildroot}%{_docdir}/%{name}/html \
%{buildroot}%{_docdir}/%{name}-%{version}/html
... but it didn't work.
And now I know why. When %doc is called it cleans the doc directory
prior to moving the files into it...
What's the right way to handle this? It just seems redundant to have a
/usr/share/doc/imagination and /usr/share/doc/imagination-3.0
1.) Verify that the app does not expect the documentation to be
located in its original path. Moving it could break the app at run-time
(e.g. a Help menu). It may be necessary to patch/reconfigure the app,
so it would look for the doc files in another location
Once you are certain that you can move the doc files without breaking
anything:
2.) Install them into a temporary location and make them available
somewhere below $(pwd), which is within the space of your extracted
package below %_builddir. Clean up and set up that temporary location
in %install. Then you can use %doc to include those doc files. E.g.
%install
...
rm -rf %(pwd)/_tmpdoc ; mkdir $(pwd)/_tmpdoc
mv %{buildroot}%{_docdir}/%{name} $(pwd)/_tmpdoc
%files
...
%doc _tmpdoc/*
6:50 p.m.
On Sat, Apr 16, 2011 at 10:12 AM, Michael Schwendt <mschwendt(a)gmail.com> wrote:
1.) Verify that the app does not expect the documentation to be
located in its original path. Moving it could break the app at run-time
(e.g. a Help menu). It may be necessary to patch/reconfigure the app,
so it would look for the doc files in another location
It does expect it in that directory and unfortunately it does not give
an error, it just fails silently. There's not even any console output.
I was going to create a separate -doc package but looks like it needs
to stay together.
I found the code where it sets the doc dir and it should be easy (if I
was a C programmer) to create a patch. I think I can manage it but it
may take me a few tries:
static void img_show_uri(GtkMenuItem *menuitem, img_window_struct *img)
{
gchar *file = NULL;
gchar *lang = NULL;
lang = g_strndup(g_getenv("LANG"),2);
file =
g_strconcat("file://",DATADIR,"/doc/",PACKAGE,"/html/",lang,"/index.html",NULL);
g_free(lang);
img_message (img, FALSE, "%s\n", file);
/* If help is not localized yet, show default language (english) */
if ( !gtk_show_uri(NULL,file, GDK_CURRENT_TIME, NULL))
{
g_free( file );
file =
g_strconcat("file://",DATADIR,"/doc/",PACKAGE,"/html/en/index.html",NULL);
gtk_show_uri(NULL,file, GDK_CURRENT_TIME, NULL);
}
g_free(file);
}
---
There's a C variable, PACKAGE_VERSION, for the version as well. We
should just be able to add it to the concatenation function I would
think.
Once you are certain that you can move the doc files without
breaking
anything:
2.) Install them into a temporary location and make them available
somewhere below $(pwd), which is within the space of your extracted
package below %_builddir. Clean up and set up that temporary location
in %install. Then you can use %doc to include those doc files. E.g.
%install
...
rm -rf %(pwd)/_tmpdoc ; mkdir $(pwd)/_tmpdoc
mv %{buildroot}%{_docdir}/%{name} $(pwd)/_tmpdoc
%files
...
%doc _tmpdoc/*
I kinda see show this works, however, till the %doc move it to the
right directory this way? I though if it had a path in it, rpm would
just mark it as documentation but not move it?
Thanks,
Richard
7:17 p.m.
On Sat, 16 Apr 2011 13:50:49 -0500, RS wrote:
> Once you are certain that you can move the doc files without
breaking
> anything:
>
> 2.) Install them into a temporary location and make them available
> somewhere below $(pwd), which is within the space of your extracted
> package below %_builddir. Clean up and set up that temporary location
> in %install. Then you can use %doc to include those doc files. E.g.
>
> %install
> ...
> rm -rf %(pwd)/_tmpdoc ; mkdir $(pwd)/_tmpdoc
> mv %{buildroot}%{_docdir}/%{name} $(pwd)/_tmpdoc
>
>
> %files
> ...
> %doc _tmpdoc/*
I kinda see show this works, however, till the %doc move it to the
right directory this way? I though if it had a path in it, rpm would
just mark it as documentation but not move it?
As "_tmpdoc/*" is not an absolute path, %doc copies the file(s) from the
local build directory and additionally marks them as documentation. Just
like
%doc AUTHORS COPYING doc/html README
which also copies those files from the local build dir.
Techniques like this are in use for a long time, so it's not as if I'm
suggesting something that wouldn't work. ;)
9:33 p.m.
On Sat, Apr 16, 2011 at 2:17 PM, Michael Schwendt <mschwendt(a)gmail.com> wrote:
On Sat, 16 Apr 2011 13:50:49 -0500, RS wrote:
> > Once you are certain that you can move the doc files without breaking
> > anything:
> >
> > 2.) Install them into a temporary location and make them available
> > somewhere below $(pwd), which is within the space of your extracted
> > package below %_builddir. Clean up and set up that temporary location
> > in %install. Then you can use %doc to include those doc files. E.g.
> >
> > %install
> > ...
> > rm -rf %(pwd)/_tmpdoc ; mkdir $(pwd)/_tmpdoc
> > mv %{buildroot}%{_docdir}/%{name} $(pwd)/_tmpdoc
> >
> >
> > %files
> > ...
> > %doc _tmpdoc/*
>
> I kinda see show this works, however, till the %doc move it to the
> right directory this way? I though if it had a path in it, rpm would
> just mark it as documentation but not move it?
As "_tmpdoc/*" is not an absolute path, %doc copies the file(s) from the
local build directory and additionally marks them as documentation. Just
like
%doc AUTHORS COPYING doc/html README
which also copies those files from the local build dir.
Techniques like this are in use for a long time, so it's not as if I'm
suggesting something that wouldn't work. ;)
No, I'm not suggesting that at all, but as much documentation as there
is, it all seems to be lacking in certain areas. You have to do a lot
of reading between the lines. I'm really trying to understand how
rpmbuild works but it can be quite convoluted.
So if I understand your example, we're going to move the files out of
BUILDROOT back to BUILD which will prevent us from getting the FILES
INSTALLED BUT NOT PACKAGED or whatever the error is. Then, while
%files is for referencing files in BUILDROOT, %doc will actually copy
files from BUILD. The only thing I can think of to add is that the doc
files are installed in %{_docdir}/%{name}/html. Wouldn't we want to
preserve the ./html directory?
Thanks,
Richard
9:59 p.m.
On Sat, 16 Apr 2011 16:33:16 -0500, RS wrote:
[...] but as much documentation as there
is, it all seems to be lacking in certain areas. You have to do a lot
of reading between the lines. I'm really trying to understand how
rpmbuild works but it can be quite convoluted.
http://www.rpm.org/max-rpm-snapshot/s1-rpm-inside-files-list-directives.html
So if I understand your example, we're going to move the files
out of
BUILDROOT back to BUILD which will prevent us from getting the FILES
INSTALLED BUT NOT PACKAGED or whatever the error is.
Well, that's not the goal of it. But in the same way as one is free
to "mess with files inside buildroot", one is not limited to deleting
or renaming files in there. One can do arbitrary things in there.
Whatever may be necessary to create a working package.
In general, if the files installed in the buildroot need to be adjusted
somehow, it's up to you to fix them for your %files list. Available
techniques, such as a tmp dir, are not specific to %doc files.
Then, while
%files is for referencing files in BUILDROOT, %doc will actually copy
files from BUILD. The only thing I can think of to add is that the doc
files are installed in %{_docdir}/%{name}/html. Wouldn't we want to
preserve the ./html directory?
Nothing is stopping you from modifying the %doc statements appropriately
to include a 'html' directory.
5:04 p.m.
Update:
I have new src and spec urls added to the ticket. It now installs the
documentation to the correct directory and loads from the gui.
Also, I searched though bugzilla and it turns out there's an even
older request for this package.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=899
I know typically the newer bug reports are marked as duplicates of the
older, but in the of a Review request, which is not really a bug,
should we do the opposite? I don't see any value in keeping them open.
Cédric,
Are you still interested in co-maintaining?
Thanks,
Richard
5:55 a.m.
Le 18/04/2011 19:04, Richard Shaw a écrit :
I know typically the newer bug reports are marked as duplicates of
the
older, but in the of a Review request, which is not really a bug,
should we do the opposite? I don't see any value in keeping them open.
Cédric,
Are you still interested in co-maintaining?
Thanks,
Richard
I am still interested in co-maintaining imagination.
Older review request of imagination are obsoletes, I think we can use
last request and close older requests with a reference to this new
review request.
Regards,
Cédric
1:03 p.m.
On Tue, Apr 19, 2011 at 12:55 AM, Olivier Cédric <cedric.olivier(a)free.fr> wrote:
I am still interested in co-maintaining imagination.
Older review request of imagination are obsoletes, I think we can use last
request and close older requests with a reference to this new review
request.
Done!
Also, please let me know if you like my idea of patching the source
instead of requiring gnome-icon-theme-legacy. Although it looks just
to be a package of symlinks to the old icon names so there's not much
of a download or install cost but it seemed more elegant to fix the
source to not require a legacy package. I could go either way on this
one.
Thanks,
Richard
11:21 p.m.
New subject: [Bug 1702] Review Request: imagination - A lightweight and simple GTK based DVD slide show creator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1702
--- Comment #1 from Richard <hobbes1069(a)gmail.com> 2011-04-17 01:21:26 ---
NEW SPEC:
https://docs.google.com/leaf?id=0B4A6of0Rl4nUNjk0OTEwMTktYTczMC00OWRjLWI5...
NEW SOURCE:
https://docs.google.com/leaf?id=0B4A6of0Rl4nUNDdjZjk0YzQtMjllMC00NzgzLTlk...
Changes:
Updated spec to move documentation to the right directory.
Created patch so program will look for help in the right directory.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:33 p.m.
New subject: [Bug 1702] Review Request: imagination - A lightweight and simple GTK based DVD slide show creator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1702
Richard <hobbes1069(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |cedric.olivier(a)free.fr
--- Comment #2 from Richard <hobbes1069(a)gmail.com> 2011-04-18 20:33:55 ---
Thanks to Cédric for https://bugzilla.rpmfusion.org/show_bug.cgi?id=1617#c3
which fixed a problem I wasn't aware of.
New spec and src rpm:
NEW SRC:
https://docs.google.com/leaf?id=0B4A6of0Rl4nUZDA4YzhmN2ItMGQ2MS00ZTllLWI0...
SPEC url is not affected.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3 a.m.
New subject: [Bug 1702] Review Request: imagination - A lightweight and simple GTK based DVD slide show creator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1702
--- Comment #3 from Richard <hobbes1069(a)gmail.com> 2011-04-19 05:00:11 ---
I figured it would be fairly trivial to patch the source to use the correct
(new) icon names and it ended up being pretty easy.
Now the package gnome-icon-theme-legacy is no longer required.
NEW SOURCE URL:
https://docs.google.com/leaf?id=0B4A6of0Rl4nUZThmNTc2NWMtMzA5Zi00YjYxLThk...
The spec has been updated but the URL is not affected.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1 p.m.
New subject: [Bug 1702] Review Request: imagination - A lightweight and simple GTK based DVD slide show creator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1702
--- Comment #4 from Richard <hobbes1069(a)gmail.com> 2011-04-19 15:00:18 ---
*** Bug 1617 has been marked as a duplicate of this bug. ***
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1 p.m.
New subject: [Bug 1702] Review Request: imagination - A lightweight and simple GTK based DVD slide show creator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1702
Richard <hobbes1069(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |alsadi(a)ojuba.org
--- Comment #5 from Richard <hobbes1069(a)gmail.com> 2011-04-19 15:00:48 ---
*** Bug 899 has been marked as a duplicate of this bug. ***
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:43 p.m.
New subject: [Bug 1702] Review Request: imagination - A lightweight and simple GTK based DVD slide show creator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1702
--- Comment #6 from Cédric OLIVIER <cedric.olivier(a)free.fr> 2011-04-19 15:43:15
---
* I have got an error when trying to build it with mock solved by settting
LDFLAGS :
%build
export LDFLAGS=" -lm"
%configure
* iconfix patch can be applied all the time, you can remove test '>=14'. I
have
made a test on a fedora13 and it works great.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:17 p.m.
New subject: [Bug 1702] Review Request: imagination - A lightweight and simple GTK based DVD slide show creator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1702
--- Comment #7 from Richard <hobbes1069(a)gmail.com> 2011-04-19 16:17:05 ---
(In reply to comment #6)
* I have got an error when trying to build it with mock solved by
settting
LDFLAGS :
%build
export LDFLAGS=" -lm"
%configure
Strange, I always build with mock and I'm not seeing the problem... I don't
have any problem adding it but I would like to know why you're getting an error
an I'm not...
What version of Fedora are you building from? F13 or 14?
Can you post a copy of the full command you used?
* iconfix patch can be applied all the time, you can remove test
'>=14'. I have
made a test on a fedora13 and it works great.
Ok, I'll take it out on the next spec rev.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:53 p.m.
New subject: [Bug 1702] Review Request: imagination - A lightweight and simple GTK based DVD slide show creator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1702
--- Comment #8 from Cédric OLIVIER <cedric.olivier(a)free.fr> 2011-04-19 16:53:35
---
build on f13 with :
$ mock -r fedora-13-x86_64-rpmfusion_free imagination-3.0-4.fc14.src.rpm
output :
gcc -DPACKAGE_NAME=\"imagination\" -DPACKAGE_TARNAME=\"imagination\"
-DPACKAGE_VERSION=\"3.0\" -DPACKAGE_STRING=\"imagination\ 3.0\"
-DPACKAGE_BUGREPORT=\"http://sourceforge.net/tracker/\?group_id=244319\&atid=1125540\"
-DPACKAGE_URL=\"\" -DPACKAGE=\"imagination\"
-DVERSION=\"3.0\" -DSTDC_HEADERS=1
-DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1
-DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1
-DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\"
-DREVISION=\"r1\"
-DGETTEXT_PACKAGE=\"imagination\" -DHAVE_LOCALE_H=1 -DHAVE_LC_MESSAGES=1
-DHAVE_BIND_TEXTDOMAIN_CODESET=1 -DHAVE_GETTEXT=1 -DHAVE_DCGETTEXT=1
-DENABLE_NLS=1 -I. -DPACKAGE_LIB_DIR=\""/usr/lib64"\"
-DPACKAGE_DATA_DIR=\""/usr/share"\"
-DPACKAGE_LOCALE_DIR=\""/usr/share/locale"\" -pthread
-I/usr/include/gtk-2.0
-I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo
-I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include
-I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12
-I/usr/include/sox -DDATADIR=\"/usr/share\" -g -Wall -c -o
imagination-img_sox.o `test -f 'img_sox.c' || echo './'`img_sox.c
img_sox.c: In function 'output_flow':
img_sox.c:34: warning: unused variable 'len'
CCLD imagination
/usr/bin/ld: imagination-imgtablebutton.o: undefined reference to symbol
'sqrtf@(a)GLIBC_2.2.5'
/usr/bin/ld: note: 'sqrtf@(a)GLIBC_2.2.5' is defined in DSO /lib64/libm.so.6 so
try adding it to the linker command line
/lib64/libm.so.6: could not read symbols: Invalid operation
collect2: ld returned 1 exit status
make[1]: *** [imagination] Error 1
make[1]: Leaving directory `/builddir/build/BUILD/imagination-3.0/src'
make: *** [all-recursive] Error 1
erreur: Mauvais status de sortie pour /var/tmp/rpm-tmp.7vTpVN (%build)
Erreur de construction de RPM:
Mauvais status de sortie pour /var/tmp/rpm-tmp.7vTpVN (%build)
Child returncode was: 1
EXCEPTION: Command failed. See logs for output.
# ['bash', '--login', '-c', 'rpmbuild -bb --target x86_64
--nodeps
builddir/build/SPECS/imagination.spec']
Traceback (most recent call last):
File "/usr/lib/python2.6/site-packages/mock/trace_decorator.py", line 70, in
trace
result = func(*args, **kw)
File "/usr/lib/python2.6/site-packages/mock/util.py", line 325, in do
raise mock.exception.Error, ("Command failed. See logs for output.\n # %s"
% (command,), child.returncode)
Error: Command failed. See logs for output.
# ['bash', '--login', '-c', 'rpmbuild -bb --target x86_64
--nodeps
builddir/build/SPECS/imagination.spec']
LEAVE do --> EXCEPTION RAISED
There is two solution for this :
1) export LDFLAGS to add -lm
2) patch makefile
Patch makefile and inform upstream is probably better.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
4:11 p.m.
New subject: [Bug 1702] Review Request: imagination - A lightweight and simple GTK based DVD slide show creator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1702
--- Comment #9 from Richard <hobbes1069(a)gmail.com> 2011-04-19 18:11:08 ---
Ok, in trying to figure out why this is only happening in F13 I've done the
following:
On my system (F14):
# ldd /usr/bin/imagination
It is linked to libm.so
I have also tried a mock build for F13 on my system and it produces the same
error as expected, so this is a difference in distributions and not the build
system (mock version)
I diffed both build logs and it obviously showed some differences in the
./configure portion, mostly version differences (perl, etc.).
I pulled both gcc lines in the build logs for the file causing the problem and
after running them through sed to break the command into individual lines
(convert spaces to new lines) the only difference I can see is F14 gets one
additional include:
-I/usr/include/gdk-pixbuf-2.0
which F13 does not. I'm not sure but I don't think this has anything to do with
the problem.
Looking at what requires gdk-pixbuf:
# rpm -q --whatrequires gdk-pixbuf2-devel
gtk2-devel-2.22.0-1.fc14.1.x86_64
I'm going to try adding this as a direct BuildRequires and mock build for F13
again and see what happens..
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
5:51 p.m.
New subject: [Bug 1702] Review Request: imagination - A lightweight and simple GTK based DVD slide show creator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1702
--- Comment #10 from Richard <hobbes1069(a)gmail.com> 2011-04-19 19:51:16 ---
As expected it didn't help. In fact F13 doesn't have gdk-pixbuf2, but a much
older version of the package.
I've emailed the author to see what he thinks.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:34 p.m.
New subject: [Bug 1702] Review Request: imagination - A lightweight and simple GTK based DVD slide show creator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1702
--- Comment #11 from Richard <hobbes1069(a)gmail.com> 2011-04-20 22:34:21 ---
Upstream development may or may not get back with me but I don't see the LDFLAG
as being a blocker.
I have also verified it builds under F13.
I think it's ready for review.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:12 p.m.
New subject: [Bug 1702] Review Request: imagination - A lightweight and simple GTK based DVD slide show creator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1702
--- Comment #12 from Kevin Kofler <kevin.kofler(a)chello.at> 2011-04-21 00:12:04 ---
F13's gdk-pixbuf2 is part of gtk2, it's been split in F14 as part of the road
to gtk3.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
11:27 p.m.
New subject: [Bug 1702] Review Request: imagination - A lightweight and simple GTK based DVD slide show creator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1702
--- Comment #13 from Richard <hobbes1069(a)gmail.com> 2011-04-21 01:27:35 ---
(In reply to comment #12)
F13's gdk-pixbuf2 is part of gtk2, it's been split in F14 as
part of the road
to gtk3.
Sorry, I should have been more specific. I emailed upstream about why F13
requires LDFLAGS="-lm" and F14 doesn't. It was supposedly fixed in version
2.2
so this may be a regression in 3.0.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:33 a.m.
New subject: [Bug 1702] Review Request: imagination - A lightweight and simple GTK based DVD slide show creator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1702
--- Comment #14 from Robert Cheramy <robert(a)cheramy.net> 2011-04-23 09:33:09 ---
-ln fixed in upstream/trunk, apply this patch (add one line in configure.in):
http://imagination.svn.sourceforge.net/viewvc/imagination/trunk/configure...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:36 p.m.
New subject: [Bug 1702] Review Request: imagination - A lightweight and simple GTK based DVD slide show creator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1702
--- Comment #15 from Richard <hobbes1069(a)gmail.com> 2011-04-24 00:36:04 ---
Applied upstream patch for linking issue on Fedora 13.
NEW SOURCE RPM:
https://docs.google.com/leaf?id=0B4A6of0Rl4nUOWVkN2EzZTYtNzU3Ny00ZmY0LWIz...
SPEC URL Not affected.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
11:17 a.m.
New subject: [Bug 1702] Review Request: imagination - A lightweight and simple GTK based DVD slide show creator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1702
--- Comment #16 from Cédric OLIVIER <cedric.olivier(a)free.fr> 2011-05-01 13:17:06
---
Sorry for delay, as promised you can find my review :
[X] rpmlint - OK
[X] Name according Naming GuideLines - OK
[X] Spec file name - OK
[+] Package must meet Packaging Guidelines - OK
- [X] Naming - OK
- [X] Version, release - OK
- [X] Licensing - OK
- [X] No inclusion of pre-built binaries or libraries - OK
- [X] Spec Legibility - OK
- [X] Use rpmlint - OK
- [X] Filesystem Layout - OK
- [!] Changelogs - (2)
- [X] Requires - OK
- [X] BuildRequires - OK
- [X] Summary and description - OK
- [X] Encoding - OK
- [X] Documentation - OK
- [X] Compiler flags - OK
- [X] Debuginfo packages - OK
- [NA] Devel Packages
- [NA] Shared Libraries
- [NA] Packaging Static Libraries
- [X] Duplication of system libraries - OK
- [NA] Configuration files
- [X] Desktop files - OK
- [X] Macros - OK
- [X] Handling Locale Files - OK
- [X] Parallel make - OK
- [X] File and Directory Ownership - OK
- [!] All patches should have an upstream bug link or comment - (1)
- [NA] Man pages - There isn't any arguments to imagination
[X] Licensing Guidelines - OK
[X] License field - OK
[!] Source URL Guidelines - (3)
[X] successfully compile - OK
[X] Packages must NOT contain any .la - OK
[X] Packages containing GUI applications must include a desktop file - OK
[X] All filenames in rpm packages must be valid UTF-8 - OK
[X] builds in mock - OK
(1) - Could you add comments on patch to explain why there are here and if you
have information about them by upstream :
http://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_hav...
(2) - typo error : ')' in last release changelog. And if it's possible, could
you add some blank lines between each release for readability ?
(3) - could you use name macro as detailed in
http://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net
So there is only cosmetics changes ...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:46 p.m.
New subject: [Bug 1702] Review Request: imagination - A lightweight and simple GTK based DVD slide show creator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1702
--- Comment #17 from Richard <hobbes1069(a)gmail.com> 2011-05-01 15:46:40 ---
(In reply to comment #16)
Sorry for delay, as promised you can find my review :
No problem!
(1) - Could you add comments on patch to explain why there are here
and if you
have information about them by upstream :
Added w/ url (from this review request)
(2) - typo error : ')' in last release changelog. And if
it's possible, could
you add some blank lines between each release for readability ?
Fixed.
(3) - could you use name macro as detailed in
http://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net
That's what I get for copy-n-pasting :) Fixed.
New spec uploaded to existing URL.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:27 a.m.
New subject: [Bug 1702] Review Request: imagination - A lightweight and simple GTK based DVD slide show creator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1702
Cédric OLIVIER <cedric.olivier(a)free.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:27 a.m.
New subject: [Bug 1702] Review Request: imagination - A lightweight and simple GTK based DVD slide show creator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1702
Cédric OLIVIER <cedric.olivier(a)free.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|2 |3
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:37 a.m.
New subject: [Bug 1702] Review Request: imagination - A lightweight and simple GTK based DVD slide show creator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1702
--- Comment #18 from Cédric OLIVIER <cedric.olivier(a)free.fr> 2011-05-03 11:37:18
---
Could you give me an updated url ?
When I follows your last link posted, the links give me
imagination-3.0-5.fc14.src.rpm.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:14 p.m.
New subject: [Bug 1702] Review Request: imagination - A lightweight and simple GTK based DVD slide show creator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1702
--- Comment #19 from Richard <hobbes1069(a)gmail.com> 2011-05-03 15:14:12 ---
(In reply to comment #18)
Could you give me an updated url ?
When I follows your last link posted, the links give me
imagination-3.0-5.fc14.src.rpm.
Here you go!
https://docs.google.com/leaf?id=0B4A6of0Rl4nUZTEyYmEwNzUtYjE4ZC00YTI2LWE3...
Richard
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:53 p.m.
New subject: [Bug 1702] Review Request: imagination - A lightweight and simple GTK based DVD slide show creator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1702
Cédric OLIVIER <cedric.olivier(a)free.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|3 |4
--- Comment #20 from Cédric OLIVIER <cedric.olivier(a)free.fr> 2011-05-06 17:53:50
---
I don't see anything else with this package, so it is:
APPROVED!
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
11:56 a.m.
New subject: [Bug 1702] Review Request: imagination - A lightweight and simple GTK based DVD slide show creator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1702
--- Comment #21 from Richard <hobbes1069(a)gmail.com> 2011-05-08 13:56:17 ---
Package CVS request
======================
Package Name: imagination
Short Description: A lightweight and simple GTK based slide show creator.
Owners: hobbes1069
Branches: F14
InitialCC:
----------------------
License tag: free
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
11:56 a.m.
New subject: [Bug 1702] Review Request: imagination - A lightweight and simple GTK based DVD slide show creator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1702
Richard <hobbes1069(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |33
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:45 p.m.
New subject: [Bug 1702] Review Request: imagination - A lightweight and simple GTK based DVD slide show creator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1702
NicolasChauvet <kwizart(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|33 |
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
4:23 p.m.
New subject: [Bug 1702] Review Request: imagination - A lightweight and simple GTK based DVD slide show creator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1702
Richard <hobbes1069(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |33
--- Comment #22 from Richard <hobbes1069(a)gmail.com> 2011-06-07 18:23:26 ---
The original cvs request was made prior to F15 releasing. Need F-15 branch too.
Package CVS request
======================
Package Name: imagination
Short Description: A lightweight and simple GTK based slide show creator.
Owners: hobbes1069
Branches: F-14 F-15
InitialCC:
----------------------
License tag: free
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:39 p.m.
New subject: [Bug 1702] Review Request: imagination - A lightweight and simple GTK based DVD slide show creator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1702
NicolasChauvet <kwizart(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|33 |
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:11 p.m.
New subject: [Bug 1702] Review Request: imagination - A lightweight and simple GTK based DVD slide show creator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1702
Richard <hobbes1069(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #23 from Richard <hobbes1069(a)gmail.com> 2011-06-29 15:11:25 ---
Packages for all active branches are in the testing repos.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
4679
days inactive
4754
days old
rpmfusion-developers@lists.rpmfusion.org
44 comments
6 participants
participants (6)
-
Agnes Jones -
manuel "lonely wolf" wolfshant -
Michael Schwendt -
Olivier Cédric -
Richard Shaw -
RPM Fusion Bugzilla