12:26 a.m.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2492
Bug #: 2492
Summary: Review request: mame-data-extras - Extra data files
for MAME
Classification: Unclassified
Product: Package Reviews
Version: Current
Platform: All
OS/Version: GNU/Linux
Status: NEW
Severity: normal
Priority: P5
Component: Review Request
AssignedTo: rpmfusion-package-review(a)rpmfusion.org
ReportedBy: belegdol(a)gmail.com
CC: rpmfusion-package-review(a)rpmfusion.org
Spec URL: http://lesloueizeh.com/belegdol/mame-data-extras.spec
SRPM URL: http://lesloueizeh.com/belegdol/mame-data-extras-0.147-1.fc19.src.rpm
This is a rewrite of the sdlmame-data package, incorporating some of the files
left out after MAME/MESS merge and adding some new ones. Not everything is
up-to-date with 0.147 yet, but I'd rather get the review started sooner and
update the files later. Should be an easy one :)
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
12:26 a.m.
New subject: [Bug 2492] Review request: mame-data-extras - Extra data files for MAME
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2492
Julian Sikorski <belegdol(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |2
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:55 a.m.
New subject: [Bug 2492] Review request: mame-data-extras - Extra data files for MAME
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2492
Julian Sikorski <belegdol(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |metamorfeus(a)gmail.com
--- Comment #1 from Julian Sikorski <belegdol(a)gmail.com> 2012-09-22 10:55:49 CEST
---
*** Bug 1426 has been marked as a duplicate of this bug. ***
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:42 p.m.
New subject: [Bug 2492] Review request: mame-data-extras - Extra data files for MAME
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2492
Sérgio Basto <sergio(a)serjux.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |sergio(a)serjux.com
--- Comment #2 from Sérgio Basto <sergio(a)serjux.com> 2012-09-24 22:42:51 CEST ---
May I use this opportunity to ask to add sdlmame-data-rom ?
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
4:34 a.m.
New subject: [Bug 2492] Review request: mame-data-extras - Extra data files for MAME
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2492
Julian Sikorski <belegdol(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |spud213(a)gmail.com
--- Comment #3 from Julian Sikorski <belegdol(a)gmail.com> 2012-10-14 06:34:07 CEST
---
*** Bug 2530 has been marked as a duplicate of this bug. ***
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:42 p.m.
New subject: [Bug 2492] Review request: mame-data-extras - Extra data files for MAME
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2492
--- Comment #4 from Julian Sikorski <belegdol(a)gmail.com> 2012-10-22 21:42:15 CEST
---
New release:
Spec URL: http://lesloueizeh.com/belegdol/mame-data-extras.spec
SRPM URL: http://lesloueizeh.com/belegdol/mame-data-extras-0.147-2.fc19.src.rpm
Changes:
- Updated everything to 0.147
- Added Robby Roto ROM
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:31 a.m.
New subject: [Bug 2492] Review request: mame-data-extras - Extra data files for MAME
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2492
--- Comment #5 from Sérgio Basto <sergio(a)serjux.com> 2012-10-27 05:31:23 CEST ---
qmc2-sdlmess.x86_64 on F18 ? should we have also, qmc2 updated ?
and btw for when mame-data in F18 ?
Other issue is mame on F18 is not 0.147
rpm -q mame
mame-0.146u4-1.fc18.x86_64
and
gnome-video-arcade.x86_64
needs new mame-0-147 ...
Thanks,
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:40 a.m.
New subject: [Bug 2492] Review request: mame-data-extras - Extra data files for MAME
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2492
--- Comment #6 from Julian Sikorski <belegdol(a)gmail.com> 2012-10-27 09:40:03 CEST
---
qmc2 still uses sdlm* names to refer to linux mame versions, so I have decided
to leave it as is.
The issue with mame atm is that the buildsys has too little memory to build it,
so all mame builds are on hold until further notice. I have offered to donate
memory dies, but I got no response so far.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:40 a.m.
New subject: [Bug 2492] Review request: mame-data-extras - Extra data files for MAME
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2492
--- Comment #7 from Sérgio Basto <sergio(a)serjux.com> 2012-10-29 03:40:19 CET ---
(In reply to comment #6)
qmc2 still uses sdlm* names to refer to linux mame versions, so I
have decided
to leave it as is.
Ah OK, after read "after MAME/MESS merge" I thought MESS was gone but the merge
is just for data-extras ? :)
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:09 a.m.
New subject: [Bug 2492] Review request: mame-data-extras - Extra data files for MAME
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2492
--- Comment #8 from Julian Sikorski <belegdol(a)gmail.com> 2012-10-29 07:09:15 CET
---
What is your point exactly? MAME and MESS are now built from the same source,
same goes for the -extras package - the latter mostly for the ease of
maintenance.
qmc2 subpackages are still called sdlmame and sdlmess because this is how the
frontend refers to them internally due to different set of options for SDL and
Windows builds.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:42 a.m.
New subject: [Bug 2492] Review request: mame-data-extras - Extra data files for MAME
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2492
--- Comment #9 from Sérgio Basto <sergio(a)serjux.com> 2012-10-29 09:42:46 CET ---
(In reply to comment #8)
What is your point exactly?
I understand your point and I
already had install qmc2 in F18 and
gnome-video-arcade too.
Sorry, I made confusion, just made confusion with MAME and MESS, I just use
MAME and to be honest I don't know what MESS is. Sorry about that confusion and
for my bad English.
I totally agreed with this package.
Thanks,
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:35 a.m.
New subject: [Bug 2492] Review request: mame-data-extras - Extra data files for MAME
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2492
--- Comment #10 from Julian Sikorski <belegdol(a)gmail.com> 2012-10-30 07:35:29 CET
---
If you agree with it, could you review it please?
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:31 a.m.
New subject: [Bug 2492] Review request: mame-data-extras - Extra data files for MAME
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2492
--- Comment #11 from Sérgio Basto <sergio(a)serjux.com> 2012-11-04 03:31:21 CET ---
(In reply to comment #10)
If you agree with it, could you review it please?
Hi, OK I Accept it, have I to change anything in this bug report ? to assign ?
$ wget http://lesloueizeh.com/belegdol/mame-data-extras.spec
$ wget http://lesloueizeh.com/belegdol/mame-data-extras-0.147-2.fc19.src.rpm
$ fedora-review -n mame-data-extras --mock-config
fedora-rawhide-x86_64rpmfusion_nonfree
Processing local files: mame-data-extras
Getting .spec and .srpm Urls from : Local files in
/home/sergio/rpmfusion/mame-data-extras
due a bug on fedora-review [1] I don't have results yet ..., I will send to you
ASAP
[1] https://bugzilla.redhat.com/show_bug.cgi?id=872898
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:27 a.m.
New subject: [Bug 2492] Review request: mame-data-extras - Extra data files for MAME
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2492
--- Comment #12 from Julian Sikorski <belegdol(a)gmail.com> 2012-11-04 08:27:51 CET
---
From wiki [1]:
When a proper review gets done the reviewer will
assign the bug to him, remove
the blocker on RF_NEW and set it to block the tracker bug RF_REVIEW (bug #3).
This indicates that a review is in progress.
[1] http://rpmfusion.org/Contributors#Wait_for_your_package_to_be_reviewed
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:41 a.m.
New subject: [Bug 2492] Review request: mame-data-extras - Extra data files for MAME
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2492
--- Comment #13 from Sérgio Basto <sergio(a)serjux.com> 2012-11-16 04:41:12 CET ---
Hi, sorry for this big delay, I have been very very busy.
If you have something that don't understand on this comment, please tell me.
This is based on fedora-review, I think some items could be improved, after
that I will approved the review.
Thanks.
[!] = Fail
[ ] = Manual review needed
Issues:
=======
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. No licenses
found. Please check the source files for licenses manually.
See: http://fedoraproject.org/wiki/Packaging
/LicensingGuidelines#ValidLicenseShortNames
[!]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 14807040 bytes in 13 files.
See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation
===== MUST items =====
[ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
===== SHOULD items =====
[!]: Spec use %global instead of %define.
Note: %define vernumber 147
Rpmlint
-------
mame-data-extras.src: W: file-size-mismatch messinfo.zip = 1902507,
http://www.progettosnaps.net/messinfo/messinfo.zip = 1940181
mame-data-extras.src: W: file-size-mismatch cheat0147.zip = 759300,
http://cheat.retrogames.com/download/cheat0147.zip = 760065
http://cheat.retrogames.com/download/cheat0147.zip :
CHECKSUM(SHA256) this package :
cc5a46a1814a4124f68880500e7736246991d8eca35f3ca46cec4d4a9739c166
CHECKSUM(SHA256) upstream package :
4bd1524583070180798014a14a97478b6c90e633ae90db530862bcacfb5d257e
http://www.progettosnaps.net/messinfo/messinfo.zip :
CHECKSUM(SHA256) this package :
d0c166fe7acd8294a7caa9703b953dc98551da5a8401f86bdf391d33dbf6507b
CHECKSUM(SHA256) upstream package :
6712cd2340c6484ac8518d8c9a46b851b755691f67c3140bd06dedc309dff83b
mame-data-extras-robby.noarch: W: spurious-executable-perm
/usr/share/mame/roms/robby.zip
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:29 p.m.
New subject: [Bug 2492] Review request: mame-data-extras - Extra data files for MAME
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2492
--- Comment #14 from Julian Sikorski <belegdol(a)gmail.com> 2013-02-05 20:29:52 CET
---
Sorry it took so long, I was waiting for all the files getting updated to
0.148. They didn't.
Spec URL: http://lesloueizeh.com/belegdol/mame-data-extras.spec
SRPM URL: http://lesloueizeh.com/belegdol/mame-data-extras-0.148-1.fc19.src.rpm
(In reply to comment #13)
Hi, sorry for this big delay, I have been very very busy.
If you have something that don't understand on this comment, please tell me.
This is based on fedora-review, I think some items could be improved, after
that I will approved the review.
Thanks.
[!] = Fail
[ ] = Manual review needed
Issues:
=======
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. No licenses
found. Please check the source files for licenses manually.
See: http://fedoraproject.org/wiki/Packaging
/LicensingGuidelines#ValidLicenseShortNames
I am actually not sure what license the files are. I could try emailing the
respective authors asking for permission, but this is bound to take a while.
[!]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 14807040 bytes in 13 files.
See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation
I killed some unnecessary files, should be better now
===== MUST items =====
[ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
Are you sure this is wrong? Can't find a mention of it in the guidelines.
===== SHOULD items =====
[!]: Spec use %global instead of %define.
Note: %define vernumber 147
Done.
Rpmlint
-------
mame-data-extras.src: W: file-size-mismatch messinfo.zip = 1902507,
http://www.progettosnaps.net/messinfo/messinfo.zip = 1940181
mame-data-extras.src: W: file-size-mismatch cheat0147.zip = 759300,
http://cheat.retrogames.com/download/cheat0147.zip = 760065
http://cheat.retrogames.com/download/cheat0147.zip :
CHECKSUM(SHA256) this package :
cc5a46a1814a4124f68880500e7736246991d8eca35f3ca46cec4d4a9739c166
CHECKSUM(SHA256) upstream package :
4bd1524583070180798014a14a97478b6c90e633ae90db530862bcacfb5d257e
http://www.progettosnaps.net/messinfo/messinfo.zip :
CHECKSUM(SHA256) this package :
d0c166fe7acd8294a7caa9703b953dc98551da5a8401f86bdf391d33dbf6507b
CHECKSUM(SHA256) upstream package :
6712cd2340c6484ac8518d8c9a46b851b755691f67c3140bd06dedc309dff83b
mame-data-extras-robby.noarch: W: spurious-executable-perm
/usr/share/mame/roms/robby.zip
Fixed.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:12 a.m.
New subject: [Bug 2492] Review request: mame-data-extras - Extra data files for MAME
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2492
Sérgio Basto <sergio(a)serjux.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Blocks|2 |3
--- Comment #15 from Sérgio Basto <sergio(a)serjux.com> 2013-02-06 07:12:53 CET ---
Hi, the report of the fedora-review, are very good, all cleaned.
just a note I prefer have a package named mame-data-extras-rom than
mame-data-extras-robby (is the sample rom, all the point on include it)
do I need do something else ?
APPROVED
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:22 a.m.
New subject: [Bug 2492] Review request: mame-data-extras - Extra data files for MAME
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2492
Sérgio Basto <sergio(a)serjux.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|3 |4
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:23 p.m.
New subject: [Bug 2492] Review request: mame-data-extras - Extra data files for MAME
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2492
Julian Sikorski <belegdol(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |33
--- Comment #16 from Julian Sikorski <belegdol(a)gmail.com> 2013-02-06 21:23:17 CET
---
Package CVS request
======================
Package Name: mame-data-extras
Short Description: Extra data files for MAME
Owners: belegdol
Branches: F-18 F-17
InitialCC:
----------------------
License tag: [nonfree]
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
5:45 p.m.
New subject: [Bug 2492] Review request: mame-data-extras - Extra data files for MAME
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2492
Sérgio Basto <sergio(a)serjux.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |33
Depends on|33 |
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:05 p.m.
New subject: [Bug 2492] Review request: mame-data-extras - Extra data files for MAME
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2492
Nicolas Chauvet <kwizart(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|33 |
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:11 p.m.
New subject: [Bug 2492] Review request: mame-data-extras - Extra data files for MAME
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2492
Nicolas Chauvet <kwizart(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3939
days inactive
4233
days old
rpmfusion-developers@lists.rpmfusion.org
21 comments
1 participants
participants (1)
-
RPM Fusion Bugzilla