12:09 p.m.
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
Summary: Review request: openshot - GNOME Non-linear video editor
Product: Package Reviews
Version: Current
Platform: All
OS/Version: GNU/Linux
Status: NEW
Severity: normal
Priority: P5
Component: Review Request
AssignedTo: rpmfusion-package-review(a)rpmfusion.org
ReportedBy: zarko.pintar(a)gmail.com
CC: rpmfusion-package-review(a)rpmfusion.org
Blocks: 2
Estimated Hours: 0.0
SPEC:
http://wiki.open.hr/~zpintar/fedora-12/openshot.spec
SRC:
http://wiki.open.hr/~zpintar/fedora-12/openshot-0.9.54-1.fc12.src.rpm
Description:
OpenShot Video Editor is a free, open-source, non-linear video editor, based on
Python, GTK, and MLT. It can edit video and audio files, composite and
transition video files, and mix multiple layers of video and audio together and
render the output in many different formats.
Why is not on Fedora:
It depend of MLT Framework
Rpmlint output:
openshot.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/openshot/locale/de_DE/LC_MESSAGES/OpenShot.mo
openshot.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/openshot/locale/es_ES/LC_MESSAGES/OpenShot.mo
openshot.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/openshot/locale/fr_FR/LC_MESSAGES/OpenShot.mo
openshot.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/openshot/locale/it_IT/LC_MESSAGES/OpenShot.mo
openshot.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/openshot/locale/nl_NL/LC_MESSAGES/OpenShot.mo
openshot.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/openshot/locale/pt_PT/LC_MESSAGES/OpenShot.mo
openshot.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/openshot/locale/sv_SE/LC_MESSAGES/OpenShot.mo
2 packages and 0 specfiles checked; 0 errors, 7 warnings.
I tried to use %find_lang OpenShot macro but without effects.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:58 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
Orcan Ogetbil <oget.fedora(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |oget.fedora(a)gmail.com
--- Comment #1 from Orcan Ogetbil <oget.fedora(a)gmail.com> 2009-12-05 22:58:20 ---
(In reply to comment #0)
Rpmlint output:
openshot.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/openshot/locale/de_DE/LC_MESSAGES/OpenShot.mo
openshot.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/openshot/locale/es_ES/LC_MESSAGES/OpenShot.mo
openshot.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/openshot/locale/fr_FR/LC_MESSAGES/OpenShot.mo
openshot.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/openshot/locale/it_IT/LC_MESSAGES/OpenShot.mo
openshot.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/openshot/locale/nl_NL/LC_MESSAGES/OpenShot.mo
openshot.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/openshot/locale/pt_PT/LC_MESSAGES/OpenShot.mo
openshot.noarch: W: file-not-in-%lang
/usr/lib/python2.6/site-packages/openshot/locale/sv_SE/LC_MESSAGES/OpenShot.mo
2 packages and 0 specfiles checked; 0 errors, 7 warnings.
I tried to use %find_lang OpenShot macro but without effects.
Yes, the %find_lang macro doesn't work in such cases because this is a weird
place to put the .mo files. I would ask upstream to use the standard
/usr/share/locale.
In case the .mo files are to stay in the python's site-packages dir, you will
need to tag the .mo files with %lang manually.
As an example of manually tagging with %lang, you can have a look at
http://cvs.fedora.redhat.com/viewvc/devel/qjackctl/qjackctl.spec?view=markup
It is not the same situation but it is similar.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:36 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #2 from Zarko Pintar (grof) <zarko.pintar(a)gmail.com> 2009-12-06
14:36:38 ---
OK, I solved this .mo files.
RPMLint is clean now.
spec and src file links are the same as above, so please look again.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:16 a.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
liangsuilong <liangsuilong(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |liangsuilong(a)gmail.com
--- Comment #3 from liangsuilong <liangsuilong(a)gmail.com> 2010-01-10 11:16:20 ---
Zarko Pintar (grof),
Now openshot-1.0.0 has been released. It is time to update your package.
I installed it manually, so nice.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:30 a.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #4 from Zarko Pintar (grof) <zarko.pintar(a)gmail.com> 2010-01-12
10:30:38 ---
The Stable release of Openshot video editor is out! (Version 1.0)
Here are spec and src files:
SPEC:
http://wiki.open.hr/~zpintar/fedora-12/openshot.spec
SRC:
http://wiki.open.hr/~zpintar/fedora-12/openshot-1.0.0-1.fc12.src.rpm
Rpmlint is completely clean, Mock build, too.
It will be nice to make review of this great video editor package, so I can put
them to RPM Fusion repo.
regards, Zarko
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:19 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
Zarko Pintar (grof) <zarko.pintar(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ry(a)n.rix.si
--- Comment #5 from Zarko Pintar (grof) <zarko.pintar(a)gmail.com> 2010-02-18
15:19:21 ---
@Ryan
Do you maybe, want to push to review this package, too?
OpenShot laying on MLT like Kdenlive.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:18 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #6 from Ryan Rix <ry(a)n.rix.si> 2010-02-18 20:18:48 ---
Do you mean to take over the review to own the application myself, or to review
this for you? I assume rpmfusion has the same review guidelines as Fedora?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:53 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #7 from Zarko Pintar (grof) <zarko.pintar(a)gmail.com> 2010-02-18
21:53:53 ---
(In reply to comment #6)
Do you mean to take over the review to own the application myself, or
to review
this for you? I assume rpmfusion has the same review guidelines as Fedora?
No, no... :)
I think, that you take care about this package, too. Nobody reviewed this. So
maybe you'll have more luck than me.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
5:12 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
Renich Bon Ciric <renich(a)woralelandia.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |renich(a)woralelandia.com
--- Comment #8 from Renich Bon Ciric <renich(a)woralelandia.com> 2010-03-08 18:12:56
---
ping! somebody review this one! BTW, 1.10 is out.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
5:23 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
rc040203(a)freenet.de changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rc040203(a)freenet.de
--- Comment #9 from rc040203(a)freenet.de 2010-03-08 18:23:51 ---
(In reply to comment #8)
ping! somebody review this one!
Is there something to review?
In my understanding, the original submitter
withdrew his submission.
BTW, 1.10 is out.
Do you volunteer to submit a package and to
fix the bugs?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:59 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #10 from Renich Bon Ciric <renich(a)woralelandia.com> 2010-03-08 20:59:12
---
(In reply to comment #9)
(In reply to comment #8)
> ping! somebody review this one!
Is there something to review? In my understanding, the original submitter
withdrew his submission.
> BTW, 1.10 is out.
Do you volunteer to submit a package and to fix the bugs?
Well, I could ;) I'm no programmer, but I can see if I can get the spec file to
build and stuff.
I'll submit a spec for review then ;=)
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:43 a.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #11 from Zarko Pintar (grof) <zarko.pintar(a)gmail.com> 2010-03-09
11:43:10 ---
(In reply to comment #10)
Well, I could ;) I'm no programmer, but I can see if I can get the spec file to
build and stuff.
I'll submit a spec for review then ;=)
And why you do not use mine spec file from Comment #4 ??
This is pretty clean spec file and you only must modify them to version 1.1 and
check with rpmlint....
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:45 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #12 from Renich Bon Ciric <renich(a)woralelandia.com> 2010-03-09 19:45:49
---
(In reply to comment #11)
(In reply to comment #10)
>
> Well, I could ;) I'm no programmer, but I can see if I can get the spec file to
> build and stuff.
>
> I'll submit a spec for review then ;=)
>
And why you do not use mine spec file from Comment #4 ??
This is pretty clean spec file and you only must modify them to version 1.1 and
check with rpmlint....
I was gonna do that exactly ;)
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:54 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #13 from Zarko Pintar (grof) <zarko.pintar(a)gmail.com> 2010-03-09
19:54:18 ---
(In reply to comment #12)
I was gonna do that exactly ;)
Good! :)
You do not need to be a programmer for make packages...
And one hint: Be familiarize with Mock building system.
With Mock you can test all packages without screw up your system with numerous
devel files ;)
good luck!
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:03 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #14 from Ryan Rix <ry(a)n.rix.si> 2010-03-16 16:03:38 ---
I'll take a look at getting this reviewed. I am now maintainer of Kdenlive in
rpmfusion, which also uses MLT, so it is probably a good idea that I maintain
both packages.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:58 a.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
Chen Lei <supercyper(a)163.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |supercyper(a)163.com
--- Comment #15 from Chen Lei <supercyper(a)163.com> 2010-05-04 11:58:25 ---
ping, any response?
Who want to be the responsor(maintainer) of OpenShot?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
12:58 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #16 from Chen Lei <supercyper(a)163.com> 2010-06-21 14:58:43 ---
If no one take this,(In reply to comment #12)
(In reply to comment #11)
> (In reply to comment #10)
> >
> > Well, I could ;) I'm no programmer, but I can see if I can get the spec
file to
> > build and stuff.
> >
> > I'll submit a spec for review then ;=)
> >
>
> And why you do not use mine spec file from Comment #4 ??
> This is pretty clean spec file and you only must modify them to version 1.1 and
> check with rpmlint....
>
I was gonna do that exactly ;)
Ping?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
4:27 a.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #17 from Renich Bon Ciric <renich(a)woralelandia.com> 2010-06-22 06:27:46
---
Ping?
;=s ummm sorry; forgot about this... let me try and see if i can submit
something. Couldn't make it work with mock I think... let me try again.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:10 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #18 from Renich Bon Ciric <renich(a)woralelandia.com> 2010-06-22 21:10:14
---
Created an attachment (id=432)
--> (http://bugzilla.rpmfusion.org/attachment.cgi?id=432)
openshot faulty spec
Hello!
Ok, line 44 is giving me hell. I'm on a 64bit system so it's resolving to:
BUILDROOT/openshot-1.1.3-1.fc13.x86_64/usr/lib
and the package only generates:
BUILDROOT/openshot-1.1.3-1.fc13.x86_64/usr/lib
help! ;)
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:41 a.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
Mohamed El Morabity <pikachu.2014(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pikachu.2014(a)gmail.com
--- Comment #19 from Mohamed El Morabity <pikachu.2014(a)gmail.com> 2010-06-23
03:41:31 ---
(In reply to comment #18)
Ok, line 44 is giving me hell. I'm on a 64bit system so it's
resolving to:
BUILDROOT/openshot-1.1.3-1.fc13.x86_64/usr/lib
and the package only generates:
BUILDROOT/openshot-1.1.3-1.fc13.x86_64/usr/lib
help! ;)
Hi,
Modify this line like this:
rm %{buildroot}/%{_prefix}/lib/mime/packages/openshot
since this useless file is installed in /usr/lib/mime/packages whatever the
architecture.
By the way:
- openshot calls melt from mlt, but RPM Fusion package mlt provides it renamed
as mlt-melt (probably to avoid conflicts with the melt executable provided by
freeze package). You should patch the source code to call mlt-melt instead of
melt (see the attached patch).
- be careful not to list locale files twice: since they are installed in
%{python_sitelib}/%{name}/locale (thanks to %{name}.lang), you should modify
your %files section like this:
%files -f %{name}.lang
%defattr(-,root,root,-)
%doc README COPYING AUTHORS
%{_bindir}/*
%{_datadir}/applications/%{name}.desktop
%{_datadir}/pixmaps/*
%{_datadir}/mime/packages/*
%dir %{python_sitelib}/%{name}
%{python_sitelib}/%{name}/*.py*
%{python_sitelib}/%{name}/classes
%{python_sitelib}/%{name}/effects
%{python_sitelib}/%{name}/export_presets
%{python_sitelib}/%{name}/images
%{python_sitelib}/%{name}/language
%{python_sitelib}/%{name}/profiles
%{python_sitelib}/%{name}/themes
%{python_sitelib}/%{name}/titles
%{python_sitelib}/%{name}/transitions
%{python_sitelib}/%{name}/windows
%{python_sitelib}/*egg-info
%{_mandir}/man*/*
.po files are also installed by default although they are useless, you shoud
remove them in %install.
- please add also the following missing Requires:
pyxdg
pygtk2-libglade
notify-python
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:42 a.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #20 from Mohamed El Morabity <pikachu.2014(a)gmail.com> 2010-06-23
03:42:43 ---
Created an attachment (id=433)
--> (http://bugzilla.rpmfusion.org/attachment.cgi?id=433)
Patch to make openshot call mlt-melt instead of melt
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:10 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #21 from Renich Bon Ciric <renich(a)woralelandia.com> 2010-06-23 20:10:57
---
Ok, it builds... but I'm too scared to try! ;)
I've done the followng:
- add patch0: mtl -> mtl-melt
- add deps:
pyxdg
pygtk2-libglade
notify-python
- removed *.po files (and some others)
Here's the spec file.
rpmlint output:
openshot.spec:54: E: hardcoded-library-path in
%{_prefix}/lib/mime/packages/openshot
0 packages and 1 specfiles checked; 1 errors, 0 warnings.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:11 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
Renich Bon Ciric <renich(a)woralelandia.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #432 is|0 |1
obsolete| |
--- Comment #22 from Renich Bon Ciric <renich(a)woralelandia.com> 2010-06-23 20:11:45
---
Created an attachment (id=434)
--> (http://bugzilla.rpmfusion.org/attachment.cgi?id=434)
it builds but needs revision
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:56 a.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #23 from Chen Lei <supercyper(a)163.com> 2010-06-24 04:56:21 ---
(In reply to comment #20)
Created an attachment (id=433)
-->
(http://bugzilla.rpmfusion.org/attachment.cgi?id=433) [details]
Patch to make openshot call mlt-melt instead of melt
This patch is not needed, we should retire freeze in Fedora because upstream
already rename this package to zeroc-ice
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:31 a.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #24 from Renich Bon Ciric <renich(a)woralelandia.com> 2010-06-24 05:31:44
---
This patch is not needed, we should retire freeze in Fedora because
upstream
already rename this package to zeroc-ice
uh huh... ok... what do I do? (sorry for the newbieness)...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:45 a.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #25 from Chen Lei <supercyper(a)163.com> 2010-06-24 05:45:42 ---
(In reply to comment #24)
> This patch is not needed, we should retire freeze in Fedora
because upstream
> already rename this package to zeroc-ice
uh huh... ok... what do I do? (sorry for the newbieness)...
Rename mlt-melt to melt in rpmfusion, because all other linux distributions use
melt in mlt, then contact freeze maintainer in fedora to rename melt to some
other name or simply retire freeze in fedora(freeze was dead for more than 10
years).
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:01 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
Robert Scheck <rpmfusion-bugzilla(a)linuxnetz.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rpmfusion-
| |bugzilla(a)linuxnetz.de
--- Comment #26 from Robert Scheck <rpmfusion-bugzilla(a)linuxnetz.de> 2010-06-24
21:01:30 ---
I don't see why I should obsolete my "freeze" package. Right now, I even
don't
see any replacement inside of Fedora.
And even if "zeroc-ice" is a replacement for "freeze", I'm even
unable to see
this package in Fedora:
https://admin.fedoraproject.org/pkgdb/acls/list/?searchwords=zeroc%2A
May you provide much more information, please? Because "freeze" has users on
EL-4+ and F-12+ - in Fedora and EPEL. I don't see how RPM Fusion would cover
this, because RPM Fusion is less wide used than EPEL.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:17 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #27 from Chen Lei <supercyper(a)163.com> 2010-06-24 21:17:55 ---
(In reply to comment #26)
I don't see why I should obsolete my "freeze" package.
Right now, I even don't
see any replacement inside of Fedora.
And even if "zeroc-ice" is a replacement for "freeze", I'm even
unable to see
this package in Fedora:
https://admin.fedoraproject.org/pkgdb/acls/list/?searchwords=zeroc%2A
Right, zeroc-ice is not a replacement for the freeze in Fedora. You don't need
to retire it.
May you provide much more information, please? Because
"freeze" has users on
EL-4+ and F-12+ - in Fedora and EPEL. I don't see how RPM Fusion would cover
this, because RPM Fusion is less wide used than EPEL.
No one except you will agree freeze have more users than mlt, in fact it's dead
in upstream for more than 10 years and don't include in all linux distributions
except fedora.
Bugzilla showes low activities on this package.
See https://bugzilla.redhat.com/buglist.cgi?component=freeze&product=Fedora
mlt is offcial supported by debian, ubuntu, gentoo, arch and melt is also
requires by other package(e.g. openshot), thus rename to melt in freeze to
some other name will be more easier. Also, fedora don't encourage packagers
maintaining packages without any upstream support.
See http://fedoraproject.org/wiki/Objectives
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:32 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #28 from Robert Scheck <rpmfusion-bugzilla(a)linuxnetz.de> 2010-06-24
21:32:18 ---
(In reply to comment #27)
No one except you will agree freeze have more users than mlt, in fact
it's
dead in upstream for more than 10 years and don't include in all linux
distributions except fedora.
Which package in EL-4+ and F-12+ is providing /usr/bin/melt except freeze?
I don't see any package in Fedora/EPEL doing that, am I overlooking one?
And as long as there is no replacement directly in EL-4+ and F-12+, I'm not
going to obsolete my freeze package.
Bugzilla showes low activities on this package.
See https://bugzilla.redhat.com/buglist.cgi?component=freeze&product=Fedora
Since when is low bug activity a reason to obsolete a package? Ever heard
about bug free software? ;-)
You have noticed, that I'm maintaining various software in Fedora and EPEL
which is kind of "special" or "exotic", did you?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:42 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #29 from Chen Lei <supercyper(a)163.com> 2010-06-24 21:42:22 ---
(In reply to comment #28)
(In reply to comment #27)
> No one except you will agree freeze have more users than mlt, in fact it's
> dead in upstream for more than 10 years and don't include in all linux
> distributions except fedora.
Which package in EL-4+ and F-12+ is providing /usr/bin/melt except freeze?
I don't see any package in Fedora/EPEL doing that, am I overlooking one?
And as long as there is no replacement directly in EL-4+ and F-12+, I'm not
going to obsolete my freeze package.
I don't metion you need to retire/obsolete it, just rename melt to some other
names, e.g. freeze-melt or whatever you like.
FYI, Fedora policy also consider file conflict in 3rd repo.
See
http://fedoraproject.org/wiki/Packaging:Conflicts#Potential_Conflicting_F...
Also, I think more packages depends on melt in mlt than melt in freeze.
Renaming melt in mlt is really a bad idea because it cause divergence between
fedora and upstream or other linux distributions. Thus, renaming melt in freeze
will be the best choice.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:47 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #30 from Chen Lei <supercyper(a)163.com> 2010-06-24 21:47:40 ---
Hi Robert,
I noticed melt in freeze is link to freeze, can you simply remove it from
package to avoid file conflict?
See
http://koji.fedoraproject.org/koji/fileinfo?rpmID=1983040&filename=/u...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:55 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #31 from Robert Scheck <rpmfusion-bugzilla(a)linuxnetz.de> 2010-06-24
21:55:09 ---
I'm sorry, but I won't give up providing /usr/bin/melt, because especially
on RHEL/CentOS, often only EPEL is used and no RPM Fusion at all. And RPM
Fusion does not cover EL-4, just EL-5+.
http://fedoraproject.org/wiki/Packaging:Alternatives is the only acceptable
way/solution to me. Either you agree about alternatives or things will stay
from my side further on as they are now.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:59 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #32 from Chen Lei <supercyper(a)163.com> 2010-06-24 21:59:28 ---
(In reply to comment #31)
I'm sorry, but I won't give up providing /usr/bin/melt,
because especially
on RHEL/CentOS, often only EPEL is used and no RPM Fusion at all. And RPM
Fusion does not cover EL-4, just EL-5+.
http://fedoraproject.org/wiki/Packaging:Alternatives is the only acceptable
way/solution to me. Either you agree about alternatives or things will stay
from my side further on as they are now.
ALternavites is only useful for two files which have the functions.
Is their any packages require melt? I think just providing freeze is enough
because melt is just a symlink.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:01 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #33 from Chen Lei <supercyper(a)163.com> 2010-06-24 22:01:05 ---
s/the functions/the same function
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:11 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #34 from Robert Scheck <rpmfusion-bugzilla(a)linuxnetz.de> 2010-06-24
22:11:34 ---
There are packages out there in the world depending on /usr/bin/melt - that's
why I am maintaining freeze. I'm not going to break things and I'm not willing
to discuss this further on. Either alternatives or nothing: Your decision.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:13 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #35 from Chen Lei <supercyper(a)163.com> 2010-06-24 22:13:14 ---
Do you mind me to submit a ticket on fesco to ask their opinion? Let them
determine which package can hold the namespace for melt from a system-wide
point of view.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:22 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #36 from Robert Scheck <rpmfusion-bugzilla(a)linuxnetz.de> 2010-06-24
22:22:36 ---
(In reply to comment #35)
Do you mind me to submit a ticket on fesco to ask their opinion? Let
them
determine which package can hold the namespace for melt from a system-wide
point of view.
Last reply from my side: /usr/sbin/sendmail, /usr/bin/java, /usr/bin/print,
/usr/bin/cdrecord or /usr/bin/mkisofs are good examples. These files can be
provided by different packages - in case of cdrecord/mkisofs they're even
and just symlinks to wodim/genisoimage. From my point of view, the situation
is very similar there, because users simply could use wodim rather cdrecord.
And if you ever looked in details to cdrecord/mkisofs alternatives: They are
even more different in functionality than you maybe think or believe...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:52 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #37 from Robert Scheck <rpmfusion-bugzilla(a)linuxnetz.de> 2010-06-24
22:52:59 ---
http://fedorahosted.org/fesco/ticket/404 - just to keep this up-to-date.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:54 a.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #38 from Ryan Rix <ry(a)n.rix.si> 2010-06-26 05:54:08 ---
Thanks for asking for the mlt maintainer's opinion on this before deciding what
is best for my packages... I would have liked at least a note of this going on
especially after it hit FESCo. I'm really too steamed about that still to have
anything to say on this bug that hasn't already been said on
https://fedorahosted.org/fesco/ticket/404#comment:7
and for that matter, this melt business has nothing to do with the review at
hand; could I suggest either moving all that discussion solely to the FESCo
ticket? Thanks.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:09 a.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
Chen Lei <supercyper(a)163.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #434|text/x-rpm-spec |text/plain
mime type| |
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:16 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
Jonathan Dieter <jdieter(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jdieter(a)gmail.com
--- Comment #39 from Jonathan Dieter <jdieter(a)gmail.com> 2010-09-23 15:16:36 ---
So where exactly is this at? I would love to see openshot in RPM Fusion and
would be willing to review it, but it's not clear who has volunteered to
maintain it.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:50 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
Elliott Sales de Andrade <quantum.analyst(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |quantum.analyst(a)gmail.com
--- Comment #40 from Elliott Sales de Andrade <quantum.analyst(a)gmail.com>
2010-10-18 00:50:48 ---
I don't know what happened here with the whole melt/mlt-melt thing, but that's
not really relevant to this request, I'd think.
I have attached an updated spec for 1.2.0, and two patches. The first patch is
for melt/mlt-melt. The second patch installs the documentation (already
upstreamed for 1.3.0).
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:51 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #41 from Elliott Sales de Andrade <quantum.analyst(a)gmail.com>
2010-10-18 00:51:19 ---
Created an attachment (id=513)
--> (http://bugzilla.rpmfusion.org/attachment.cgi?id=513)
OpenShot 1.2.0 RPM spec
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:51 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #42 from Elliott Sales de Andrade <quantum.analyst(a)gmail.com>
2010-10-18 00:51:51 ---
Created an attachment (id=514)
--> (http://bugzilla.rpmfusion.org/attachment.cgi?id=514)
Use mlt-melt instead of melt.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:52 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #43 from Elliott Sales de Andrade <quantum.analyst(a)gmail.com>
2010-10-18 00:52:14 ---
Created an attachment (id=515)
--> (http://bugzilla.rpmfusion.org/attachment.cgi?id=515)
Correctly install documentation
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:59 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #44 from Elliott Sales de Andrade <quantum.analyst(a)gmail.com>
2010-10-18 00:59:50 ---
Oops, pardon me, that updated spec is for 1.2.2, not 1.2.0.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:54 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
Richard <hobbes1069(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hobbes1069(a)gmail.com
--- Comment #45 from Richard <hobbes1069(a)gmail.com> 2010-10-20 22:54:56 ---
I would like to see this package available as well. I am willing to test the
package when it becomes available.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:12 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
David Timms <dtimms(a)iinet.net.au> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dtimms(a)iinet.net.au
--- Comment #46 from David Timms <dtimms(a)iinet.net.au> 2010-10-20 23:12:05 ---
(In reply to comment #45)
I would like to see this package available as well. I am willing to
test the
package when it becomes available.
Can you perform a test build using the latest
src.rpm and patches linked in
this bug ?
You use: rpmbuild -ba whatever.spec
The review guidelines are at:
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
http://fedoraproject.org/wiki/Packaging/Guidelines
We look forward to your input ;-)
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:24 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #47 from Richard <hobbes1069(a)gmail.com> 2010-10-21 00:24:46 ---
I was able to build the install rpm cleanly and install it but had a couple of
questions.
1. Should the package be GPG signed by RPMFusion yet? I had to --nogpgcheck to
get yum to install.
2. I did a yum deplist on the resultant package and noticed it didn't list
"mlt-melt" or "frei0r-plugins" as dependencies.
I did the build remotely from work so I will not be able to test it until later
tonight.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
12:08 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #48 from David Timms <dtimms(a)iinet.net.au> 2010-10-21 14:08:43 ---
(In reply to comment #47)
I was able to build the install rpm cleanly and install it but had a
couple of
questions.
1. Should the package be GPG signed by RPMFusion yet? I had to --nogpgcheck to
get yum to install.
Packages only get signed by RPM Fusion after they have been
accepted into and
built on the RPM Fusion builders. Hence --nogpgcheck is required while
developing the package.
2. I did a yum deplist on the resultant package and noticed it
didn't list
"mlt-melt" or "frei0r-plugins" as dependencies.
Are you testing with Elliott's patches, updated spec and newer upstream version
?
While successful running is important, more important is that the packaging
guidelines are followed - that is the point of the review - I'm encouraging you
to take a look at the spec, and run through the packaging guidelines, to decide
whether the spec passes, fails or you can't tell for each point in the spec.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
12:57 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #49 from Richard <hobbes1069(a)gmail.com> 2010-10-21 14:57:26 ---
(In reply to comment #48)
(In reply to comment #47)
> I was able to build the install rpm cleanly and install it but had a couple of
> questions.
>
> 1. Should the package be GPG signed by RPMFusion yet? I had to --nogpgcheck to
> get yum to install.
Packages only get signed by RPM Fusion after they have been accepted into and
built on the RPM Fusion builders. Hence --nogpgcheck is required while
developing the package.
That makes sense, I just wanted to check.
> 2. I did a yum deplist on the resultant package and noticed it
didn't list
> "mlt-melt" or "frei0r-plugins" as dependencies.
Are you testing with Elliott's patches, updated spec and newer upstream version?
I downloaded both patches and the spec from this bug report. I didn't see a
link for the 1.2.2 source RPM so I downloaded it from the openshot website. I
looked through the .spec file and didn't see any reference to mtl-melt (the
package) or frei0r-plugins.
While successful running is important, more important is that the
packaging
guidelines are followed - that is the point of the review - I'm encouraging you
to take a look at the spec, and run through the packaging guidelines, to decide
whether the spec passes, fails or you can't tell for each point in the spec.
I did review the links but there was a LOT of info on them I just haven't had
time to go through line by line. It may be this weekend before I do.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:49 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #50 from Richard <hobbes1069(a)gmail.com> 2010-10-21 15:49:47 ---
rpmlint output:
rpmlint -v openshot-1.2.2.spec
./rpmbuild/RPMS/noarch/openshot-1.2.2-1.fc13.noarch.rpm
openshot-1.2.2.spec: I: checking-url
http://launchpad.net/openshot/1.2/1.2.2/+download/openshot-1.2.2.tar.gz
(timeout 10 seconds)
openshot.noarch: I: checking
openshot.noarch: I: checking-url http://www.openshotvideo.com/ (timeout 10
seconds)
1 packages and 1 specfiles checked; 0 errors, 0 warnings.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:17 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #51 from Richard <hobbes1069(a)gmail.com> 2010-10-21 16:17:20 ---
Other than the missing dependencies the only two things that I can tell the
package MIGHT be violating is:
- The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
- Permissions on files must be set properly. Executables should be set with
executable permissions, for example. Every %files section must include a
%defattr(...) line.
Can someone confirm one way or the other?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:34 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #52 from Richard <hobbes1069(a)gmail.com> 2010-10-25 15:34:11 ---
(In reply to comment #51)
Other than the missing dependencies the only two things that I can
tell the
package MIGHT be violating is:
- The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
Having slept on it and looking again there it is not using the %find_lang macro
but it's not using %{_datadir}/locale/* either. It's using some shell script. I
don't know if this is necessary since it's python based or for some other
reason but the locale files are definitely installed but under
"/usr/lib/python2.6/site-packages/openshot/locale/*".
- Permissions on files must be set properly. Executables should be
set with
executable permissions, for example. Every %files section must include a
%defattr(...) line.
I don't know why I didn't see it the first time but the spec file is indeed
using the %defattr macro.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
5:19 a.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #53 from Elliott Sales de Andrade <quantum.analyst(a)gmail.com>
2010-10-28 07:19:46 ---
I guess I should have mentioned that I'm not with OpenShot, so my updated spec
won't be related to the one on their website. I merely updated the one that was
here (and wrote the docs patch.)
For dependencies, it lists mlt-python which I think should take care of
mlt-melt. Technically, frei0r-plugins isn't required, but I could add that,
since the effects are limited without it.
The locale files are installed in the python site-package, for whatever reason,
so the spec uses a modified find_lang script to get them. See comment #1.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
12:58 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #54 from Richard <hobbes1069(a)gmail.com> 2010-10-28 14:58:02 ---
(In reply to comment #53)
I guess I should have mentioned that I'm not with OpenShot, so my
updated spec
won't be related to the one on their website. I merely updated the one that was
here (and wrote the docs patch.)
For dependencies, it lists mlt-python which I think should take care of
mlt-melt. Technically, frei0r-plugins isn't required, but I could add that,
since the effects are limited without it.
The locale files are installed in the python site-package, for whatever reason,
so the spec uses a modified find_lang script to get them. See comment #1.
Sounds good to me! What else needs to be done to make this an official package?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:45 a.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #55 from Richard <hobbes1069(a)gmail.com> 2010-11-11 04:45:15 ---
I have since upgraded my system to Fedora 14 so now I have packages built for
F13 & 14 although I can't run it due to the mlt package not being updated for
python 2.7 yet....
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
5:20 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #56 from Richard <hobbes1069(a)gmail.com> 2010-11-23 18:20:33 ---
I hate to "bump" this but I still need some guidance on what else is needed to
make this an official package...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:07 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #57 from Richard <hobbes1069(a)gmail.com> 2011-02-11 16:07:22 ---
Ok, sorry to vent here but it's now February and no one has responded to me.
Would someone please give me some direction or tell me that they have no
intention of helping me get this package supported so I can stop wasting my
time talking to myself?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
4:52 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #58 from Jonathan Dieter <jdieter(a)gmail.com> 2011-02-11 17:52:23 ---
I think the problem is that it's not clear whether you're reviewing the package
or offering to maintain it.
It appeared that you were reviewing the package in which case it is up to
Elliot to reply as he appears to be the last person who put together the
package (or another interested party if he is not longer interested in
packaging openshot).
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:13 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #59 from Richard <hobbes1069(a)gmail.com> 2011-02-11 21:13:26 ---
I'm interested if he is no longer but I have to admit I haven't done it before
so I'll need some guidance.
The packages I built are using Elliott's patches.
I also rebuilt the necessary mlt packages (mlt-melt and mlt-python version
0.5.10) for F14 from source since they were not available for F14 from
rpmfusion.
The packages meet the packaging guidelines as far as I can tell. What's the
next step?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:21 a.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
Hans de Goede <j.w.r.degoede(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |j.w.r.degoede(a)gmail.com
--- Comment #60 from Hans de Goede <j.w.r.degoede(a)gmail.com> 2011-02-12 10:21:56
---
(In reply to comment #59)
I'm interested if he is no longer but I have to admit I
haven't done it before
so I'll need some guidance.
The packages I built are using Elliott's patches.
I also rebuilt the necessary mlt packages (mlt-melt and mlt-python version
0.5.10) for F14 from source since they were not available for F14 from
rpmfusion.
The packages meet the packaging guidelines as far as I can tell. What's the
next step?
Hi,
So if I understand correctly you want to take over the roll as submitter of
this package and
maintain it in rpmfusion?
Are you already a maintainer of packages (a packager) in Fedora itself?
If so, then you need to find a reviewer of this package (just say the word and
I'll volunteer). If you're
not a Fedora packager yet, then you need to find someone to sponsor you, and
show you the ropes,
normally we prefer if people become a Fedora packager first, see:
http://fedoraproject.org/wiki/PackageMaintainers/Join
If you've no packages you're interested in submitting / maintaining for Fedora
itself, we could
do a similar traject here.
Regards,
Hans
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:29 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #61 from Richard <hobbes1069(a)gmail.com> 2011-02-12 22:29:15 ---
(In reply to comment #60)
So if I understand correctly you want to take over the roll as
submitter of
this package and
maintain it in rpmfusion?
I'm certainly not opposed to the idea, but my first preference would be someone
with more experience. However if no one else will, then yes.
Are you already a maintainer of packages (a packager) in Fedora
itself?
If so, then you need to find a reviewer of this package (just say the word and
I'll volunteer). If you're
not a Fedora packager yet, then you need to find someone to sponsor you, and
show you the ropes,
normally we prefer if people become a Fedora packager first, see:
http://fedoraproject.org/wiki/PackageMaintainers/Join
If you've no packages you're interested in submitting / maintaining for Fedora
itself, we could
do a similar traject here.
This would be the only package, so no, I'm not already a Fedora packager. I
pick thing up pretty quickly though. I have some Python experience including
maintaining a package on sourceforge (discspan) and some BASH script hacking.
One thing I think I can figure out but a hint would save some time. I know the
preference is to depend on something IN a package and not the package itself. I
know openshot needs the mlt-melt executable but I'm not sure what requires the
mlt-python package. As far as frei0r-plugins, it's just a collection of what
looks to be effect libraries so I think we would need to require the package
for that one.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
11 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #62 from Richard <hobbes1069(a)gmail.com> 2011-02-15 00:00:56 ---
I have a new package built for version 1.3.0 with updated patches and spec file
which now requires frei0r-plugins.
I don't have a F13 machine handy to build for since I believe the python
version is 2.6 in F13 and 2.7 in F14. Does the source RPM created by rpmbuild
package the patches and spec file? If so it should be pretty trivial to for
someone to build a F13 package.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
4:16 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #63 from Richard <hobbes1069(a)gmail.com> 2011-02-16 17:16:31 ---
If anyone would like to test the 1.3.0 packages for me heres a link:
https://docs.google.com/leaf?id=0B4A6of0Rl4nUYjBkM2Y4NTYtZjIyYS00NjYxLWJl...
Also, I'll be attaching the updated spec and patches to this bug report.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
4:20 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #64 from Richard <hobbes1069(a)gmail.com> 2011-02-16 17:20:26 ---
Created an attachment (id=577)
--> (http://bugzilla.rpmfusion.org/attachment.cgi?id=577)
New spec file for version 1.3.0
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
4:21 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #65 from Richard <hobbes1069(a)gmail.com> 2011-02-16 17:21:14 ---
Created an attachment (id=578)
--> (http://bugzilla.rpmfusion.org/attachment.cgi?id=578)
Updated doc install patch
I don't think this one is different from 1.2.2
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
4:21 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #66 from Richard <hobbes1069(a)gmail.com> 2011-02-16 17:21:40 ---
Created an attachment (id=579)
--> (http://bugzilla.rpmfusion.org/attachment.cgi?id=579)
Updated mlt-melt patch for 1.3.0
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
4:23 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #67 from Richard <hobbes1069(a)gmail.com> 2011-02-16 17:23:59 ---
First link was for the openshot RPM only. This link has openshot and mlt and
mlt-python for F14.
https://docs.google.com/leaf?id=0B4A6of0Rl4nUZDkxZWQ2NzItZTMxYi00NjU2LThk...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:17 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #68 from Didier Moens <Didier.Moens(a)dmbr.UGent.be> 2011-02-16 21:17:17
---
Installs and runs without any immediately apparant issues on F14 x86_64.
Much appreciated, Richard.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:48 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #69 from Richard <hobbes1069(a)gmail.com> 2011-03-04 15:48:41 ---
Ok, if no one objects, I'll volunteer to become a packager and take on this
package.
I have it building cleanly under mock and checking good with rpmlint.
I'm trying to do the same with mlt but it requires ffmpeg-devel which is not in
the fedora repos and I need some help adding the proper RPMFusion repos to my
mock configuration.
New openshot packages here:
https://docs.google.com/leaf?id=0B4A6of0Rl4nUZDkxZWQ2NzItZTMxYi00NjU2LThk...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:07 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
Adam Huffman <bloch(a)verdurin.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |bloch(a)verdurin.com
--- Comment #70 from Adam Huffman <bloch(a)verdurin.com> 2011-04-02 16:07:25 ---
Looks good though you might want to be consistent over old and new-style macros
i.e. $RPM_BUILD_ROOT vs. %{buildroot}
Installs and runs fine on my F14 box.
NB: I'm not an RPMFusion sponsor
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:33 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
Richard <hobbes1069(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #513 is|0 |1
obsolete| |
Attachment #577 is|0 |1
obsolete| |
--- Comment #71 from Richard <hobbes1069(a)gmail.com> 2011-04-02 17:33:40 ---
Created an attachment (id=605)
--> (http://bugzilla.rpmfusion.org/attachment.cgi?id=605)
Updates spec file for better packaging guideline compliance.
Fixed...
Now what?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:30 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
Hans de Goede <j.w.r.degoede(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|2 |3
AssignedTo|rpmfusion-package- |j.w.r.degoede(a)gmail.com
|review(a)rpmfusion.org |
--- Comment #72 from Hans de Goede <j.w.r.degoede(a)gmail.com> 2011-04-04 20:30:53
---
Hi again,
And sorry for the silence since my last post in this bug it has been
a crazy busy time at work.
I'm very happy to see that you're willing to move forward with this and invest
time in it, since openshot is quite a popular piece of software, so it would be
really good to have it packaged for rpmfusion.
(In reply to comment #71)
Created an attachment (id=605)
-->
(http://bugzilla.rpmfusion.org/attachment.cgi?id=605) [details]
Updates spec file for better packaging guideline compliance.
Fixed...
Now what?
Since this is your first Fedora/RPMFusion package you need a sponsor, and
you're the first person ever to go to the sponsor process here at RPMFusion,
rather then just being a Fedora packager already and thus automatically being
accepted as a RPMFusion packager, with that said I like the proactive attitude
which I've seen from you so far and I'm a Fedora sponsor, so I'm going to
assume my sponsor rights extend to rpmfusion too. For some more info on this
whole sponsor thingie, see:
http://fedoraproject.org/wiki/PackageMaintainers/Join
http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group
But what this boils down to, esp. for rpmfusion is:
1) If you've any questions, I'm the person to go to to ask them. And don't
hesitate to ask any!
2) If you make a mess of things and then disappear I get to clean up
after you, so please don't disappear on me :)
Other then that I suggest we just treat this as a regular package submission
and go through a normal package review as described here:
http://fedoraproject.org/wiki/Package_Review_Process
That means that right now you don't need to do anything. I will go and review
your package as time permits. Or rather I'll make some time for this this
evening or tomorrow as this all has been taking long enough already!
So right now you don't need to do anything, and I'll get back to you with a
review of your package (and likely a list of items that need fixing) soon.
Regards,
Hans
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:34 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
Hans de Goede <j.w.r.degoede(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |metal3d(a)gmail.com
--- Comment #73 from Hans de Goede <j.w.r.degoede(a)gmail.com> 2011-04-04 20:34:32
---
*** Bug 1658 has been marked as a duplicate of this bug. ***
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
7:14 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #74 from Richard <hobbes1069(a)gmail.com> 2011-04-04 21:14:39 ---
Thank you for helping me with this. I'm going through something similar on
Fedora for blender. Unfortunately the package maintainers pop in to tell me
what's wrong with my package (in a general sense) but when I ask for specifics
I hear nothing... It can get very frustrating.
I'm a long time Fedora user so I'm not planning on going anywhere.
A tangent to this package is mlt (and the openshot requirement, mlt-python).
F14/Rawhide seems to be stuck on 0.5.4 while F13 is on 0.5.10, however, in
either case neither package has been updated since 2009.
I've got the current git download (0.7.0) and am attempting to build it.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
12:31 a.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #75 from Richard <hobbes1069(a)gmail.com> 2011-04-05 02:31:17 ---
Installed my mlt-0.7.0 package and seems to work fine with openshot.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
2:38 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #76 from Richard <hobbes1069(a)gmail.com> 2011-04-05 16:38:25 ---
I have create a new BZ ticket for mlt:
https://bugzilla.rpmfusion.org/show_bug.cgi?id=1688
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
9:52 a.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #77 from Hans de Goede <j.w.r.degoede(a)gmail.com> 2011-04-10 11:52:40
---
Hi,
I've finally managed to make time to do a full review of this, below are the
results:
Good:
=====
- rpmlint checks return:
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
- package meets naming guidelines
- package meets packaging guidelines
- license ( ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
Needs work:
===========
- The %if ! (0%{?fedora} > 12 || 0%{?rhel} > 5) .. %endif block at the top
should be dropped IMHO, as I don't expect openshot to ever get supported
on EL-5, and Fedora 12 is end of life already.
- I notice that Release: is still one. Next time you do an update (like
the changing of $RPM_BUILD_ROOT vs. %{buildroot}) please bump Release
and add a %changelog entry with the changes. Within Fedora we've the rule
to bump Release and add a %changelog entry even during review to make it
easier for reviewers to check what has changed
- If this is no longer needed please drop it:
# Fix documentation
#for file in `find docs/gnome/ -name '*.xml'`; do
#sed -i -e 's~<\(caption\|mediaobject\|emphasis\)/>~~g' -e '/^[
]\+$/d' $fi
#done
- "CFLAGS="$RPM_OPT_FLAGS" %{__python} setup.py build" should be just
"%{__python} setup.py build" specifying CFLAGS for a noarch package is weird.
- Please add a comment above "License GPLv3", that all files are GPLv3+, except
for files under openshot/uploads/youtube which are "ASL 2.0" and
openshot/window/SimpleGtkBuilderApp.py which is "LGPLv3", making the
effective
license of openshot GPLv3.
The needs work items, are really just small nitpicks / small fixes. So good
job!
Regards,
Hans
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
9:53 a.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
Hans de Goede <j.w.r.degoede(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
9:56 a.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #78 from Hans de Goede <j.w.r.degoede(a)gmail.com> 2011-04-10 11:56:07
---
Hmm, oops,
Some corrections to the good table, the relevant lines
in my previous comment should be replaced with:
- license (GPLv3) OK, text in %doc, matches source
- locales properly handled
- .desktop file properly handled
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
4:14 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #79 from Richard <hobbes1069(a)gmail.com> 2011-04-10 18:14:39 ---
(In reply to comment #77)
Needs work:
===========
- The %if ! (0%{?fedora} > 12 || 0%{?rhel} > 5) .. %endif block at the top
should be dropped IMHO, as I don't expect openshot to ever get supported
on EL-5, and Fedora 12 is end of life already.
Fixed
- I notice that Release: is still one. Next time you do an update
(like
the changing of $RPM_BUILD_ROOT vs. %{buildroot}) please bump Release
and add a %changelog entry with the changes. Within Fedora we've the rule
to bump Release and add a %changelog entry even during review to make it
easier for reviewers to check what has changed
Sorry, I didn't think it was necessary to bump the release until it became a
"real" package. Fixed.
- If this is no longer needed please drop it:
# Fix documentation
#for file in `find docs/gnome/ -name '*.xml'`; do
#sed -i -e 's~<\(caption\|mediaobject\|emphasis\)/>~~g' -e '/^[
]\+$/d' $fi
#done
I haven't needed it yet but the original spec author could comment. I'll remove
it for now.
Technically per the Fedora packaging guidelines BuildRoot is no longer needed.
Should I remove it as well?
- "CFLAGS="$RPM_OPT_FLAGS" %{__python} setup.py
build" should be just
"%{__python} setup.py build" specifying CFLAGS for a noarch package is weird.
It was probably left over from the spec template since it assumes it is arch
specified I believe. Fixed.
- Please add a comment above "License GPLv3", that all
files are GPLv3+, except
for files under openshot/uploads/youtube which are "ASL 2.0" and
openshot/window/SimpleGtkBuilderApp.py which is "LGPLv3", making the
effective
license of openshot GPLv3.
Done.
I'm rebuilding now to make sure I didn't muck anything up!
Richard
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
6:01 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #80 from Hans de Goede <j.w.r.degoede(a)gmail.com> 2011-04-10 20:01:15
---
(In reply to comment #79)
Technically per the Fedora packaging guidelines BuildRoot is no
longer needed.
Should I remove it as well?
No I would leave it in, it does not harm, and removing it causes rpmlint
noise (false positive warnings).
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
7:33 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
Richard <hobbes1069(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #433 is|0 |1
obsolete| |
Attachment #514 is|0 |1
obsolete| |
Attachment #605 is|0 |1
obsolete| |
--- Comment #81 from Richard <hobbes1069(a)gmail.com> 2011-04-10 21:33:50 ---
Created an attachment (id=608)
--> (http://bugzilla.rpmfusion.org/attachment.cgi?id=608)
Updated spec file
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
1:33 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #82 from Richard <hobbes1069(a)gmail.com> 2011-04-11 15:33:01 ---
(In reply to comment #80)
(In reply to comment #79)
> Technically per the Fedora packaging guidelines BuildRoot is no longer needed.
> Should I remove it as well?
>
No I would leave it in, it does not harm, and removing it causes rpmlint
noise (false positive warnings).
Strange. I'm working on a couple of packages for Fedora where I removed
BuildRoot: and rpmlint didn't complain...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
2:42 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
Hans de Goede <j.w.r.degoede(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|3 |4
--- Comment #83 from Hans de Goede <j.w.r.degoede(a)gmail.com> 2011-04-11 16:42:01
---
(In reply to comment #82)
(In reply to comment #80)
> (In reply to comment #79)
>
> > Technically per the Fedora packaging guidelines BuildRoot is no longer needed.
> > Should I remove it as well?
> >
>
> No I would leave it in, it does not harm, and removing it causes rpmlint
> noise (false positive warnings).
Strange. I'm working on a couple of packages for Fedora where I removed
BuildRoot: and rpmlint didn't complain...
Maybe that got (finally) fixed then! If you want to remove the buildroot, feel
free!
The latest version of this package is *approved*. So now go make your self an
rpmfusion account here, if you've not done so already:
http://rpmfusion.org/Contributors#head-643ba68e754c44d2db673ad9aea6a843ad...
And once you've been sponsored (cvsextras membership has been approved) you can
go and do a cvs request, and once that is done import and build :)
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
4:05 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #84 from Richard <hobbes1069(a)gmail.com> 2011-04-11 18:05:18 ---
(In reply to comment #83)
Maybe that got (finally) fixed then! If you want to remove the
buildroot, feel
free!
I'll worry about it for the next release.
The latest version of this package is *approved*. So now go make your
self an
rpmfusion account here, if you've not done so already:
http://rpmfusion.org/Contributors#head-643ba68e754c44d2db673ad9aea6a843ad...
Done!
And once you've been sponsored (cvsextras membership has been
approved) you can
go and do a cvs request, and once that is done import and build :)
Done!
Will this be considered a free or non-free package? I know it's open source but
it depends on a lot of media/codecs...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
5:31 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #85 from Hans de Goede <j.w.r.degoede(a)gmail.com> 2011-04-11 19:31:24
---
(In reply to comment #84)
Will this be considered a free or non-free package? I know it's
open source but
it depends on a lot of media/codecs...
The only non Fedora dependency it has is mlt, and since mlt lives in
rpmfusion-free and openshot itself has a proper FOSS license, it can go to
rpmfusion-free too.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
6:27 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #86 from Richard <hobbes1069(a)gmail.com> 2011-04-11 20:27:18 ---
While I'm waiting for cvs access I was reading ahead on the Contributer wiki...
Package CVS request
======================
Package Name: openshot
Short Description:
Owners: hobbes1069
Branches:
InitialCC:
----------------------
License tag: free
Ok, the others I'm not sure.
For the short description I know the original bug reported said it's for Gnome,
but really it only requires GTK, wouldn't it be more appropriate to use
something like:
A GTK based non-linear video editor
Which branches should be supported? I don't see why all of them wouldn't work.
(F13/F14/F15/Rawhide)
InitalCC?
As far as adding a block for bug 33, do I need to wait until I get CVS access?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
8:50 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
--- Comment #87 from Hans de Goede <j.w.r.degoede(a)gmail.com> 2011-04-11 22:50:39
---
Hi,
(In reply to comment #86)
While I'm waiting for cvs access I was reading ahead on the
Contributer wiki...
Package CVS request
======================
Package Name: openshot
Short Description:
Owners: hobbes1069
Branches:
InitialCC:
----------------------
License tag: free
Ok, the others I'm not sure.
For the short description I know the original bug reported said it's for Gnome,
but really it only requires GTK, wouldn't it be more appropriate to use
something like:
A GTK based non-linear video editor
Yes that is fine.
Which branches should be supported? I don't see why all of them
wouldn't work.
(F13/F14/F15/Rawhide)
Note rpmfusion has not branched between devel and F15 yet, so devel is
currently tracking F15 and we don't have any branch actually tracking rawhide.
Given that this needs a new mlt, and that is only built for F14 and devel, I
would only request an F14 branch (you get devel == F15 automatically).
InitalCC?
leave it Empty
As far as adding a block for bug 33, do I need to wait until I get
CVS access?
I just sponsored you, so you should have CVS access now. Please do a new fully
filled in "Package CVS request" and make this bug block 33 (and keep it
blocking bug 4).
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
8:56 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
Richard <hobbes1069(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |33
--- Comment #88 from Richard <hobbes1069(a)gmail.com> 2011-04-11 22:56:19 ---
Package CVS request
======================
Package Name: openshot
Short Description: A GTK based non-linear video editor
Owners: hobbes1069
Branches: F14
InitialCC:
----------------------
License tag: free
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
10:53 a.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
NicolasChauvet <kwizart(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|33 |
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
2:36 p.m.
New subject: [Bug 993] Review request: openshot - GNOME Non-linear video editor
http://bugzilla.rpmfusion.org/show_bug.cgi?id=993
Richard <hobbes1069(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #89 from Richard <hobbes1069(a)gmail.com> 2011-04-12 16:36:53 ---
Import and build succeeded.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
4768
days inactive
5262
days old
rpmfusion-developers@lists.rpmfusion.org
92 comments
1 participants
participants (1)
-
RPM Fusion Bugzilla