http://bugzilla.rpmfusion.org/show_bug.cgi?id=1278 --- Comment #2 from Michael Schwendt <mschwendt(a)gmail.com&gt; 2010-06-16 11:12:12 --- * mpg312 should not mess with the mpg123 namespace anymore when the new mpg123 returns. The mpg123 executable is not option-compatible with mpg321. * The packaging looks sane. I'm not an RPMFusion dev, so I can't approve this, however. And one could argue about whether the stuff in the -plugins-extras package is worthwhile. It will have a very limited target group (if at all). -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1278 Michael Schwendt <mschwendt(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mschwendt(a)gmail.com --- Comment #4 from Michael Schwendt <mschwendt(a)gmail.com&gt; 2010-06-16 14:27:21 --- libmpg123 is not internal to anything, since it will be needed to build a plug-in for Audacious. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1278 --- Comment #6 from Chen Lei <supercyper(a)163.com&gt; 2010-06-16 15:53:06 --- ./configure show mpg123 support assembler level optimiztion for different CPUs, maybe those optimization should be enabled. I also suggest to add a --with-default-audio=pulse switch to %configure. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1278 --- Comment #8 from Hans de Goede <j.w.r.degoede(a)hhs.nl&gt; 2010-06-18 09:41:31 --- (In reply to comment #2) Hi Michael, Anyone who is a sponsered Fedora packager automatically is a rpmfusion packager and can submit / review / maintain packages here. So if you're happy with the package can you please add an approved comment, then I'll move forward with the CVS procedure etc. (In reply to comment #3) Hi Chen, Upstream and various users of the libs refer to them as libmpg123, and that is for example also what the pkgconfig is called. (In reply to comment #6) When no options are given all assembly code gets compiled in and which one to use gets determined runtime. The alsa output works fine with the alsa pulseaudio plugin, and given that this is a cmdline app using pulseaudio (which only runs under a gdm login) does not necessarily make sense. Moreover pulseaudio upstream advices normal apps to use libalsa together with the alsa pulseaudio plugin, so that they will work on non pulseaudio using systems too. Thanks & Regards, Hans -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1278 --- Comment #10 from Chen Lei <supercyper(a)163.com&gt; 2010-06-18 10:22:53 --- (In reply to comment #8) If the libs is used internally, I think it should be called it as xxx-libs, though debian guys like to call it libxxx. I cann't found a example in fedora which a internal lib is called as libxxx e.g xz-libs python-libs ffmpeg-libs They all be used by external program and be called libxxx in their API docs. Also, most of xxx shlib packages in fedora are actually called as libxxx in their API docs. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1278 --- Comment #12 from Karel Volný <kvolny(a)redhat.com&gt; 2010-06-21 10:27:33 --- (In reply to comment #11) I'd refer to comment #8 - "pulseaudio (which only runs under a gdm login)" ... if I get it right, it would NOT work out of the box (in text, which is the mode you'd most probably like to use mpg123 in) now a bit flame - go search Red Hat bugzilla for PulseAudio problems, do you really think that making PulseAudio default led to more things working (out of the box)? ... aliasing mplayer to "mplayer -ao alsa" made my life a lot easier -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1278 --- Comment #14 from Michael Schwendt <mschwendt(a)gmail.com&gt; 2010-07-01 20:31:09 --- JFYI, Audacious Plugins 2.4-alpha2 contains a copy of libmpeg123 (whether modified or not, haven't examined that). It doesn't look like an external lib is checked for, because the previous configure check is gone. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1278 NicolasChauvet <kwizart(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #15 from NicolasChauvet <kwizart(a)gmail.com&gt; 2010-07-14 10:58:11 --- 1/ Either libmpeg123 or mpg123-libs is a matter of convention to me. tarball, then usually libraries targetted for multilibs subpackage has -libs suffix. Now using lib has a prefix for mpeg123 when dealing with library is a debian guideline. What should be keepted in mind, is that projects often change to this namespace then. This seems the case here but only in wording, not as source archive yet. In this case, it only matter not to conflicts with an already existant package. (as we already have libmpeg2 libmpeg3 mpeg4ip libmpg4v2 etc). 2/ alternatives. As of #c2 since mpg123 and mpg321 aren't option compatible anymore, alternative could be dropped. Now maybe an mpg321 update will restore this compatibility later. As I previously pushed for the mpg321 to support alternatives, I think it's good to keep. 3/ audio output. What annoy me the most is to have the jack audio output at the same level as deprecated output such as nas or esd. vlc has removed the code for theses output since about 2 development cycle (including arts). So maybe we shoudn't build them anymore. Using extras in this case is the right thing but we shoudn't mix extras as 'less used plugins' and 'plugin for distro from the last century'. Now I understand the viewpoint of using pulseaudio output by default, I pushed this way for a desktop music app reviewed here. But things aren't the same in console mode. (and that's what I've done for the vlc case where the PA output is removed from vlc-core to leave with vlc which brings desktop modules). There is also a hight dependency footprint bring by the PA output. So my advice is to split the pulseaudio and jack output to separate plugin, and to have them added conditionally in comps.xml when the pa-libs or the jack package is available. Runtime test is following... -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1278 --- Comment #17 from Hans de Goede <j.w.r.degoede(a)hhs.nl&gt; 2010-07-16 13:24:52 --- (In reply to comment #16) Done, here is a new version with the pa and jack output plugins both in separate sub packages: Spec: http://jwrdegoede.danny.cz/mpg123.spec SRPM: http://jwrdegoede.danny.cz/mpg123-1.12.1-4.fc14.src.rpm -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1278 Hans de Goede <j.w.r.degoede(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33 --- Comment #19 from Hans de Goede <j.w.r.degoede(a)gmail.com&gt; 2010-07-16 21:00:30 --- Package CVS request ====================== Package Name: mpg123 Short Description: cmdline MPEG audio player Owners: jwrdegoede Branches: F-12 F-13 InitialCC: ---------------------- License tag: free -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1278 --- Comment #20 from NicolasChauvet <kwizart(a)gmail.com&gt; 2010-08-10 11:10:15 --- @Hans, The cvs for this package have been created but the pakage wasn't imported yet. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.