[Bug 4540] New: Review Request: nvidia-modprobe - Load the NVIDIA kernel module and create NVIDIA character device files
2:05 p.m.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4540
Bug ID: 4540
Summary: Review Request: nvidia-modprobe - Load the NVIDIA
kernel module and create NVIDIA character device files
Product: Package Reviews
Version: Current
Hardware: x86_64
OS: GNU/Linux
Status: NEW
Severity: enhancement
Priority: P1
Component: Review Request
Assignee: rpmfusion-package-review(a)rpmfusion.org
Reporter: kwizart(a)gmail.com
CC: rpmfusion-package-review(a)rpmfusion.org
Group: Package Reviews
SRPM: http://dl.kwizart.net/review/nvidia-modprobe-381.22-1.fc27.src.rpm
SPEC: http://dl.kwizart.net/review/nvidia-modprobe.spec
Description: Load the NVIDIA kernel module and create NVIDIA character device
files
This package is for the nonfree section because it's only relevant along nvidia
driver.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
2:05 p.m.
New subject: [Bug 4540] Review Request: nvidia-modprobe - Load the NVIDIA kernel
module and create NVIDIA character device files
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4540
Nicolas Chauvet <kwizart(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Group|Package Reviews |
CC list accessible|1 |0
Reporter|1 |0
accessible| |
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
2:08 p.m.
New subject: [Bug 4540] Review Request: nvidia-modprobe - Load the NVIDIA kernel
module and create NVIDIA character device files
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4540
Richard <hobbes1069(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |hobbes1069(a)gmail.com
Blocks| |3
Referenced Bugs:
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3
[Bug 3] Tracker: Packages under review.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
3:39 p.m.
New subject: [Bug 4540] Review Request: nvidia-modprobe - Load the NVIDIA kernel
module and create NVIDIA character device files
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4540
--- Comment #1 from Richard <hobbes1069(a)gmail.com> ---
Bah, fedora-review is broken... I guess I'll have to do this the hard way.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
7:41 a.m.
New subject: [Bug 4540] Review Request: nvidia-modprobe - Load the NVIDIA kernel
module and create NVIDIA character device files
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4540
Simone Caronni <negativo17(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |negativo17(a)gmail.com
--- Comment #2 from Simone Caronni <negativo17(a)gmail.com> ---
Passing DEBUG does not strip the binaries, so the following changes should
actually give the same results with slightly shorter commands. NV_VERBOSE
during install should not be needed; I don't see any difference; it's just
installing 2 directories and 2 files.
%prep
%setup -q
# Remove additional CFLAGS added when enabling DEBUG
sed -i '/+= -O0 -g/d' utils.mk
%build
export CFLAGS="%{optflags}"
export LDFLAGS="%{?__global_ldflags}"
%make_build NV_VERBOSE=1 PREFIX=%{_prefix} DEBUG=1
%install
%make_install PREFIX=%{_prefix}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
4:53 p.m.
New subject: [Bug 4540] Review Request: nvidia-modprobe - Load the NVIDIA kernel
module and create NVIDIA character device files
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4540
--- Comment #3 from Nicolas Chauvet <kwizart(a)gmail.com> ---
(In reply to Simone Caronni from comment #2)
Passing DEBUG does not strip the binaries, so the following changes
should
actually give the same results with slightly shorter commands. NV_VERBOSE
Yep, but
at the cost of using a dynamic patch (sed), which at the end, make it
worth (gendiff will fails to create a ).
Creating a static patch based on this will unlikely be accepted upstream , then
will need to be rebase on each releases.
So, thx for sharing your way, but that was indeed on purpose.
Of course one can still fix it better upstream. But that fine enough for me.
Any other issue with this review ?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
6:42 a.m.
New subject: [Bug 4540] Review Request: nvidia-modprobe - Load the NVIDIA kernel
module and create NVIDIA character device files
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4540
--- Comment #4 from Simone Caronni <negativo17(a)gmail.com> ---
(In reply to Nicolas Chauvet from comment #3)
Any other issue with this review ?
I see no issues.
(In reply to Richard from comment #1)
Bah, fedora-review is broken... I guess I'll have to do this the
hard way.
Richard, will you do it or I can do it?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
12:15 p.m.
New subject: [Bug 4540] Review Request: nvidia-modprobe - Load the NVIDIA kernel
module and create NVIDIA character device files
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4540
--- Comment #5 from Richard <hobbes1069(a)gmail.com> ---
If you've got time go for it. Thanks!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
7:35 a.m.
New subject: [Bug 4540] Review Request: nvidia-modprobe - Load the NVIDIA kernel
module and create NVIDIA character device files
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4540
--- Comment #6 from Simone Caronni <negativo17(a)gmail.com> ---
Sorry for the late reply, I've been extremely busy.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
7:36 a.m.
New subject: [Bug 4540] Review Request: nvidia-modprobe - Load the NVIDIA kernel
module and create NVIDIA character device files
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4540
Simone Caronni <negativo17(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|3 |
Flags| |fedora-review+
--- Comment #7 from Simone Caronni <negativo17(a)gmail.com> ---
I see no issues with the package, rpmlint, licenses, fedora-review, etc.
Package approved.
Referenced Bugs:
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3
[Bug 3] Tracker: Packages under review.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
8:08 a.m.
New subject: [Bug 4540] Review Request: nvidia-modprobe - Load the NVIDIA kernel
module and create NVIDIA character device files
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4540
Nicolas Chauvet <kwizart(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|rpmfusion-package-review@rp |negativo17(a)gmail.com
|mfusion.org |
--- Comment #8 from Nicolas Chauvet <kwizart(a)gmail.com> ---
Thx for the review
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
6:13 a.m.
New subject: [Bug 4540] Review Request: nvidia-modprobe - Load the NVIDIA kernel
module and create NVIDIA character device files
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4540
Nicolas Chauvet <kwizart(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #9 from Nicolas Chauvet <kwizart(a)gmail.com> ---
I've imported nvidia-modprobe. We will make use of it with 384+
--
You are receiving this mail because:
You are on the CC list for the bug.
2487
days inactive
2536
days old
rpmfusion-developers@lists.rpmfusion.org
11 comments
1 participants
participants (1)
-
RPM Fusion Bugzilla