https://bugzilla.rpmfusion.org/show_bug.cgi?id=3099 Xavier Bachelot <xavier(a)bachelot.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2 -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3099 --- Comment #2 from Xavier Bachelot <xavier(a)bachelot.org&gt; 2014-01-05 12:21:07 CET --- (In reply to comment #1) True, but all currently supported releases have libaacs 0.7.0, so it's not strictly necessary. Anyway, I could change to a versionned BR: for next iteration. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3099 Xavier Bachelot <xavier(a)bachelot.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |negativo17(a)gmail.com --- Comment #4 from Xavier Bachelot <xavier(a)bachelot.org&gt; 2014-01-06 12:04:30 CET --- *** Bug 3103 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3099 Simone Caronni <negativo17(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #5 from Simone Caronni <negativo17(a)gmail.com&gt; 2014-01-08 08:54:51 CET --- Couple of fixes... 1) Package should require these, for ldconfig and for installing the directory that contains pkgconfig files. Requires: pkgconfig Requires(post): ldconfig 2) Please remove the "Group" directives since they're not needed since RHEL 5. 3) Please bump libaacs-devel requirements to 0.7.0, it's written in the autotools files. libaacs-devel >= 0.7.0 Apart from these small issues, the package is ok! There are a couple of minor cosmetic changes that you could perform, but these are up to you: -%{_libdir}/pkgconfig/libbdplus.pc +%{_libdir}/pkgconfig/%{name}.pc -make install DESTDIR=$RPM_BUILD_ROOT -find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';' +%make_install +find %{buildroot} -name '*.la' -delete The latter %make_install is the default when creating barebone spec files with rpmdev-newspec. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3099 --- Comment #7 from Simone Caronni <negativo17(a)gmail.com&gt; 2014-01-09 10:48:49 CET --- Can't run fedora-review on prebuilt packages / src.rpm / .spec due to some obscure bug in the latest version that I don't have time to debug: DEBUG: Exception down the road... Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 232, in run self._do_run(outfile) File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 222, in _do_run self._do_report(outfile) File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 96, in _do_report self._run_checks(self.bug.spec_file, self.bug.srpm_file, outfile) File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line 105, in _run_checks self.checks = Checks(spec, srpm) File "/usr/lib/python2.7/site-packages/FedoraReview/checks.py", line 268, in __init__ _ChecksLoader.__init__(self) File "/usr/lib/python2.7/site-packages/FedoraReview/checks.py", line 166, in __init__ self._load_checks() File "/usr/lib/python2.7/site-packages/FedoraReview/checks.py", line 204, in _load_checks tests = registry.register(plugin) File "/usr/lib/python2.7/site-packages/FedoraReview/registry.py", line 130, in register obj = (c[1])(self.checks) File "/usr/lib/python2.7/site-packages/FedoraReview/plugins/generic_should.py", line 80, in __init__ if self.flags['EPEL5']: KeyError: 'EPEL5' Rpmlint is not giving any error, all the bits from a manual review are in place. Approving the package. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3099 Simone Caronni <negativo17(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|3 |4 -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3099 --- Comment #9 from Xavier Bachelot <xavier(a)bachelot.org&gt; 2014-01-09 12:25:43 CET --- (In reply to comment #8) Yes, it's also true for EL6. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3099 Nicolas Chauvet <kwizart(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33 | -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.