https://bugzilla.rpmfusion.org/show_bug.cgi?id=3554 --- Comment #1 from Mamoru TASAKA <mtasaka(a)fedoraproject.org&gt; 2015-03-01 12:44:05 CET --- Martin, would you swap review with mine (bug 3553)? -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3554 Mamoru TASAKA <mtasaka(a)fedoraproject.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3554 --- Comment #3 from Mamoru TASAKA <mtasaka(a)fedoraproject.org&gt; 2015-03-01 15:28:00 CET --- Program itself seems to be working correctly. * License - Well, please never modify license text downstream, even if rpmlint complains for it. License modification must be done only on upstream. * BuildRequires: - For pkgconfig based BR (i.e. "PKG_CHECK_MODULES" in configure.ac) it is better to use pkgconfig vitual BR, like BuildRequires: pkgconfig(flac) (not a blocker) * License tag - (not a blocker) License tag can simply be GPLv2+ (This is effectively one single binary, and writing multiple licenses where GPLv2+ is predominant actually does not make sense) * License file - Use %license for license text: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging... * %defattr - %defattr can be removed (current rpmbuild does not need this any longer) * rpmfusion category - Well, I think this is "free" category for rpmfusion, not "nonfree" My recognition is that they are actually "free" (patent issue or so does not make it "nonfree" category), would you check this? (Also check MOCK.log attached) * incorrect-fsf-address rpmlint - Please ping upsteam later (check rpmlint result for -debuginfo rpm) (not a blocker) Well, please check above. I don't see strict blocker for this package. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3554 --- Comment #5 from Mamoru TASAKA <mtasaka(a)fedoraproject.org&gt; 2015-03-01 16:03:49 CET --- (Additional notes: pkgconfig based BR is written on https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelin... ) -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3554 Mamoru TASAKA <mtasaka(a)fedoraproject.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|3 |4 --- Comment #7 from Mamoru TASAKA <mtasaka(a)fedoraproject.org&gt; 2015-03-02 06:05:22 CET --- Well, I still object to patching against license text on downside, however I won't make it a blocker for now. ---------------------------------------------------- This package (aqualung) is APPROVED by mtasaka ---------------------------------------------------- -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3554 MartinKG <mgansser(a)alice.de&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33 --- Comment #9 from MartinKG <mgansser(a)alice.de&gt; 2015-03-02 08:26:49 CET --- Package CVS request ====================== Package Name: aqualung Short Description: Music Player for GNU/Linux Owners: martinkg Branches: f20 f21 f22 InitialCC: ---------------------- License tag: free -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3554 MartinKG <mgansser(a)alice.de&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #10 from MartinKG <mgansser(a)alice.de&gt; 2015-03-05 20:37:37 CET --- Built on devel 22162 (aqualung): Build on target fedora-21-rpmfusion_free succeeded. http://buildsys.rpmfusion.org/plague-results/fedora-21-rpmfusion_free/aqu... Will be pushed into testing in a few days (until the built packages are pushed into -testing, rebuilt packages are available on the above URLs) Closing, thank you. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.