6:46 p.m.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3430
Bug #: 3430
Summary: Review request: qtads - Multimedia interpreter for
Tads games
Classification: Unclassified
Product: Package Reviews
Version: Current
Platform: All
OS/Version: GNU/Linux
Status: NEW
Severity: normal
Priority: P5
Component: Review Request
AssignedTo: rpmfusion-package-review(a)rpmfusion.org
ReportedBy: valtri(a)civ.zcu.cz
CC: rpmfusion-package-review(a)rpmfusion.org
Spec URL: http://scientific.zcu.cz/fedora/qtads-2.1.6-1/qtads.spec
SRPM URL:
http://scientific.zcu.cz/fedora/qtads-2.1.6-1/qtads-2.1.6-1.fc22.src.rpm
Description: QTads is a cross-platform, multimedia interpreter for Tads games,
compatible with HTML TADS. Both Tads versions in use today (Tads 2 and Tads 3)
are supported.
Why this package is not eligible to be included in Fedora: non-commercial
license of the bundled parts (tads2, tads3, htmltads)
Rpmlint:
qtads.src: W: invalid-license non-commercial
qtads.src: W: invalid-license non-commercial
qtads.src:25: W: unversioned-explicit-provides bundled(md5-deutsch-c++)
qtads.src:26: W: unversioned-explicit-provides bundled(sha2-gladman)
qtads.src: W: invalid-url Source0:
http://downloads.sourceforge.net/qtads/qtads-2.1.6.tar.bz2 HTTP Error 404: Not
Found
qtads.x86_64: W: invalid-license non-commercial
qtads.x86_64: W: invalid-license non-commercial
qtads.x86_64: E: incorrect-fsf-address /usr/share/licenses/qtads/COPYING
qtads.x86_64: E: incorrect-fsf-address
/usr/share/licenses/qtads/HTML_TADS_LICENSE
qtads-debuginfo.x86_64: W: invalid-license non-commercial
qtads-debuginfo.x86_64: W: invalid-license non-commercial
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/syssoundogg.h
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/qtadssound.cc
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/sysframe.h
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/dispwidget.cc
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/settings.h
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/syswingroup.cc
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/confdialog.cc
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/sysimagejpeg.h
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/hos_qt.cc
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/qtadstimer.h
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/sysframe.cc
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/syssoundwav.h
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/settings.cc
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/syswinaboutbox.h
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/qtadsimage.cc
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/syswinaboutbox.cc
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/sysfont.h
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/syssoundmpeg.h
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/main.cc
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/dispwidget.h
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/hos_qt.h
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/qtadshostifc.h
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/dispwidgetinput.h
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/syswin.cc
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/dispwidgetinput.cc
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/qtadssound.h
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/missing.h
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/sysimagemng.h
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/sysimage.cc
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/syssound.cc
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/syssoundmidi.h
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/syswingroup.h
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/sysimagepng.h
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/confdialog.h
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/missing.cc
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/syswin.h
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/syswininput.cc
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/oemqt.c
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/osqt.cc
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/qtadsimage.h
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/osqt.h
qtads-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/qtads-2.1.6/src/syswininput.h
3 packages and 0 specfiles checked; 44 errors, 9 warnings.
invalid-license: non-free licenses are not known to rpmlint
unversioned-explicit-provides: these bundled pieces has no version (it is also
in other packages)
incorrect-fsf-address: reported here: https://github.com/realnc/qtads/pull/3
invalid-url: temporary outtage I guess? we can change it to github (where the
tarbal is generated though)
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:46 p.m.
New subject: [Bug 3430] Review request: qtads - Multimedia interpreter for Tads games
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3430
František Dvořák <valtri(a)civ.zcu.cz> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |2
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
11:36 a.m.
New subject: [Bug 3430] Review request: qtads - Multimedia interpreter for Tads games
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3430
Hans de Goede <j.w.r.degoede(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |j.w.r.degoede(a)gmail.com
AssignedTo|rpmfusion-package-review@rp |j.w.r.degoede(a)gmail.com
|mfusion.org |
--- Comment #1 from Hans de Goede <j.w.r.degoede(a)gmail.com> 2015-12-28 12:36:26 CET
---
Hi,
I've had this package on my list of interesting pkgs to review for a while now.
So here we are almost a year later and I finally have some time to review this.
I should have a review done for this pkg soon,
Note that currently rpmfusion infra is being migrated to git + koji, so atm new
pkg requests are not being processed. So once this pkg passes review you
unfortunately still need to wait a bit longer... But first lets get the review
done.
Regards,
Hans
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:33 p.m.
New subject: [Bug 3430] Review request: qtads - Multimedia interpreter for Tads games
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3430
Hans de Goede <j.w.r.degoede(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Blocks|2 |4
--- Comment #2 from Hans de Goede <j.w.r.degoede(a)gmail.com> 2015-12-28 16:33:38 CET
---
Full review done:
Good:
=====
- rpmlint checks return:
qtads.src: W: invalid-license non-commercial
qtads.src: W: invalid-license non-commercial
qtads.src:25: W: unversioned-explicit-provides bundled(md5-deutsch-c++)
qtads.src:26: W: unversioned-explicit-provides bundled(sha2-gladman)
qtads.x86_64: W: invalid-license non-commercial
qtads.x86_64: W: invalid-license non-commercial
qtads-debuginfo.x86_64: W: invalid-license non-commercial
qtads-debuginfo.x86_64: W: invalid-license non-commercial
3 packages and 0 specfiles checked; 0 errors, 8 warnings.
These can all be ignored
- package meets naming guidelines
- package meets packaging guidelines
- license (non-commercial) OK, text in %license, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- .desktop file provided and properly installed
Everything in order: Approved.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
8:17 p.m.
New subject: [Bug 3430] Review request: qtads - Multimedia interpreter for Tads games
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3430
František Dvořák <valtri(a)civ.zcu.cz> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |33
--- Comment #3 from František Dvořák <valtri(a)civ.zcu.cz> 2015-12-30 21:17:36 CET
---
Package CVS request
======================
Package Name: qtads
Short Description: Multimedia interpreter for Tads games
Owners: valtri
Branches: f23
InitialCC:
----------------------
License tag: nonfree
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
2:14 p.m.
New subject: [Bug 3430] Review request: qtads - Multimedia interpreter for Tads games
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3430
Nicolas Chauvet <kwizart(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|33 |
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
8:50 a.m.
New subject: [Bug 3430] Review request: qtads - Multimedia interpreter for Tads
games
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3430
Nicolas Chauvet <kwizart(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |valtri(a)civ.zcu.cz
Flags| |fedora-review+,
| |needinfo?(valtri(a)civ.zcu.cz
| |)
--- Comment #4 from Nicolas Chauvet <kwizart(a)gmail.com> ---
@František Dvořák
The package module was created for this bug but the package was not ever built.
Please escalate to me if you miss anything to import the package.
http://rpmfusion.org/Contributors
--
You are receiving this mail because:
You are on the CC list for the bug.
2:48 p.m.
New subject: [Bug 3430] Review request: qtads - Multimedia interpreter for Tads
games
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3430
František Dvořák <valtri(a)civ.zcu.cz> changed:
What |Removed |Added
----------------------------------------------------------------------------
namespace| |nonfree
--- Comment #5 from František Dvořák <valtri(a)civ.zcu.cz> ---
Yes, this is waiting for me (I built only frobtads at the time). I'll re-check
and build this package.
--
You are receiving this mail because:
You are on the CC list for the bug.
408
days inactive
3644
days old
rpmfusion-developers@lists.rpmfusion.org
12 comments
1 participants
participants (1)
-
RPM Fusion Bugzilla