12:04 p.m.
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1845
Summary: Review request: miro - Internet TV Player
Product: Package Reviews
Version: Current
Platform: All
OS/Version: GNU/Linux
Status: NEW
Severity: normal
Priority: P5
Component: Review Request
AssignedTo: rpmfusion-package-review(a)rpmfusion.org
ReportedBy: michel+rpmf(a)sylvestre.me
CC: rpmfusion-package-review(a)rpmfusion.org
Blocks: 2
Estimated Hours: 0.0
Spec: http://salimma.fedorapeople.org/specs/media/miro.spec
SRPM: http://salimma.fedorapeople.org/specs/media/miro-4.0.2-1.fc15.src.rpm
Description:
Miro is a free HD video player. It offers over 6,000 free internet TV
shows and video podcasts, and has a simple interface designed for
fullscreen HD video. It downloads most videos, allowing users to take
their shows with them.
Why not Fedora:
This was previously maintained in Fedora, up to 3.5.x, but the new 4.x versions
have a hard dependency on ffmpeg for format conversion; I am one of the Fedora
maintainers, and as discussed with upstream and other Fedora comaintainers,
we're moving the package to RPMfusion for now.
rpmlint:
on SRPM:
$ rpmlint media/miro-4.0.2-1.fc15.src.rpm
miro.src: W: spelling-error %description -l en_US podcasts -> podcast, pod
casts, pod-casts
miro.src: W: spelling-error %description -l en_US fullscreen -> full screen,
full-screen, firescreen
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
These are correct spellings, just not in aspell's dictionary
on binary:
$ rpmlint ~/rpmbuild/RPMS/x86_64/miro-4.0.2-1.fc15.x86_64.rpm
miro.x86_64: W: spelling-error %description -l en_US podcasts -> podcast, pod
casts, pod-casts
miro.x86_64: W: spelling-error %description -l en_US fullscreen -> full screen,
full-screen, firescreen
miro.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/miro/plat/xlibhelper.so
xlibhelper.so()(64bit)
miro.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/miro/ngrams.so ngrams.so()(64bit)
miro.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/miro/frontends/widgets/gtk/webkitgtkhacks.so
webkitgtkhacks.so()(64bit)
miro.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/miro/infolist.so infolist.so()(64bit)
miro.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/miro/frontends/widgets/gtk/pygtkhacks.so
pygtkhacks.so()(64bit)
miro.x86_64: W: no-manual-page-for-binary miro-segmenter
1 packages and 0 specfiles checked; 0 errors, 8 warnings.
Spelling "errors": same explanation
Privae shared objects: common in Python arch-dependent packages
Missing manual: the binary is normally used by the Miro program itself, though
since it can also be used on the command line, perhaps it does not need to be
moved to /usr/libexec
$ rpmlint ~/rpmbuild/RPMS/x86_64/miro-debuginfo-4.0.2-1.fc15.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
12:36 p.m.
New subject: [Bug 1845] Review request: miro - Internet TV Player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1845
Nicolas Chauvet <kwizart(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kwizart(a)gmail.com
--- Comment #1 from Nicolas Chauvet <kwizart(a)gmail.com> 2011-07-14 14:36:22 ---
Does the format conversion feature of Miro really worth the move to RPM Fusion?
There are lot of video conversion tool that can be dedicated to the convertion
task. Miro does more than that, so that's a pity to remove it from fedora.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:13 p.m.
New subject: [Bug 1845] Review request: miro - Internet TV Player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1845
--- Comment #2 from Michel Alexandre Salim <michel+rpmf(a)sylvestre.me> 2011-07-14
16:13:06 ---
(In reply to comment #1)
Does the format conversion feature of Miro really worth the move to
RPM Fusion?
Format conversion was an optional feature in 3.5.x, but unfortunately is
integral in 4.x, to support synchronization for portable devices (which might
require format conversions).
Upstream chose to use ffmpeg to implement this, even though playback is
gstreamer-based, since Debian and Ubuntu have a stripped version of ffmpeg that
does not support patent-encumbered formats.
There are lot of video conversion tool that can be dedicated to the
convertion
task. Miro does more than that, so that's a pity to remove it from fedora.
I agree, however, upstream would not be able to fix this for several months at
least (I've asked).
Should we see if we can get a 'lite' version of ffmpeg into Fedora instead?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:19 p.m.
New subject: [Bug 1845] Review request: miro - Internet TV Player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1845
Rex Dieter <rdieter(a)math.unl.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rdieter(a)math.unl.edu
--- Comment #3 from Rex Dieter <rdieter(a)math.unl.edu> 2011-07-14 16:19:57 ---
I, for one, would welcome a ffmpeg-lite, but getting the implementation right
may well be hard.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:30 p.m.
New subject: [Bug 1845] Review request: miro - Internet TV Player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1845
--- Comment #4 from Nicolas Chauvet <kwizart(a)gmail.com> 2011-07-14 16:30:15 ---
(In reply to comment #3)
I, for one, would welcome a ffmpeg-lite, but getting the
implementation right
may well be hard.
Specially with the fork between ffmpeg/libav and other branch
instabilities.
If that ffmpeg-lite would be worked on, that will be on the perspective to be
usable without expecting to recover the missing patented codecs support with an
complement package from RPMFusion. From that time such ffmpeg-lite shoudn't
crash on missing codecs, nor Miro.
IIRC debian only remove the support of the encoding capability of patented
codec, the playback isn't affected, so that would be another level of
difficulty.
Actually, I'm not sure anyone ever tried to work on the topic.
(I don't plan to do so, as I'm not that concerned by the patent problem)
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:49 p.m.
New subject: [Bug 1845] Review request: miro - Internet TV Player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1845
--- Comment #5 from Michel Alexandre Salim <michel+rpmf(a)sylvestre.me> 2011-07-14
16:49:02 ---
(In reply to comment #4)
(In reply to comment #3)
> I, for one, would welcome a ffmpeg-lite, but getting the implementation right
> may well be hard.
Specially with the fork between ffmpeg/libav and other branch instabilities.
If that ffmpeg-lite would be worked on, that will be on the perspective to be
usable without expecting to recover the missing patented codecs support with an
complement package from RPMFusion. From that time such ffmpeg-lite shoudn't
crash on missing codecs, nor Miro.
IIRC debian only remove the support of the encoding capability of patented
codec, the playback isn't affected, so that would be another level of
difficulty.
I've not looked at it closely, but you're probably right. For Fedora
we'd need
to strip playback as well, and also probably strip the source tarball of the
infringing code (ouch).
Miro upstream is considering making a wrapper that acts like ffmpeg but calls
gstreamer behind the scenes, but hasn't started yet and estimated it won't be
done for a few months -- should we review and get this into RPM Fusion, then,
for now?
The Fedora package will still be maintained at version 3.5.x, at least as long
as Fedora 15 is supported. So if there's a solution that allows Miro to be
built without linking to RPM Fusion packages, we can easily resume maintaining
it there. I will probably block it from Rawhide if miro 4.x is going to be in
RPM fusion, though.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:23 p.m.
New subject: [Bug 1845] Review request: miro - Internet TV Player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1845
Richard <hobbes1069(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hobbes1069(a)gmail.com
--- Comment #6 from Richard <hobbes1069(a)gmail.com> 2011-07-28 20:23:12 ---
Ok, I'm seeing if I can help out here. I tried building the package in mock but
the test was failing...
The first time it was sue to gnome-python-gconf not being installed so I added
it to the BuildRequire's, now I'm getting the following and don't have much
more time today to troubleshoot. Here's the build.log snippet:
"""
Compile successful. Running....
using ./miro.real
Gconf error.
Failed to contact configuration server; some possible causes are that you need
to enable TCP/IP networking for ORBit, or you have stale NFS locks due to a
system crash. See http://projects.gnome.org/gconf/ for information. (Details -
1: Failed to get connection to session: Error spawning command line
`dbus-launch --autolaunch=a81623df8a244e03af73734a77e34b91 --binary-syntax
--close-stderr': Failed to execute child process "dbus-launch" (Permission
denied))
kill: usage: kill [-s sigspec | -n signum | -sigspec] pid | jobspec ... or kill
-l [sigspec]
error: Bad exit status from /var/tmp/rpm-tmp.ZKH5xK (%check)
RPM build errors:
Bad exit status from /var/tmp/rpm-tmp.ZKH5xK (%check)
Child returncode was: 1
EXCEPTION: Command failed. See logs for output.
"""
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:51 p.m.
New subject: [Bug 1845] Review request: miro - Internet TV Player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1845
--- Comment #7 from Richard <hobbes1069(a)gmail.com> 2011-07-28 20:51:51 ---
Ok, I've added additional build requirements after each error until I got here:
Compile successful. Running....
using ./miro.real
Xlib: extension "RANDR" missing on display ":99.0".
.................python:
/builddir/build/BUILD/Python-2.7/Modules/gcmodule.c:326: visit_decref:
Assertion `gc->gc.gc_refs != 0' failed.
dist//usr/bin/miro: line 66: 10389 Aborted (core dumped)
miro.real "$@"
kill: usage: kill [-s sigspec | -n signum | -sigspec] pid | jobspec ... or kill
-l [sigspec]
error: Bad exit status from /var/tmp/rpm-tmp.riOQsr (%check)
Bad exit status from /var/tmp/rpm-tmp.riOQsr (%check)
RPM build errors:
Child returncode was: 1
EXCEPTION: Command failed. See logs for output.
Now I'm stuck...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:55 p.m.
New subject: [Bug 1845] Review request: miro - Internet TV Player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1845
--- Comment #8 from Richard <hobbes1069(a)gmail.com> 2011-07-28 20:55:03 ---
Forgot, here's the updated spec for what I've done so far:
http://hobbes1069.fedorapeople.org/miro.spec
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:30 p.m.
New subject: [Bug 1845] Review request: miro - Internet TV Player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1845
--- Comment #9 from Michel Alexandre Salim <michel+rpmf(a)sylvestre.me> 2011-07-29
00:30:25 ---
(In reply to comment #8)
Forgot, here's the updated spec for what I've done so far:
http://hobbes1069.fedorapeople.org/miro.spec
Hi Richard,
Thanks for looking into this! When Miro was in Fedora I could easily use Koji's
scratch build facility to test for build dependency completeness, but I guess
that option is gone now (sigh..)
I'll set up mock and try and get things working. Could you just disable the
%check section for now and see if things work as expected? One of the test
imposes a timeout of 6 seconds too (up from 4 seconds in the original 4.0.2
release) so I might just disable that test -- build servers can be slower if
they're under heavy load, which was the reason for that post-4.0.2 relaxation
in timing requirement in the first place
I'll try and get an updated spec, with complete BRs for mock building and
updated for 4.0.2.1, sometime tomorrow.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
12:30 a.m.
New subject: [Bug 1845] Review request: miro - Internet TV Player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1845
--- Comment #10 from Richard <hobbes1069(a)gmail.com> 2011-07-29 02:30:25 ---
Well in this case the test may have been working :) At least insofar as letting
us know we have a problem :)
I skipped %check and got a "clean" build, however, after trying to run it from
the command line I got this:
python: /builddir/build/BUILD/Python-2.7/Modules/gcmodule.c:326: visit_decref:
Assertion `gc->gc.gc_refs != 0' failed.
/usr/bin/miro: line 66: 30241 Aborted (core dumped) miro.real
"$@"
which is the same error as we were getting in %check...
Richard
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:30 p.m.
New subject: [Bug 1845] Review request: miro - Internet TV Player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1845
--- Comment #11 from Michel Alexandre Salim <michel+rpmf(a)sylvestre.me> 2011-07-31
20:30:54 ---
Added the missing build requirements (and some runtime ones) and tested them
with mock
Spec: http://salimma.fedorapeople.org/specs/media/miro.spec
SRPM: http://salimma.fedorapeople.org/specs/media/miro-4.0.2.1-1.fc15.src.rpm
- Update to 4.0.2.1
- Fix permissions of installed executables and .so modules
- Add missing build and runtime dependencies
Richard, your build environment seems rather strange (e.g. the Python-2.7
PYTHONPATH). Could you try testing the build under the following:
as root or with sudo:
yum install mock-rpmfusion-free
usermod -a -G mock your-user-name
setenforce 0
(the last line is necessary as there seems to be a bug running xvfb-run with
SELinux enabled)
as your normal user:
$ mock -r fedora-15-i386-rpmfusion_free --rebuild
/path/to/miro-4.0.2.1-1.fc15.src.rpm
If you don't use mock, at least make sure you don't have a ~/.pydistutils.cfg
or another such file that's modifying the Python environment.
The rpmlint results for the new SRPM:
miro.src: W: spelling-error %description -l en_US podcasts -> podcast, pod
casts, pod-casts
miro.src: W: spelling-error %description -l en_US fullscreen -> full screen,
full-screen, firescreen
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
and for the mock-generated binaries:
$ rpmlint /var/lib/mock/fedora-15-x86_64/result/miro*.rpm
miro.src: W: spelling-error %description -l en_US podcasts -> podcast, pod
casts, pod-casts
miro.src: W: spelling-error %description -l en_US fullscreen -> full screen,
full-screen, firescreen
miro.x86_64: W: spelling-error %description -l en_US podcasts -> podcast, pod
casts, pod-casts
miro.x86_64: W: spelling-error %description -l en_US fullscreen -> full screen,
full-screen, firescreen
miro.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/miro/plat/xlibhelper.so
xlibhelper.so()(64bit)
miro.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/miro/ngrams.so ngrams.so()(64bit)
miro.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/miro/frontends/widgets/gtk/webkitgtkhacks.so
webkitgtkhacks.so()(64bit)
miro.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/miro/infolist.so infolist.so()(64bit)
miro.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/miro/frontends/widgets/gtk/pygtkhacks.so
pygtkhacks.so()(64bit)
miro.x86_64: W: no-manual-page-for-binary miro-segmenter
3 packages and 0 specfiles checked; 0 errors, 10 warnings.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:20 p.m.
New subject: [Bug 1845] Review request: miro - Internet TV Player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1845
--- Comment #12 from Richard <hobbes1069(a)gmail.com> 2011-07-31 21:20:53 ---
(In reply to comment #11)
Richard, your build environment seems rather strange (e.g. the
Python-2.7
PYTHONPATH). Could you try testing the build under the following:
I'll take a look but I am building under mock... I use a separate build user
because I often troubleshoot/experiment with straight rpmbuild and don't want a
bad scriptlet to take out my normal user.
as root or with sudo:
yum install mock-rpmfusion-free
usermod -a -G mock your-user-name
setenforce 0
I've already done all that (except the last one, I'm running permissive due to
other issues).
as your normal user:
$ mock -r fedora-15-i386-rpmfusion_free --rebuild
/path/to/miro-4.0.2.1-1.fc15.src.rpm
I'm assuming this is the command you run? I'm still on F14 x86_64 and --rebuild
is assumed so I usually use something like:
mock -r fedora-14-x86_64-rpmfusion_free --resultdir=/home/build
./miro....src.rpm
Richard
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:44 p.m.
New subject: [Bug 1845] Review request: miro - Internet TV Player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1845
--- Comment #13 from Richard <hobbes1069(a)gmail.com> 2011-07-31 21:44:01 ---
Looking at the build log for the F15/i686 build and although it "completes" it
looks like a lot of the tests fail and I see errors around trying to import
pygst, looks like "gstreamer-python" needs to be added, but it looks like
it's
already in the spec file... weird.
I still have the same error on F14/x86_64...
Richard
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:12 p.m.
New subject: [Bug 1845] Review request: miro - Internet TV Player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1845
--- Comment #14 from Michel Alexandre Salim <michel+rpmf(a)sylvestre.me> 2011-07-31
22:12:21 ---
Hi Richard,
Spec: http://salimma.fedorapeople.org/specs/media/miro.spec
SRPM: http://salimma.fedorapeople.org/specs/media/miro-4.0.2.1-2.fc15.src.rpm
- Fix screensaver inhibition exception when enabling full-screen mode
I'm using fedora-15-x86_64-rpmfusion_free; let me try
fedora-14-x86_64-rpmfusion_free and fedora-15-i386 and get back to you
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:27 p.m.
New subject: [Bug 1845] Review request: miro - Internet TV Player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1845
--- Comment #15 from Michel Alexandre Salim <michel+rpmf(a)sylvestre.me> 2011-07-31
22:27:46 ---
Aha, yes, gstreamer-python should be a BuildRequires: as well as a Requires: --
adding it currently causes an exception to be raised, let me fix that.
Will try and debug the F-14 build problem after the F-15 tests all pass. They
should, since they pass just fine on my computer outside of mock, so it must be
just some missing BRs.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:57 p.m.
New subject: [Bug 1845] Review request: miro - Internet TV Player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1845
--- Comment #16 from Michel Alexandre Salim <michel+rpmf(a)sylvestre.me> 2011-07-31
23:57:04 ---
Hi Richard,
Spec: http://salimma.fedorapeople.org/specs/media/miro.spec
SRPM: http://salimma.fedorapeople.org/specs/media/miro-4.0.2.1-3.fc15.src.rpm
- Add missing BR for Gstreamer tests
I fear that Miro simply won't work with Fedora 14's python -- there have been
issues with garbage collection in the past, on various distributions; normally
this is attributable to overly-aggressive compiler optimizations.
Do you have a Fedora 15 machine you can test this on? All the tests now run
(I've verified this by running 'mock --shell', and then running the tests
manually from inside the build directory).
I've tried disabling the tests, but the resulting binary RPM triggers the same
GC problem at normal runtime on my F-14 x86_64 machine. So until this problem
is figured out (perhaps requiring a F-14 python update) I intend to build this
package only for F-15 and above.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:17 p.m.
New subject: [Bug 1845] Review request: miro - Internet TV Player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1845
--- Comment #17 from Richard <hobbes1069(a)gmail.com> 2011-08-01 00:17:43 ---
Yes, this definitely looks like a problem with the python version in F14. I'm
not sure what's going on as F15/16 already has Python 2.7.1 and build for 2.7.2
in koji but F14 seems to be stuck at 2.7.0. It seems strange not to upgrade to
a bugfix release.
I tried building 2.7.1 from F15 for F14 but there was an error I'm not sure how
to fix so that might have something to do with it.
I just got done upgrading the wife's laptop to F15. Actually I was done with
that this morning, it took until now to restore 27GB of backup data onto it
over wireless. Mental note, don't restore over wireless :)
Richard
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
11:16 p.m.
New subject: [Bug 1845] Review request: miro - Internet TV Player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1845
--- Comment #18 from Michel Alexandre Salim <michel+rpmf(a)sylvestre.me> 2011-08-01
01:16:32 ---
Garbage collection failure reported to Miro developers; hopefully they can help
trace its cause:
http://bugzilla.pculture.org/show_bug.cgi?id=18019
If it's indeed python 2.7.0 that's the cause then... hopefully the relevant
maintainers can be persuaded to issue an update. If it requires rebuilding the
entire stack, I fear they would say no.
I'll try rebuilding F-15's python for F-14 and see if I can build Miro against
it, meanwhile, could you test on F-15? If anything, it'd be nice to test the
patch I'm submitting upstream (present in my SRPM since -2.fc15) to work around
GNOME 3's screensaver not currently having an Inhibit method, and DBus throwing
an exception when an inhibit message is sent.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
11:28 p.m.
New subject: [Bug 1845] Review request: miro - Internet TV Player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1845
--- Comment #19 from Michel Alexandre Salim <michel+rpmf(a)sylvestre.me> 2011-08-01
01:28:37 ---
Looks like it's hairier than I thought -- I ran into the same problem:
http://koji.fedoraproject.org/koji/getfile?taskID=3242274&name=build.log
Let's skip F-14 for now as far as this review is concerned; I'll try and see if
Miro upstream and Fedora Python developers can develop a fix (though given that
F-14 has only less than 4 months of support left)
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:59 a.m.
New subject: [Bug 1845] Review request: miro - Internet TV Player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1845
--- Comment #20 from Richard <hobbes1069(a)gmail.com> 2011-08-01 03:59:38 ---
Seems to work, but doesn't find flash, however, I'm using the 32bit flash on
64bit fedora. I've got nspluginwrapper working for Firefox and Chrome but miro
might not know where to look.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:18 a.m.
New subject: [Bug 1845] Review request: miro - Internet TV Player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1845
--- Comment #21 from Richard <hobbes1069(a)gmail.com> 2011-08-01 04:18:30 ---
Ok, looks like it's finding flash, it just doesn't like the wrapped version:
*** NSPlugin Wrapper ***
WARNING:(../src/npw-wrapper.c:3499):invoke_NP_Initialize: assertion failed:
(rpc_method_invoke_possible(g_rpc_connection))
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
11:48 a.m.
New subject: [Bug 1845] Review request: miro - Internet TV Player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1845
leigh scott <leigh123linux(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |leigh123linux@fedoraproject.
| |org
--- Comment #22 from leigh scott <leigh123linux(a)fedoraproject.org> 2011-08-01
13:48:40 ---
(In reply to comment #16)
Hi Richard,
normally
this is attributable to overly-aggressive compiler optimizations.
You also need to fix the build flags ( does it need to duplicate the flags 3
times?).
gcc -pthread -c -fno-strict-aliasing -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2
-fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i686
-mtune=atom -fasynchronous-unwind-tables -D_GNU_SOURCE -fPIC -fwrapv -O2 -g
-pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m32 -march=i686 -mtune=atom
-fasynchronous-unwind-tables -D_GNU_SOURCE -fPIC -fwrapv -O2 -g -pipe -Wall
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m32 -march=i686 -mtune=atom
-fasynchronous-unwind-tables -D_GNU_SOURCE -fPIC -fwrapv -I. -IInclude
-I/builddir/build/BUILD/Python-2.7.1/Include -I/usr/lib/libffi-3.0.9/include
-fPIC -DPy_BUILD_CORE -o Modules/python.o
/builddir/build/BUILD/Python-2.7.1/Modules/python.c
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:13 p.m.
New subject: [Bug 1845] Review request: miro - Internet TV Player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1845
--- Comment #23 from Michel Alexandre Salim <michel+rpmf(a)sylvestre.me> 2011-08-01
20:13:16 ---
So the reason miro wasn't triggering the assertion on F-15+ is this change:
(per Python maintainer dmalcolm)
http://pkgs.fedoraproject.org/gitweb/?p=python.git;a=commitdiff;h=970523c...
F-14 python is compiled with -DNDEBUG, F-15 is not. So the Miro C/Pyrex code
still has a reference counting bug somewhere but it's just not being checked on
F-15 and above.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
5:13 p.m.
New subject: [Bug 1845] Review request: miro - Internet TV Player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1845
--- Comment #24 from Michel Alexandre Salim <michel+rpmf(a)sylvestre.me> 2011-08-02
19:13:30 ---
(In reply to comment #22)
You also need to fix the build flags ( does it need to duplicate the
flags 3
times?).
It doesn't, no. Looks like an upstream bug, but I'll try and track it
down.
Meanwhile, would one of you like to start reviewing this? Thanks
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
5:47 p.m.
New subject: [Bug 1845] Review request: miro - Internet TV Player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1845
--- Comment #25 from Richard <hobbes1069(a)gmail.com> 2011-08-02 19:47:02 ---
(In reply to comment #24)
(In reply to comment #22)
> You also need to fix the build flags ( does it need to duplicate the flags 3
> times?).
>
It doesn't, no. Looks like an upstream bug, but I'll try and track it down.
Remember, that was an excerpt from a python build, not miro...
As far as the review goes, I can start, but I'd really like to see at least a
patch for the reference counting bug...
Richard
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:39 p.m.
New subject: [Bug 1845] Review request: miro - Internet TV Player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1845
--- Comment #26 from Michel Alexandre Salim <michel+rpmf(a)sylvestre.me> 2011-08-02
20:39:20 ---
(In reply to comment #25)
(In reply to comment #24)
> (In reply to comment #22)
> > You also need to fix the build flags ( does it need to duplicate the flags 3
> > times?).
> >
> It doesn't, no. Looks like an upstream bug, but I'll try and track it down.
Remember, that was an excerpt from a python build, not miro...
That's due to the -DNDEBUG fix I mentioned; while not clobbering the built-in
settings, the side effect is that some compiler settings are duplicated.
The same thing is affecting Miro, actually; when Pyrex is used, it picks up the
CFLAGS *and* the compiler flags used to compile Python. But it's harmless,
anyway.
Looking into the CFLAGS have made me realize, though, that miro-segmenter was
being built without CFLAGS (because setup.py invokes the compiler manually,
since miro-segmenter is not a module, and didn't pass the proper parameters).
I've patched it in -4, and submitted it to upstream:
http://bugzilla.pculture.org/show_bug.cgi?id=18027
As far as the review goes, I can start, but I'd really like to
see at least a
patch for the reference counting bug...
Fair enough. And good thing you did test on F-14! That *would* take some time,
though.
Spec: http://salimma.fedorapeople.org/specs/media/miro.spec
SRPM: http://salimma.fedorapeople.org/specs/media/miro-4.0.2.1-4.fc15.src.rpm
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:08 p.m.
New subject: [Bug 1845] Review request: miro - Internet TV Player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1845
--- Comment #27 from Richard <hobbes1069(a)gmail.com> 2011-09-29 20:08:31 ---
Ping!
Anything to report or is this review dead?
Thanks,
Richard
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
12:11 p.m.
New subject: [Bug 1845] Review request: miro - Internet TV Player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1845
--- Comment #28 from Michel Alexandre Salim <michel+rpmf(a)sylvestre.me> 2011-09-30
14:11:57 ---
Review is not dead, however, I've not heard back from upstream, sadly. Not even
my trivial and obviously correct patches are getting applied. I did provide a
F-14 QEMU virtual machine to one of the Miro developers who promised to forward
it to someone who can work on the bug, but have not heard back.
Since Miro works fine in practice on F-15 and above, and F-14 will soon be
EOLed, would you be willing to just not make the GC problem a blocker? It's not
as if Miro leaks memory as badly as Firefox pre-7 *ducks*
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
12:57 p.m.
New subject: [Bug 1845] Review request: miro - Internet TV Player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1845
Richard <hobbes1069(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--- Comment #29 from Richard <hobbes1069(a)gmail.com> 2011-09-30 14:57:28 ---
(In reply to comment #28)
Review is not dead, however, I've not heard back from upstream,
sadly. Not even
my trivial and obviously correct patches are getting applied. I did provide a
F-14 QEMU virtual machine to one of the Miro developers who promised to forward
it to someone who can work on the bug, but have not heard back.
Strange, since the problem appears to be a reference counting bug, I would
expect it to be a problem on all platforms. Is it just that the tools on Linux
are catching this problem and Windows is not?
Since Miro works fine in practice on F-15 and above, and F-14 will
soon be
EOLed, would you be willing to just not make the GC problem a blocker? It's not
as if Miro leaks memory as badly as Firefox pre-7 *ducks*
It's not the end of the world. If this was a daemon or something that would
likely stay running all the time I would be more concerned. I wouldn't mind
some of the other RPM Fusion maintainers giving their $.02, but I don't think
it's a blocker. It's not like there's not other approved packages with bugs
on
RPM Fusion :)
We should track the problem though, even if upstream isn't being super
responsive. After the CVS request and miro gets added as a component to
bugzilla let's put in a bug for the problem.
Hopefully I'll find some time to do the full review soon.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
4:15 p.m.
New subject: [Bug 1845] Review request: miro - Internet TV Player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1845
Richard <hobbes1069(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|rpmfusion-package- |hobbes1069(a)gmail.com
|review(a)rpmfusion.org |
Status|ASSIGNED |NEW
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
4:23 p.m.
New subject: [Bug 1845] Review request: miro - Internet TV Player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1845
Richard <hobbes1069(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--- Comment #30 from Richard <hobbes1069(a)gmail.com> 2011-10-04 18:23:34 ---
Ok, last spec review before doing a full review:
1. As far as obsoleting the Fedora version of miro, the version and release
should probably be set statically at the "cutover" point instead of a variable,
which I think will cause it to obsolete itself on the next RPM Fusion release.
2. I don't think you need the "-n miro-%{version}" in %setup since it
defaults
to "%{name}-%{version}".
3. Don't need "rm -rf %{buildroot} in %install unless your planning on
supporting EL5.
4. Don't need "%defattr(..." in %files unless building for EL5.
5. I don't think we need the "%if 0%{?fedora} >= 9" since there's no
expectation of this ever being build for Fedora 9.
Don't worry about posting a new package just yet. I'll go ahead and make the
changes on my end and make sure I didn't break anything.
Richard
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
8:04 p.m.
New subject: [Bug 1845] Review request: miro - Internet TV Player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1845
--- Comment #31 from Richard <hobbes1069(a)gmail.com> 2011-10-04 22:04:51 ---
6. We need to clean up private shared object provides:
$ rpmlint miro
miro.x86_64: W: spelling-error %description -l en_US podcasts -> podcast, pod
casts, pod-casts
miro.x86_64: W: spelling-error %description -l en_US fullscreen -> full screen,
full-screen, firescreen
miro.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/miro/plat/xlibhelper.so
xlibhelper.so()(64bit)
miro.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/miro/ngrams.so ngrams.so()(64bit)
miro.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/miro/frontends/widgets/gtk/webkitgtkhacks.so
webkitgtkhacks.so()(64bit)
miro.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/miro/infolist.so infolist.so()(64bit)
miro.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/miro/frontends/widgets/gtk/pygtkhacks.so
pygtkhacks.so()(64bit)
miro.x86_64: W: no-manual-page-for-binary miro-segmenter
1 packages and 0 specfiles checked; 0 errors, 8 warnings.
See:
http://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering#...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
8:37 p.m.
New subject: [Bug 1845] Review request: miro - Internet TV Player
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1845
--- Comment #32 from Richard <hobbes1069(a)gmail.com> 2011-10-04 22:37:00 ---
+: OK
-: must be fixed
=: should be fixed (at your discretion)
?: Question or clairification needed
N: not applicable
MUST:
[+] rpmlint output: shown in comment:
[+] follows package naming guidelines
[+] spec file base name matches package name
[+] package meets the packaging guidelines
[+] package uses a Fedora approved license: GPLv2+ with exceptions.
[+] license field matches the actual license.
[+] license file is included in %doc: license.txt
[+] spec file is in American English
[+] spec file is legible
[+] sources match upstream: md5sum matches (69b1195296651c006f75f28d5b010365)
[+] package builds on at least one primary arch: Tested F15 x86_64
[N] appropriate use of ExcludeArch
[+] all build requirements in BuildRequires
[N] spec file handles locales properly
[N] ldconfig in %post and %postun
[+] no bundled copies of system libraries
[N] no relocatable packages
[+] package owns all directories that it creates
[+] no files listed twice in %files
[+] proper permissions on files
[+] consistent use of macros
[+] code or permissible content
[N] large documentation in -doc
[+] no runtime dependencies in %doc
[N] header files in -devel
[N] static libraries in -static
[N] .so in -devel
[N] -devel requires main package
[+] package contains no libtool archives
[+] package contains a desktop file, uses desktop-file-install/validate
[+] package does not own files/dirs owned by other packages
[+] all filenames in UTF-8
SHOULD:
[+] query upstream for license text
[N] description and summary contains available translations
[+] package builds in mock
[+] package builds on all supported arches
[+] package functions as described: Tested basic usage.
[+] sane scriptlets
[N] subpackages require the main package
[N] placement of pkgconfig files
[N] file dependencies versus package dependencies
[-] package contains man pages for binaries/scripts
Ok, to sum up, everything looks good as long as:
- the "private shared object provides" are taken care of
- The license field is updated to something like, "GPLv2+, except lib/ which
includes MIT and BSD licensed files."
If you use the licensecheck tool it will let you know that some of the files in
the lib/ directory are not GPLv2+ licensed.
Other non-critical problems:
- /usr/bin/miro-segmenter does not have a man page or any documentation that I
can find.
- It looks like miro 4.0.3 has been releaed. Might as well update it now.
I had to update the spec file to get things building so I can give you mine if
you want or you can update it yourself. After these are cleared up I think
you'll be good to go.
Richard
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
4587
days inactive
4669
days old
rpmfusion-developers@lists.rpmfusion.org
33 comments
1 participants
participants (1)
-
RPM Fusion Bugzilla