http://bugzilla.rpmfusion.org/show_bug.cgi?id=303 Manuel Wolfshant <wolfy(a)fedoraproject.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wolfy(a)fedoraproject.org --- Comment #1 from Manuel Wolfshant <wolfy(a)fedoraproject.org&gt; 2009-01-05 11:08:12 --- Please be as kind as to NOT ignore the warning about the line too long. Proper formatting helps in displaying properly in package managers. Especially as you can easily fix that (that is by using 2 commands in vim). -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=303 --- Comment #3 from Juan Moreno <uncholowapo(a)gmail.com&gt; 2009-01-05 11:26:23 --- (In reply to comment #1) Ok here is the new updated spec file: http://rapidshare.com/files/179967871/Mupen64Plus_updated_.spec And this is what rpmlint shows with it: [Juan@shadowtracer Desktop]$ rpmlint Mupen64Plus.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. [Juan@shadowtracer Desktop]$ -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=303 --- Comment #5 from Andrea Musuruane <musuruan(a)gmail.com&gt; 2009-01-05 12:15:07 --- (In reply to comment #4) If that is the case, you are not requiring the following dependencies: BuildRequires: desktop-file-utils Requires: hicolor-icon-theme Moreover you are not using desktop-file-validate to validate file installed by makefile: https://fedoraproject.org/wiki/TomCallaway/DesktopFileVendor You will see another problem when you'll use desktop-file-validate. This is wrong in %files: %{_datadir}/* In this way the package will own a directory that belongs to another package: /usr/share/applications This is wrong in %install: make install PREFIX=%{buildroot}/usr use macros: make install PREFIX=%{buildroot}/%{_prefix} This is wrong in %files: /usr/man/man1/mupen64plus.1.gz The path you are providing is wrong. Man entries are not installed in /usr/man but in /usr/share/man. Moreover you must use macros, such as: %{_mandir}/man1/mupen64plus.1* Therefore you will need to set some of the following variables when calling the makefile: PREFIX=path == install/uninstall prefix (default: /usr/local/) SHAREDIR=path == path to install shared data (default: PREFIX/share/mupen64 plus/) BINDIR=path == path to install mupen64plus binary (default: PREFIX/bin/) LIBDIR=path == path to install plugin libs (default: SHAREDIR/plugins/) MANDIR=path == path to install manual files (default: PREFIX/man/man1/) Optsflags are not used when compiling. Rpmlint is not silent: $ rpmlint /home/andrea/rpmbuild/RPMS/x86_64/Mupen64Plus-1.5-1.fc10.x86_64.rpm Mupen64Plus.x86_64: W: devel-file-in-non-devel-package /usr/share/mupen64plus/doc/Audio_1.1.h Mupen64Plus.x86_64: W: devel-file-in-non-devel-package /usr/share/mupen64plus/doc/Rsp_1.1.h Mupen64Plus.x86_64: W: devel-file-in-non-devel-package /usr/share/mupen64plus/doc/Audio_1.2.h Mupen64Plus.x86_64: W: devel-file-in-non-devel-package /usr/share/mupen64plus/doc/Input_1.1.h Mupen64Plus.x86_64: W: devel-file-in-non-devel-package /usr/share/mupen64plus/doc/Graphics_1.3.h Mupen64Plus.x86_64: E: explicit-lib-dependency libpng Mupen64Plus.x86_64: E: explicit-lib-dependency zlib Mupen64Plus.x86_64: W: incoherent-version-in-changelog 1.5 ['1.5-1.fc10', '1.5-1'] Mupen64Plus.x86_64: W: executable-stack /usr/bin/mupen64plus Mupen64Plus.x86_64: E: arch-dependent-file-in-usr-share /usr/share/mupen64plus/plugins/blight_input.so Mupen64Plus.x86_64: E: arch-dependent-file-in-usr-share /usr/share/mupen64plus/plugins/dummyaudio.so Mupen64Plus.x86_64: E: arch-dependent-file-in-usr-share /usr/share/mupen64plus/plugins/mupen64_input.so Mupen64Plus.x86_64: E: arch-dependent-file-in-usr-share /usr/share/mupen64plus/plugins/ricevideo.so Mupen64Plus.x86_64: E: arch-dependent-file-in-usr-share /usr/share/mupen64plus/plugins/jttl_audio.so Mupen64Plus.x86_64: E: arch-dependent-file-in-usr-share /usr/share/mupen64plus/plugins/glide64.so Mupen64Plus.x86_64: E: arch-dependent-file-in-usr-share /usr/share/mupen64plus/plugins/mupen64_hle_rsp_azimer.so Mupen64Plus.x86_64: E: arch-dependent-file-in-usr-share /usr/share/mupen64plus/plugins/glN64.so Mupen64Plus.x86_64: E: arch-dependent-file-in-usr-share /usr/share/mupen64plus/plugins/dummyvideo.so Mupen64Plus.x86_64: W: non-standard-dir-in-usr man 1 packages and 0 specfiles checked; 11 errors, 8 warnings. $ rpmlint /home/andrea/rpmbuild/RPMS/x86_64/Mupen64Plus-debuginfo-1.5-1.fc10.x86_64.rpm Mupen64Plus-debuginfo.x86_64: E: empty-debuginfo-package Use rpmlint -i to have a description of the actions needed. Can you host your files somewhere else than rapidshare? It is very frustrating to use. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=303 --- Comment #7 from Andrea Musuruane <musuruan(a)gmail.com&gt; 2009-01-05 12:40:37 --- (In reply to comment #6) Because you already have a google account, you can use http://pages.google.com. Please note the "upload" link on the right. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=303 --- Comment #9 from Juan Moreno <uncholowapo(a)gmail.com&gt; 2009-01-05 15:23:37 --- Ok, for the man page I didn't set that. In the install script that is called by the makefile, it is set there. I have no idea how to modify that in the spec file. I have also found that when I call "make install", it just points to the install.sh script only and nothing else. I'll use that instead also because in the readme it says that I can list the variables for the install directories. "Make install" will only use PREFIX. Should I use the default /usr/local or /usr for prefix? I have read that it is better to install in the /usr directory but I have also read that some programs work better from their defaults. And for the optflags I am guessing I am supposed to split out a devel package? I have very little experience with devel packages. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=303 --- Comment #11 from Andrea Musuruane <musuruan(a)gmail.com&gt; 2009-01-06 11:04:26 --- (In reply to comment #9) First, the default prefix you must use is the value of the macro %{_prefix}. Therefore always use this macro. For the record, the value of this macro is /usr. Then, in the README file, I found that you can use the following options when calling make: PREFIX=path == install/uninstall prefix (default: /usr/local/) SHAREDIR=path == path to install shared data (default: PREFIX/share/mupen64 plus/) BINDIR=path == path to install mupen64plus binary (default: PREFIX/bin/) LIBDIR=path == path to install plugin libs (default: SHAREDIR/plugins/) MANDIR=path == path to install manual files (default: PREFIX/man/man1/) Therefore, use something like: make install PREFIX=%{buildroot}%{_prefix} MANDIR=%{buildroot}%{_mandir} LIBDIR=... I hope this answer your question. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=303 --- Comment #13 from Andrea Musuruane <musuruan(a)gmail.com&gt; 2009-02-17 10:22:40 --- Ping. Any update? -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=303 --- Comment #15 from Andrea Musuruane <musuruan(a)gmail.com&gt; 2009-02-17 12:14:24 --- (In reply to comment #14) Update this package (and any other package you have under review) with the suggested changes. "Unofficially" review other packages so that possible sponsors can evaluate your knowledge. Other info here: https://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=303 --- Comment #17 from Andrea Musuruane <musuruan(a)gmail.com&gt; 2009-02-18 14:07:16 --- (In reply to comment #16) You should not post SPEC file in a bugzilla entry but you must provide two link one to the spec file and one to the src.rpm. These files must be hosted somewhere on the net. I cannot believe you cannot find a free hosting server. * You also need to validate with rpmlint all *.rpm files created with the build process. After that you have to install all *.rpm files created with the build process and use rpmlint against the installed files. For example: rpmlint Mupen64Plus * You must report this problem upstream. Then, while waiting for upstream to fix it, you can use grep to fix the Icon entry in the desktop file. I suggest you not to use an absolute path. You also have to install the icons in the appropriate directories. http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s05.html * It seems strange to me that rpmlint does not complain about the missing release in the changelog entries: * Sun Jan 4 2009 Juan Moreno <uncholowapo(a)gmail.com&gt; 1.5 - New release after half a year. Read changelog for details * Moreover, you must write the changes in the changelog entries. The above one is not acceptable. * Categories in the desktop file must be changed from Categories=Qt;Game; to Categories=Game;Emulator; use --add-category and --remove-category options in desktop-file-install. For more info, read its man page. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=303 --- Comment #19 from Andrea Musuruane <musuruan(a)gmail.com&gt; 2009-08-05 14:48:21 --- Ping ping. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=303 Andrea Musuruane <musuruan(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |musuruan(a)gmail.com Status|NEW |RESOLVED Resolution| |WONTFIX --- Comment #21 from Andrea Musuruane <musuruan(a)gmail.com&gt; 2009-11-30 10:54:32 --- Closing this review request because submitter is MIA. There is another review request by a sponsored Fedora contributor (and former Dribble maintainer) at #908. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.