https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532 Dominic Robinson <development-K9RvgheM1OmXW9pm(a)dcrdev.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2, 30 Referenced Bugs: https://bugzilla.rpmfusion.org/show_bug.cgi?id=2 [Bug 2] Tracker: New packages awaiting review https://bugzilla.rpmfusion.org/show_bug.cgi?id=30 [Bug 30] Tracker : Sponsorship Request -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532 --- Comment #2 from leigh scott <leigh123linux(a)gmail.com&gt; --- (In reply to Dominic Robinson from comment #0) You have no errors because your debug package is broken (review failure) due to your cmake command kodi-inputstream.adaptive-debuginfo.x86_64: E: debuginfo-without-sources Once the debug package is fixed you have plenty of errors $ rpmlint /home/leigh/development/rpmbuild/RPMS/x86_64/kodi-inputstream.adaptive-debuginfo-17.1-1.20161215gitcd26d5d.fc26.x86_64.rpm 1 packages and 0 specfiles checked; 224 errors, 246 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532 --- Comment #4 from Dominic Robinson <development-K9RvgheM1OmXW9pm(a)dcrdev.com&gt; --- ^ SPEC: https://raw.githubusercontent.com/dcrdev/rpm-kodi-inputstream.adaptive/ko... Source RPM: https://github.com/dcrdev/rpm-kodi-inputstream.adaptive/releases/download... Debuginfo: https://github.com/dcrdev/rpm-kodi-inputstream.adaptive/releases/download... -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532 --- Comment #6 from Dominic Robinson <development-K9RvgheM1OmXW9pm(a)dcrdev.com&gt; --- Done SPEC: https://raw.githubusercontent.com/dcrdev/rpm-kodi-inputstream-adaptive/ko... Source RPM: https://github.com/dcrdev/rpm-kodi-inputstream-adaptive/releases/download... Debuginfo: https://github.com/dcrdev/rpm-kodi-inputstream-adaptive/releases/download... Thanks -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532 --- Comment #8 from Nicolas Chauvet <kwizart(a)gmail.com&gt; --- (In reply to Dominic Robinson from comment #7) @Dominic, I'm okay to sponsor you if you can find a reviewer for your package. Please consider reviewing other packages until then. Probably the best candidate for the review is Mohamed, (pikachu.2014). -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532 Dominic Robinson <development-K9RvgheM1OmXW9pm(a)dcrdev.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|2, 30 |3 Referenced Bugs: https://bugzilla.rpmfusion.org/show_bug.cgi?id=2 [Bug 2] Tracker: New packages awaiting review https://bugzilla.rpmfusion.org/show_bug.cgi?id=3 [Bug 3] Tracker: Packages under review. https://bugzilla.rpmfusion.org/show_bug.cgi?id=30 [Bug 30] Tracker : Sponsorship Request -- You are receiving this mail because: You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532 --- Comment #11 from Dominic Robinson <development-K9RvgheM1OmXW9pm(a)dcrdev.com&gt; --- Huh I thought it built under arm as well - in any case I've made the changes: https://repo.dcrdev.com/fc25/specfiles/kodi-inputstream-adaptive.spec https://repo.dcrdev.com/fc25/SRPMS/kodi-inputstream-adaptive-17.1-0.1.201... https://repo.dcrdev.com/fc25/x86_64/debug/kodi-inputstream-adaptive-debug... -- You are receiving this mail because: You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532 --- Comment #13 from Mohamed El Morabity <pikachu.2014(a)gmail.com&gt; --- Sorry for the delay, here is a first review. 1) Package version is not 17.1. You should refer to the inputstream.adaptive/addon.xml.in file to get the right version corresponding to the snapshot you're packaging. The snapshot you're packaging corresponds to a 1.0.6 version (see https://github.com/peak3d/inputstream.adaptive/commit/cd26d5d7896e402be18...). You should ask upstream to create release tags to make things easier for you... Even if it quite rare from Kodi addon developers :(. 2) As a result, you should set up a dedicated for the minimum required Kodi version. By the way, since Kodi addon API is stable between major release, requiring kodi >= 17.0 may be enough: %global kodi_version 17.0 [...] BuildRequires: cmake BuildRequires: gcc-c++ BuildRequires: kodi-devel >= %{kodi_version} BuildRequires: kodi-platform-devel >= %{kodi_version} BuildRequires: expat-devel Requires: kodi >= %{kodi_version} 3) If you plan to package more binary Kodi addons and use this .spec as a model, I suggest you to define your package name from the upstream name, and not the reverse (in case some Kodi addons may use dashes as separators). Replace : Name: kodi-inputstream-adaptive [...] %global aname %(n=%{name}; n=${n//-/.}; echo ${n:5}) by %global aname inputstream.adaptive [...] Name: kodi-%(n=%{name}; n=${n//./-}) 4) Binary addons are dlopened at Kodi execution. They're not shared libraries. As a result, you don't need to call ldconfig at post-install. Remove %post/%postun targets. 5) This addon bundled libbento4. If you don't plan to unbundle this third-party library as allowed by Fedora guidelines, you must add a virtual Provided on this library: Provides: bundled(bento4) (unfortunately I'm unable to determine which version of bento4 is bundled). -- You are receiving this mail because: You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532 --- Comment #15 from Dominic Robinson <development-K9RvgheM1OmXW9pm(a)dcrdev.com&gt; --- Ok thanks all for the feedback - I've made some adjustments: https://repo.dcrdev.com/fc25/specfiles/kodi-inputstream-adaptive.spec https://repo.dcrdev.com/fc25/SRPMS/kodi-inputstream-adaptive-1.0.6-0.1.20... https://repo.dcrdev.com/fc25/x86_64/debug/kodi-inputstream-adaptive-debug... https://repo.dcrdev.com/fc25/x86_64/kodi-inputstream-adaptive-1.0.6-0.1.2... @Mohamed - I take your point about the naming convention, but unfortunately rpmbuild complains about recursion when trying to resolve the name directive dynamically. In regards to the bundled bento4 - I'm not certain which version it is either; I did some comparisons between it and the bento4 git repo and was unable come up with anything mainly due to the infrequency in which it is committed to. I have added the virtual provides for now, but the lack of version obviously throws a warning in rpmlint. @Michael I have requested they ship a copy of the gpl upstream. -- You are receiving this mail because: You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532 Nicolas Chauvet <kwizart(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|"Review request: |Review request: |kodi-inputstream.adaptive - |kodi-inputstream-adaptive - |Adaptive file addon for |Adaptive file addon for |Kodi's InputStream |Kodi's InputStream |interface |interface -- You are receiving this mail because: You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532 --- Comment #18 from leigh scott <leigh123linux(a)gmail.com&gt; --- (In reply to Dominic Robinson from comment #17) F26 release is probably a major factor for the delay, reviews tend to be lower priority during this time. -- You are receiving this mail because: You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532 --- Comment #20 from Dominic Robinson <development-K9RvgheM1OmXW9pm(a)dcrdev.com&gt; --- Done - https://repo.dcrdev.com/fc26/specfiles/kodi-inputstream-adaptive.spec https://repo.dcrdev.com/fc26/SRPMS/kodi-inputstream-adaptive-1.0.6-0.1.20... https://repo.dcrdev.com/fc26/x86_64/kodi-inputstream-adaptive-1.0.6-0.1.2... https://repo.dcrdev.com/fc26/x86_64/debug/kodi-inputstream-adaptive-debug... Regarding the git snapshot - upstream keep the version in the xml static across commits, therefore to me I think that would make it difficult to differentiate between package versions. Additionally I'm picking the commit based one what Kodi are shipping as part of Kodiubuntu. -- You are receiving this mail because: You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532 Nicolas Chauvet <kwizart(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(development-K9Rvg | |heM1OmXW9pm(a)dcrdev.com) --- Comment #22 from Nicolas Chauvet <kwizart(a)gmail.com&gt; --- Ping ? -- You are receiving this mail because: You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532 Nicolas Chauvet <kwizart(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #24 from Nicolas Chauvet <kwizart(a)gmail.com&gt; --- (In reply to Dominic Robinson from comment #23) Sorry, I meant a %kodi_version macro. It would be defined in the kodi-devel package ( echo %kodi_version %{version} > %{buildroot}%{rpmmacrodir}/macros.kodi ) Then when plugins would build, they would have: Requires: kodi >= %{kodi_version} Anyway, it seems a minor issue and not particular to this plugins. this can be fixed and coordinated later. Do you plan to fix the name with modified macro ? This looks really scary. -- You are receiving this mail because: You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532 --- Comment #26 from Dominic Robinson <development-K9RvgheM1OmXW9pm(a)dcrdev.com&gt; --- Also bit confused - is this package approved, I note the fedora-review + flag and also the repository having been created here: https://admin.rpmfusion.org/pkgdb/package/free/kodi-inputstream-adaptive/ . Wasn't I suppose to be the one who requests the package, as it stands I'm not the maintainer of that repository? -- You are receiving this mail because: You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532 --- Comment #28 from Nicolas Chauvet <kwizart(a)gmail.com&gt; --- (In reply to Dominic Robinson from comment #26) Yep, seems like this package was mass imported along the other ones from Mohamed. I will transfer the ownership to you once this package got formally approved can you remind your RPM Fusion FAS account name ? -- You are receiving this mail because: You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532 --- Comment #30 from Nicolas Chauvet <kwizart(a)gmail.com&gt; --- okay, so this package is formally APPROVED. I will give the ownership to you. -- You are receiving this mail because: You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532 --- Comment #31 from Dominic Robinson <development-K9RvgheM1OmXW9pm(a)dcrdev.com&gt; --- It doesn't look like the git server has my public key key authorised? Does this take a while? debug1: Host 'pkgs.rpmfusion.org' is known and matches the RSA host key. debug1: Found key in /home/dcrdev/.ssh/known_hosts:1 debug3: send packet: type 21 debug2: set_newkeys: mode 1 debug1: rekey after 4294967296 blocks debug1: SSH2_MSG_NEWKEYS sent debug1: expecting SSH2_MSG_NEWKEYS debug3: receive packet: type 21 debug1: SSH2_MSG_NEWKEYS received debug2: set_newkeys: mode 0 debug1: rekey after 4294967296 blocks debug2: key: /home/dcrdev/.ssh/id_rsa (0x55e5989f52b0), agent debug2: key: /home/dcrdev/.ssh/id_dsa ((nil)) debug2: key: /home/dcrdev/.ssh/id_ecdsa ((nil)) debug2: key: /home/dcrdev/.ssh/id_ed25519 ((nil)) debug3: send packet: type 5 debug3: receive packet: type 6 debug2: service_accept: ssh-userauth debug1: SSH2_MSG_SERVICE_ACCEPT received debug3: send packet: type 50 debug3: receive packet: type 51 debug1: Authentications that can continue: publickey debug3: start over, passed a different list publickey debug3: preferred gssapi-keyex,gssapi-with-mic,publickey,keyboard-interactive,password debug3: authmethod_lookup publickey debug3: remaining preferred: keyboard-interactive,password debug3: authmethod_is_enabled publickey debug1: Next authentication method: publickey debug1: Offering RSA public key: /home/dcrdev/.ssh/id_rsa debug3: send_pubkey_test debug3: send packet: type 50 debug2: we sent a publickey packet, wait for reply debug3: receive packet: type 51 debug1: Authentications that can continue: publickey debug1: Trying private key: /home/dcrdev/.ssh/id_dsa debug3: no such identity: /home/dcrdev/.ssh/id_dsa: No such file or directory debug1: Trying private key: /home/dcrdev/.ssh/id_ecdsa debug3: no such identity: /home/dcrdev/.ssh/id_ecdsa: No such file or directory debug1: Trying private key: /home/dcrdev/.ssh/id_ed25519 debug3: no such identity: /home/dcrdev/.ssh/id_ed25519: No such file or directory debug2: we did not send a packet, disable method debug1: No more authentication methods to try. Permission denied (publickey). -- You are receiving this mail because: You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532 --- Comment #33 from Dominic Robinson <development-K9RvgheM1OmXW9pm(a)dcrdev.com&gt; --- Sadly still not liking it: debug1: Offering RSA public key: /home/dcrdev/.ssh/id_rsa debug3: send_pubkey_test debug3: send packet: type 50 debug2: we sent a publickey packet, wait for reply debug3: receive packet: type 51 debug1: Authentications that can continue: publickey debug1: Trying private key: /home/dcrdev/.ssh/id_dsa debug3: no such identity: /home/dcrdev/.ssh/id_dsa: No such file or directory debug1: Trying private key: /home/dcrdev/.ssh/id_ecdsa debug3: no such identity: /home/dcrdev/.ssh/id_ecdsa: No such file or directory debug1: Trying private key: /home/dcrdev/.ssh/id_ed25519 debug3: no such identity: /home/dcrdev/.ssh/id_ed25519: No such file or directory debug2: we did not send a packet, disable method debug1: No more authentication methods to try. Permission denied (publickey). -- You are receiving this mail because: You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532 --- Comment #35 from Dominic Robinson <development-K9RvgheM1OmXW9pm(a)dcrdev.com&gt; --- Ok thanks - working now. So I've pushed to all branches, requested builds for those branches and those builds have succeeded: http://koji.rpmfusion.org/koji/packageinfo?packageID=508 Is that all I need to do? I note they are not listed here, as suggested by the documentation: http://koji.rpmfusion.org/mash/ -- You are receiving this mail because: You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4532 Nicolas Chauvet <kwizart(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug.