2:25 p.m.
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1786
Summary: Review request: wbar - wbar is a quick launch bar.
Product: Package Reviews
Version: Current
Platform: i386
OS/Version: GNU/Linux
Status: NEW
Severity: normal
Priority: P5
Component: Review Request
AssignedTo: rpmfusion-package-review(a)rpmfusion.org
ReportedBy: sajozsattila(a)yahoo.com
CC: rpmfusion-package-review(a)rpmfusion.org
Estimated Hours: 0.0
I made one Fedora 15 package and I am looking a sponsore.
The packages (src and i386) are downloaded from:
http://www.sajozsattila.co.uk/Files/wbar-2.2.2-1.fc15.i386.rpm
http://www.sajozsattila.co.uk/Files/wbar-2.2.2-1.fc15.src.rpm
%{description}
wbar is a quick launch bar. Its fast, light and cool eye-candy.
Its hacked in c++ trying to keep code as readable as possible
with out sacrificing speed. It works directly on top of X to avoid
going throug a lot of layers.
Initially developed for Fluxbox, then tested on WindowMaker, Xfce,
Gnome, etc.
Since version 1.0 can run on top of desktops such as xfdesktop
or nautilus with the -above-desk switch.
When I tested the package with the rpminv I got the next:
wbar.i386: W: spelling-error %description -l en_US xfdesktop -> desktop
wbar.i386: W: unstripped-binary-or-object /usr/bin/wbar
wbar.i386: W: unstripped-binary-or-object /usr/bin/wbar-config
wbar.i386: W: non-conffile-in-etc /etc/default/wbar/wbar.cfg
wbar.i386: W: devel-file-in-non-devel-package /usr/bin/wbar-config
wbar.i386: W: non-conffile-in-etc /etc/xdg/autostart/wbar.desktop
wbar.src: W: spelling-error %description -l en_US xfdesktop -> desktop
I can ignore the spelling-errors, and the wbar.cfg and wbar.desktop are config
files. But unforunatelly I can't manage the unstripped-binary errors.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:34 p.m.
New subject: [Bug 1786] Review request: wbar - wbar is a quick launch bar.
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1786
--- Comment #1 from Andrea Musuruane <musuruan(a)gmail.com> 2011-06-04 16:34:54 ---
Please always state why this software cannot be included in Fedora.
Moreover, you must also provide a link to the spec file of the package you are
submitting.
If you are seeking a sponsor you must also be set to block the tracker bug:
NEEDSPONSORS (bug #30). Thus, some potential sponsors will look at the
NEEDSPONSORS bug to find packages to review.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:13 p.m.
New subject: [Bug 1786] Review request: wbar - wbar is a quick launch bar.
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1786
--- Comment #2 from Attila Zsolt Sajo <sajozsattila(a)yahoo.com> 2011-06-04 17:13:35
---
The spec file:
http://www.sajozsattila.co.uk/Files/wbar.spec
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:16 p.m.
New subject: [Bug 1786] Review request: wbar - wbar is a quick launch bar.
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1786
Attila Zsolt Sajo <sajozsattila(a)yahoo.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |30
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:48 p.m.
New subject: [Bug 1786] Review request: wbar - wbar is a quick launch bar.
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1786
Attila Zsolt Sajo <sajozsattila(a)yahoo.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|30 |
--- Comment #3 from Attila Zsolt Sajo <sajozsattila(a)yahoo.com> 2011-06-04 17:48:39
---
The spec file:
http://www.sajozsattila.co.uk/Files/wbar.spec
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
4:16 p.m.
New subject: [Bug 1786] Review request: wbar - wbar is a quick launch bar.
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1786
Richard <hobbes1069(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hobbes1069(a)gmail.com
--- Comment #4 from Richard <hobbes1069(a)gmail.com> 2011-06-04 18:16:38 ---
I can't accept review responsibilty at this time. Too many irons in the fire.
But I'll suggest some fixes.
All 3 macros at the top of your spec file are unnecessary. Both %{name} and
%{version} will get assigned automatically from the Name: and Version: fields.
Since %{release} is not used anywhere else but the Release: field it's not
needed either.
BuildRoot: and %clean are not needed at all if you're not going to build for
EPEL.
Remove the unneeded newline after %description.
Under %setup I don't think you need the -n option. It should look in
%{name}-%{version} by default.
Under %install just use "make" you don't need to use the macro for it. As I
understand it the macros are for situation where you need to override the
default behavior.
That's all I can see in a very quick review.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:45 p.m.
New subject: [Bug 1786] Review request: wbar - wbar is a quick launch bar.
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1786
Andrea Musuruane <musuruan(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |musuruan(a)gmail.com
--- Comment #5 from Andrea Musuruane <musuruan(a)gmail.com> 2011-06-11 15:45:57 ---
Why can't this package go directly to Fedora? The license is free (GPLv3+) and
it does not depend on software in RPM Fusion. Can you please explain?
RPM Fusion does not accept packages that can be included in Fodora. If this is
the case, this review request must be closed and a new one should be opened in
Fedora.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:30 p.m.
New subject: [Bug 1786] Review request: wbar - wbar is a quick launch bar.
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1786
--- Comment #6 from Kevin Kofler <kevin.kofler(a)chello.at> 2011-06-12 00:30:49 ---
There are some patents on the OS X dock and clones. In particular, I've been
told the icon zoom effect is patented. That may or may not affect this package.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:57 p.m.
New subject: [Bug 1786] Review request: wbar - wbar is a quick launch bar.
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1786
Tim Lauridsen <tla(a)rasmil.dk> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tla(a)rasmil.dk
--- Comment #7 from Tim Lauridsen <tla(a)rasmil.dk> 2011-06-14 15:57:51 ---
The patent is here
http://patft.uspto.gov/netacgi/nph-Parser?Sect1=PTO1&Sect2=HITOFF&...
If the bar has a feature, there zooms the icon when the touched by the mouse,
then it can not be allow into Fedora, but if not then it should be ok.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:11 p.m.
New subject: [Bug 1786] Review request: wbar - wbar is a quick launch bar.
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1786
--- Comment #8 from Attila Zsolt Sajo <sajozsattila(a)yahoo.com> 2011-06-15 15:11:36
---
(In reply to comment #7)
The patent is here
http://patft.uspto.gov/netacgi/nph-Parser?Sect1=PTO1&Sect2=HITOFF&...
If the bar has a feature, there zooms the icon when the touched by the mouse,
then it can not be allow into Fedora, but if not then it should be ok.
This program have got zoom effect, so I don't think it is fit in the Fedora.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:14 p.m.
New subject: [Bug 1786] Review request: wbar - wbar is a quick launch bar.
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1786
--- Comment #9 from Attila Zsolt Sajo <sajozsattila(a)yahoo.com> 2011-06-15 15:14:45
---
(In reply to comment #4)
I can't accept review responsibilty at this time. Too many irons
in the fire.
But I'll suggest some fixes.
All 3 macros at the top of your spec file are unnecessary. Both %{name} and
%{version} will get assigned automatically from the Name: and Version: fields.
Since %{release} is not used anywhere else but the Release: field it's not
needed either.
BuildRoot: and %clean are not needed at all if you're not going to build for
EPEL.
Remove the unneeded newline after %description.
Under %setup I don't think you need the -n option. It should look in
%{name}-%{version} by default.
Under %install just use "make" you don't need to use the macro for it. As
I
understand it the macros are for situation where you need to override the
default behavior.
That's all I can see in a very quick review.
I fixed the spec file, and I uploaded in the same address.
(http://sajozsattila.co.uk/Files/wbar.spec) And there is no more
unstripped-binary-or-object error.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:17 p.m.
New subject: [Bug 1786] Review request: wbar - wbar is a quick launch bar.
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1786
--- Comment #10 from Attila Zsolt Sajo <sajozsattila(a)yahoo.com> 2011-06-15 15:17:19
---
Sorry, the correct spec file's address:
http://www.sajozsattila.co.uk/Files/wbar.spec
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:44 p.m.
New subject: [Bug 1786] Review request: wbar - wbar is a quick launch bar.
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1786
David Timms <dtimms(a)iinet.net.au> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dtimms(a)iinet.net.au
--- Comment #11 from David Timms <dtimms(a)iinet.net.au> 2011-06-16 15:44:07 ---
(In reply to comment #10)
Sorry, the correct spec file's address:
http://www.sajozsattila.co.uk/Files/wbar.spec
404 Not Found
File not found.
Also, ensure you update the release/version of the spec with each change, along
with the descriptions. This means that a new srpm name will be created.
Post a link to the .src.rpm that you created by building your spec, when you
are posting the link to an updated spec. (We use the normal Fedora rpm
packaging guidelines, with minimal changes to suit the systems in place here,
and altered freedom in packaging constraint).
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
4908
days inactive
4920
days old
rpmfusion-developers@lists.rpmfusion.org
12 comments
1 participants
participants (1)
-
RPM Fusion Bugzilla