http://bugzilla.rpmfusion.org/show_bug.cgi?id=67 --- Comment #2 from Denis Leroy <denis(a)poolshark.org&gt; 2008-10-21 10:19:10 --- http://www.poolshark.org/src/open-vm-tools-0.0.0.123053-2.fc10.src.rpm http://www.poolshark.org/src/open-vm-tools.spec The VMwareDnD directory is what is recommended by the open-vm-tools packaging wiki: http://open-vm-tools.wiki.sourceforge.net/Packaging It's used to store temporary files duing drag'n drop operations. This probably would be happier somewhere in /var/tmp. We could patch the code for this. The setuid flag on mount.vmhgfs is also what is recommended by upstream... -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=67 Orcan Ogetbil <orcanbahri(a)yahoo.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |orcanbahri(a)yahoo.com --- Comment #4 from Orcan Ogetbil <orcanbahri(a)yahoo.com&gt; 2008-10-22 21:14:39 --- The package needs some more work. Here are my notes: * rpmlint errors/warnings: open-vm-tools.src: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 51) open-vm-tools.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libguestlib.so open-vm-tools.x86_64: W: spurious-executable-perm /usr/share/doc/open-vm-tools-0.0.0.123053/README open-vm-tools.x86_64: E: wrong-script-end-of-line-encoding /usr/share/doc/open-vm-tools-0.0.0.123053/README open-vm-tools.x86_64: W: spurious-executable-perm /usr/share/doc/open-vm-tools-0.0.0.123053/ChangeLog open-vm-tools.x86_64: E: executable-marked-as-config-file /etc/vmware-tools/vm-support open-vm-tools.x86_64: W: spurious-executable-perm /usr/share/doc/open-vm-tools-0.0.0.123053/AUTHORS open-vm-tools.x86_64: E: script-without-shebang /etc/pam.d/vmware-guestd-x64 open-vm-tools.x86_64: E: executable-marked-as-config-file /etc/vmware-tools/poweron-vm-default open-vm-tools.x86_64: E: setuid-binary /usr/bin/vmware-user-suid-wrapper root 04755 open-vm-tools.x86_64: E: non-standard-executable-perm /usr/bin/vmware-user-suid-wrapper 04755 open-vm-tools.x86_64: E: setuid-binary /sbin/mount.vmhgfs root 04755 open-vm-tools.x86_64: E: non-standard-executable-perm /sbin/mount.vmhgfs 04755 open-vm-tools.x86_64: W: devel-file-in-non-devel-package /usr/include/vmci/vmci_sockets.h open-vm-tools.x86_64: E: executable-marked-as-config-file /etc/vmware-tools/poweroff-vm-default open-vm-tools.x86_64: E: postin-without-ldconfig /usr/lib64/libguestlib.so.0.0.0 open-vm-tools.x86_64: E: postun-without-ldconfig /usr/lib64/libguestlib.so.0.0.0 open-vm-tools.x86_64: W: spurious-executable-perm /usr/share/doc/open-vm-tools-0.0.0.123053/NEWS open-vm-tools.x86_64: W: spurious-executable-perm /usr/share/doc/open-vm-tools-0.0.0.123053/COPYING open-vm-tools.x86_64: E: executable-marked-as-config-file /etc/vmware-tools/resume-vm-default open-vm-tools.x86_64: W: non-conffile-in-etc /etc/modprobe.d/vmnics open-vm-tools.x86_64: W: non-conffile-in-etc /etc/sysconfig/mouse open-vm-tools.x86_64: E: executable-marked-as-config-file /etc/vmware-tools/suspend-vm-default open-vm-tools.x86_64: W: obsolete-not-provided open-vm-tools-kmod open-vm-tools.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/vmware-toolbox-cmd ['/usr/lib64'] open-vm-tools.x86_64: E: use-tmp-in-%post open-vm-tools.x86_64: W: service-default-enabled /etc/init.d/vmware-guest open-vm-tools.x86_64: E: incoherent-subsys /etc/init.d/vmware-guest vmware-guestd open-vm-tools.x86_64: W: no-reload-entry /etc/init.d/vmware-guest open-vm-tools.x86_64: W: incoherent-init-script-name vmware-guest open-vm-tools.x86_64: E: invalid-desktopfile /usr/share/applications/vmware-toolbox.desktop Most of these errors/warnings can be fixed easily. For instance, do a rpmlint -I spurious-executable-perm to learn more about the error/warning message. You will need to come up with a acceptable reasoning if you need any of the sources of these messages stay as they are. Feel free to ask questions if you're not sure how to solve a specific issue. * I think you should take the "+" off from the License field since the files you are compiling include the explicit phrase: * This program is free software; you can redistribute it and/or modify it * under the terms of the GNU Lesser General Public License as published * by the Free Software Foundation version 2.1 and no later version. * Every binary RPM package which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. * Is this permission really needed? %attr(4755,root,root) %{_bindir}/vmware-user-suid-wrapper Won't it go with %defattr ? * Header files must be in a -devel package. * If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} * Please follow the Desktop Files guidelines of Fedora: http://fedoraproject.org/wiki/Packaging/Guidelines#desktop You need to make use of desktop-file-install and/or desktop-file-validate * Make sure you that the setuid of the mount file won't generate security issues as pointed out by Thorsten. * After you're done with all of the above please verify that the final provides and requires are sane and that the package installs and removes properly (I didn't check this yet, will do it after everything is done). -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=67 Andrea Musuruane <musuruan(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |musuruan(a)gmail.com --- Comment #6 from Andrea Musuruane <musuruan(a)gmail.com&gt; 2008-10-26 17:49:39 --- I just had a quick glance at the SPEC file. Please, do not use dos2unix, use sed instead: https://fedoraproject.org/wiki/Packaging/Guidelines#Rpmlint_Errors "permissions" is spelled wrong in %prep :) -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=67 --- Comment #8 from Andrea Musuruane <musuruan(a)gmail.com&gt; 2008-10-27 16:29:27 --- I had another (deeper) look: * BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) * BuildRequires: desktop-file-utils is missing. * Because of the above it cannot be built in mock. * You should not Require desktop-file-utils to handle the desktop database: https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database * Macro usage can be improved. For example, use %{name} instead of open-vm-tools. * Macro usage is not consistent. Therefore sed instead %{__sed}. * Version in changelog in not coherent. * rpmlint output is not clean. Please run rpmlint with the "-i" parameter for an explanation. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=67 --- Comment #10 from Andrea Musuruane <musuruan(a)gmail.com&gt; 2008-10-27 17:22:06 --- (In reply to comment #9) I think you should at least resolve these: open-vm-tools.i386: W: service-default-enabled /etc/init.d/vmware-guestd open-vm-tools.i386: W: no-reload-entry /etc/init.d/vmware-guestd open-vm-tools.i386: W: incoherent-init-script-name vmware-guestd BTW, what happened to the libraries, headers and related things that Orcan Ogetbil noted? -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=67 --- Comment #12 from Denis Leroy <denis(a)poolshark.org&gt; 2008-10-27 17:58:31 --- There was a single header file for people interested in hacking with VMWare's guest communication socket. I've removed it, I admit out of laziness. If somebody files a request for it, we can then create a true "open-vm-tools-devel". -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=67 --- Comment #14 from Thorsten Leemhuis <fedora(a)leemhuis.info&gt; 2008-10-28 06:58:56 --- (In reply to comment #13) Now what I warned of in Comment #11 can happen: Someone installs a devel package and gets a service enabled (and kmods installed). That is not nice; the best way to circumvent that afaics is to also split the of libs (at least those required by the files in the devel package) into a subpackage; the devel package then should require the libs package; none of those two should require the base package. Just a note, it imho is nice to fix rpath issues, but I don't consider that a blocker If the version of the "open-vm-tools" and the modules in the kmod package needs to be strictly identical (e.g. if they need to be build from the same sources) then yes, this is definitely necessary to remove old kmods that are known to not work with updated open-vm-tools -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=67 --- Comment #16 from Denis Leroy <denis(a)poolshark.org&gt; 2008-10-31 10:58:07 --- http://www.poolshark.org/src/open-vm-tools-0.0.0.123053-8.fc10.src.rpm http://www.poolshark.org/src/open-vm-tools.spec Fixed, I used an xpm icon present in the toolbox source. This is an upstream problem. Code points at a non-existent documentation directory. Upstream tarball doesn't include any. I've notified upstream. I disagree on this one, it contains detailed bug fixes information for example. Man pages are not in the upstream tarball. Let's focus on upstream for now and file an RFE post-review for this. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=67 --- Comment #18 from Thorsten Leemhuis <fedora(a)leemhuis.info&gt; 2008-11-01 14:58:26 --- (In reply to comment #17) Yeah, but the real solution is to get them upstream, as there is a great risk that the man pages get outdated quickly if they are forgotten to get resynced. Hence I'd approve this package without it I tend to agree. Andrea, would you maybe willing to provide a updated spec file? Denis invested a lot of work already and I think a patch would help to sped things up and make life easier for everybody Anyway, a lot of people looked into these packages in between and I lost track a bit. Have all blockers been solved (yes, I know, there are still some issues, but I'm wondering if the package is "good enough" now)? Does anyone want to take care of the real review? -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=67 --- Comment #20 from Andrea Musuruane <musuruan(a)gmail.com&gt; 2008-11-01 15:59:55 --- (In reply to comment #18) I would like but I don't think I have got yet the full understanding of these utilities to make this patch. Sorry. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=67 --- Comment #22 from Kevin Kofler <kevin.kofler(a)chello.at&gt; 2008-11-04 06:27:59 --- The reason given being that dos2unix does not work on FC3, which looks entirely obsolete to me. FC3 support was dropped ages ago! -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=67 --- Comment #24 from Matthias Saou <matthias(a)rpmforge.net&gt; 2008-11-04 11:46:21 --- Server load caused by running dos2unix? Funny! :-) One good reason I can think of is that dos2unix messes with permissions. I've often seen it change file modes from 644 to 600 for no good reason (not because of the current UMASK). This might have been fixed in recent versions, but was definitely a common pitfall at some point. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=67 --- Comment #26 from Orcan Ogetbil <orcanbahri(a)yahoo.com&gt; 2008-11-04 19:23:12 --- (In reply to comment #25) Then, according to this argument, nobody should vote since one vote doesn't really count much. Or when playing poker, betting $100 is the same thing as betting $101, which is the same thing as $102... Do you understand where I'm leading? I saw many unnecessary BR's in the "Merge Review"s I checked on Fedoraland. Each BR may be tiny by itself. But I can assure you that they add up to significant amounts at the end of the day. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=67 --- Comment #28 from Denis Leroy <denis(a)poolshark.org&gt; 2008-11-10 09:37:36 --- Hi Torsten, Things have been busy here, but I fixed the issues you reported. I believe you're correct on the /etc/xdg/autostart question. http://www.poolshark.org/src/open-vm-tools-0.0.0.123053-9.fc10.src.rpm http://www.poolshark.org/src/open-vm-tools.spec -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=67 --- Comment #30 from Denis Leroy <denis(a)poolshark.org&gt; 2008-11-10 21:43:01 --- Sure, thanks Thorsten. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=67 Thorsten Leemhuis <fedora(a)leemhuis.info&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #32 from Thorsten Leemhuis <fedora(a)leemhuis.info&gt; 2008-11-11 07:12:17 --- (In reply to comment #31) That would be great to have for quite a lot of packages -- especially for the graphics drivers; there is http://rpmfusion.org/RPMFusionSwitcher, but more would be nice to have... Anyway: package imported, built and pushed to the testing/rawhide repos; thx to everyone who helped getting this package ready -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=67 Michael Schwendt <mschwendt(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mschwendt(a)gmail.com --- Comment #34 from Michael Schwendt <mschwendt(a)gmail.com&gt; 2008-11-14 12:59:30 --- This needs either a packaging fix in "procps" (Fedora) or an entry on the multilib resolver blacklist. source rpm: open-vm-tools-0.0.0.123053-9.fc9.src.rpm package: open-vm-tools-0.0.0.123053-9.fc9.i386 from rpmfusion-nonfree-updates-te sting-9-x86_64 unresolved deps: libproc-3.2.7.so(_3_2_5) libproc-3.2.7.so open-vm-tools-devel 32-bit requires libguestlib.so.0 from open-vm-tools 32-bit which in turn requires libproc-3.2.7.so from procps (Fedora). procps 32-bit is not available in 64-bit repos, however (because it is not a -devel pkg, not a virtual one either). -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=67 Thorsten Leemhuis <fedora(a)leemhuis.info&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |4 -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.