https://bugzilla.rpmfusion.org/show_bug.cgi?id=2298 Andrea Musuruane <musuruan(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2 -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2298 --- Comment #2 from Jeremy Newton <alexjnewt(a)hotmail.com&gt; 2012-04-27 17:46:17 CEST --- Package review: +: OK -: must be fixed =: should be fixed (at your discretion) ?: Question or clairification needed N: not applicable MUST: [+] rpmlint output 200 someodd errors from incorrect-fsf-address, though this has been addressed upstream, so no problems. [+] follows package naming guidelines [+] spec file base name matches package name [+] package meets the packaging guidelines [+] package uses a Fedora approved license: [-] license field matches the actual license. The follow files were not picked up as GPLv2+ in licensecheck: fceu2.1.5/src/emufile.cpp: MIT/X11 (BSD like) fceu2.1.5/src/emufile.h: MIT/X11 (BSD like) fceu2.1.5/src/drivers/common/hq3x.cpp: LGPL (v2.1 or later) fceu2.1.5/src/drivers/common/nes_ntsc_impl.h: LGPL (v2.1 or later) fceu2.1.5/src/drivers/common/nes_ntsc.c: LGPL (v2.1 or later) fceu2.1.5/src/drivers/common/hq2x.cpp: LGPL (v2.1 or later) [+] license file is included in %doc: [+] spec file is in American English [+] spec file is legible [+] sources match upstream: md5sum matches (e8b20e62bbbb061b1a59d51b47c827bd) [+] package builds on at least one primary arch: [N] appropriate use of ExcludeArch [+] all build requirements in BuildRequires [N] spec file handles locales properly [N] ldconfig in %post and %postun [+] no bundled copies of system libraries [+] no relocatable packages [+] package owns all directories that it creates [+] no files listed twice in %files [+] proper permissions on files [+] consistent use of macros [+] code or permissible content [N] large documentation in -doc [+] no runtime dependencies in %doc [N] header files in -devel [N] static libraries in -static [N] .so in -devel [N] -devel requires main package [+] package contains no libtool archives [+] package contains a desktop file, uses desktop-file-install/validate [+] package does not own files/dirs owned by other packages [+] all filenames in UTF-8 SHOULD: [?] query upstream for license text Didn't query [?] description and summary contains available translations No explicit need, no need to fix [+] package builds in mock: Works with i686 [+] package builds on all supported arches Works in x86_64 and i686 [+] package functions as described One game tested, no issues, perfect run time. [+] sane scriptlets [N] subpackages require the main package [N] placement of pkgconfig files [N] file dependencies versus package dependencies [+] package contains man pages for binaries/scripts COMMENTS: -The license issue should be fixed, with a license breakdown and all that. -I would suggest that patch 1 should be sent upstream, if it hasn't already. -Since this provides fceultra, gfceu is never removed upon update. Either the fceultra should be removed or an obsoletes gfceu should be added. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2298 --- Comment #4 from Jeremy Newton <alexjnewt(a)hotmail.com&gt; 2012-04-27 20:13:14 CEST --- (In reply to comment #3) No problem, if you have some time, you can return the favour :) https://bugzilla.rpmfusion.org/show_bug.cgi?id=908 Sorry I didn't mean that there is a problem with the licenses, but merely that all should be included in the spec like so: and a license breakdown should be included in the comments above or below it. If you need an example, take a look at this spec: http://dl.dropbox.com/u/42480493/pcsxr.spec -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2298 --- Comment #6 from Andrea Musuruane <musuruan(a)gmail.com&gt; 2012-04-28 14:39:52 CEST --- http://www.lesloueizeh.com/musuruan/fceux.spec http://www.lesloueizeh.com/musuruan/fceux-2.1.5-2.fc16.src.rpm Changelog: - Obsoleted gfceu too - Notified upstream about underlinking -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2298 Andrea Musuruane <musuruan(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33 --- Comment #8 from Andrea Musuruane <musuruan(a)gmail.com&gt; 2012-04-28 17:26:43 CEST --- Package CVS request ====================== Package Name: fceux Short Description: A cross platform, NTSC and PAL Famicom/NES emulator Owners: musuruan Branches: F-16 F-17 InitialCC: ---------------------- License tag: free -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2298 Andrea Musuruane <musuruan(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #9 from Andrea Musuruane <musuruan(a)gmail.com&gt; 2012-05-11 12:46:39 CEST --- Built and published. Closing. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.