4:20 a.m.
Hi,
On Qui, 2016-11-17 at 10:38 +0100, David Timms wrote:
+# invoke with: rpmbuild --without mp3 audacity-freeworld.spec to
undefine mp3.
+%bcond_without mp3
+%if %{without mp3}
+# user passed [--without mp3]. Yes, rpm logic seems wrong!
+%define mp3importexport 0
+%else
+%define mp3importexport 1
+%endif
bcond_with and bcond_without are pretty easy to use and works well, I
(personally) don't understand why we have another variants.
But they have one little trick: : "never use without_foo, _with_foo nor
_without_foo, only with_foo." . Also reading /usr/lib/rpm/macros, at
line 111, we got all examples that we may need.
we don't have "without" operator only "with" so at least
%if %{without mp3} , should be: %if ! %{with mp3} ...
Cheers,
--
Sérgio M. B.
4:24 a.m.
New subject: [audacity-freeworld] fix mp3importexport conditional.
Sérgio Basto wrote:
bcond_with and bcond_without are pretty easy to use and works well,
I
(personally) don't understand why we have another variants.
Because bcond_with and bcond_without have one major flaw: They are
"backwards" compared to how most people think.
"%bcond_with foo" actually means to build WITHOUT foo by default, and to add
a "--with foo" switch to build with foo. Likewise, "%bcond_without
foo"
actually means to build WITH foo by default, and to add a "--without foo"
switch to build without foo. Many packagers find that really confusing.
And the --with and --without switches cannot be used in Koji anyway, so you
may as well hardcode the options in the specfile using %global.
Kevin Kofler
4:36 a.m.
New subject: [audacity-freeworld] fix mp3importexport conditional.
On Seg, 2016-11-21 at 05:24 +0100, Kevin Kofler wrote:
"%bcond_with foo" actually means to build WITHOUT foo by
default, and
to add
a "--with foo" switch to build with foo. Likewise, "%bcond_without
foo"
actually means to build WITH foo by default, and to add a "--without
foo"
switch to build without foo. Many packagers find that really
confusing.
"%bcond_with foo" means that you could use --with foo , otherwise
is WITHOUT foo , "%bcond_without foo" means that you have option
--without foo , it was easy to fix, for me. Again but the trick is not
use "without" in conditions, we may use: if ! %{with foo} or {!?with
foo: ...}
--
Sérgio M. B.
4:39 a.m.
New subject: [audacity-freeworld] fix mp3importexport conditional.
On Seg, 2016-11-21 at 05:24 +0100, Kevin Kofler wrote:
And the --with and --without switches cannot be used in Koji anyway,
we can use in mock and is good to test all conditions (with or without
foo(s) ), without change the spec.
--
Sérgio M. B.
2919
days inactive
2919
days old
rpmfusion-developers@lists.rpmfusion.org
3 comments
2 participants
participants (2)
-
Kevin Kofler -
Sérgio Basto