10:12 p.m.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4186
Bug #: 4186
Summary: scid - A chess database application
Classification: Unclassified
Product: Package Reviews
Version: Current
Platform: All
OS/Version: GNU/Linux
Status: NEW
Severity: normal
Priority: P5
Component: Review Request
AssignedTo: rpmfusion-package-review(a)rpmfusion.org
ReportedBy: sergio(a)serjux.com
CC: rpmfusion-package-review(a)rpmfusion.org
SPEC: http://www.serjux.com/rpms/scid.spec
SRPM: http://www.serjux.com/rpms/scid-4.6.2-1.fc21.src.rpm
I will be able to add this package , the scid.spec is the same made by Mikhail
Kalenkov , I just update it to 4.6.2
Scid can perform many different searches, such as for particular
players, a certain opening position, material searches, and pattern
searches such as isolated pawns. It is very fast, because it uses its
own efficient format, but it can convert games to and from PGN, the
standard format for chess game files.
Scid can use a chess engine such as Crafty to analyze games and also
has a "tree" mode where it automatically shows all moves played from
the current position, their opening codes, success rates, etc.
Why not in Fedora:
Scid package has some small part of nonfree code. It is Nalimov
tablebase decoding code. Nalimov tablebases may be very important in the
endgame
analysis.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:14 p.m.
New subject: [Bug 4186] scid - A chess database application
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4186
Sérgio Basto <sergio(a)serjux.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |Mikhail.Kalenkov(a)gmail.com
--- Comment #1 from Sérgio Basto <sergio(a)serjux.com> 2016-08-15 00:14:05 CEST ---
*** Bug 310 has been marked as a duplicate of this bug. ***
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:14 p.m.
New subject: [Bug 4186] scid - A chess database application
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4186
Sérgio Basto <sergio(a)serjux.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |2
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
11:50 p.m.
New subject: [Bug 4186] scid - A chess database application
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4186
--- Comment #2 from Sérgio Basto <sergio(a)serjux.com> 2016-08-15 01:50:34 CEST ---
SPEC: http://www.serjux.com/rpms/scid.spec
SRPM: http://www.serjux.com/rpms/scid-4.6.4-1.fc23.src.rpm
- Update scid to 4.6.4
- Drop patch0, is upstreamed
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
11:59 a.m.
New subject: [Bug 4186] scid - A chess database application
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4186
Antonio Trande <anto.trande(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Blocks|2 |3
AssignedTo|rpmfusion-package-review@rp |anto.trande(a)gmail.com
|mfusion.org |
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
4:32 p.m.
New subject: [Bug 4186] scid - A chess database application
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4186
--- Comment #3 from Antonio Trande <anto.trande(a)gmail.com> 2016-08-15 18:32:25 CEST
---
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %license.
Note: License file copyright is not marked as %license
See:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
- Requires depedencies are not arched
Requires: %{name} = %{version}-%{release}
- /usr/share/scid/tcl is not owned
- I guess tcl extensions must be installed according to the TclTk guidelines
http://fedoraproject.org/wiki/Packaging:Tcl
- ./tkscid results not fully hardened, probably linker flags are missing.
See the build log.
- There are some errors/warnings from rpmlint which must be fixed.
- Why do you move files under %{buildroot}/%{_docdir}/%{name}?
You can just use %doc or %license.
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL", "GPL (v2 or later) (with incorrect FSF address)",
"Unknown or generated". 201 files have unknown license. Detailed
output of licensecheck in /home/sagitter/scid/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[?]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/scid/tcl
[?]: Package must own all directories that it creates.
Note: Directories without known owners:
/usr/share/icons/hicolor/scalable/apps, /usr/share/scid/tcl,
/usr/share/icons/hicolor, /usr/share/icons/hicolor/scalable
[!]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[?]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: update-desktop-database is invoked in %post and %postun if package
contains desktop file(s) with a MimeType: entry.
Note: desktop file(s) with MimeType entry in scid
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in scid
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 245760 bytes in 10 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[!]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in scid-
sounds , scid-books , scid-debuginfo
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[!]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
Note: Arch-ed rpms have a total of 10547200 bytes in /usr/share
scid-4.6.4-1.fc26.x86_64.rpm:10547200
See:
http://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_G...
[x]: Rpmlint is run on debuginfo package(s).
Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
Rpmlint
-------
Checking: scid-4.6.4-1.fc26.x86_64.rpm
scid-sounds-4.6.4-1.fc26.noarch.rpm
scid-books-4.6.4-1.fc26.noarch.rpm
scid-debuginfo-4.6.4-1.fc26.x86_64.rpm
scid-4.6.4-1.fc26.src.rpm
scid.x86_64: W: invalid-license distributable only in Scid
scid.x86_64: W: obsolete-not-provided scid-bases
scid.x86_64: E: arch-dependent-file-in-usr-share
/usr/share/scid/engines/phalanx-scid/phalanx-scid
scid.x86_64: E: arch-dependent-file-in-usr-share
/usr/share/scid/engines/togaII1.2.1a/togaII
scid.x86_64: W: file-not-utf8 /usr/share/doc/scid/ezsmtp/koi8-r-body.txt
scid.x86_64: E: incorrect-fsf-address /usr/bin/sc_remote
scid.x86_64: E: wrong-script-interpreter /usr/bin/pgnfix /usr/bin/env python
scid.x86_64: E: incorrect-fsf-address /usr/share/licenses/scid/phalanx/COPYING
scid.x86_64: E: incorrect-fsf-address /usr/share/doc/scid/phalanx/README
scid.x86_64: E: non-executable-script
/usr/share/scid/tcl/contrib/ezsmtp/install.tcl 644 /bin/sh
scid.x86_64: E: incorrect-fsf-address
/usr/share/licenses/scid/togaII/copying.txt
scid.x86_64: E: non-executable-script /usr/share/scid/tcl/options.tcl 644
/bin/sh
scid.x86_64: E: non-executable-script /usr/share/scid/tcl/start.tcl 644 /bin/sh
scid.x86_64: E: incorrect-fsf-address /usr/share/doc/scid/togaII/readme.txt
scid.x86_64: W: no-manual-page-for-binary pgnfix
scid.x86_64: W: no-manual-page-for-binary sc_eco
scid.x86_64: W: no-manual-page-for-binary sc_remote
scid.x86_64: W: no-manual-page-for-binary tkscid
scid.x86_64: W: no-manual-page-for-binary sc_import
scid.x86_64: W: no-manual-page-for-binary spf2spi
scid.x86_64: W: no-manual-page-for-binary sc_spell
scid.x86_64: W: no-manual-page-for-binary scidpgn
scid.x86_64: W: no-manual-page-for-binary scid
scid.x86_64: W: no-manual-page-for-binary sc_epgn
scid.x86_64: W: no-manual-page-for-binary spliteco
scid-sounds.noarch: W: no-documentation
scid-books.noarch: W: invalid-license freely redistributable
scid-books.noarch: W: no-documentation
scid-books.noarch: E: world-writable /usr/share/scid/books/varied.bin 666
scid-books.noarch: E: world-writable /usr/share/scid/books/gm2600.bin 666
scid-books.noarch: E: world-writable /usr/share/scid/books/Performance.bin 666
scid-books.noarch: E: world-writable /usr/share/scid/books/Elo2400.bin 666
scid-books.noarch: E: world-writable /usr/share/scid/books/readme.txt 666
scid-debuginfo.x86_64: W: invalid-license distributable only in Scid
scid.src: W: invalid-license distributable only in Scid
scid.src:24: W: unversioned-explicit-obsoletes scid-bases
scid.src:83: W: configure-without-libdir-spec
5 packages and 0 specfiles checked; 16 errors, 21 warnings.
Rpmlint (debuginfo)
-------------------
Checking: scid-debuginfo-4.6.4-1.fc26.x86_64.rpm
scid-debuginfo.x86_64: W: invalid-license distributable only in Scid
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
Rpmlint (installed packages)
----------------------------
scid-sounds.noarch: W: no-documentation
scid.x86_64: W: invalid-license distributable only in Scid
scid.x86_64: W: obsolete-not-provided scid-bases
scid.x86_64: E: arch-dependent-file-in-usr-share
/usr/share/scid/engines/togaII1.2.1a/togaII
scid.x86_64: E: arch-dependent-file-in-usr-share
/usr/share/scid/engines/phalanx-scid/phalanx-scid
scid.x86_64: E: incorrect-fsf-address /usr/share/doc/scid/phalanx/README
scid.x86_64: W: file-not-utf8 /usr/share/doc/scid/ezsmtp/koi8-r-body.txt
scid.x86_64: E: incorrect-fsf-address /usr/share/licenses/scid/phalanx/COPYING
scid.x86_64: E: incorrect-fsf-address /usr/bin/sc_remote
scid.x86_64: E: wrong-script-interpreter /usr/bin/pgnfix /usr/bin/env python
scid.x86_64: E: non-executable-script
/usr/share/scid/tcl/contrib/ezsmtp/install.tcl 644 /bin/sh
scid.x86_64: E: non-executable-script /usr/share/scid/tcl/start.tcl 644 /bin/sh
scid.x86_64: E: non-executable-script /usr/share/scid/tcl/options.tcl 644
/bin/sh
scid.x86_64: E: incorrect-fsf-address /usr/share/doc/scid/togaII/readme.txt
scid.x86_64: E: incorrect-fsf-address
/usr/share/licenses/scid/togaII/copying.txt
scid.x86_64: W: no-manual-page-for-binary sc_remote
scid.x86_64: W: no-manual-page-for-binary tkscid
scid.x86_64: W: no-manual-page-for-binary sc_spell
scid.x86_64: W: no-manual-page-for-binary sc_epgn
scid.x86_64: W: no-manual-page-for-binary sc_eco
scid.x86_64: W: no-manual-page-for-binary spf2spi
scid.x86_64: W: no-manual-page-for-binary scid
scid.x86_64: W: no-manual-page-for-binary scidpgn
scid.x86_64: W: no-manual-page-for-binary pgnfix
scid.x86_64: W: no-manual-page-for-binary spliteco
scid.x86_64: W: no-manual-page-for-binary sc_import
scid-books.noarch: W: invalid-license freely redistributable
scid-books.noarch: W: no-documentation
scid-books.noarch: E: world-writable /usr/share/scid/books/varied.bin 666
scid-books.noarch: E: world-writable /usr/share/scid/books/Performance.bin 666
scid-books.noarch: E: world-writable /usr/share/scid/books/gm2600.bin 666
scid-books.noarch: E: world-writable /usr/share/scid/books/Elo2400.bin 666
scid-books.noarch: E: world-writable /usr/share/scid/books/readme.txt 666
scid-debuginfo.x86_64: W: invalid-license distributable only in Scid
4 packages and 0 specfiles checked; 16 errors, 18 warnings.
Requires
--------
scid-sounds (rpmlib, GLIBC filtered):
scid
tcl-snack
scid (rpmlib, GLIBC filtered):
/bin/sh
/usr/bin/env
/usr/bin/tclsh
libc.so.6()(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
libm.so.6()(64bit)
libpthread.so.0()(64bit)
libstdc++.so.6()(64bit)
libstdc++.so.6(CXXABI_1.3)(64bit)
libstdc++.so.6(CXXABI_1.3.8)(64bit)
libtcl8.6.so()(64bit)
libz.so.1()(64bit)
rtld(GNU_HASH)
tcl
tk
scid-books (rpmlib, GLIBC filtered):
scid
scid-debuginfo (rpmlib, GLIBC filtered):
Provides
--------
scid-sounds:
scid-sounds
scid:
application()
application(scid.desktop)
mimehandler(application/x-chess-pgn)
scid
scid(x86-64)
scid-books:
scid-books
scid-debuginfo:
scid-debuginfo
scid-debuginfo(x86-64)
Source checksums
----------------
http://downloads.sourceforge.net/scid/scid-4.6.4.zip :
CHECKSUM(SHA256) this package :
4fde535051786c0f8b13e6a2a20b306e7ba29e7af7394f5e510aae4f87e223e6
CHECKSUM(SHA256) upstream package :
4fde535051786c0f8b13e6a2a20b306e7ba29e7af7394f5e510aae4f87e223e6
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64-rpmfusion_free
-rn scid-4.6.4-1.fc23.src.rpm
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
4:50 a.m.
New subject: [Bug 4186] scid - A chess database application
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4186
--- Comment #4 from Sérgio Basto <sergio(a)serjux.com> 2016-08-17 06:50:56 CEST ---
(In reply to comment #3)
Files reuploaded.
- If (and only if) the source package includes the text of the
license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %license.
Note: License file copyright is not marked as %license
See:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
fixed
- Requires depedencies are not arched
Requires: %{name} = %{version}-%{release}
fixed
- /usr/share/scid/tcl is not owned
fixed
- I guess tcl extensions must be installed according to the TclTk
guidelines
http://fedoraproject.org/wiki/Packaging:Tcl
need help here, what I need to do ?
- ./tkscid results not fully hardened, probably linker flags are
missing.
See the build log.
cflags ans ldflags are set, still happens ?
- There are some errors/warnings from rpmlint which must be fixed.
- Why do you move files under %{buildroot}/%{_docdir}/%{name}?
You can just use %doc or %license.
%doc and %license copy thing from BUILD dir to %{buildroot}, we already have
lots of files in %{buildroot} , so is just manage that better .
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
10:03 a.m.
New subject: [Bug 4186] scid - A chess database application
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4186
--- Comment #5 from Antonio Trande <anto.trande(a)gmail.com> 2016-08-17 12:03:42 CEST
---
(In reply to comment #4)
(In reply to comment #3)
> - I guess tcl extensions must be installed according to the TclTk guidelines
> http://fedoraproject.org/wiki/Packaging:Tcl
need help here, what I need to do ?
Make a separated (noarch) sub-package with a tcl- suffix that contains all own
/.tcl/docs/license files.
%{_datadir}/%{name}/tcl directory should be installed under
'%{_datadir}/tcl%{tcl_version}}':
%{_datadir}/tcl%{tcl_version}}/%{name}-%{version}/tcl
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
10:30 a.m.
New subject: [Bug 4186] Review request: scid - A chess database application
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4186
Nicolas Chauvet <kwizart(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
namespace| |nonfree
--- Comment #7 from Nicolas Chauvet <kwizart(a)gmail.com> ---
Is this review still relevant ?
--
You are receiving this mail because:
You are on the CC list for the bug.
11:24 a.m.
New subject: [Bug 4186] Review request: scid - A chess database application
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4186
--- Comment #8 from Sérgio Basto <sergio(a)serjux.com> ---
(In reply to Nicolas Chauvet from comment #7)
Is this review still relevant ?
yes, still need finishing tcl packaging ... or wait someone do it for me
Thanks
--
You are receiving this mail because:
You are on the CC list for the bug.
2252
days inactive
3052
days old
rpmfusion-developers@lists.rpmfusion.org
13 comments
1 participants
participants (1)
-
RPM Fusion Bugzilla