http://bugzilla.rpmfusion.org/show_bug.cgi?id=1355 Magnus Tuominen <magnus.tuominen(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2 -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1355 --- Comment #2 from Chen Lei <supercyper(a)163.com&gt; 2010-08-04 10:27:32 --- This is package is not suitable for rpmfusion, since it also support gstreamer backend(actually upstream recommend this backend) See http://flavio.tordini.org/minitube/minitube-linux-setup -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1355 Kevin Kofler <kevin.kofler(a)chello.at&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kevin.kofler(a)chello.at Status|RESOLVED |REOPENED Resolution|INVALID | --- Comment #4 from Kevin Kofler <kevin.kofler(a)chello.at&gt; 2010-08-04 10:38:40 --- This package is NOT suitable for Fedora. It DOES NOT WORK without packages from RPM Fusion, even with the GStreamer backend, since it will try to use an MP4 or FLV format, not WebM. In addition, the GStreamer backend for Phonon is NOT the default, and this is a systemwide setting and cannot be changed per application. Therefore, RPM Fusion IS the correct place for this package. IMHO the package should be in RPM Fusion Free with a hard Requires: xine-lib-extras-freeworld, that way it'll work out of the box. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1355 Chen Lei <supercyper(a)163.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |supercyper(a)163.com --- Comment #6 from Chen Lei <supercyper(a)163.com&gt; 2010-08-04 11:53:08 --- The fact is minitube can't play a lot of videos in youtube without codecs from rpmfusion(xine-lib-freeworld or gstreamer-plugins-ugly). But it should not depend on any packages in rpmfusion, because we can not force users to use xine backend. The gstreamer backend is the recommended backend by the minitube author, also phonon itself don't depend on any backends explicitly. Phonon only depends on a virtual provides phonon-backend. rpm -qa|grep phonon phonon-4.4.2-1.fc13.x86_64 phonon-backend-gstreamer-4.4.2-1.fc13.x86_64 -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1355 --- Comment #8 from leigh scott <leigh123linux(a)fedoraproject.org&gt; 2010-08-04 14:29:04 --- (In reply to comment #5) Take a look at my spec file as you aren't validating the desktop file and haven't included the necessary scriptlets. http://fedoraforum.org/leigh123linux/review/minitube/1/minitube.spec -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1355 --- Comment #10 from Manuel Wolfshant <wolfy(a)fedoraproject.org&gt; 2010-08-04 15:08:41 --- Only that unlike in Fedora, in RPMFusion we can add a "README.Fedora" advising users how to also install the needed codecs from RPMFusion. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1355 --- Comment #12 from Magnus Tuominen <magnus.tuominen(a)gmail.com&gt; 2010-08-04 15:58:04 --- new builds: http://magnu5.fedorapeople.org/review/minitube/SPECS/minitube.spec http://magnu5.fedorapeople.org/review/minitube/SRPMS/minitube-1.1-3.fc13.... rpmlint -iv minitube.spec minitube.spec: I: checking-url http://flavio.tordini.org/files/minitube/minitube-1.1.tar.gz (timeout 10 seconds) 0 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint -iv minitube-1.1-3.fc13.src.rpm minitube.src: I: checking minitube.src: I: checking-url http://flavio.tordini.org/minitube (timeout 10 seconds) minitube.src: I: checking-url http://flavio.tordini.org/files/minitube/minitube-1.1.tar.gz (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Stole lots of stuff from leigh (thanks!) Also removed the Req: on xine-lib-extras-freeworld -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1355 --- Comment #14 from Manuel Wolfshant <wolfy(a)fedoraproject.org&gt; 2010-08-05 00:31:45 --- I second that. If possible ( and by requiring the packages which provide the codecs it is possible) the package should work by default. For a worst case scenario, see my previous comment, which should be amended as "we can add a "README.Fedora" file advising users how to also install the needed codecs from RPMFusion or add a short paragraph in the Description tag, telling users that the codecs installed by packages X and Y are also needed." -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1355 --- Comment #16 from Kevin Kofler <kevin.kofler(a)chello.at&gt; 2010-08-05 03:31:43 --- You can USE another backend, you'll just have xine-lib-extras-freeworld (and thus xine-lib) dragged in as a dependency even if you don't use it. It's the tradeoff for making things work out of the box. Magnus tested it, it worked just fine. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1355 --- Comment #18 from Kevin Kofler <kevin.kofler(a)chello.at&gt; 2010-08-05 04:52:46 --- You can fire up System Settings in GNOME too. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1355 --- Comment #20 from Kevin Kofler <kevin.kofler(a)chello.at&gt; 2010-08-05 05:47:03 --- You need to fire up the KDE System Settings (systemsettings from kdebase-workspace), not the gnome-control-center nor qtconfig-qt4. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1355 --- Comment #22 from Magnus Tuominen <magnus.tuominen(a)gmail.com&gt; 2010-08-05 10:50:36 --- (In reply to comment #21) ehh, it does indeed pull in phonon, phonon-backend-xine. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1355 --- Comment #24 from Thorsten Leemhuis <fedora(a)leemhuis.info&gt; 2010-08-05 11:45:44 --- Just a crazy thought: if webm support for this is on the horizon then why not review the package in Fedora now and import it here if we agree that's the best place; then it can get moved to Fedora without a additional review once the webm support shows up -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1355 --- Comment #26 from leigh scott <leigh123linux(a)fedoraproject.org&gt; 2010-08-05 16:07:44 --- The packaging issue could be resolved with meta subpackages for gnome and kde to drag in the required deps. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1355 --- Comment #28 from Kevin Kofler <kevin.kofler(a)chello.at&gt; 2010-08-05 17:11:02 --- (Note that the second solution does NOT drag in phonon-backend-xine, only xine-lib-extras-freeworld and (through dependencies) xine-lib.) -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1355 --- Comment #30 from Magnus Tuominen <magnus.tuominen(a)gmail.com&gt; 2010-08-05 17:30:56 --- (In reply to comment #28) Are you sure about this? I just installed minitube after removing phonon-backend-xine and phonon-backend-gstreamer, and phonon-backend-xine, phonon and qt-x11 got installed as dependancys. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1355 --- Comment #32 from Chen Lei <supercyper(a)163.com&gt; 2010-08-05 17:48:56 --- (In reply to comment #30) If you install phonon-backend-gstreamer, then you won't install phonon-backend-xine as a dependency to minitube. Actually, I think it'll be better to remove all those extra dependencies. Because most KDE users already install xine-lib-extras-freeworld(for amaroK), most GNOME users already install gsteamer-plugins-*(for totem). A simple desciption in rpm will be more appropiate. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1355 --- Comment #34 from Kalev Lember <kalev(a)smartlink.ee&gt; 2010-08-09 11:42:19 --- This results in unowned directories: %{_datadir}/%{name}/ and %{_datadir}/%{name}/locale/ are not traced by this rpm. To fix that, use either: %{_datadir}/%{name}/ or: %dir %{_datadir}/%{name}/ %dir %{_datadir}/%{name}/locale/ %{_datadir}/%{name}/locale/*.qm It would also be nice to use %{version} macro in Source0 URL so that you wouldn't have to update version in two separate places (Version: and Source0:) when you update the package. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1355 --- Comment #36 from Kalev Lember <kalev(a)smartlink.ee&gt; 2010-08-09 12:36:02 --- The licensing is unclear. How did you determine that the package is "GPLv3+ and LGPLv2+"? Some of the source files are (C) 2009 Nokia Corporation and have proper license headers; other have no headers and I couldn't find any readme.txt file or similar which would clarify authors' intent. Can you ask upstream to clarify [1] the licensing of the files which lack license headers and preferably add proper license headers to those files? [1] https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Clar... -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1355 --- Comment #38 from Magnus Tuominen <magnus.tuominen(a)gmail.com&gt; 2010-08-09 21:20:01 --- (In reply to comment #37) Kalev Lember, oops :) -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1355 --- Comment #40 from leigh scott <leigh123linux(a)fedoraproject.org&gt; 2010-08-10 18:15:28 --- Created an attachment (id=462) --> (http://bugzilla.rpmfusion.org/attachment.cgi?id=462) lang.patch -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1355 --- Comment #42 from Kevin Kofler <kevin.kofler(a)chello.at&gt; 2010-08-10 19:55:07 --- Uh, it's not the country code that's relevant here, it's the language code. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1355 --- Comment #44 from Kalev Lember <kalev(a)smartlink.ee&gt; 2010-08-11 12:57:29 --- (In reply to comment #43) That patch looks nice, props to Leigh. Magnus, can you submit the patch upstream so that it'll be included in the next release? I think the reasoning that it's needed for rpm's find_lang to work is good enough. Some issues with the package: Mustfix: - /usr/share/minitube/ and /usr/share/minitube/locale/ directories are unowned. Nice to have: - can you sort the list of files with license info at the top of the spec file? It's a bit hard to read the way it is now. - file names like lang.patch and QString.patch have a good chance of clashing with files from other source packages (not in the official build system, but when people "rpm -i" the source rpms in their own computer). Can you prefix them with minitube- like minitube-lang.patch, minitube-QString.patch? - it might be safer to BR qt4-devel instead of qt-devel, but see below: $ repoquery --whatprovides qt-devel qt-devel-1:4.6.3-8.fc13.i686 qt-devel-1:4.6.3-8.fc13.x86_64 qt-devel-1:4.6.2-16.fc13.i686 qt3-devel-0:3.3.8b-29.fc13.x86_64 qt3-devel-0:3.3.8b-29.fc13.i686 qt-devel-1:4.6.2-16.fc13.x86_64 qt-devel-1:4.6.3-8.fc13.i686 qt-devel-1:4.6.3-8.fc13.x86_64 Kevin: Why do the qt3-devel packages Provide qt-devel? Is it really needed? Looks like a good way to shoot yourself in the foot. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1355 --- Comment #46 from Kalev Lember <kalev(a)smartlink.ee&gt; 2010-08-11 13:12:36 --- (In reply to comment #45) Opened a ticket: https://bugzilla.redhat.com/show_bug.cgi?id=623106 -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1355 Kalev Lember <kalev(a)smartlink.ee&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|2 |4 AssignedTo|rpmfusion-package- |kalev(a)smartlink.ee |review(a)rpmfusion.org | Status|REOPENED |NEW --- Comment #48 from Kalev Lember <kalev(a)smartlink.ee&gt; 2010-08-11 14:11:50 --- RPM Fusion review minitube-1.1-6.fc13.src.rpm 2010-08-11 + OK ! needs attention rpmlint output: $ rpmlint minitube-1.1-6.fc13.src.rpm minitube minitube-debuginfo minitube.i686: W: no-manual-page-for-binary minitube 3 packages and 0 specfiles checked; 0 errors, 1 warnings. + Rpmlint warnings are harmless and can be ignored + The package is named according to the Package Naming Guidelines + Spec file name matches the base package name + Package meets the Packaging Guidelines + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The license field in the spec file matches the actual license + The package contains license files (COPYING, LICENSE.LGPL, and INSTALL) + Spec file is written in American English + Spec file is legible + Upstream sources match sources in the srpm. md5sum: 075841322631486a8bb69575ec05f5ca minitube-1.1.tar.gz 075841322631486a8bb69575ec05f5ca Download/minitube-1.1.tar.gz + The package builds in koji n/a ExcludeArch bugs filed + BuildRequires look sane + The spec file handles locales properly n/a ldconfig + Package does not bundle copies of system libraries n/a Package isn't relocatable + Package owns all directories it creates + No duplicate files in %files + Permissions are properly set and %files has %defattr + Consistent use of macros + The package must contain code, or permissable content. n/a Large documentation files should go in -doc subpackage + Files marked %doc don't affect the package n/a Header files must go to -devel n/a Static libraries should be in -static n/a Library files that end in .so must go to -devel package n/a -devel must require the fully versioned base + Package doesn't contain any libtool .la files + Proper .desktop file handling + Directory ownership sane + Filenames are valid UTF-8 Looks good. APPROVED -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1355 Magnus Tuominen <magnus.tuominen(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33 --- Comment #49 from Magnus Tuominen <magnus.tuominen(a)gmail.com&gt; 2010-08-11 16:25:38 --- Package CVS request ====================== Package Name: minitube Short Description: A YouTube desktop client Owners: magnu5 Branches: F12, F13, F14, devel InitialCC: ---------------------- License tag: free -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1355 Magnus Tuominen <magnus.tuominen(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #50 from Magnus Tuominen <magnus.tuominen(a)gmail.com&gt; 2010-09-04 12:00:06 --- Packages built for all branches. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.