9:09 p.m.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345
Bug #: 3345
Summary: Review request: kodi - Media center
Classification: Unclassified
Product: Package Reviews
Version: Current
Platform: All
OS/Version: GNU/Linux
Status: NEW
Severity: normal
Priority: P5
Component: Review Request
AssignedTo: rpmfusion-package-review(a)rpmfusion.org
ReportedBy: mike(a)cchtml.com
CC: rpmfusion-package-review(a)rpmfusion.org
Spec file: http://michael.cronenworth.com/RPMS/kodi.spec
SRPM file:
http://michael.cronenworth.com/RPMS/kodi-14.0-0.1.alpha2.fc22.src.rpm
Why not in Fedora: Requires ffmpeg and other RPM Fusion libraries
This is essentially a rename of xbmc, but I want to keep xbmc in RPM Fusion
until Fedora 20 is EOL next year.
Fedora 21 or higher is required (FFmpeg 2.2.0 or higher is required to build).
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:10 p.m.
New subject: [Bug 3345] Review request: kodi - Media center
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345
Michael Cronenworth <mike(a)cchtml.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |alexl(a)users.sourceforge.net
| |, ktdreyer(a)ktdreyer.com
Blocks| |2
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
5:14 a.m.
New subject: [Bug 3345] Review request: kodi - Media center
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345
--- Comment #1 from Michael Cronenworth <mike(a)cchtml.com> 2014-09-03 07:14:06 CEST
---
Version 14.0 alpha 3 has been released.
New spec: http://michael.cronenworth.com/RPMS/kodi.spec
New SRPM: http://michael.cronenworth.com/RPMS/kodi-14.0-0.2.alpha3.fc22.src.rpm
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
11:43 p.m.
New subject: [Bug 3345] Review request: kodi - Media center
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345
W. Michael Petullo <mike(a)flyn.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mike(a)flyn.org
--- Comment #2 from W. Michael Petullo <mike(a)flyn.org> 2014-12-03 00:43:26 CET ---
I would like to help review this package, but it seems that
michael.cronenworth.com is unavailable. As a result, I cannot download the
SRPMs.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
12:04 a.m.
New subject: [Bug 3345] Review request: kodi - Media center
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345
--- Comment #3 from Michael Cronenworth <mike(a)cchtml.com> 2014-12-03 01:04:48 CET
---
I'm having ISP issues. They are resolved (for the moment) but you may
experience timeouts until I can get it fixed tomorrow.
This package is also out of date, but there are RPMFusion build infrastructure
issues regarding F21/rawhide so I cannot build the latest version yet.
Thanks for looking at this.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:05 a.m.
New subject: [Bug 3345] Review request: kodi - Media center
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345
--- Comment #4 from W. Michael Petullo <mike(a)flyn.org> 2014-12-03 03:05:28 CET ---
Until we get a newer package, I have been experimenting with the work at:
https://github.com/mooninite/xbmc-rpm
I have submitted a pull request there for an update to 14.0rc1. I will perform
a formal review of Michael's packages once I can.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:05 a.m.
New subject: [Bug 3345] Review request: kodi - Media center
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345
--- Comment #5 from Michael Cronenworth <mike(a)cchtml.com> 2014-12-24 04:05:31 CET
---
Kodi 14.0 final has been released.
http://michael.cronenworth.com/RPMS/kodi.spec
http://michael.cronenworth.com/RPMS/kodi-14.0-1.fc21.src.rpm
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:37 p.m.
New subject: [Bug 3345] Review request: kodi - Media center
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345
--- Comment #6 from W. Michael Petullo <mike(a)flyn.org> 2014-12-27 22:37:34 CET ---
As the packager stated, Kodi is the next version of what was formerly named
XBMC. The XBMC package review can be found at:
https://bugzilla.rpmfusion.org/show_bug.cgi?id=1030
Many of the points discussed in the XBMC review still exist in the Kodi package
due to the way the developers of Kodi distribute their software. For example,
there are a number of libraries included in Kodi, but I think they have been
modified such that they are no longer compatible with the system-installed
versions. The package is also a little different because it downloads the Kodi
source code from GitHub using a script included in the package source.
One issue that could be resolved is that the ExcludeArch statement in the RPM
specification does not contain a comment which refers to a bug report. (See
"ExcludeArch" within http://fedoraproject.org/wiki/Packaging:ReviewGuidelines.)
rpmlint:
kodi.x86_64: E: explicit-lib-dependency libbluray
kodi.x86_64: E: explicit-lib-dependency libcrystalhd
kodi.x86_64: E: explicit-lib-dependency libmad
kodi.x86_64: E: explicit-lib-dependency librtmp
kodi.x86_64: W: spelling-error %description -l en_US playlist -> play list,
play-list, pluralist
kodi.x86_64: W: spelling-error %description -l en_US slideshow -> sideshow,
slide show, slide-show
kodi.x86_64: E: incorrect-fsf-address /usr/bin/kodi-standalone
kodi.x86_64: W: devel-file-in-non-devel-package
/usr/share/kodi/addons/library.xbmc.addon/dlfcn-win32.cpp
kodi.x86_64: W: devel-file-in-non-devel-package
/usr/share/kodi/addons/library.xbmc.codec/libXBMC_codec.h
kodi.x86_64: E: incorrect-fsf-address /usr/share/doc/kodi/LICENSE.GPL
kodi.x86_64: W: dangling-symlink
/usr/share/kodi/addons/skin.confluence/fonts/Roboto-Bold.ttf
/usr/share/fonts/google-roboto/Roboto-Bold.ttf
kodi.x86_64: E: non-executable-script
/usr/share/kodi/addons/service.xbmc.versioncheck/lib/viewer.py 0644L
/usr/bin/python
kodi.x86_64: E: non-executable-script
/usr/share/kodi/addons/service.xbmc.versioncheck/service.py 0644L
/usr/bin/python
kodi.x86_64: W: devel-file-in-non-devel-package
/usr/share/kodi/addons/library.xbmc.pvr/libXBMC_pvr.h
kodi.x86_64: W: devel-file-in-non-devel-package
/usr/share/kodi/addons/library.xbmc.addon/dlfcn-win32.h
kodi.x86_64: W: devel-file-in-non-devel-package
/usr/share/kodi/addons/library.xbmc.addon/libXBMC_addon.h
kodi.x86_64: W: dangling-symlink
/usr/share/kodi/addons/skin.confluence/fonts/Roboto-Regular.ttf
/usr/share/fonts/google-roboto/Roboto-Regular.ttf
kodi.x86_64: W: dangling-symlink
/usr/lib64/kodi/addons/script.module.pil/lib/PIL
/usr/lib64/python2.7/site-packages/PIL
kodi.x86_64: E: incorrect-fsf-address /usr/bin/kodi
kodi.x86_64: W: devel-file-in-non-devel-package
/usr/share/kodi/addons/library.xbmc.gui/libXBMC_gui.h
kodi.x86_64: E: incorrect-fsf-address
/usr/share/kodi/addons/service.xbmc.versioncheck/LICENSE.txt
kodi.x86_64: W: no-manual-page-for-binary xbmc-standalone
kodi.x86_64: W: no-manual-page-for-binary xbmc
kodi.x86_64: W: no-manual-page-for-binary kodi-standalone
kodi.x86_64: W: no-manual-page-for-binary kodi
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/xbmc/screensavers/rsxs-0.9/src/resource.hh
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/resid/wave6581__ST.cc
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/xbmc/screensavers/rsxs-0.9/lib/mbchar.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/xbmc/screensavers/rsxs-0.9/lib/mbchar.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/xbmc/screensavers/rsxs-0.9/lib/mbuiter.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/resid/filter.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/buffer_a.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/resid/pot.cc
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/resid/voice.cc
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/filter.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/filter.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/version.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/sflayer.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/optcode.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/xbmc/screensavers/rsxs-0.9/src/solarwinds/wind.cc
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/audio_cnv.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/audio_cnv.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/resid/sid.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/instrum.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/instrum.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/wrdt.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/miditrace.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/miditrace.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/xbmc/interfaces/python/generated/AddonModuleXbmcplugin.cpp
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/xbmc/interfaces/python/generated/AddonModuleXbmc.cpp
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/resid/sid.cc
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/utils/mblock.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/utils/mblock.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/resample.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/nosefart/src/memguard.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/nosefart/src/memguard.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/xbmc/visualizations/Goom/goom2k4-0/src/goomsl_yacc.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/xbmc/visualizations/Goom/goom2k4-0/src/goomsl_yacc.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/libsidplay/src/sidtune/PP20.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/xbmc/visualizations/OpenGLSpectrum/opengl_spectrum.cpp
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/reverb.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/resid/wave8580_PS_.cc
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/reverb.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/xbmc/screensavers/rsxs-0.9/src/euphoria/euphoria.hh
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libexif/IptcParse.cpp
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/libsidplay/include/sidplay/Buffer.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/xbmc/storage/linux/UDevProvider.cpp
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/timidity.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/xbmc/screensavers/rsxs-0.9/src/solarwinds/wind.hh
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/tables.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/tables.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/SlingboxLib/SlingboxLib.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/xbmc/screensavers/rsxs-0.9/src/common.hh
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/nosefart/src/sndhrdw/nes_apu.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/nosefart/src/sndhrdw/nes_apu.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/SlingboxLib/SlingboxLib.cpp
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/quantity.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/quantity.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/nosefart/src/sndhrdw/fds_snd.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/sysdep.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/nosefart/src/sndhrdw/fds_snd.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/resid/envelope.cc
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/resid/filter.cc
kodi-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/kodi-14.0/lib/libUPnP/Platinum/Source/Core/PltConstants.cpp
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/effect.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/xbmc/powermanagement/linux/LogindUPowerSyscall.cpp
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/libsidplay/src/sidtune/SidTuneTools.cpp
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/libsidplay/src/sidtune/prg.cpp
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/nosefart/src/types.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libexif/ExifParse.cpp
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/libsidplay/src/sidtune/PP20_Defs.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/libsidplay/src/sidtune/SidTune.cpp
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/xbmc/screensavers/rsxs-0.9/src/pngimage.cc
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/xbmc/interfaces/python/generated/AddonModuleXbmcgui.cpp
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/libarc/url.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/libarc/url.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/xbmc/windowing/WinEventsX11.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/xbmc/screensavers/rsxs-0.9/src/euphoria/wisp.cc
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/modmid_a.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/xbmc/screensavers/rsxs-0.9/src/color.hh
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/resid/voice.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/mid.defs
kodi-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/kodi-14.0/lib/libUPnP/Neptune/Source/Core/NptTime.cpp
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/resample.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/controls.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/resid/wave8580_P_T.cc
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/libsidplay/src/sidtune/InfoFile.cpp
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libexif/JpegParse.cpp
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/utils/strtab.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/utils/strtab.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/xbmc/screensavers/rsxs-0.9/src/vector.hh
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/wave_a.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/xbmc/screensavers/rsxs-0.9/src/euphoria/euphoria.cc
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/resid/envelope.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/resid/spline.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/resid/extfilt.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/libsidplay/src/sidtune/PP20.cpp
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/sbkconv.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/nosefart/src/cpu/nes6502/nes6502.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/nosefart/src/cpu/nes6502/nes6502.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/readmidi.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/xbmc/screensavers/rsxs-0.9/src/hack.hh
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/resid/wave8580__ST.cc
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/sfitem.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/sfitem.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/xbmc/screensavers/rsxs-0.9/src/solarwinds/solarwinds.cc
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/controls.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/resid/wave6581_P_T.cc
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/xbmc/screensavers/rsxs-0.9/src/plasma/plasma.cc
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/nosefart/src/machine/nsf.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/nosefart/src/machine/nsf.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/resid/extfilt.cc
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/xbmc/interfaces/python/generated/AddonModuleXbmcvfs.cpp
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/recache.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/recache.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/xbmc/screensavers/rsxs-0.9/src/vroot.hh
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/resid/wave6581_PST.cc
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/wrd.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/timidity.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/utils/timer.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/utils/timer.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/xbmc/screensavers/rsxs-0.9/src/common.cc
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/resid/pot.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/xbmc/windowing/WinEventsX11.cpp
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/libarc/url_mem.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/resid/wave6581_PS_.cc
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/xbmc/interfaces/python/generated/AddonModuleXbmcaddon.cpp
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/nosefart/src/sndhrdw/vrc7_snd.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/nosefart/src/sndhrdw/vrc7_snd.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/libsidplay/src/sidtune/MUS.cpp
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/resid/wave8580_PST.cc
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/libsidplay/src/reloc65.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/smplfile.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/freq.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/libsidplay/src/sidtune/SidTuneTools.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/xbmc/screensavers/rsxs-0.9/src/euphoria/wisp.hh
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/freq.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/resid/wave.cc
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/nosefart/src/sndhrdw/vrcvisnd.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/nosefart/src/sndhrdw/vrcvisnd.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/cmyth/libcmyth/utf8tolatin1.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/resid/siddefs.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/xbmc/screensavers/rsxs-0.9/src/solarwinds/solarwinds.hh
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/resid/wave.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/aq.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/playmidi.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/aq.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/playmidi.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/nosefart/src/sndhrdw/mmc5_snd.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/nosefart/src/sndhrdw/mmc5_snd.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/xbmc/screensavers/rsxs-0.9/src/pngimage.hh
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/common.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/common.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/libsidplay/include/sidplay/SidTune.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/xbmc/screensavers/rsxs-0.9/src/color.cc
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/nosefart/src/log.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/nosefart/src/log.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/mix.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/sdl_c.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/mix.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/output.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/output.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity_codec.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/xbmc/guilib/cximage.cpp
kodi-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/kodi-14.0/lib/libUPnP/Platinum/Source/Core/PltConstants.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/libsidplay/src/sidtune/PSID.cpp
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/sffile.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/libarc/url_file.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/readmidi.h
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/timidity/timidity/sffile.c
kodi-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/kodi-14.0/lib/libsidplay2/libsidplay/src/sidtune/p00.cpp
kodi-devel.x86_64: W: no-documentation
kodi-eventclients.x86_64: W: spelling-error %description -l en_US xbmc -> ICBM
kodi-eventclients.x86_64: W: no-documentation
kodi-eventclients.x86_64: E: non-executable-script
/usr/lib/python2.7/site-packages/kodi/xbmcclient.py 0644L /usr/bin/python
kodi-eventclients.x86_64: E: non-executable-script
/usr/lib/python2.7/site-packages/kodi/ps3/sixaxis.py 0644L /usr/bin/python
kodi-eventclients.x86_64: E: non-executable-script
/usr/lib/python2.7/site-packages/kodi/zeroconf.py 0644L /usr/bin/env
kodi-eventclients.x86_64: E: incorrect-fsf-address /usr/bin/kodi-send
kodi-eventclients.x86_64: E: incorrect-fsf-address /usr/bin/kodi-j2meremote
kodi-eventclients.x86_64: W: no-manual-page-for-binary kodi-ps3d
kodi-eventclients.x86_64: W: no-manual-page-for-binary kodi-j2meremote
kodi-eventclients.x86_64: W: no-manual-page-for-binary kodi-wiiremote
kodi-eventclients.x86_64: W: no-manual-page-for-binary kodi-ps3remote
kodi-eventclients.x86_64: W: no-manual-page-for-binary kodi-send
kodi-eventclients-devel.x86_64: W: no-documentation
kodi.src: W: spelling-error %description -l en_US playlist -> play list,
play-list, pluralist
kodi.src: W: spelling-error %description -l en_US slideshow -> sideshow, slide
show, slide-show
kodi.src: W: strange-permission kodi-generate-tarball-xz.sh 0775L
kodi.src:5: W: macro-in-comment %{version}
kodi.src:5: W: macro-in-comment %{PRERELEASE}
kodi.src:334: W: macro-in-comment %{_libdir}
kodi.src:335: W: macro-in-comment %{python_sitearch}
kodi.src:335: W: macro-in-comment %{_libdir}
kodi.src: W: invalid-url Source0: kodi-14.0-patched.tar.xz
6 packages and 0 specfiles checked; 178 errors, 36 warnings.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:03 p.m.
New subject: [Bug 3345] Review request: kodi - Media center
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345
Jonathan Dieter <jdieter(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |jdieter(a)gmail.com
Blocks|2 |3
AssignedTo|rpmfusion-package-review@rp |jdieter(a)gmail.com
|mfusion.org |
--- Comment #7 from Jonathan Dieter <jdieter(a)gmail.com> 2014-12-28 20:03:08 CET ---
Mike P, I'm assuming since you didn't take the bug, you're not actually doing
the formal review, so I'm taking it. Please feel free to take it back if you
want to do the formal review and are already either a Fedora packager or an RPM
Fusion packager.
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable
Major Issues (details in list)
==============================
- Licensing in spec isn't exhaustive
- Bundled libs
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[!]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
The spec doesn't yet acknowledge the multiple licenses, so the breakdown
isn't documented.
[!]: License field in the package spec file matches the actual license.
The licenses listed in the spec are GPLv2+ and GPLv3+, which is just a
subset of the licenses actually listed in the source files. This is
particularly true when the licensing for the bundled libraries is
included. I think this may mean the license should be a combination of
all of the below. *Gulp*
Note: Checking patched sources after %prep for licenses. Licenses found:
"LGPL (v2.1 or later) (with incorrect FSF address)", "LGPL (v2) (with
incorrect FSF address)", "GPL (v2) (with incorrect FSF address)",
"LGPL
(v2 or later) (with incorrect FSF address)", "BSD (2 clause) LGPL (v2 or
later) (with incorrect FSF address)", "LGPL (with incorrect FSF
address)", "ISC", "GPL (v2.1 or later)", "*No
copyright* GPL (v2 or
later)", "*No copyright* MIT/X11 (BSD like)", "PHP (v3.01)",
"*No
copyright* GPL (v2 or later) (with incorrect FSF address)", "LGPL (v2 or
later)", "GPL (v3 or later)", "*No copyright* GPL (v2.1 or
later)",
"Public domain GPL (v2 or later)", "zlib/libpng", "BSD (2
clause) GPL (v2
or later)", "GPL (v2 or later) (with incorrect FSF address)",
"BSD (2
clause)", "Apache (v2.0)", "GPL (with incorrect FSF
address)", "MIT/X11
(BSD like)", "*No copyright* LGPL (v2.1 or later) (with incorrect FSF
address)", "*No copyright* Public domain", "BSD", "BSD
(3 clause)",
"Public domain MIT/X11 (BSD like)", "GPL (v2 or later)",
"BSD (2 clause)
MIT/X11 (BSD like)", "Unknown or generated", "BSD (4
clause)", "BSL
(v1.0)", "LGPL (v2.1 or later)", "GPL (v2)", "MPL
(v1.1) GPL
(unversioned/unknown version) GPL (v2 or later)". 1420 files have unknown
license. Detailed output of licensecheck in attached licensecheck.txt
[!]: Package contains no bundled libraries without FPC exception.
As was the case with xbmc, kodi contains a large number of bundled
libraries. I would really like to see if we can break off a few more of
them, particularly the ones that are already in Fedora. At the very
least, let's split off common libraries that are bundled in the bundled
libraries (i.e. zlib in libupnp).
A small list of libraries I'd really like to see split off:
- libprojectM
- afpfs-ng (might already be used as a system lib, but still in lib dir)
- zlib from libupnp
[!]: License file installed when any subpackage combination is installed.
License file is not installed when kodi-eventclients is installed
[!]: Package consistently uses macros (instead of hard-coded directory names).
In the %build section, two paths are directly specified. Is the spec file
the most appropriate place for these includes?
[!]: Requires correct, justified where necessary.
Manual requires aren't arch-specific. (e.g. we should Require:
libbluray%{?_isa} rather than just Require: libbluray)
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package must own all directories that it creates.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Spec file is legible and written in American English.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
[x]: Package does not contain duplicates in %files.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 122880 bytes in 19 files.
[-]: Each %files section contains %defattr if rpm < 4.4
Python:
[x]: Package meets the Packaging Guidelines::Python
[x]: Binary eggs must be removed in %prep
[-]: Python eggs must not download any dependencies during the build process.
[-]: A package which is used by another package via an egg interface should
provide egg info.
===== SHOULD items =====
Generic:
[!]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in kodi-devel
, kodi-eventclients , kodi-eventclients-devel
[!]: Install man pages for binaries
Man pages are available, but not installed properly. Instead, they are
currently listed as %doc
[!]: Package should compile and build into binary rpms on all supported
architectures.
Is there a reason we have ExcludeArch: ppc64?
[x]: Avoid bundling fonts in non-fonts packages.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: SourceX tarball generation or download is documented.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[-]: %check is present and all tests pass.
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
===== EXTRA items =====
Generic:
[!]: Large data in /usr/share should live in a noarch subpackage if package is
arched.
Not sure if 47MB is worth the effort of splitting this into a noarch
package.
Note: Arch-ed rpms have a total of 47022080 bytes in /usr/share
kodi-14.0-1.fc21.x86_64.rpm:47001600
See:
http://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_G...
[!]: Package should not use obsolete m4 macros
I don't consider these showstoppers, but thought they should be listed
Note: Some obsoleted macros found, see end of comment.
See: https://fedorahosted.org/FedoraReview/wiki/AutoTools
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
AutoTools: Obsoleted m4s found
------------------------------
AM_PROG_LIBTOOL found in:
kodi-14.0/xbmc/visualizations/Goom/goom2k4-0/configure.in:8
AC_PROG_LIBTOOL found in: kodi-14.0/lib/gtest/configure.ac:30,
kodi-14.0/lib/libdvd/libdvdnav/configure.ac:100,
kodi-14.0/lib/cpluff/configure.ac:63,
kodi-14.0/lib/cpluff/examples/configure.ac:31, kodi-14.0/configure.in:588
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:04 p.m.
New subject: [Bug 3345] Review request: kodi - Media center
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345
--- Comment #8 from Jonathan Dieter <jdieter(a)gmail.com> 2014-12-28 20:04:10 CET ---
Created attachment 1377
--> https://bugzilla.rpmfusion.org/attachment.cgi?id=1377
License details on a file by file basis
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
7:04 p.m.
New subject: [Bug 3345] Review request: kodi - Media center
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345
--- Comment #9 from Jonathan Dieter <jdieter(a)gmail.com> 2014-12-28 20:04:54 CET ---
Created attachment 1378
--> https://bugzilla.rpmfusion.org/attachment.cgi?id=1378
RPM lint output
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
7:12 p.m.
New subject: [Bug 3345] Review request: kodi - Media center
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345
--- Comment #10 from Jonathan Dieter <jdieter(a)gmail.com> 2014-12-28 20:12:49 CET
---
(In reply to comment #7)
[!]: Package contains no bundled libraries without FPC exception.
As was the case with xbmc, kodi contains a large number of bundled
libraries. I would really like to see if we can break off a few more of
them, particularly the ones that are already in Fedora. At the very
least, let's split off common libraries that are bundled in the bundled
libraries (i.e. zlib in libupnp).
A small list of libraries I'd really like to see split off:
- libprojectM
- afpfs-ng (might already be used as a system lib, but still in lib dir)
- zlib from libupnp
Just wanted to add two obvious bundled libs that I believe may already be used
as system libs, but are still in the lib dir:
- libcec
- libdvd
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
9:03 p.m.
New subject: [Bug 3345] Review request: kodi - Media center
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345
--- Comment #11 from Michael Cronenworth <mike(a)cchtml.com> 2014-12-28 22:03:33 CET
---
(In reply to comment #10)
> A small list of libraries I'd really like to see split
off:
> - libprojectM
> - afpfs-ng (might already be used as a system lib, but still in lib dir)
> - zlib from libupnp
Just wanted to add two obvious bundled libs that I believe may already be used
as system libs, but are still in the lib dir:
- libcec
- libdvd
The bundled libprojectM is forked from version 1.2. The version in Fedora is
2.0. There's a reason they call it "XBMCProjectM".
The afpfs-ng, libcec, libdvdread, and zlib packages from Fedora are already
being used.
Please note that licensecheck will list files that are conditionally compiled
for Windows, OS X, or Android/ARM. The GPL is the main license that everything
will fall under. Since some of the code is compiled into libraries
(/usr/lib/kodi/system) I will include the licenses for them and the license
files for eventclients.
In regards to arched-Requires: This package is not multi-lib.
http://michael.cronenworth.com/RPMS/kodi.spec
http://michael.cronenworth.com/RPMS/kodi-14.0-1.1.fc21.src.rpm
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
9:37 p.m.
New subject: [Bug 3345] Review request: kodi - Media center
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345
--- Comment #12 from Jonathan Dieter <jdieter(a)gmail.com> 2014-12-28 22:37:15 CET
---
(In reply to comment #11)
The bundled libprojectM is forked from version 1.2. The version in
Fedora is
2.0. There's a reason they call it "XBMCProjectM".
Ok, fair enough.
The afpfs-ng, libcec, libdvdread, and zlib packages from Fedora are
already
being used.
That's great, but I think it would be good to actually remove them from the
generated source tree, if for no other reasons than to guarantee that they
aren't being built.
Please note that licensecheck will list files that are conditionally
compiled
for Windows, OS X, or Android/ARM. The GPL is the main license that everything
will fall under. Since some of the code is compiled into libraries
(/usr/lib/kodi/system) I will include the licenses for them and the license
files for eventclients.
Thank you. This looks good now.
In regards to arched-Requires: This package is not multi-lib.
Maybe not, but the libraries are multi-lib. If, for some strange reason, I
have libcec.i686 installed, but not libcec.x86_64, installing kodi won't bring
in libcec.x86_64. The manual requires need to have arched-Requires.
You could argue that
http://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package
doesn't apply to kodi's devel packages because they're not multi-lib, but
I'd
probably do it anyway, just to be safe.
Apart from all that, do you have thoughts on the man pages and the ExcludeArch?
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
3:38 a.m.
New subject: [Bug 3345] Review request: kodi - Media center
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345
--- Comment #13 from Michael Cronenworth <mike(a)cchtml.com> 2014-12-29 04:38:53 CET
---
(In reply to comment #12)
That's great, but I think it would be good to actually remove
them from the
generated source tree, if for no other reasons than to guarantee that they
aren't being built.
The Kodi build system expects the autotools files to be present even if we're
not compiling them. I'd rather not patch the autotools files as these will
constantly change. This is different from the past (pre-Kodi) where we could
drop the code.
Maybe not, but the libraries are multi-lib. If, for some strange
reason, I
have libcec.i686 installed, but not libcec.x86_64, installing kodi won't bring
in libcec.x86_64. The manual requires need to have arched-Requires.
For the sake of getting this reviewed I've changed them.
Apart from all that, do you have thoughts on the man pages and the
ExcludeArch?
The ExcludeArch stays. Upstream does not support it. The man pages have been
moved.
http://michael.cronenworth.com/RPMS/kodi.spec
http://michael.cronenworth.com/RPMS/kodi-14.0-1.2.fc21.src.rpm
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
8:09 a.m.
New subject: [Bug 3345] Review request: kodi - Media center
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345
--- Comment #14 from Dan Horák <dan(a)danny.cz> 2014-12-29 09:09:17 CET ---
please switch to ExclusiveArch, there are many more arches in Fedora land where
kodi won't built or work
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
8:32 a.m.
New subject: [Bug 3345] Review request: kodi - Media center
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345
--- Comment #15 from Jonathan Dieter <jdieter(a)gmail.com> 2014-12-29 09:32:37 CET
---
(In reply to comment #14)
please switch to ExclusiveArch, there are many more arches in Fedora
land where
kodi won't built or work
That's up to Michael, but it seems to conflict with
http://fedoraproject.org/wiki/Architectures#ExcludeArch_.26_ExclusiveArch
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
8:34 a.m.
New subject: [Bug 3345] Review request: kodi - Media center
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345
--- Comment #16 from Jonathan Dieter <jdieter(a)gmail.com> 2014-12-29 09:34:39 CET
---
(In reply to comment #13)
(In reply to comment #12)
> That's great, but I think it would be good to actually remove them from the
> generated source tree, if for no other reasons than to guarantee that they
> aren't being built.
The Kodi build system expects the autotools files to be present even if we're
not compiling them. I'd rather not patch the autotools files as these will
constantly change. This is different from the past (pre-Kodi) where we could
drop the code.
> Maybe not, but the libraries are multi-lib. If, for some strange reason, I
> have libcec.i686 installed, but not libcec.x86_64, installing kodi won't bring
> in libcec.x86_64. The manual requires need to have arched-Requires.
For the sake of getting this reviewed I've changed them.
Thank you. This looks good.
> Apart from all that, do you have thoughts on the man pages and
the ExcludeArch?
The ExcludeArch stays. Upstream does not support it. The man pages have been
moved.
Ok. Thanks for moving the man pages
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
8:38 a.m.
New subject: [Bug 3345] Review request: kodi - Media center
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345
T.C. Hollingsworth <tchollingsworth(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tchollingsworth(a)gmail.com
--- Comment #17 from T.C. Hollingsworth <tchollingsworth(a)gmail.com> 2014-12-29
09:38:32 CET ---
(In reply to comment #13)
The Kodi build system expects the autotools files to be present even
if we're
not compiling them. I'd rather not patch the autotools files as these will
constantly change. This is different from the past (pre-Kodi) where we could
drop the code.
You can do something like:
find path/to/bundled/dep -name "*.c" -exec rm -f {} \;
find path/to/bundled/dep -name "*.h" -exec rm -f {} \;
in %prep to nuke the source files but leave the autocrap. This shouldn't break
the build, but it will leave the reviewer confident that these bundled
libraries are not used. :-)
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
8:41 a.m.
New subject: [Bug 3345] Review request: kodi - Media center
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345
--- Comment #18 from Jonathan Dieter <jdieter(a)gmail.com> 2014-12-29 09:41:56 CET
---
Reassessment of failed items:
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable
Major Issues (details in list)
==============================
===== MUST items =====
Generic:
[x]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[x]: License field in the package spec file matches the actual license.
[x]: Package contains no bundled libraries without FPC exception.
I'm going to call this a pass now because the remaining bundled libraries
have been heavily forked by xbmc.
[x]: License file installed when any subpackage combination is installed.
[x]: Requires correct, justified where necessary.
Manual requires aren't arch-specific. (e.g. we should Require:
libbluray%{?_isa} rather than just Require: libbluray)
===== SHOULD items =====
Generic:
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Install man pages for binaries
[x]: Package should compile and build into binary rpms on all supported
architectures.
xbmc doesn't work on ppc64, thus the ExcludeArch
===== EXTRA items =====
Generic:
[!]: Large data in /usr/share should live in a noarch subpackage if package is
arched.
Still not split, but not a blocker and probably not worth the effort
[!]: Package should not use obsolete m4 macros
Not a blocker
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
8:42 a.m.
New subject: [Bug 3345] Review request: kodi - Media center
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345
--- Comment #19 from Jonathan Dieter <jdieter(a)gmail.com> 2014-12-29 09:42:54 CET
---
(In reply to comment #17)
(In reply to comment #13)
> The Kodi build system expects the autotools files to be present even if we're
> not compiling them. I'd rather not patch the autotools files as these will
> constantly change. This is different from the past (pre-Kodi) where we could
> drop the code.
You can do something like:
find path/to/bundled/dep -name "*.c" -exec rm -f {} \;
find path/to/bundled/dep -name "*.h" -exec rm -f {} \;
in %prep to nuke the source files but leave the autocrap. This shouldn't break
the build, but it will leave the reviewer confident that these bundled
libraries are not used. :-)
Michael, it would nice if you implemented this, but I'm not going to call it a
requirement.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
8:43 a.m.
New subject: [Bug 3345] Review request: kodi - Media center
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345
Jonathan Dieter <jdieter(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|3 |4
--- Comment #20 from Jonathan Dieter <jdieter(a)gmail.com> 2014-12-29 09:43:43 CET
---
This package is approved!
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
3:14 p.m.
New subject: [Bug 3345] Review request: kodi - Media center
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345
--- Comment #21 from Michael Cronenworth <mike(a)cchtml.com> 2014-12-29 16:14:18 CET
---
(In reply to comment #17)
You can do something like:
find path/to/bundled/dep -name "*.c" -exec rm -f {} \;
find path/to/bundled/dep -name "*.h" -exec rm -f {} \;
in %prep to nuke the source files but leave the autocrap. This shouldn't break
the build, but it will leave the reviewer confident that these bundled
libraries are not used. :-)
That will not work because the source is downloaded during the build if the
library is not found. The code I was referring to is code that is not even
built (Android, Win32 files).
The reviewer should be performing a test build (normally a scratch build in
Fedora reviews) to verify what is and is not built.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
3:18 p.m.
New subject: [Bug 3345] Review request: kodi - Media center
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345
--- Comment #22 from Michael Cronenworth <mike(a)cchtml.com> 2014-12-29 16:18:14 CET
---
Package CVS request
======================
Package Name: kodi
Short Description: Media center
Owners: mooninite,ktdreyer
Branches: F-21
InitialCC:
----------------------
License tag: free
Thanks for the review.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
3:18 p.m.
New subject: [Bug 3345] Review request: kodi - Media center
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345
Michael Cronenworth <mike(a)cchtml.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |33
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
6:07 p.m.
New subject: [Bug 3345] Review request: kodi - Media center
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345
Mohamed El Morabity <pikachu.2014(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |3478
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
2:11 p.m.
New subject: [Bug 3345] Review request: kodi - Media center
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345
Nicolas Chauvet <kwizart(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|33 |
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
4:17 p.m.
New subject: [Bug 3345] Review request: kodi - Media center
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345
Michael Cronenworth <mike(a)cchtml.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #23 from Michael Cronenworth <mike(a)cchtml.com> 2014-12-30 17:17:39 CET
---
Package imported and built.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
11:51 a.m.
New subject: [Bug 3345] Review request: kodi - Media center
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345
javiermon(a)gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |javiermon(a)gmail.com
--- Comment #24 from javiermon(a)gmail.com 2015-01-02 12:51:15 CET ---
How long does it take to build a package in rpmfusion repo?
http://download1.rpmfusion.org/free/fedora/updates/testing/21/x86_64/repo...
only shows rpms from the 2014/12/30
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
1:39 p.m.
New subject: [Bug 3345] Review request: kodi - Media center
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345
--- Comment #25 from Jonathan Dieter <jdieter(a)gmail.com> 2015-01-05 14:39:48 CET
---
Created attachment 1383
--> https://bugzilla.rpmfusion.org/attachment.cgi?id=1383
Patch to convert dirs to symlinks during upgrade
Unfortunately, I've found a major problem when trying to upgrade to this
package. If you attempt to run yum --enablerepo=rpmfusion*updates-testing
update xbmc, you'll get a couple of file conflicts. This is because
/usr/share/xbmc and /usr/lib64/xbmc are directories in the xbmc package, but
symlinks in the kodi package.
Rpm doesn't handle directories turning into symlinks properly, so we have add
some scriptlets to make an update work. See
https://fedoraproject.org/wiki/Packaging:Guidelines#Replacing_a_symlink_t...
and
https://fedoraproject.org/wiki/Packaging:Directory_Replacement#Scriptlet_....
The attached patch applies against the 14.0-1.3 spec and adds the necessary
scriplets.
Apologies for not catching this during the review.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
9:09 p.m.
New subject: [Bug 3345] Review request: kodi - Media center
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345
--- Comment #26 from Nicolas Chauvet <kwizart(a)gmail.com> 2015-01-05 22:09:10 CET
---
(In reply to comment #25)
Created attachment 1383 [details]
Patch to convert dirs to symlinks during upgrade
Why do we have to handle the
symlink in the first step ?
Can we simply drop the symlink ?, packaged plugins will be renamed anyway, so
this may introduce issues when xbmc-pvr will be renamed and then the package
upgraded.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
9:40 p.m.
New subject: [Bug 3345] Review request: kodi - Media center
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345
--- Comment #27 from Jonathan Dieter <jdieter(a)gmail.com> 2015-01-05 22:40:13 CET
---
(In reply to comment #26)
(In reply to comment #25)
> Created attachment 1383 [details]
> Patch to convert dirs to symlinks during upgrade
Why do we have to handle the symlink in the first step ?
Can we simply drop the symlink ?, packaged plugins will be renamed anyway, so
this may introduce issues when xbmc-pvr will be renamed and then the package
upgraded.
Good point. If the symlinks aren't actually needed by Kodi, I would +1 just
removing them.
To address your specific issue, I don't see how kodi-pvr will have any problems
as it should install everything into /usr/share/kodi and %{_libdir}/kodi, but
updating xbmc to kodi while not updating xbmc-pvr to kodi-pvr would leave
xbmc-pvr missing a whole bunch of files. Either way, it's an ugly mess best
dealt with by removing the symlinks if we can.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
10:01 p.m.
New subject: [Bug 3345] Review request: kodi - Media center
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345
--- Comment #28 from Michael Cronenworth <mike(a)cchtml.com> 2015-01-05 23:01:12 CET
---
Upstream provides the symlinks presumably for compatibility with add-ons and
other third-party applications that will still look for "xbmc" and are not
controlled by upstream.
The patch does not fix the problem entirely. I will be pushing an update once I
have time to perform testing.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
10:39 p.m.
New subject: [Bug 3345] Review request: kodi - Media center
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345
--- Comment #29 from Nicolas Chauvet <kwizart(a)gmail.com> 2015-01-05 23:39:29 CET
---
(In reply to comment #28)
Upstream provides the symlinks presumably for compatibility with
add-ons and
what means "presumably" in this context ?
Introducing a symlink I can't see how kodi in pretrans will not mess with
xbmc-pvr-plugins and it's capability to properly upgrade to kodi-pvr-plugins
without the whole xmbc-pvr-plugins staying behind as un-handled directory.
Best would be to move from directory to %ghost instead, and to handle the
remaining files in %posttrans if any.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
3:58 a.m.
New subject: [Bug 3345] Review request: kodi - Media center
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345
--- Comment #30 from Michael Cronenworth <mike(a)cchtml.com> 2015-01-06 04:58:29 CET
---
(In reply to comment #28)
what means "presumably" in this context ?
XBMC has been the name for 13 years and there are thousands of addons made
specifically for XBMC. Some may have hard-coded paths so as a path of
transition they have left symlinks to "xbmc". I bet the symlinks will be gone
with Kodi 15.0.
Best would be to move from directory to %ghost instead, and to handle
the
remaining files in %posttrans if any.
Yes, that's what I was going to do.
A new build has been pushed to handle the XBMC->Kodi upgrade. This will make
everything painless.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
3642
days inactive
3777
days old
rpmfusion-developers@lists.rpmfusion.org
34 comments
1 participants
participants (1)
-
RPM Fusion Bugzilla