https://bugzilla.rpmfusion.org/show_bug.cgi?id=6891 Bug ID: 6891 Summary: Review request: makemkv - DVD and Blu-ray to MKV converter Product: Package Reviews Version: Current Hardware: All OS: GNU/Linux Status: NEW Severity: enhancement Priority: P1 Component: Review Request Assignee: rpmfusion-package-review(a)rpmfusion.org Reporter: siliconwaffle(a)trilbyproject.org CC: rpmfusion-package-review(a)rpmfusion.org namespace: nonfree SPEC: https://raw.githubusercontent.com/siliconwaffle/makemkv/main/makemkv.spec SRPM: https://get.station307.com/T94vXAtrAt3/makemkv-1.17.6-1.fc39.src.rpm Description: MakeMKV is your one-click solution to convert video that you own into free and patents-unencumbered format that can be played everywhere. MakeMKV is a format converter, otherwise called "transcoder". It converts the video clips from proprietary (and usually encrypted) disc into a set of MKV files, preserving most information but not changing it in any way. The MKV format can store multiple video/audio tracks with all meta-information and preserve chapters. There are many players that can play MKV files nearly on all platforms, and there are tools to convert MKV files to many formats, including DVD and Blu-ray discs. Additionally MakeMKV can instantly stream decrypted video without intermediate conversion to wide range of players, so you may watch Blu-ray and DVD discs with your favorite player on your favorite OS or on your favorite device. This package is not eligible to be included in Fedora because it includes makemkvcon which is commercial, closed source software and is bound to a EULA. rpmlint outputs: rpmlint ~/rpmbuild/SRPMS/makemkv-1.17.6-1.fc39.src.rpm ================================================================================= rpmlint session starts ================================================================================= rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 makemkv.src: E: spelling-error ('transcoder', '%description -l en_US transcoder -> trans coder, trans-coder, transponder') makemkv.src: E: spelling-error ('decrypted', '%description -l en_US decrypted -> encrypted') makemkv.src: W: invalid-license GuinpinSoft Inc EULA makemkv.src: E: description-line-too-long MakeMKV is your one-click solution to convert video that you own into free and patents-unencumbered format that can be played everywhere. MakeMKV is a format converter, otherwise called "transcoder". It converts the video clips from proprietary (and usually encrypted) disc into a set of MKV files, preserving most information but not changing it in any way. The MKV format can store multiple video/audio tracks with all meta-information and preserve chapters. There are many players that can play MKV files nearly on all platforms, and there are tools to convert MKV files to many formats, including DVD and Blu-ray discs. makemkv.src: E: description-line-too-long Additionally MakeMKV can instantly stream decrypted video without intermediate conversion to wide range of players, so you may watch Blu-ray and DVD discs with your favorite player on your favorite OS or on your favorite device. ============================================ 1 packages and 0 specfiles checked; 4 errors, 1 warnings, 5 filtered, 4 badness; has taken 0.5 s ============================================ For the two spelling errors, I chose to ignore them because 1. The description that contains them is copy/pasted directly from makemkv.com and 2. They are technically not even misspellings, I found them in online dictionaries. As for the invalid license, that's just the name of the EULA which bounds users of the software, perhaps I'm supposed to use the term 'commercial' or 'proprietary', however I have not found any documentation that would lead me to believe that using the name of the EULA is invalid. Also, from what I've read on the makemkv forum, upstream wishes that the EULA be acknowledged very plainly to users since the packaging process bypass the agreement to the EULA phase of installation in order to automate the process. For the description being too long, I chose to ignore this because it still builds just fine in mock and because to break the description up into smaller bits wouldn't look very clean, it's just messy and I believe it to be unnecessary(but perhaps I am wrong and it is really necessary). rpmlint /var/lib/mock/fedora-39-x86_64/result/makemkv-libs-1.17.6-1.fc39.x86_64.rpm ================================================================================= rpmlint session starts ================================================================================= rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 makemkv-libs.x86_64: E: shared-library-not-executable /usr/lib64/libdriveio.so.0 makemkv-libs.x86_64: E: shared-library-not-executable /usr/lib64/libmakemkv.so.1 makemkv-libs.x86_64: E: shared-library-not-executable /usr/lib64/libmmbd.so.0 makemkv-libs.x86_64: W: invalid-license GuinpinSoft Inc EULA =========================================== 1 packages and 0 specfiles checked; 3 errors, 1 warnings, 15 filtered, 3 badness; has taken 0.2 s ============================================ I did make an attempt to patch the makefile in order to fix the library permissions but so far I have been unsuccessful. It would appear that mock gets very confused when I give it 2 source tarballs and becomes even more confused when I attempt to pass a patch as well, so trying to get mock to actually apply the patch correctly has been troublesome. Ultimately, I only decided to leave it as is because the libraries do still appear to function properly. I have been in contact with the developer who wrote the thing so I'll shoot him an email about this and a couple other issues I've encountered. I've already addressed the invalid license error. rpmlint /var/lib/mock/fedora-39-x86_64/result/makemkvcon-1.17.6-1.fc39.x86_64.rpm ================================================================================= rpmlint session starts ================================================================================= rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 makemkvcon.x86_64: E: spelling-error ('cli', 'Summary(en_US) cli -> cl, clii, clit') makemkvcon.x86_64: E: spelling-error ('cli', '%description -l en_US cli -> cl, clii, clit') makemkvcon.x86_64: W: position-independent-executable-suggested /usr/bin/makemkvcon makemkvcon.x86_64: W: no-manual-page-for-binary makemkvcon makemkvcon.x86_64: W: no-manual-page-for-binary mmccextr makemkvcon.x86_64: W: no-manual-page-for-binary mmgplsrv makemkvcon.x86_64: W: no-manual-page-for-binary sdftool makemkvcon.x86_64: W: no-documentation makemkvcon.x86_64: W: invalid-license GuinpinSoft Inc EULA ============================================ 1 packages and 0 specfiles checked; 2 errors, 7 warnings, 4 filtered, 2 badness; has taken 0.4 s ============================================ For the two spelling errors, those aren't really spelling errors, just abbreviations. As for the position independent executable error, from what I understand this is addressed during compilation and this executable is distributed as is, not with source code. This will be one of the issues that I notify upstream about so it can hopefully be addressed before his next planned release. I chose to ignore the missing documentation and no manual-page errors because there is no publicly available up-to-date documentation, I've only been able to find docs that are close to a decade old now. I will eventually write documentation to distribute as I use and learn the software. rpmlint /var/lib/mock/fedora-39-x86_64/result/makemkv-1.17.6-1.fc39.x86_64.rpm ================================================================================= rpmlint session starts ================================================================================= rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 makemkv.x86_64: E: spelling-error ('transcoder', '%description -l en_US transcoder -> trans coder, trans-coder, transponder') makemkv.x86_64: E: spelling-error ('decrypted', '%description -l en_US decrypted -> encrypted') makemkv.x86_64: W: no-manual-page-for-binary makemkv makemkv.x86_64: W: no-documentation makemkv.x86_64: W: invalid-license GuinpinSoft Inc EULA makemkv.x86_64: E: description-line-too-long MakeMKV is your one-click solution to convert video that you own into free and patents-unencumbered format that can be played everywhere. MakeMKV is a format converter, otherwise called "transcoder". It converts the video clips from proprietary (and usually encrypted) disc into a set of MKV files, preserving most information but not changing it in any way. The MKV format can store multiple video/audio tracks with all meta-information and preserve chapters. There are many players that can play MKV files nearly on all platforms, and there are tools to convert MKV files to many formats, including DVD and Blu-ray discs. makemkv.x86_64: E: description-line-too-long Additionally MakeMKV can instantly stream decrypted video without intermediate conversion to wide range of players, so you may watch Blu-ray and DVD discs with your favorite player on your favorite OS or on your favorite device. ============================================ 1 packages and 0 specfiles checked; 4 errors, 3 warnings, 3 filtered, 4 badness; has taken 0.4 s ============================================ I have already addressed every error presented in here. This is my first package submission to RPM Fusion, and I have never submitted a package to Fedora before(however I do plan to do so in the next few days). I am fully prepared to actively maintain every package I submit, without patching since I am not fluent in any coding language. I am also seeking a sponsor. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.