10:04 p.m.
http://bugzilla.rpmfusion.org/show_bug.cgi?id=803
Summary: Review request: openafs-kmod - Kernel Modules
Product: Package Reviews
Version: Current
Platform: All
OS/Version: GNU/Linux
Status: NEW
Severity: normal
Priority: P5
Component: Review Request
AssignedTo: rpmfusion-package-review(a)rpmfusion.org
ReportedBy: jjneely(a)ncsu.edu
CC: rpmfusion-package-review(a)rpmfusion.org
Blocks: 2
Estimated Hours: 0.0
This is the matching kernel module for the OpenAFS packages.
http://www4.ncsu.edu/~jjneely/SPECS/openafs-kmod.spec
http://www4.ncsu.edu/~jjneely/SRPMS/openafs-kmod-1.4.11-1.fc11.src.rpm
$ rpmlint openafs-kmod-1.4.11-1.fc11.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint kmod-openafs-1.4.11-1.fc11.i586.rpm
kmod-openafs.i586: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
$ rpmlint kmod-openafs-2.6.29.6-217.2.16.fc11.i686.PAE-1.4.11-1.fc11.i686.rpm
kmod-openafs-2.6.29.6-217.2.16.fc11.i686.PAE.i686: W: summary-not-capitalized
openafs kernel module(s) for 2.6.29.6-217.2.16.fc11.i686.PAE
kmod-openafs-2.6.29.6-217.2.16.fc11.i686.PAE.i686: W:
unstripped-binary-or-object
/lib/modules/2.6.29.6-217.2.16.fc11.i686.PAE/extra/openafs/openafs.ko
kmod-openafs-2.6.29.6-217.2.16.fc11.i686.PAE.i686: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
I believe the above rpmlintage is pretty normal for kmods.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:23 p.m.
New subject: [Bug 803] Review request: openafs-kmod - Kernel Modules
http://bugzilla.rpmfusion.org/show_bug.cgi?id=803
Thorsten Leemhuis <fedora(a)leemhuis.info> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|2 |3
Status|NEW |ASSIGNED
--- Comment #1 from Thorsten Leemhuis <fedora(a)leemhuis.info> 2009-10-21 22:23:52
---
hmmm, it takes quite a while to build this kmod package; is everything done by
the spec file strictly needed? Isn't there some shortcut to build just the
module directly? That would help akmod users quite a lot...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:24 p.m.
New subject: [Bug 803] Review request: openafs-kmod - Kernel Modules
http://bugzilla.rpmfusion.org/show_bug.cgi?id=803
Thorsten Leemhuis <fedora(a)leemhuis.info> changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|rpmfusion-package- |fedora(a)leemhuis.info
|review(a)rpmfusion.org |
Status|ASSIGNED |NEW
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
4:18 a.m.
New subject: [Bug 803] Review request: openafs-kmod - Kernel Modules
http://bugzilla.rpmfusion.org/show_bug.cgi?id=803
--- Comment #2 from Jack Neely <jjneely(a)ncsu.edu> 2009-10-22 06:18:21 ---
The spec file is using the short cut, amazingly. OpenAFS is big, slow to
build, and all around fun to maintain.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
4:08 p.m.
New subject: [Bug 803] Review request: openafs-kmod - Kernel Modules
http://bugzilla.rpmfusion.org/show_bug.cgi?id=803
Jochen Schmitt <Jochen(a)herr-schmitt.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |Jochen(a)herr-schmitt.de
Status|NEW |ASSIGNED
--- Comment #3 from Jochen Schmitt <Jochen(a)herr-schmitt.de> 2009-10-28 17:08:00
---
During the local build I will get the following output:
$ rpmbuild -ba openafs-kmod.spec
Ausführung(%prep): /bin/sh -e /var/tmp/rpm-tmp.7xzp9S
+ umask 022
+ cd /home/s4504kr/rpmbuild/BUILD
+ LANG=C
+ export LANG
+ unset DISPLAY
+ kmodtool --target x86_64 --repo '%{repo}' --kmodname openafs-kmod --newest
%define kmodtool_check echo "kmodtool error:
buildsys-build-%{repo}-kerneldevpkgs not found"; exit 2;
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
5:01 p.m.
New subject: [Bug 803] Review request: openafs-kmod - Kernel Modules
http://bugzilla.rpmfusion.org/show_bug.cgi?id=803
--- Comment #4 from Jack Neely <jjneely(a)ncsu.edu> 2009-10-28 18:01:12 ---
(In reply to comment #3)
During the local build I will get the following output:
$ rpmbuild -ba openafs-kmod.spec
Ausführung(%prep): /bin/sh -e /var/tmp/rpm-tmp.7xzp9S
+ umask 022
+ cd /home/s4504kr/rpmbuild/BUILD
+ LANG=C
+ export LANG
+ unset DISPLAY
+ kmodtool --target x86_64 --repo '%{repo}' --kmodname openafs-kmod --newest
%define kmodtool_check echo "kmodtool error:
buildsys-build-%{repo}-kerneldevpkgs not found"; exit 2;
You'll need to build in mock with the proper buildsys-build-rpmfusion meta
package (which is pulled in by buildsys-build).
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
6:08 p.m.
New subject: [Bug 803] Review request: openafs-kmod - Kernel Modules
http://bugzilla.rpmfusion.org/show_bug.cgi?id=803
--- Comment #5 from Jochen Schmitt <Jochen(a)herr-schmitt.de> 2009-11-02 19:08:21
---
I have tried out a
$ mock -r rpmfusion-devel-x86_64 openafs-kmod-1.4.11-1.fc11.src.rpm
without any success.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
6:22 p.m.
New subject: [Bug 803] Review request: openafs-kmod - Kernel Modules
http://bugzilla.rpmfusion.org/show_bug.cgi?id=803
--- Comment #6 from Jack Neely <jjneely(a)ncsu.edu> 2009-11-02 19:22:45 ---
It builds in my mock with
--define "repo rpmfusion"
Thorsten, can you confirm this is correct or foobar?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
6:37 p.m.
New subject: [Bug 803] Review request: openafs-kmod - Kernel Modules
http://bugzilla.rpmfusion.org/show_bug.cgi?id=803
--- Comment #7 from Jochen Schmitt <Jochen(a)herr-schmitt.de> 2009-11-02 19:37:56
---
I have make a compare with the nvidia kernel module.
On the nvidia kmod I couldn't found any occurence of the %{repo} macro, so I
have replace it with 'rpmfusion' on your SPEC file. After I have done it, the
build works fine.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
8:17 p.m.
New subject: [Bug 803] Review request: openafs-kmod - Kernel Modules
http://bugzilla.rpmfusion.org/show_bug.cgi?id=803
--- Comment #8 from Thorsten Leemhuis <fedora(a)leemhuis.info> 2009-11-02 21:17:42
---
(In reply to comment #6)
It builds in my mock with
--define "repo rpmfusion"
Thorsten, can you confirm this is correct or foobar?
This is how it could work in a world where one kmod spec file is used by
different repos, but actually that's not the case so it's likely better and
easier for everyone if we just hardcode "rpmfusion" in the spec file for now.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
9:21 p.m.
New subject: [Bug 803] Review request: openafs-kmod - Kernel Modules
http://bugzilla.rpmfusion.org/show_bug.cgi?id=803
--- Comment #9 from Jack Neely <jjneely(a)ncsu.edu> 2009-11-02 22:21:20 ---
http://www4.ncsu.edu/~jjneely/SPECS/openafs-kmod-1.4.11-3.fc11.spec
http://www4.ncsu.edu/~jjneely/SRPMS/openafs-kmod-1.4.11-3.fc11.src.rpm
The repo macro has been removed in favor of hard coding in 'rpmfusion'
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
6:19 p.m.
New subject: [Bug 803] Review request: openafs-kmod - Kernel Modules
http://bugzilla.rpmfusion.org/show_bug.cgi?id=803
--- Comment #10 from Jochen Schmitt <Jochen(a)herr-schmitt.de> 2009-11-03 19:19:21
---
Good:
+ Package name fullfill naming guidelines
+ URL tag shows on proper project homepage
+ Package contains most recent stabel release of the application
+ License tag states IBM as a valid OSS License
+ Package has proper BuildRoot definition
+ Could downloading package via spectool -g
+ Packaged tar ball matches with upstream
(md5sum: 8375721949e33a91aa62e006f2ba7b3e)
+ Local build works fine
+ Rpmlint is quite for source rpm
+ Rpmlint is quite for binary packages
+ Rpmlint is quite for debuginfo packages
+ Buildroot will be cleaned at the beginning fo %clean and %install
+ Mock build works fine
+ All files are owned by the package
+ Package files has proper file permissions
+ Package has proper ChangeLog
Bad:
- Please take a more verbose summary text for the package
- IBM Public license is not compatible the the license used
for the Linux kernel. So we need a clarification to which
repository we should put your package.
- Package doesn't contains verbatin copy of the license
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
7:15 p.m.
New subject: [Bug 803] Review request: openafs-kmod - Kernel Modules
http://bugzilla.rpmfusion.org/show_bug.cgi?id=803
--- Comment #11 from Jochen Schmitt <Jochen(a)herr-schmitt.de> 2009-11-03 20:15:17
---
Good:
+ On rpmfusion-devel we have clarified, that this package should go to the ree
repo.
Bad:
- I have got the following error messages during installing of the package:
$ sudo rpm -Uvh kmod-openafs-1.4.11-3.fc11.x86_64.rpm
kmod-openafs-2.6.30.9-90.fc11.x86_64-1.4.11-3.fc11.x86_64.rpm
Fehler: Fehlgeschlagende Abhängigkeiten:
openafs-kmod-common >= 1.4.11 wird benötigt von
kmod-openafs-2.6.30.9-90.fc11.x86_64-1.4.11-3.fc11.x86_64
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
7:28 p.m.
New subject: [Bug 803] Review request: openafs-kmod - Kernel Modules
http://bugzilla.rpmfusion.org/show_bug.cgi?id=803
--- Comment #12 from Thorsten Leemhuis <fedora(a)leemhuis.info> 2009-11-03 20:28:55
---
(In reply to comment #11)
Bad:
- I have got the following error messages during installing of the package:
$ sudo rpm -Uvh kmod-openafs-1.4.11-3.fc11.x86_64.rpm
kmod-openafs-2.6.30.9-90.fc11.x86_64-1.4.11-3.fc11.x86_64.rpm
Fehler: Fehlgeschlagende Abhängigkeiten:
openafs-kmod-common >= 1.4.11 wird benötigt von
kmod-openafs-2.6.30.9-90.fc11.x86_64-1.4.11-3.fc11.x86_64
That's normal. Kmod package always have this dep (it's actually created
automatically) to make sure the common package (e.g. one of those build from
Bug 802 in this case) gets installed.
That package also should include the license file -- the individual kmod
packages should not.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
7:41 p.m.
New subject: [Bug 803] Review request: openafs-kmod - Kernel Modules
http://bugzilla.rpmfusion.org/show_bug.cgi?id=803
--- Comment #13 from Jochen Schmitt <Jochen(a)herr-schmitt.de> 2009-11-03 20:41:04
---
Good:
+ Local install/uninstall works fine.
Your are APPROVED.
Because you have the blocker bug BZ#30 on BZ #802, please let me knewn your FAS
name, so I can sponsor your.
Best Regards:
Jochen Schmitt
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
7:48 p.m.
New subject: [Bug 803] Review request: openafs-kmod - Kernel Modules
http://bugzilla.rpmfusion.org/show_bug.cgi?id=803
--- Comment #14 from Jack Neely <jjneely(a)ncsu.edu> 2009-11-03 20:48:43 ---
Thanks!
My FAS account (both RPM Fusion and Fedora) is "jjneely"
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
7:56 p.m.
New subject: [Bug 803] Review request: openafs-kmod - Kernel Modules
http://bugzilla.rpmfusion.org/show_bug.cgi?id=803
--- Comment #15 from Jochen Schmitt <Jochen(a)herr-schmitt.de> 2009-11-03 20:56:21
---
Ok, I have sponsored you, so you can create your CVSAdmin request for importing
your package into the free repo.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
11:28 p.m.
New subject: [Bug 803] Review request: openafs-kmod - Kernel Modules
http://bugzilla.rpmfusion.org/show_bug.cgi?id=803
Jack Neely <jjneely(a)ncsu.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|3 |4, 33
--- Comment #16 from Jack Neely <jjneely(a)ncsu.edu> 2009-11-13 00:28:10 ---
Thanks Jochen! Below is my CVS request:
Package CVS request
======================
Package Name:openafs-kmod
Short Description:Kmod for OpenAFS
Owners:jjneely@ncsu.edu
Branches:F-11
InitialCC:jjneely@ncsu.edu
----------------------
License tag: [free]
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
6:24 p.m.
New subject: [Bug 803] Review request: openafs-kmod - Kernel Modules
http://bugzilla.rpmfusion.org/show_bug.cgi?id=803
--- Comment #17 from Jack Neely <jjneely(a)ncsu.edu> 2009-11-18 19:24:49 ---
Updating my CVS request for F12
Package CVS request
======================
Package Name:openafs-kmod
Short Description:Kmod for OpenAFS
Owners:jjneely@ncsu.edu
Branches:F-11 F-12
InitialCC:jjneely@ncsu.edu
----------------------
License tag: [free]
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
2:02 p.m.
New subject: [Bug 803] Review request: openafs-kmod - Kernel Modules
http://bugzilla.rpmfusion.org/show_bug.cgi?id=803
Thorsten Leemhuis <fedora(a)leemhuis.info> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|33 |
--- Comment #18 from Thorsten Leemhuis <fedora(a)leemhuis.info> 2009-11-22 15:02:05
---
(In reply to comment #17)
Package CVS request
Done. Note, I added myself as CCed, as I kind of are the co-maintainer for all
kmod in rpmfusion
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
7:08 p.m.
New subject: [Bug 803] Review request: openafs-kmod - Kernel Modules
http://bugzilla.rpmfusion.org/show_bug.cgi?id=803
Jack Neely <jjneely(a)ncsu.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |33
--- Comment #19 from Jack Neely <jjneely(a)ncsu.edu> 2009-12-10 20:08:53 ---
cvs commit...
? F-11/import.log
**** Access denied: jjneely is not in ACL for rpms/openafs-kmod/F-11
cvs commit: Pre-commit check failed
cvs [commit aborted]: correct above errors first!
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
10:10 a.m.
New subject: [Bug 803] Review request: openafs-kmod - Kernel Modules
http://bugzilla.rpmfusion.org/show_bug.cgi?id=803
Xavier Lamien <lxtnow(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|33 |
--- Comment #20 from Xavier Lamien <lxtnow(a)gmail.com> 2010-01-05 11:10:49 ---
Fixed.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
2:24 p.m.
New subject: [Bug 803] Review request: openafs-kmod - Kernel Modules
http://bugzilla.rpmfusion.org/show_bug.cgi?id=803
Jack Neely <jjneely(a)ncsu.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
3:47 p.m.
New subject: [Bug 803] Review request: openafs-kmod - Kernel Modules
http://bugzilla.rpmfusion.org/show_bug.cgi?id=803
Jack Neely <jjneely(a)ncsu.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |33
--- Comment #21 from Jack Neely <jjneely(a)ncsu.edu> 2010-05-18 17:47:51 ---
Package Change Request
======================
Package Name: openafs-kmod
New Branches: F-13
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
9:46 p.m.
New subject: [Bug 803] Review request: openafs-kmod - Kernel Modules
http://bugzilla.rpmfusion.org/show_bug.cgi?id=803
Jack Neely <jjneely(a)ncsu.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|33 |
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
5293
days inactive
5558
days old
rpmfusion-developers@lists.rpmfusion.org
24 comments
1 participants
participants (1)
-
RPM Fusion Bugzilla